From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 69082AC0920 for ; Thu, 23 Nov 2023 01:20:14 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=U8dKHPbxSUC+bqrpkvhTgS9JVbQD/KwnMzbHMwyhkW8=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1700702413; v=1; b=bTAG3P8erSUNAcbnSvhDmFmFn3hWyqzj5zKK6F9ye4A12XgqcYF2lAWMcewPieq4e8zarYOz Ovtn+v5avpG4rFvqbsdjBqQRI5xTKMwlftjs7l9xTp3FQQOpmhzaK/LUkA8M7FTuvpwsS9Ka3+e aHVlxBzwiV+RJb0s+zko6qa8= X-Received: by 127.0.0.2 with SMTP id MCmSYY7687511xo0MyK78eH2; Wed, 22 Nov 2023 17:20:13 -0800 X-Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.60]) by mx.groups.io with SMTP id smtpd.web10.82120.1700702412272556585 for ; Wed, 22 Nov 2023 17:20:12 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fETRlT9ZnKBVXH+0oWz+tVV6FqqJtT1Up4MDicKyYSN2Jf+048nWkr+vOHN7VK5vYioxJP3ZP5KaJPKiFrKBw13t44hHgFF2aVwB6dEKQTviGiTvL9GitzqdVQFtbCEGOtIbY0LQzSFAXbDX1KWOMqDf37x5R1Y+RElAT1umyuFWNKicvAUITKyy3ur427Z7aWvcBm9UwhpL6cW57vdipWl3EzK9xvEwJi1B3RPripOa8HdlokiJZvxRC2XpTngxK/tA++THwGWLX1qg5z1EmVjHHRw2iiYX4zgFTL3K75Q1WROR26k54rmveaYK4dFLYywrNBHyaBt1MzICb8JVcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DQUfa3hC/nMXgDWCXpG/Q7BYZRAopOsROAZJnJX7A6Y=; b=jbWAP1WbkdSEd2FqTTOjer0dR3iSB+z/HRugdciRXSjvaP4YJ2pPpdiRAdjEGvW0BYgoQO2ft2L9jT5383rNYdyrMA8DW4y+xV67lpfEyV2J0M9WlI+NCLXVedgYFvD9EloIXwsJrOsjf/un8kgQunBSgjUIDImJLQT2ya+uCvDdrVtajYzNWW6emny7qOYj8kIrTrSdk4nhMaQ0l79qVa0NZN/IYPtEz0jfCHnZqWECIAPibhOByKDwzTrtBKQKi5NSEXra8j9CgGz4kyQWUhS5mGXxF5Yi2YzMOAo8NksxYD4AuENzpSShQXZwL2o+hOMU3FJpTgGQypy9W8hOMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by SA1PR12MB6821.namprd12.prod.outlook.com (2603:10b6:806:25c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.19; Thu, 23 Nov 2023 01:20:10 +0000 X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::91d9:e679:32a3:dd05]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::91d9:e679:32a3:dd05%5]) with mapi id 15.20.7025.017; Thu, 23 Nov 2023 01:20:09 +0000 From: "Chang, Abner via groups.io" To: Nickle Wang , Mike Maslenkin , "devel@edk2.groups.io" CC: "igork@ami.com" Subject: Re: [edk2-devel] [PATCH v2 3/3] RedfishPkg: fix searching for the BMC-exposed USB NIC Thread-Topic: [PATCH v2 3/3] RedfishPkg: fix searching for the BMC-exposed USB NIC Thread-Index: AQHaHaAwd+m7wQyEYkCCg9zwhDrJrbCHC3aAgAAPAAA= Date: Thu, 23 Nov 2023 01:20:09 +0000 Message-ID: References: <20231123000103.31216-1-mike.maslenkin@gmail.com> <20231123000103.31216-4-mike.maslenkin@gmail.com> In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=6cffde9f-6d2d-4889-b6ca-edc66c1e6fc3;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-11-23T01:17:42Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|SA1PR12MB6821:EE_ x-ms-office365-filtering-correlation-id: 883961fa-bf04-41dc-3334-08dbebc255af x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: iqIFEhQBV2uQqThfSdAhV1YYwkqPei43VTQrvVfgZt96STtNkpalpTRt2aWrMDFPEipOGc3XG6bx4pdQBEJ3UfuRydk8jloKCq10W7Yc1MJvwVaN7uUEv+fviygNR6+1iuxqxIgsg6SNv5aio/DP5cBzoepMZPh6GQh4hubxx8DocBRdFP6BjXvPIn8H4duTkbJ7rQuWpZOxJXb6uOGxLSe0pypODJxzmCXHKbS1+7QlP5tbWRRIK0QJC5Cl4X91UW9Yd/UP2aD3PtpPA9aTrNO/tyDVcPoYO0BAF3D+oTJitpCRqYfTMtkYBV0AsublYqCmI1g131FAdCJPVGOQs4UY8Iwf3YzSMLzDwtLqXJ7A6L322IdYVDbT2lQUKR2wRiuRnKSg5bIzkF33DY8pWJLPE/b25tNwZ0o4PKe+IvXgP4iS0TuhlrAV6WgsAYjhbrmAZuA6gQSmDk2LW0ylYSV99URHkF51uSsx852TdlK1ilZhxecO+yDBz7VFdcSuLtbomIpFjOkEvnf2C2zKIKj3odv54TfdRRhGZxv2i55STx7XloI3SkEWf0pmlYA+8fQDfAOj7Q6PCavIReRuKc1MAQdGAmJI79y0NydoAKUqHnYMtvBeK6wIgH87fI6jzmyqhJiId9+iYn6sHxOCMAWVkdEOuVFBjbR3Bh3FMo2p8bFSSoVm9+2tsISlSkLm x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?oIW0fnQwKRaa89kCY/gBxJCWKHoPTFOspF5Br0Kl656X8eEwuLBTJm3JedLC?= =?us-ascii?Q?jcg0epaab/C0KwnGFMThSw06BLEj+s5SBM1EhcHcGg/2A7Hpf+ZvbBnjrdfw?= =?us-ascii?Q?NeXoM49V7zmFuDMmAqZjpv3NRLvL1OzZVas7xfPnL/qCN6wi+Y/OAl5UB9RV?= =?us-ascii?Q?w6TEYYEEMRKP0nRyJa55cXknY0W56xvEti9FyAyzWdvRuYbIW7ds8+PRmhQN?= =?us-ascii?Q?mLLQ9JNplp+VZukWUPRm0xIW5c80mnBUfrGrOwaAZfgpzGELqBDDBrSfIO20?= =?us-ascii?Q?ExgHoRuRkD6LX5LjEB8H1C71Uir/fNH3s0/bMaqT5P38OUrb0ZN1YghNZLjV?= =?us-ascii?Q?TJJPEgftLX+l8anBuiSdLULT1b50FdsJ9YJnTu9Nat411M6KN1Gzl3tDsn6j?= =?us-ascii?Q?lt1/Jv5h2VR4FoZ5X3TJaGPfLcpc32JIwYXrD2WJskj5Nz6d2G8X84TJbDOP?= =?us-ascii?Q?qgFyUxk+oOnmqX5vW9hCbD1S/p3/WOwf0scPyRmhh+JFEmYAe/RLwYkrs6Bl?= =?us-ascii?Q?Pni74U4uuFxcJj9LZtU9evP+NiguPaZ6tBSzs3HOyQrH8joTSirXXVPBjt/7?= =?us-ascii?Q?+ihCqEVYWHqy79F8RjTgpja5eQfb9IgEDIPRGMiM4067s6ZpRWjXLbv6klux?= =?us-ascii?Q?SS+ievgNntA6VRJ+SY45v3DtTzIKGZWAkSo2G/WLYrBPxy+E/fnXYk+ugGax?= =?us-ascii?Q?ER4MxJSlVzRI3P5NT+zkuF2jotCvaGYrtExkwYLCw8/g5LspEzERJnzLqI0p?= =?us-ascii?Q?QCzZ1LoHcGAkipOdPESIiF/pgRJti8uLadVLguIpJnwI0Z8a/+KqJT76mFdU?= =?us-ascii?Q?xH2vADXu0V1YZvSc4Mmc/sU+f1PjP55w7s048okDxJtHqZUzDExyVAwqlbdt?= =?us-ascii?Q?6ixEBzvSq1Vp26oj1qgAOliZwdK9ExvmWqhTNyJ6Jy/jqOk3ueEuQjfDuJMQ?= =?us-ascii?Q?csUhA6eiVmxDKHpYkdc6mINCDi7hZhYoRlhaDBqSUj0Vio+8io6PtvMyhOjJ?= =?us-ascii?Q?mJYHxkBKVXnQb680bMv+GsLI5B4DfadAE83Oor2H8YEuZLOgngguNWtqgnUO?= =?us-ascii?Q?HAAsjRJgBfczSGF5EEpTBKhhU6agq2IoE34bzfWk/N8t45WzRM81pclm4gjA?= =?us-ascii?Q?3RpRYcboAwsK0qMFK9PEn7mq4NeUkQImEvyBlLjsOD7Uc5U/So5v9sLRl6Qh?= =?us-ascii?Q?G21NjjFwTyGYun9+cYVvQ//YlU+C4eyTJongA71fqiOwzJ7s6ZXLtJuEDzam?= =?us-ascii?Q?PF/5/LVsXuOh7Hq96ZkOvk+PF6zs7/dG+vX/VBYU8KuFDfhneT0SohfmgFmn?= =?us-ascii?Q?mHFqNhUXBZ0d1iygr+nEpjW5DCFRF46ONu72mBfQluD8euNkvPdWRo2vjAZ3?= =?us-ascii?Q?7MlkJ/kDNDLQKDXng6dyFxLrY000w4FjeRipXkePfqX3ZyTjrqR9chKIqLPC?= =?us-ascii?Q?QkMWPGdkbuFwYBRpeU0vZcy7xUm6+pNh47HpD8BjNKDBncT+exCCNNW9ZRcb?= =?us-ascii?Q?mtFtIVTHyIE5QSl9NHqFWUJ2KEr40ZXA4v0cDHLagTmZgcuuSHoPDupc8qBZ?= =?us-ascii?Q?sUgM2xJH+PHEmB+0xk0=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 883961fa-bf04-41dc-3334-08dbebc255af X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Nov 2023 01:20:09.6703 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3zBjJdx1UPBfzVRXxSm2KQcHDWgShcgKgVjmrwpwtWvSiF3s9T/u4k9TwablIRoURSN25UtTQjVh8Vjw4QJD6A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB6821 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: ZCcQt9IT1o37Zl0xQYVCrk0ix7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=bTAG3P8e; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io [AMD Official Use Only - General] HI Nickle and Mike, I also have some fixes and revised BMC USB NIC library for searching BMC ex= posed NIC. Please don't not merge this patch set just for now. I will review this and = compare with the changes I have. Thanks Abner > -----Original Message----- > From: Nickle Wang > Sent: Thursday, November 23, 2023 8:24 AM > To: Mike Maslenkin ; devel@edk2.groups.io > Cc: Chang, Abner ; igork@ami.com > Subject: RE: [PATCH v2 3/3] RedfishPkg: fix searching for the BMC-exposed > USB NIC > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > Reviewed-by: Nickle Wang > > Regards, > Nickle > > > -----Original Message----- > > From: Mike Maslenkin > > Sent: Thursday, November 23, 2023 8:01 AM > > To: devel@edk2.groups.io > > Cc: abner.chang@amd.com; Nickle Wang ; > > igork@ami.com > > Subject: [PATCH v2 3/3] RedfishPkg: fix searching for the BMC-exposed U= SB > NIC > > > > External email: Use caution opening links or attachments > > > > > > According to RedfishPkg/Readme.md document: > > "The last byte of host-end USB NIC MAC address is the last byte of BMC-= end > USB > > NIC MAC address minus 1." > > > > It is necessary to subtract 1 from IpmiLanChannelMacAddress. > > > > Cc: Abner Chang > > Cc: Nickle Wang > > Cc: Igor Kulchytskyy > > Signed-off-by: Mike Maslenkin > > --- > > .../PlatformHostInterfaceBmcUsbNicLib.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git > > > a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInter > fac > > eBmcUsbNicLib.c > > > b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInter > fac > > eBmcUsbNicLib.c > > index 95900579118b..20ec89d4fcb0 100644 > > --- > > > a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInter > fac > > eBmcUsbNicLib.c > > +++ > b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostI > > +++ nterfaceBmcUsbNicLib.c > > @@ -738,8 +738,8 @@ HostInterfaceIpmiCheckMacAddress ( > > (VOID *)&IpmiLanChannelMacAddress.Addr, > > > > IpmiLanMacAddressSize - 1 > > > > ) !=3D 0) || > > > > - (IpmiLanChannelMacAddress.Addr[IpmiLanMacAddressSize - 1] != =3D > > > > - *(UsbNicInfo->MacAddress + IpmiLanMacAddressSize - 1) - 1) > > > > + (IpmiLanChannelMacAddress.Addr[IpmiLanMacAddressSize - 1] - = 1 > > + !=3D > > > > + *(UsbNicInfo->MacAddress + IpmiLanMacAddressSize - 1)) > > > > ) > > > > { > > > > DEBUG ((DEBUG_REDFISH_HOST_INTERFACE, " MAC address is not > > matched.\n")); > > > > -- > > 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111636): https://edk2.groups.io/g/devel/message/111636 Mute This Topic: https://groups.io/mt/102759080/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-