From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.48]) by mx.groups.io with SMTP id smtpd.web08.1021.1668329629894715708 for ; Sun, 13 Nov 2022 00:53:50 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=n3hgH58l; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.220.48, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jg2CU3PQ4gkpPQ7h+uDOszoaMfZLt0sNdAMw5S6OqaYe2x+JL7j93DuYRS6xPuqSWGs835rA5VX8dWVmzg/sYnbGZjF2+cOJ/iW1bTi9qUNyisy7hhrAps/DNouiIuvXpM+1aEjVExlMvcnP2nohWW+NirWBERfHb0IDYfrKjLBHURKciuGxv9H7GJSQAL8PX5uPoSzBc7R89YWi9Ow9OH9XtVdEaoTbCu4HhOg4BUj8dv3AjTL8POQAAfqqh7c9IKjD6w+kYe8kHV5SUHSoEMbX3qG+NBGIKI1JSsoB6AhoQYnGJer7MruHXebDNTWUN/bAkBYECcy6g9piiqgpFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VvNWJGQi3fO9nauMSQ0R3fVVfeUvflzG7ABmVF0qO8Y=; b=gAF7e7NS5LawT5r+G9PvZS+6mG4h1F0+xz5DPQmWmlJVMYdznKT5ysmzCUZ4FyZnLQoSM9js+YGoCDWP/Os7bWI5OiwB9uTSg/MijyK9L9SAfy1fbuE+CeclZf59oTAZxpQ07MBwNC+HyySXBjIgsLjJ4+YxAtgCCxLE2MYjZkfheNgSHp1Kidj+ALtMTYuSAnF/t8PdntNRpegfBJ/T5QJUhTq884Z0ZJSx1ZIyBTNQLQZEpmnr07e47x/mQiLsQXGuL7yY/0WXkzrze6gLineuJnwphaeYmj7wVCO22c6KKUD+0tuaXpkUf4v+CZ0fylCPKZHXSNajY0822oNjKQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VvNWJGQi3fO9nauMSQ0R3fVVfeUvflzG7ABmVF0qO8Y=; b=n3hgH58lgI6Pdw/ZAaPbtYg6CyMWt8V4oO4PW23ds9q4zOnBwhjugU2NitpGSsLMLOu2ndkQqRvidH341ft0hpiytFo44B3V4BGVmg9V1fZ13WD4I6CVq5vlVXN8s848pYNqbcxzy7rpTLG2ItpxVubStk0DRzBHwAjpdWzopKE= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by IA1PR12MB6187.namprd12.prod.outlook.com (2603:10b6:208:3e5::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.16; Sun, 13 Nov 2022 08:53:44 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::ce0a:283e:839:34bd]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::ce0a:283e:839:34bd%3]) with mapi id 15.20.5813.016; Sun, 13 Nov 2022 08:53:43 +0000 From: "Chang, Abner" To: "Kinney, Michael D" , "devel@edk2.groups.io" , Michael Kubacki CC: "Wee, Sing" , Rebecca Cran , "lersek@redhat.com" , "heyi.guo@linaro.org" Subject: Re: [edk2-devel] [edk2-CCodingStandardsSpecification] Create release/2.30 branch Thread-Topic: [edk2-devel] [edk2-CCodingStandardsSpecification] Create release/2.30 branch Thread-Index: AQHY6iTO/YoJYNprhk6n4u7gZgA2Y64j7deAgADKZ8CADnIecIAAmBCAgAfCNSCAAK6tgIAAcbTA Date: Sun, 13 Nov 2022 08:53:43 +0000 Message-ID: References: <20221027165416.1610-1-abner.chang@amd.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2022-11-13T08:53:41Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=5a02eed5-1610-4e42-b21c-addb92aee61b; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|IA1PR12MB6187:EE_ x-ms-office365-filtering-correlation-id: efcabb48-3e30-4aae-c64d-08dac55491bc x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0RpQjX0p/S7o7h8dVHKIFArcWq5CXu7P2E11PebnNwNjn4MOm7sAoiDZpLFsgk/ZPWaVcOhnNWIAe/zCtUvLbV/QkL+e3ZKBytCJM+MhYWsEICNbvxFL/2BlhCZdG+ITESwfILXok/5o9H18WeFrvfz65cdaNkwYRAb8c7rL+IXmIbPKJL4xspvRCLjZ3Xc+bVj1mD3p533kg/UdU9uVLa4FBB4EPp4dQ4B1VuA8+rxZ7ExeVLH8rby2vbhErBU8SpwfxJJ+QEPnlaDf1wxYuWMZjNMcGdsl8S1kMMpdB8l5y7wdrWcH1BvKdPnhWe+vFsVykB83qvv3U+9TPhJZwUuqhrDNrBnhRwB0LmbLsIB+0kLCJWCVWkWNn6WYFFZ+NQgRdf88MM7YWli3zIgOdZm8Q14LZ3TEBGk7uqPZWw9zA8EirT8oMcPMUymoslWHqQAfiFZOWXcXVRBxi2XmAKz3iBW28Cc3a/5zSKNsFjTBe3SCBuDMd0k6bmihny5/YSFqgU45Q6Bo3AR+wHn8N/W3sc7CVQQHbW2V+BLp03iE4tTPB7BR3J3MjSHqiQVIgxskDJDiG7ThpzoPW4sf1b0UgOoKM1hPoCgdEVPQyTrMPCXql/rAlcw+vdtL/EAy/cLh/kUJTVHwvRbt1ryNlP9CN5pxPyYDmgdsdwGutmoLv/kYj/rQuS1+htwioeddww64A9yDyXM+IUn83iwciusysyzQqJ4yOcQW2qDx3KGzjHbxw1Cxpzf0+/irN2afb31hl93L5eNa4SnJEkuL1KtDM4InRATawTXAC+ir47+I5mDC54knE9Y3EpbDm7O5aSvnYpXu+1Px4d622F/7mA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(366004)(396003)(136003)(346002)(376002)(451199015)(4326008)(122000001)(26005)(9686003)(316002)(71200400001)(45080400002)(38070700005)(55016003)(110136005)(52536014)(86362001)(54906003)(2906002)(8676002)(66476007)(6506007)(66446008)(64756008)(66556008)(7696005)(66946007)(76116006)(38100700002)(478600001)(966005)(33656002)(53546011)(66899015)(8936002)(83380400001)(5660300002)(186003)(41300700001)(30864003);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?txsL2VkWLb0cwJpqP5FFxDUn5u4Ze1gExKjShh2tIEEySpnaQ9nUpN2vAGSx?= =?us-ascii?Q?zGAmtIFcv7OpGkXDiFjWE41DSqcNjxk6XQ+2X4AV5FeTirISZxGsBoq7pdQB?= =?us-ascii?Q?eTRIVFTFByibkbdI0lDbEQFZKPH0LO0nHIOLWYMaBUSoUS8k0jZcLQgM8jeu?= =?us-ascii?Q?YqnH/DhBhEGQFaq4vmMFnbAe+CrkhmLsy2Oin7VmfhyhEJoqm2JT8imfCkKL?= =?us-ascii?Q?pZd3mv/rlRleQtACit1BRJEeX3x6QUEvptF3+zbURqsb973XcQ9GEWfX3a4F?= =?us-ascii?Q?J3CDUGagjJPDh9aII4IjLaeEqH0F9xYM09/GtEt4essI0fFYjLAy0k57uKGt?= =?us-ascii?Q?R158NozaDOscsESaWRSKXFbaD20++9pDFKafHMM0HVq91mDANAEYcp4Bxh3L?= =?us-ascii?Q?pV/g+ANW7wRkhAEqWRrFTNG9+bMZx/tovdh4/d+w23DVr4SkgwmoInz77xpw?= =?us-ascii?Q?qJhYWJdseu9sV3e0VfsxuGoGqWGgdxLA25vWsGaqX28wG4L3KbzRwYZCokPK?= =?us-ascii?Q?+o6a27sz76eC2YSXHoYyX+YYD4GO0V6iWcXKqhNnm6qlbGSgNgHNt+gAnlRk?= =?us-ascii?Q?FySBN9bNLi4sJJt/CfiTHH1Rks55NdqILRV1A3Z/20QDehmrScTUcdSYvzMP?= =?us-ascii?Q?xSAj0qf+NfWgQ2a3fy3l78a0yvg6BMYeDcfCGED2stFt0y1br2SxWuLauizQ?= =?us-ascii?Q?3N4xsyP87Olz4MlEb2x8tnW5kqHfM7ucRnWR4EhBgm+bdsfc712xr2px7FCK?= =?us-ascii?Q?LXadhibN2opgfxA9atfMUcmYaLpNn34+H9BJl/zeLRGt18DdrnaDkKviLAb5?= =?us-ascii?Q?nOrRZQmHuP/gNcb8J1IP3dEv+KhSs1ViC/Rb3pv0bIjsoaxfXLWMkVqmcTpb?= =?us-ascii?Q?y3HXVgl8++yXPK1OG6CQglbqKDIdCTMonk95OEGB+JrQk91fHzDrozxMDdDt?= =?us-ascii?Q?cp1q7xVM3ywL0nwLP9Zk9lYSR7QS5nIb0X9YMaO9s5vTgTh7TfqAKhJcZiBR?= =?us-ascii?Q?jIwa5aFxZ4x5Ra/W9+7WrG620V08vjsUryGmqFzXov8l0L115B4cBZr7JnSo?= =?us-ascii?Q?Xdx0Ab4cKO4WUkxFjPWT2nivEDY03J8vyLeKnNRiCusITbewDSFR1UXVhf+O?= =?us-ascii?Q?reYNWE1xEm3VC+V8Stz2OUMa5Nxl3eMyK+m2opl+POw215oAb2WuwK8ezR2f?= =?us-ascii?Q?mUJCDVu1uy9Mu+gfVpI07SxQKoERvwFEDqAeWG3TAzqaCXOlXzzyYYz/aj5g?= =?us-ascii?Q?m0kwq1f4RfbKSvDNZpRE/oSOiN5Jcym27al0ef8GBlz3BgkIe48lbgyURGKd?= =?us-ascii?Q?aO3PISI/VoVmBKvjcfXlbikXt6j4I7UencXC97hTEylFkEjTBWpgyOBuU5q/?= =?us-ascii?Q?hyzSbHLG3p+IQqa9V3I0r0+V7GGf1zvCmTyPYa6ICpROkgSEyXlhMHXBtxlm?= =?us-ascii?Q?kcU7lsU+tEvUoLFgIvP7/0AFVfVDmQ0Zwcvc/E2cgRPH/bOUYd6n0DeJDXgj?= =?us-ascii?Q?CJPg2npDBVISFU0UgyXVA21Iq0K84BMgdk/DimiNXLHRj+B3nWtCQknEWzDG?= =?us-ascii?Q?nicfJZKB1ObYCG5Z+m0=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: efcabb48-3e30-4aae-c64d-08dac55491bc X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Nov 2022 08:53:43.9026 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gJJEwZLwKFvtYwH3yaIGPBFJjdIqPE4DWT2dIH/p8Sw++cgaP6ha9llmAtkT4/RIJFAjRWQFZkJwwbi+WNci0A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6187 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] > -----Original Message----- > From: Kinney, Michael D > Sent: Sunday, November 13, 2022 10:01 AM > To: Chang, Abner ; devel@edk2.groups.io; Michael > Kubacki ; Kinney, Michael D > > Cc: Wee, Sing ; Rebecca Cran > ; lersek@redhat.com; heyi.guo@linaro.org > Subject: RE: [edk2-devel] [edk2-CCodingStandardsSpecification] Create > release/2.30 branch >=20 > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. >=20 >=20 > We do not want to do another global reformat for column width change. Then we will have two formats in edk2. >=20 > What does Uncristify do now? We need to make sure spec matches current > behavior. The code is not corrected to < 80 column by Uncrustify ATM. We can merge th= is patch to CCS v2.3 pre-release and publish it when the tool is updated. Abner =20 >=20 > I added Michael Kubacki to this thread earlier so he can provide the deta= ils. >=20 >=20 > Mike >=20 > > -----Original Message----- > > From: Chang, Abner > > Sent: Saturday, November 12, 2022 5:37 PM > > To: devel@edk2.groups.io; Kinney, Michael D > > ; Michael Kubacki > > > > Cc: Wee, Sing ; Rebecca Cran > > ; lersek@redhat.com; heyi.guo@linaro.org > > Subject: RE: [edk2-devel] [edk2-CCodingStandardsSpecification] Create > > release/2.30 branch > > > > [AMD Official Use Only - General] > > > > Yes Mike, we can merge the patch 1/2 for the line in 80 columns topic. > > Not sure if Uncrustify is smart enough to correct the existing code > > that have the line with column > 80, especially for the postfix comment= that > makes the line has > 80 columns. Or we just leave the code there. > > > > But for the patch 2/2: The multi line function > > > (https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fedk2= .gr > oups.io%2Fg%2Fdevel%2Ftopic%2F30907266%2313206&data=3D05%7C01%7 > CAbner.Chang%40amd.com%7C506359e24b5d4b01b96708dac51af1f0%7C3dd8 > 961fe4884e608e11a82d994e183d%7C0%7C0%7C638039016763599434%7CUnk > nown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1h > aWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3DV6oGitSmRBs0o%2B > vxPGmlj%2FxKChlsYAVL7QFXP8SdcRA%3D&reserved=3D0), there is no > conclusion yet however I think we can fix it in CCS v2.3. > > My reply is here: > > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fedk= 2 > > .groups.io%2Fg%2Fdevel%2Fmessage%2F96324&data=3D05%7C01%7CAbn > er.Chan > > > g%40amd.com%7C506359e24b5d4b01b96708dac51af1f0%7C3dd8961fe4884e6 > 08e11a > > > 82d994e183d%7C0%7C0%7C638039016763599434%7CUnknown%7CTWFpbGZs > b3d8eyJWI > > > joiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C300 > 0%7 > > > C%7C%7C&sdata=3DWnR6F81HyKoAfkfYsYUszraIZESLzu8zdQH07MN1AJ8%3 > D&r > > eserved=3D0 > > > > Thanks > > Abner > > > > > -----Original Message----- > > > From: devel@edk2.groups.io On Behalf Of > > > Michael D Kinney via groups.io > > > Sent: Tuesday, November 8, 2022 1:07 AM > > > To: Chang, Abner ; devel@edk2.groups.io; > > > Michael Kubacki ; Kinney, Michael D > > > > > > Cc: Wee, Sing ; Rebecca Cran > > > ; lersek@redhat.com; heyi.guo@linaro.org > > > Subject: Re: [edk2-devel] [edk2-CCodingStandardsSpecification] > > > Create > > > release/2.30 branch > > > > > > Caution: This message originated from an External Source. Use proper > > > caution when opening attachments, clicking links, or responding. > > > > > > > > > Hi Abner, > > > > > > Thanks for the review. I agree we should try to get a few more of > > > these resolved for Version 2.3. > > > > > > +Michael Kubacki for Uncrustify configuration settings discussion on > > > +the column width > > > and args per line in function call topics. We need to know what the > > > current Uncrustify configuration settings for these 2 topics. It > > > would be better of the spec and the Uncrustify settings were aligned > > > and for any changes going forward they are made to the spec and Uncru= stify > settings at the same time. > > > > > > Details of these 2 topics are as follows: > > > > > > * TianoCore BZ links: > > > > > > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fb= u > > > gz > > > > illa.tianocore.org%2Fshow_bug.cgi%3Fid%3D713&data=3D05%7C01%7Cab > > > > ner.chang%40amd.com%7Cc3101043683346dc8bac08dac0e28499%7C3dd8961 > > > > fe4884e608e11a82d994e183d%7C0%7C0%7C638034376370079115%7CUnkno > > > wn%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1 > > > > haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3DD69iyxD8b723VL > > > 9I2okQHPr%2FTILymNgLR1%2BC9zdeKXE%3D&reserved=3D0 - Update > EDK II > > > C Coding standard to state a stronger preference for 80 column line > > > widths > > > > > > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fb= u > > > gz > > > > illa.tianocore.org%2Fshow_bug.cgi%3Fid%3D714&data=3D05%7C01%7Cab > > > > ner.chang%40amd.com%7Cc3101043683346dc8bac08dac0e28499%7C3dd8961 > > > > fe4884e608e11a82d994e183d%7C0%7C0%7C638034376370079115%7CUnkno > > > wn%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1 > > > haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3DiytS8GVsHwWl8 > > > oLHM4C0IKemmVp5Y9qyPrcGD5kehRw%3D&reserved=3D0 - Update EDK > II C > > > Coding Standards to allow multiple arguments per line in a function > > > call > > > > > > * The patch emails and discussions are in groups.io: > > > > > > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fe= d > > > k > 2.groups.io%2Fg%2Fdevel%2Fmessage%2F13204&data=3D05%7C01%7Cab > > > > ner.chang%40amd.com%7Cc3101043683346dc8bac08dac0e28499%7C3dd8961 > > > > fe4884e608e11a82d994e183d%7C0%7C0%7C638034376370079115%7CUnkno > > > wn%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1 > > > > haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3D8wsQDvWYYEag > > > M3u8zHTGiladwgosQ%2BUAyQVByqnqstU%3D&reserved=3D0 > > > > > > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fe= d > > > k > 2.groups.io%2Fg%2Fdevel%2Fmessage%2F13205&data=3D05%7C01%7Cab > > > > ner.chang%40amd.com%7Cc3101043683346dc8bac08dac0e28499%7C3dd8961 > > > > fe4884e608e11a82d994e183d%7C0%7C0%7C638034376370079115%7CUnkno > > > wn%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1 > > > > haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3Dqg06y6ulcsV67iiT > > > VLO081VAm2mFw0CA49djt3SmwxQ%3D&reserved=3D0 > > > Leif provide a Reviewed-by: > > > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fe= d > > > k > 2.groups.io%2Fg%2Fdevel%2Fmessage%2F13228&data=3D05%7C01%7Cab > > > > ner.chang%40amd.com%7Cc3101043683346dc8bac08dac0e28499%7C3dd8961 > > > > fe4884e608e11a82d994e183d%7C0%7C0%7C638034376370079115%7CUnkno > > > wn%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1 > > > haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3DPwYZPFfScXiZcX > > > akiqSM%2BEGoIY2ay8KyVPQ0cYkf8h8%3D&reserved=3D0 > > > > > > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fe= d > > > k > 2.groups.io%2Fg%2Fdevel%2Fmessage%2F13206&data=3D05%7C01%7Cab > > > > ner.chang%40amd.com%7Cc3101043683346dc8bac08dac0e28499%7C3dd8961 > > > > fe4884e608e11a82d994e183d%7C0%7C0%7C638034376370079115%7CUnkno > > > wn%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1 > > > haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3DbPuRMrDPRm2 > > > %2Fr3ahPJ8tsb78xQ1QowIbKGb2Nj3A5ME%3D&reserved=3D0 > > > There is a good discussion of this change with no Rb. > > > > > > * The links to the formatted versions of the reviews are no longer wo= rking, > > > but they can be view on GitHub in the branch Laszlo provided and se= lect the > > > "Display the rich diff" view of the markdown changes: > > > > > > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fg= i > > > th > > > ub.com%2Flersek%2Fedk2- > > > > CCodingStandardsSpecification%2Fcommit%2F2c5534a24b15616fdaa0247885 > > > > 8ed1d8908dc653&data=3D05%7C01%7Cabner.chang%40amd.com%7Cc310 > > > > 1043683346dc8bac08dac0e28499%7C3dd8961fe4884e608e11a82d994e183d% > > > > 7C0%7C0%7C638034376370079115%7CUnknown%7CTWFpbGZsb3d8eyJWIjoi > > > > MC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C300 > > > 0%7C%7C%7C&sdata=3Dw8LngdyWH5fu1dhszkdgMmkWBkXq3tF9nvgN0z > > > SYqVw%3D&reserved=3D0 > > > > > > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fg= i > > > th > > > ub.com%2Flersek%2Fedk2- > > > > CCodingStandardsSpecification%2Fcommit%2Fe3797dc48316052005cefa2624 > > > > 6ab2fd32641881&data=3D05%7C01%7Cabner.chang%40amd.com%7Cc310 > > > > 1043683346dc8bac08dac0e28499%7C3dd8961fe4884e608e11a82d994e183d% > > > > 7C0%7C0%7C638034376370079115%7CUnknown%7CTWFpbGZsb3d8eyJWIjoi > > > > MC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C300 > > > 0%7C%7C%7C&sdata=3DRUnEumRPpYd7%2Fl9ENVu6g7KeyscFZnMjN%2B > > > Zeb7S9b9E%3D&reserved=3D0 > > > > > > Best regards, > > > > > > Mike > > > > > > > -----Original Message----- > > > > From: Chang, Abner > > > > Sent: Monday, November 7, 2022 6:18 AM > > > > To: Kinney, Michael D ; > > > > devel@edk2.groups.io > > > > Cc: Wee, Sing ; Rebecca Cran > > > > ; lersek@redhat.com; heyi.guo@linaro.org > > > > Subject: RE: [edk2-devel] [edk2-CCodingStandardsSpecification] > > > > Create > > > > release/2.30 branch > > > > > > > > [AMD Official Use Only - General] > > > > > > > > Hi Mike, > > > > You probably missed this email. I checked the below C coding > > > > standard spec > > > related BZ and had some comments in line below. > > > > > > > > > -----Original Message----- > > > > > From: Chang, Abner > > > > > Sent: Saturday, October 29, 2022 11:33 AM > > > > > To: Kinney, Michael D ; > > > > > devel@edk2.groups.io > > > > > Subject: RE: [edk2-devel] [edk2-CCodingStandardsSpecification] > > > > > Create > > > > > release/2.30 branch > > > > > > > > > > [AMD Official Use Only - General] > > > > > > > > > > Hi Mike, > > > > > Below are the tickets pulled out from BZ, is there any one you > > > > > think is not necessary now? > > > > > Abner > > > > > > > > > > 713 EDK2 Document michael.d.kinney@intel.com CONF = --- > > > > > Update EDK II C Coding standard to state a stronger > > > > > preference for 80 column line widths 2021-07-27 > > > > Seems no conclusion from the discussion in BZ. > > > > > > > > > 1766 EDK2 Document michael.d.kinney@intel.com = CONF -- > - > > > > > Remove use of STATIC macros from EDK II C Coding Standard > > > > > Specification 2020-12-09 > > > > No conclusion yet. > > > > > > > > > 1698 EDK2 Document michael.d.kinney@intel.com = CONF -- > - > > > > > Spurious rule about comment style in CCS 6.2.3 2021-07-27 > > > > Had we addressed this issue on the coding standard spec yet? If > > > > not, we > > > can fix this in the version 2.3. > > > > > > > > > 714 EDK2 Document michael.d.kinney@intel.com CONF = --- > > > > > Update EDK II C Coding Standards to allow multiple arguments = per > > > > > line in a function call 2021-07-27 > > > > Have these patches been reviewed? > > > > [edk2] [edk2-CCodingStandardsSpecification PATCH 0/2] improvements > > > > related to line wrapping [edk2] > > > > [edk2-CCodingStandardsSpecification > > > > PATCH 1/2] Source Files / General Rules: limit line lengths to 80 > > > > columns [edk2] [edk2-CCodingStandardsSpecification PATCH 2/2] > > > > Source Files / Spacing / Multi-line func. calls: allow condensed > > > > arguments > > > > > > > > > > > https://nam11.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fmi= d. > > > m > > > > ail-archive.com%2F20170811164851.9466-1- > > > lersek%40redhat.com&data=3D0 > > > > > > > > 5%7C01%7Cabner.chang%40amd.com%7Cc3101043683346dc8bac08dac0e284 > > > 99%7C3d > > > > > > > > d8961fe4884e608e11a82d994e183d%7C0%7C0%7C638034376370079115%7CU > > > nknown% > > > > > > > 7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haW > > > wiLCJX > > > > > > > > VCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3DRtbRn2cTrhwUvlFxjWP7bEg > > > o7gnGR8R9v > > > > EKSe65RXEg%3D&reserved=3D0 > > > > > > > https://nam11.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fmi= d. > > > m > > > > ail-archive.com%2F20170811164851.9466-2- > > > lersek%40redhat.com&data=3D0 > > > > > > > > 5%7C01%7Cabner.chang%40amd.com%7Cc3101043683346dc8bac08dac0e284 > > > 99%7C3d > > > > > > > > d8961fe4884e608e11a82d994e183d%7C0%7C0%7C638034376370079115%7CU > > > nknown% > > > > > > > 7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haW > > > wiLCJX > > > > > > > > VCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3Dq7qLZjyr6IUpYtNraPlZKQJvB > > > ekm11v%2 > > > > FkJbztxA76eI%3D&reserved=3D0 > > > > > > > https://nam11.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fmi= d. > > > m > > > > ail-archive.com%2F20170811164851.9466-3- > > > lersek%40redhat.com&data=3D0 > > > > > > > > 5%7C01%7Cabner.chang%40amd.com%7Cc3101043683346dc8bac08dac0e284 > > > 99%7C3d > > > > > > > > d8961fe4884e608e11a82d994e183d%7C0%7C0%7C638034376370079115%7CU > > > nknown% > > > > > > > 7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haW > > > wiLCJX > > > > > > > > VCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3DM0sZmbstyxn7iWay996bjUJ > > > maBqblRFNr > > > > 52P6JCOOhk%3D&reserved=3D0 > > > > > > > > > 2664 EDK2 Document michael.d.kinney@intel.com = CONF -- > - > > > > > Discrepancies/inconsistencies in coding standards, style and > > > > > examples 2021-10-02 > > > > I think we can fix the above inconsistent issues in the version 2.3= release. > > > > > > > > Thanks > > > > Abner > > > > > > > > > > > > > > > -----Original Message----- > > > > > > From: Kinney, Michael D > > > > > > Sent: Friday, October 28, 2022 11:22 PM > > > > > > To: devel@edk2.groups.io; Chang, Abner ; > > > > > Kinney, > > > > > > Michael D > > > > > > Subject: RE: [edk2-devel] [edk2-CCodingStandardsSpecification] > > > > > > Create > > > > > > release/2.30 branch > > > > > > > > > > > > Caution: This message originated from an External Source. Use > > > > > > proper caution when opening attachments, clicking links, or res= ponding. > > > > > > > > > > > > > > > > > > Hi Abner, > > > > > > > > > > > > Have you reviewed the open BZs against the EDK II C Coding Stan= dard. > > > > > > > > > > > > Are there any other issues that are considered important to > > > > > > fix before making a new official release? > > > > > > > > > > > > Thanks, > > > > > > > > > > > > Mike > > > > > > > > > > > > > -----Original Message----- > > > > > > > From: devel@edk2.groups.io On Behalf > > > > > > > Of Chang, Abner via groups.io > > > > > > > Sent: Thursday, October 27, 2022 9:54 AM > > > > > > > To: devel@edk2.groups.io > > > > > > > Cc: Abner Chang > > > > > > > Subject: [edk2-devel] [edk2-CCodingStandardsSpecification] > > > > > > > Create > > > > > > > release/2.30 branch > > > > > > > > > > > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > > > > > Signed-off-by: Abner Chang > > > > > > > --- > > > > > > > book.json | 3 +-- > > > > > > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > > > > > > > > > > > diff --git a/book.json b/book.json index d112b26..1fdd570 > > > > > > > 100644 > > > > > > > --- a/book.json > > > > > > > +++ b/book.json > > > > > > > @@ -1,8 +1,7 @@ > > > > > > > { > > > > > > > > > > > > > > "variables" : { > > > > > > > > > > > > > > - "draft" : "yes", > > > > > > > > > > > > > > "title" : "EDK II C Coding Standards Specification", > > > > > > > > > > > > > > - "version" : "Revision 2.2" > > > > > > > > > > > > > > + "version" : "Revision 2.3" > > > > > > > > > > > > > > }, > > > > > > > > > > > > > > "plugins": ["puml-aleung"], > > > > > > > > > > > > > > "pluginsConfig": {} > > > > > > > > > > > > > > -- > > > > > > > 2.37.1.windows.1 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >=20 > > >