public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Chang, Abner via groups.io" <abner.chang=amd.com@groups.io>
To: Joey Vagedes <joeyvagedes@microsoft.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Subject: Re: [edk2-devel] [PATCH] BaseTools/Workspace: Build fail if structure PCD is referred
Date: Thu, 28 Dec 2023 23:22:36 +0000	[thread overview]
Message-ID: <MN2PR12MB3966AFBCFCE5727686E31CE1EA9EA@MN2PR12MB3966.namprd12.prod.outlook.com> (raw)
In-Reply-To: <26170.1703779379208781928@groups.io>

[-- Attachment #1: Type: text/plain, Size: 1572 bytes --]

[AMD Official Use Only - General]

Ok, please let me know when you merge the fix.

Thank you
Abner

From: Joey Vagedes via groups.io <joeyvagedes=microsoft.com@groups.io>
Sent: Friday, December 29, 2023 12:03 AM
To: Chang; Chang, Abner <Abner.Chang@amd.com>; devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH] BaseTools/Workspace: Build fail if structure PCD is referred

Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.


Hello,

This is in regard to my recent patch (see commit here: BaseTools: Resolve regex syntax warnings · tianocore/edk2@9f0061a (github.com)<https://github.com/tianocore/edk2/commit/9f0061a03b61d282fbc0ba5be22155d06a5e64a1>) that was resolving the newly introduced syntax warnings (that will become syntax errors) in Python3.12 for using invalid escape characters.

A few of the strings that I converted from normal strings to raw strings to resolve the issue contained both valid and invalid escape characters. I'm going back through the changes I made in the PR to resolve any strings that contain both valid and invalid escape characters.



I will send out the patch soon.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112993): https://edk2.groups.io/g/devel/message/112993
Mute This Topic: https://groups.io/mt/103395845/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 5088 bytes --]

      parent reply	other threads:[~2023-12-28 23:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-28  3:04 [edk2-devel] [PATCH] BaseTools/Workspace: Build fail if structure PCD is referred Chang, Abner via groups.io
2023-12-28  3:08 ` Chang, Abner via groups.io
2023-12-28 16:02   ` Joey Vagedes via groups.io
2023-12-28 17:01     ` Joey Vagedes via groups.io
2023-12-28 23:22     ` Chang, Abner via groups.io [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MN2PR12MB3966AFBCFCE5727686E31CE1EA9EA@MN2PR12MB3966.namprd12.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox