Re: [edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH V3 02/34] MdePkg: Add RISCV_EFI_BOOT_PROTOCOL related definitions

["Chang, Abner" <abner.chang@amd.com>]

[AMD Official Use Only - General]



> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Sunil V L via
> groups.io
> Sent: Thursday, October 13, 2022 5:58 PM
> To: devel@edk2.groups.io
> Cc: Michael D Kinney <michael.d.kinney@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Zhiguang Liu <zhiguang.liu@intel.com>
> Subject: [edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH V3 02/34] MdePkg:
> Add RISCV_EFI_BOOT_PROTOCOL related definitions
> 
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
> 
> 
> REF:
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.
> tianocore.org%2Fshow_bug.cgi%3Fid%3D4076&amp;data=05%7C01%7Cabner.
> chang%40amd.com%7C0df18d1274f04083208208daad018bc2%7C3dd8961fe48
> 84e608e11a82d994e183d%7C0%7C0%7C638012519406523318%7CUnknown%
> 7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiL
> CJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=%2Bynu9ig0EeeuMDr5V0F
> ON3iY1p4nrTdb77O0j8SGkxs%3D&amp;reserved=0
> 
> RISC-V UEFI based platforms need to support RISCV_EFI_BOOT_PROTOCOL.
> Add this protocol GUID definition and the header file required.
> 
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Signed-off-by: Sunil V L <sunilvl@ventanamicro.com>
> ---
>  MdePkg/MdePkg.dec                           |  6 ++++
>  MdePkg/Include/Protocol/RiscVBootProtocol.h | 32 +++++++++++++++++++++
>  2 files changed, 38 insertions(+)
>  create mode 100644 MdePkg/Include/Protocol/RiscVBootProtocol.h
> 
> diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index
> f1ebf9e251c1..8f1bcfdc3e97 100644
> --- a/MdePkg/MdePkg.dec
> +++ b/MdePkg/MdePkg.dec
> @@ -1915,6 +1915,12 @@ [Protocols]
>    ## Include/Protocol/ShellDynamicCommand.h
>    gEfiShellDynamicCommandProtocolGuid  = { 0x3c7200e9, 0x005f, 0x4ea4,
> {0x87, 0xde, 0xa3, 0xdf, 0xac, 0x8a, 0x27, 0xc3 }}
> 
> +  #
> +  # Protocols defined for RISC-V systems  #  ##
> + Include/Protocol/RiscVBootProtocol.h
> +  gRiscVEfiBootProtocolGuid  = { 0xccd15fec, 0x6f73, 0x4eec, { 0x83,
> + 0x95, 0x3e, 0x69, 0xe4, 0xb9, 0x40, 0xbf }}
> +
>  #
>  # [Error.gEfiMdePkgTokenSpaceGuid]
>  #   0x80000001 | Invalid value provided.
> diff --git a/MdePkg/Include/Protocol/RiscVBootProtocol.h
> b/MdePkg/Include/Protocol/RiscVBootProtocol.h
> new file mode 100644
> index 000000000000..cb94f61cd46c
> --- /dev/null
> +++ b/MdePkg/Include/Protocol/RiscVBootProtocol.h
> @@ -0,0 +1,32 @@
> +/** @file
> +  RISC-V Boot Protocol mandatory for RISC-V UEFI platforms.
> +
> +  Specification available at
> +
I found here are some whitespaces in the patch. You can check it again.
And I can't apply this patch on edk2 master. Is your edk2-staging branch rebase to edk2 master?

Thanks
Abner

> + https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith
> + ub.com%2Friscv-non-isa%2Friscv-
> uefi&amp;data=05%7C01%7Cabner.chang%40a
> +
> md.com%7C0df18d1274f04083208208daad018bc2%7C3dd8961fe4884e608e11
> a82d99
> +
> 4e183d%7C0%7C0%7C638012519406523318%7CUnknown%7CTWFpbGZsb3d8e
> yJWIjoiMC
> +
> 4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C
> %7C%
> +
> 7C&amp;sdata=f2SuwtirAU08pL2MlMris2XmdKkf6OH1muIG%2FPhmH5M%3D&
> amp;rese
> + rved=0
> +
> +  Copyright (c) 2022, Ventana Micro Systems Inc. All rights
> + reserved.<BR>
> +  SPDX-License-Identifier: BSD-2-Clause-Patent
> +
> +**/
> +
> +#ifndef RISCV_BOOT_PROTOCOL_H_
> +#define RISCV_BOOT_PROTOCOL_H_
> +
> +typedef struct _RISCV_EFI_BOOT_PROTOCOL RISCV_EFI_BOOT_PROTOCOL;
> +
> +#define RISCV_EFI_BOOT_PROTOCOL_REVISION  0x00010000 #define
> +RISCV_EFI_BOOT_PROTOCOL_LATEST_VERSION \
> +        RISCV_EFI_BOOT_PROTOCOL_REVISION
> +
> +typedef EFI_STATUS
> +(EFIAPI *EFI_GET_BOOT_HARTID)(
> +  IN RISCV_EFI_BOOT_PROTOCOL   *This,
> +  OUT UINTN                    *BootHartId
> +  );
> +
> +typedef struct _RISCV_EFI_BOOT_PROTOCOL {
> +  UINT64                 Revision;
> +  EFI_GET_BOOT_HARTID    GetBootHartId;
> +} RISCV_EFI_BOOT_PROTOCOL;
> +
> +#endif
> --
> 2.25.1
> 
> 
> 
> 
>