From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from NAM02-BN1-obe.outbound.protection.outlook.com (NAM02-BN1-obe.outbound.protection.outlook.com [40.107.212.70])
 by mx.groups.io with SMTP id smtpd.web10.6918.1665664816940050091
 for <devel@edk2.groups.io>;
 Thu, 13 Oct 2022 05:40:17 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@amd.com header.s=selector1 header.b=G6Z7I18P;
 spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.212.70, mailfrom: abner.chang@amd.com)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=adYI/kj5RFQo3nc2do5YwTMY96KEfQKF04S2fZGU1qcwCcyIoBEfqyAyVE7acjG3kvUquUUdflym/JRsyGt333n5rcV7eh+VfKlvoVGUBp3vvnvE+IGWbcVP8nUN6YXK+G35q9bE7KCI91mdj6P111ndcDJ/JDm2YH7rBSXp5e+7mfZawAHne6/ku2517a2yPsHIwwCI8gqfqjM01Lx3/gjV4GW2GAxY3R8yUXo/isG1BZTkySuxxTFsynSfeW6iTFCwOosY509luqMvYzBMuKkf2RyPZWb6p9OtKqio2lQZ5X3Key+xJbe219XL3WrUHtnBVR+sfFVUO2zZLWK43Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=3EbPB/YjydUBPQyE+aXcEuuMhTbE7bqBLf7EndY08ns=;
 b=eXrsZArCM26yayybmqQG2xbB6j9yXPCbTzv0Zl36OOTjo7bmwfxpQmvGUcIuEmpdntgWa0oJzVygJjVSYV2JGDjFXN1aqcyTcyID2QnlePluTpFPPvmd35cSAWj+sNg4sQK9ZmScb0X4ShPdhE+/KRG5VXICCP3wzqq98ImEE9DWQ8oupM71rv/3qEeYiJZjpgCLEnRYriNnbF1iQggw9eLo+L/FuNwDvZyHM3Nrg/T9yDUJtrP7gOeO+e0XFdaWkf98MAZfGjq2+AuobJIYpl7B8bVwsCYiYlPM+RcBEH+gESilpF4ItZfZestdPAcojwc5nHpAQd61OPI1aWTFFQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass
 header.d=amd.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=3EbPB/YjydUBPQyE+aXcEuuMhTbE7bqBLf7EndY08ns=;
 b=G6Z7I18PPemagXpSf7UXwAxdPAY8ct9Z3zm6TPYyEIlctER4otZwM4t7EIyYORY7MwTr+myf8QNJek1xe4+uNLh48gnhKH56ga2T5CSLQr7rkMnxNjkjNAlANDQ0xiSwV1ITOnJf3BAlVGk92hFL6hoFXqR8H2OHArtGoUFWfnY=
Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18)
 by DM6PR12MB4450.namprd12.prod.outlook.com (2603:10b6:5:28e::18) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.22; Thu, 13 Oct
 2022 12:40:14 +0000
Received: from MN2PR12MB3966.namprd12.prod.outlook.com
 ([fe80::dd29:6efb:1027:cfb2]) by MN2PR12MB3966.namprd12.prod.outlook.com
 ([fe80::dd29:6efb:1027:cfb2%5]) with mapi id 15.20.5723.026; Thu, 13 Oct 2022
 12:40:14 +0000
From: "Chang, Abner" <abner.chang@amd.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>, "sunilvl@ventanamicro.com"
	<sunilvl@ventanamicro.com>
CC: Michael D Kinney <michael.d.kinney@intel.com>, Liming Gao
	<gaoliming@byosoft.com.cn>, Zhiguang Liu <zhiguang.liu@intel.com>
Subject: Re: [edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH V3 02/34] MdePkg: Add RISCV_EFI_BOOT_PROTOCOL related definitions
Thread-Topic: [edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH V3 02/34]
 MdePkg: Add RISCV_EFI_BOOT_PROTOCOL related definitions
Thread-Index: AQHY3upqLjoXjnwDwEKWfbZIPsvg2K4MQo1g
Date: Thu, 13 Oct 2022 12:40:14 +0000
Message-ID: 
 <MN2PR12MB3966B26A4D69011A0BB7BD16EA259@MN2PR12MB3966.namprd12.prod.outlook.com>
References: <20221013095829.1454581-1-sunilvl@ventanamicro.com>
 <20221013095829.1454581-3-sunilvl@ventanamicro.com>
In-Reply-To: <20221013095829.1454581-3-sunilvl@ventanamicro.com>
Accept-Language: zh-CN, en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;
 MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2022-10-13T12:40:10Z;
 MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;
 MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;
 MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d;
 MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=f1b34c85-6ebe-4820-9d3d-290e3384cf16;
 MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=amd.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|DM6PR12MB4450:EE_
x-ms-office365-filtering-correlation-id: b25800c2-021e-4c4e-c3a1-08daad18137c
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 
 q/W75XG8z6LLZNyoS3BB1BqHKlkYuYGL77/9kJuYcJOKg2GBGhiWzoRL5BpwECPQrbci/Ozte+E34s9H+LXtwXwdIonm2B4NfhSzIIr1hko219zLsDSkPIL7vy/hcuJU4wmr9UYGnAVn2u9UUbKYQK+0aiYegtgPF8h37Rzl4q47ANCgKC8gWOVa3fSBOULZvBh1oVYgIOhb7nMJV9/gUaoDJkDX3UKlp9bIzrZKikSyXFsRoh7nKCz2s3+4YcrBZePaS7xRYZqHq3g6rAmgihGW9Bitctt/7Zzl51nfoogGnvGIo10ZIIibjh4XHhJCqwUGNvkzlA5G5TbAdlk1Rs97poSp/RzcRQX8yRnw4wsF120uH9ggOq8R5kJbyko9riq3j0+u/Fe4J4vkBA7KpY6iLmPEtSO8aNLqUXSrUW8P3gyNCUv+mrTW18rpaqHZcx5FqMojKJOofDYv6e3nJhmyH+SQHZKTupW88/XQrFDfgOfsxmNXx/AqkWfek54oV80YJONvMzlOrJlzONIX6EazkLzga/fPjef4O5wh2l/P/J5xcHwMA3IROoAFWOV5rkBISo4Py3J8n46wfU0ZQI2o/WCNKNWzLRIVhPEwgYOzKZuI/lYWkbz+k8Ss23r7xbv5QmQRZ6+mg8mKTufuuR0KCoUromHn2PhMjPIbMJU86ku4s9ZWSRPbwfIP6HruEM9oHspINgejn3g7AQsr8q6yyNmuLLKW6ofUNTvaFZpT2C+z7t+BjCbAei3cdL7t0PdbNQdi3wQUGZv2mgFlBW37om0ruziVvZ19X3YmsBBUeaDpKLLm2B/218wf/9YKvfAYzORntAsHmvD5Nqz/1w==
x-forefront-antispam-report: 
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(376002)(39860400002)(396003)(136003)(346002)(451199015)(122000001)(8936002)(52536014)(66899015)(2906002)(38100700002)(38070700005)(5660300002)(41300700001)(4326008)(76116006)(64756008)(55016003)(66946007)(66556008)(66476007)(66446008)(83380400001)(8676002)(186003)(86362001)(316002)(7696005)(966005)(478600001)(33656002)(53546011)(6506007)(54906003)(45080400002)(26005)(9686003)(110136005)(71200400001);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?zX/9NmeQ5SOL+VhJ3f54lX5LFnn+PaC7z0xtTTSkmBf4uFAn1xdYPrKqA/1J?=
 =?us-ascii?Q?OZ96ThQ+23E8edXD2vMBFGzCLIFlUDQlEkShovXgmEoz0owsseSYC+8wNImv?=
 =?us-ascii?Q?SyC/zbzdjZtOevC4aPFgz0GhC8VYVvKN54xjvVknXsPraLzIQ1blxC/1H2Y9?=
 =?us-ascii?Q?s2ewK8cfnGNWGKcNq4Y4d7NtKWqInd52CW0h2wzZmy+loFzkfeUeUIUVpG1K?=
 =?us-ascii?Q?/kBnxbwC5qVMHer99risege3lW+Qpwk1X42+BoP9EgS/v+xzDV4CFSYXdnGC?=
 =?us-ascii?Q?zfZmYzh6An06qLiXkTJUMSeP78eQ2Dvewt6AKKITdfiu6kMcM1y0Olf5PVAW?=
 =?us-ascii?Q?Ty8RWbK/W/szba9y2okVNF4hgVLyP8i76RG8J7yKgVbZJOOVsYpCC6SGrLwB?=
 =?us-ascii?Q?7bMkgS1HHHv6XC7WRhka0N1ngQB86P3CurnHkhyJrPCYA7xrqaLVoALKMvJx?=
 =?us-ascii?Q?Wv9XDd9leMC60EzuPlLfVt0bkcMzLDtadVhZboUk0CvhdfiU5w2hkpNjrRey?=
 =?us-ascii?Q?D/Lp8VVeP6kUfB4tdOcYhZ0W3+yJJVTZh0WEgtltpEVEJcEHwuEd4oenzB1L?=
 =?us-ascii?Q?rn6R1xOn5lhj+tPLsO9qqsgBmSM0uY2gXa0jdZdpF18/xHVADOW1p3iB35tp?=
 =?us-ascii?Q?ru2VdY2loTnCfhr9PMHUBb+wYl4XhishFjG5kYPDCfk2r2aA1x8ei6bAFxPF?=
 =?us-ascii?Q?slXxEXDc7tnfGjxVn4UlHRdDhzoM+zkYWE5ITosUCgGNWM6SP/7suW9FNwQr?=
 =?us-ascii?Q?gorCjZIE1ldAqI6vapV+6QJm6GvSInlzfskRvbGbBzgxfTmBF3Zob6bkqse6?=
 =?us-ascii?Q?23jRoOOYHd07B8uLhr9X8TkbOmy1PKAPIA/XrYlX9acG8eRxE2BykKg/Nwry?=
 =?us-ascii?Q?JV8nBSbUEcRkhliFf96VX6p57BnxswdJj67eNXri0ecqj2ErwTDguuJZ2HzE?=
 =?us-ascii?Q?sGc15ZRxvRKMw1iJ8myS7e3fB2BzcD4T10yebtbQS5QcHoKOEuNInYktpBY5?=
 =?us-ascii?Q?oU0AfOZlv/N7xSoWSjBmjb6W7PKJgaHMdV5YrSXdM61usEUHa8gNV6wtaNpH?=
 =?us-ascii?Q?oYGMcsR00z+jGR+x8+Iq15Jzk5XE4a/oOFJcVeu+ovnKLyScVBkffheY2Z4C?=
 =?us-ascii?Q?jTOvKbo1Hkvb1NzLbSYPwpatVmViqPYTkJMwwex4vkjQrAFSTY+g7f5NZYLh?=
 =?us-ascii?Q?xW7exZMuHmMV+UuVCL3nzi+vwKUFyzYMsiNJY0uUQqmzRJQMnJiHnThHbpCV?=
 =?us-ascii?Q?UjCqzo9YYvmdsM3Nvd6QceH3lv/pEMZxhzjF+GGou7UQESTL305EqYMRNRgE?=
 =?us-ascii?Q?fmLsFZJKU3Rr40bRZw0tRuYSXYpmcSFu9vpHNNXkLJ+j1SAxJFLnp0znEBh2?=
 =?us-ascii?Q?XConbJvbp3F5QG2ktdkxA0384p4rjjt2/fI8d4isZHvRQRc8mI+NMtB/SugU?=
 =?us-ascii?Q?q7+oCgE6VjywPYSnZwaL4TPo45TgBIEEyFJylI9wtUvCKf/RZAJnY23RkAmx?=
 =?us-ascii?Q?9o/sttQuigapFVBGgC+3bBUV06hxtXNbey72mPSV4zEPnm7qiJroYaFHZXke?=
 =?us-ascii?Q?8kDCLtsBPOYb2Yw9u04=3D?=
MIME-Version: 1.0
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b25800c2-021e-4c4e-c3a1-08daad18137c
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Oct 2022 12:40:14.3798
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: GQLYBpR8uFktK1waBKQK5TIYw4yv3MkMNX1bdE2KcJ/SwbPw9AgVB43ZKzWMVAz5IfO4/+BKy5SO28vfrtBVrw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4450
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

[AMD Official Use Only - General]



> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Sunil V L =
via
> groups.io
> Sent: Thursday, October 13, 2022 5:58 PM
> To: devel@edk2.groups.io
> Cc: Michael D Kinney <michael.d.kinney@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Zhiguang Liu <zhiguang.liu@intel.com>
> Subject: [edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH V3 02/34] MdePk=
g:
> Add RISCV_EFI_BOOT_PROTOCOL related definitions
>=20
> Caution: This message originated from an External Source. Use proper caut=
ion
> when opening attachments, clicking links, or responding.
>=20
>=20
> REF:
> https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fbugzi=
lla.
> tianocore.org%2Fshow_bug.cgi%3Fid%3D4076&amp;data=3D05%7C01%7Cabner.
> chang%40amd.com%7C0df18d1274f04083208208daad018bc2%7C3dd8961fe48
> 84e608e11a82d994e183d%7C0%7C0%7C638012519406523318%7CUnknown%
> 7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiL
> CJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=3D%2Bynu9ig0EeeuMDr5V0F
> ON3iY1p4nrTdb77O0j8SGkxs%3D&amp;reserved=3D0
>=20
> RISC-V UEFI based platforms need to support RISCV_EFI_BOOT_PROTOCOL.
> Add this protocol GUID definition and the header file required.
>=20
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Signed-off-by: Sunil V L <sunilvl@ventanamicro.com>
> ---
>  MdePkg/MdePkg.dec                           |  6 ++++
>  MdePkg/Include/Protocol/RiscVBootProtocol.h | 32 +++++++++++++++++++++
>  2 files changed, 38 insertions(+)
>  create mode 100644 MdePkg/Include/Protocol/RiscVBootProtocol.h
>=20
> diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index
> f1ebf9e251c1..8f1bcfdc3e97 100644
> --- a/MdePkg/MdePkg.dec
> +++ b/MdePkg/MdePkg.dec
> @@ -1915,6 +1915,12 @@ [Protocols]
>    ## Include/Protocol/ShellDynamicCommand.h
>    gEfiShellDynamicCommandProtocolGuid  =3D { 0x3c7200e9, 0x005f, 0x4ea4,
> {0x87, 0xde, 0xa3, 0xdf, 0xac, 0x8a, 0x27, 0xc3 }}
>=20
> +  #
> +  # Protocols defined for RISC-V systems  #  ##
> + Include/Protocol/RiscVBootProtocol.h
> +  gRiscVEfiBootProtocolGuid  =3D { 0xccd15fec, 0x6f73, 0x4eec, { 0x83,
> + 0x95, 0x3e, 0x69, 0xe4, 0xb9, 0x40, 0xbf }}
> +
>  #
>  # [Error.gEfiMdePkgTokenSpaceGuid]
>  #   0x80000001 | Invalid value provided.
> diff --git a/MdePkg/Include/Protocol/RiscVBootProtocol.h
> b/MdePkg/Include/Protocol/RiscVBootProtocol.h
> new file mode 100644
> index 000000000000..cb94f61cd46c
> --- /dev/null
> +++ b/MdePkg/Include/Protocol/RiscVBootProtocol.h
> @@ -0,0 +1,32 @@
> +/** @file
> +  RISC-V Boot Protocol mandatory for RISC-V UEFI platforms.
> +
> +  Specification available at
> +
I found here are some whitespaces in the patch. You can check it again.
And I can't apply this patch on edk2 master. Is your edk2-staging branch re=
base to edk2 master?

Thanks
Abner

> + https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgit=
h
> + ub.com%2Friscv-non-isa%2Friscv-
> uefi&amp;data=3D05%7C01%7Cabner.chang%40a
> +
> md.com%7C0df18d1274f04083208208daad018bc2%7C3dd8961fe4884e608e11
> a82d99
> +
> 4e183d%7C0%7C0%7C638012519406523318%7CUnknown%7CTWFpbGZsb3d8e
> yJWIjoiMC
> +
> 4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C
> %7C%
> +
> 7C&amp;sdata=3Df2SuwtirAU08pL2MlMris2XmdKkf6OH1muIG%2FPhmH5M%3D&
> amp;rese
> + rved=3D0
> +
> +  Copyright (c) 2022, Ventana Micro Systems Inc. All rights
> + reserved.<BR>
> +  SPDX-License-Identifier: BSD-2-Clause-Patent
> +
> +**/
> +
> +#ifndef RISCV_BOOT_PROTOCOL_H_
> +#define RISCV_BOOT_PROTOCOL_H_
> +
> +typedef struct _RISCV_EFI_BOOT_PROTOCOL RISCV_EFI_BOOT_PROTOCOL;
> +
> +#define RISCV_EFI_BOOT_PROTOCOL_REVISION  0x00010000 #define
> +RISCV_EFI_BOOT_PROTOCOL_LATEST_VERSION \
> +        RISCV_EFI_BOOT_PROTOCOL_REVISION
> +
> +typedef EFI_STATUS
> +(EFIAPI *EFI_GET_BOOT_HARTID)(
> +  IN RISCV_EFI_BOOT_PROTOCOL   *This,
> +  OUT UINTN                    *BootHartId
> +  );
> +
> +typedef struct _RISCV_EFI_BOOT_PROTOCOL {
> +  UINT64                 Revision;
> +  EFI_GET_BOOT_HARTID    GetBootHartId;
> +} RISCV_EFI_BOOT_PROTOCOL;
> +
> +#endif
> --
> 2.25.1
>=20
>=20
>=20
>=20
>=20