From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (NAM12-DM6-obe.outbound.protection.outlook.com [40.107.243.49]) by mx.groups.io with SMTP id smtpd.web10.50052.1673512387458668969 for ; Thu, 12 Jan 2023 00:33:07 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=rw2M75Rj; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.243.49, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GBdkihlO4Ah+7unB4pux9BnqaBNAxju/KbgNwkOcO16BLHhsjhrsoSCmet1bsS7BAeRXL1uX2AlfydzCtRW/bu6cZodtoi/DchMGifT8WFj4mUMwveLFzCOcA5AVw0ARvg4xd++nKdaWPtNpuKvTZD8dcurpBV70WYoNCyM+hkwqnE8JY6r3E6OvxTI5gdyJ0qwkg73DoNps12uDXUtgNYpRJPr1DCsmgeM1rCDJMuualsxeDjEpz14x9oe2Hbvg/6bR2MrXogsBvUDaCtw3wNdQABQzYokjFtZk7mgusElyTSPgmZC5AUoK4AS5SVcMOWkvA1UagWOKQE/RsYaWpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=veTSSlwQtgeKIVJ+25aibjN86gmZjv4gLik3nNbLPxA=; b=fdh05rlcK/bd3UkGKy38gViNWNNH0kAx93nK/gBeqFndroNl6w4mf/Qnzu9yFkGNByVF2EodXyp4ojn444u3nxPGjyjv/DzN5+VK2zWP5dYz8FWLKc8Fp1XxGGRlkO4mp/kzO18pE+/px9UDJK9cSaXotBqFQUuMMhcLbqty/EfjxEyW+p/Lf+F+LAXDtEqrwEwAe+FoItvxAC7Ckq8RxarnlGzZcAKQRIIfGMsmkGfpY4dJUlw/L4o8bE0kw8TqNeCfq83tJLR0b+hNh+FNdcHk/fVa0d5bO8nTzvT0wlYgtmHWl8ZrngeuhXtnh0v3REzgtuRBpyachEXmMVFlvw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=veTSSlwQtgeKIVJ+25aibjN86gmZjv4gLik3nNbLPxA=; b=rw2M75RjJi47hTSr5ToM0wORZYIkxM5+/lzVgkAxOICoNT/XEnSk3qI4G+eJBp8LR3qIr5ZcglMoVG/HcVzoC4P0Z4pUQsa6PYzAoddrRVllYPxKurBWNdozpnaRxbvfILHrFUmDMz9PVUEm1rQ5J2F6EuXllQ91XH6j92Rb2tM= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by IA1PR12MB7541.namprd12.prod.outlook.com (2603:10b6:208:42f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Thu, 12 Jan 2023 08:33:05 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::cddb:3de9:cd1d:26e4]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::cddb:3de9:cd1d:26e4%5]) with mapi id 15.20.5986.018; Thu, 12 Jan 2023 08:33:05 +0000 From: "Chang, Abner" To: "Oram, Isaac W" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" , "Kinney, Michael D" , "Gao, Liming" , "Liu, Zhiguang" , Nickle Wang , Igor Kulchytskyy Subject: Re: [edk2-devel] [edk2-platforms][PATCH V2] IPMI changes for Redfish Thread-Topic: [edk2-devel] [edk2-platforms][PATCH V2] IPMI changes for Redfish Thread-Index: AQHZIR8LWofAPDAH8EaQaIRDPPizoK6QC/DAgAAJh+CAAJR7sIAJN/zAgACbpsA= Date: Thu, 12 Jan 2023 08:33:04 +0000 Message-ID: References: <20230105160100.772-1-abner.chang@amd.com> <17377895696F6651.2132@groups.io> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-01-12T08:33:01Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=000b0d3a-a306-4c25-90c5-99c69b4fe807; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|IA1PR12MB7541:EE_ x-ms-office365-filtering-correlation-id: d5791e7c-7751-4235-0d4d-08daf4779fff x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: AqO+lJ15mft4YADeIoIpeDq0qi9j7IbWLF1oXvWc7fDX1YlkJ6a6emXUvPY9QeFp41GwBYWi1jASONo7ByC41zHSr4oxwbKef9f+N67A0wMfHx7gc1sHD9+tLRTUKt4u79WH6CydyDaeA/RDZ+UdzcaVScLOlZoyCEn6EhaQsDgnMNySJf8fUbxNZUmC/ixeWYESvB1Fb8bUBm2kqfJPtbyWu1lyr/MbDfiF/JWu2yG/R3iFW+6qbkQY4D8+utZ5g9AvSGAfqdcbisn9kWnMnw/9oN0KQhvPCwMmNoB4fxAnDJmqYdyb1vmMwKvqZ21IkfhxYBD+W6cCVi5WZy2tsPKxOpdfd2x5LU//t/a26YGXnsNK/jg5U36uKKdFZ2IrV687h6pKY64A/NQgp05rDve3H+r8xPW6fbQLEZzhMNXIZRgnu2QX+6NaufhOayynRISJIKcdfc5KPJqAp1PAIaLIPZV3ABhAQRNQYGdmY1mCHmhg/zW6ebUuYlzM8P0F+aWubnu96oEZB/y3hL5DdZVUJQlgRfB+ROP7HS/YBxbBJX8GeJoJROyG6qfdNsCtM6XCWRDCA6TxqOVwaMl+uKvkvNR67DJ7Ed8FEejNucGf7q1m+O6TFi1i5iNsKUy2ttVTiIUqoxCs7Ku/lldxMxWZ76tsR09PlXG4Jjmfm2Nm2iZr2iXOgRiBf4LBLbTvtv0ogeniB2pEqgg61/OHHP6Gv/P4ngsHZLbo1n5Y9+Q= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(366004)(346002)(136003)(376002)(451199015)(53546011)(6506007)(2906002)(71200400001)(7696005)(478600001)(186003)(26005)(9686003)(966005)(66476007)(66899015)(66556008)(54906003)(4326008)(76116006)(66946007)(64756008)(8676002)(316002)(66446008)(45080400002)(41300700001)(55016003)(33656002)(38100700002)(5660300002)(110136005)(122000001)(52536014)(8936002)(83380400001)(86362001)(38070700005);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?L8Suwi/4frkCpvgOLSC/q+Z9YGTo5MBClnrB4sIN4RPrzrxgULcr3CP//G8N?= =?us-ascii?Q?H6GxF99uT6RzOge1HGFhS/WtLPT0yTxTFdjJFP+QPpgURhx5lYqvmdojMHXy?= =?us-ascii?Q?NQVSOeBjh2h4rGR+5AIqZZtdstvfrbYvcn1tQi7w7orVUjkA6VtpSmKSGVW2?= =?us-ascii?Q?1BJb3F81cXnZt/MNv3nzd75PN6PJIqhNPvv2TPILa357ZLwzl1RRk6//k++J?= =?us-ascii?Q?wX1D0qz2T1hnl5XyhlKslEjQKZkrrFO/mMbIorhL73oggjI6v9e1IXsc6QOu?= =?us-ascii?Q?lZAHP+7La2bq6j8HHo6ID6+pabojJ9EDYNqrurOfP9ACwOiJLwfsOhL0Y+i4?= =?us-ascii?Q?URPa7/TSF+5XIsXwvUY0N4d3IcV0fb3vHEWe5yblZUI0Fls6Y/9UCK59WymA?= =?us-ascii?Q?/E3VhivOJG0FmNirjgrwWDaGw4Nk2ti10gurdE1dR7iSFwlKDradaC+iVVPR?= =?us-ascii?Q?egBtfFfG/0l5K1/ryP+yAhYoSHSzcRQJZTdyNI9Nzqkt+uyTZEQSKJgP9Ixc?= =?us-ascii?Q?Q19zEfqczrMOnAS/L/i56zNiY1MkTLo1djl9kFwnOZi7YcX9V9caUJLQhsxK?= =?us-ascii?Q?u12GSva1sc9QrYhrfJGIBCl3P4jxLhCDiVyWB9nFDZekqW/BMsrYKUto/SHt?= =?us-ascii?Q?/u6keOXH4rXumKWUzsyV1IBsuPHKlngwoo1WkTxHWm27GIVvMK4VbiepirW/?= =?us-ascii?Q?XAFDU4TWrkgyZa0oyXLREjH9sarRIGeqoXZJJbV+1lIVEdnqbInh/Vl29QoZ?= =?us-ascii?Q?BypPzWWYbb8+kgqJxomSDtB+uaEcTt2vjwU3rI1sLS3Z41Dn5Xw0tuDOUHCs?= =?us-ascii?Q?6vjkgxjCDfBxq21FwTuir11OJBsPja6hrwopkWgyLIk9BRTaqKjGE5ZVIgKq?= =?us-ascii?Q?8OSKQGPtud7xM0bkOCFiQBydwwDFV/dQWs0p1AGPHe2HQ8YCaLlyDddGKV5I?= =?us-ascii?Q?ek7fH/NddZwtQ1pI4rixnOv6kUmmScFLD4/McLhFurttSIPo9//6S4NpcgqR?= =?us-ascii?Q?9TtKQpMtjv5VsxM9QBv36V2EzksvmRgBlfnbjX5rE0uAFV/nfkk8mpX+Kruj?= =?us-ascii?Q?jodPavo4VZUjdckm5SzUSThxoRFfYXtwFi47M8X6tUDea4QtAnRSdZNqPcWy?= =?us-ascii?Q?5C52ncuo21KnZLB2vXWtamM5X0zhyBKfiBP/fWacnRgeEjQ9wyHMD510FEgm?= =?us-ascii?Q?F10VUbZPLrC/0t1WrjaW1cTeOorrLltMJ1BMJHMqGdIien0zrQnOBQK9Qgy+?= =?us-ascii?Q?Ebf3ykOxt1Vr/6siTS7rnO8PvgnkjWjBMlH44lW0Cc/6Ebw4TxK0CmERsc1/?= =?us-ascii?Q?Bw82wmPP6rEuUl+XgaKwTVKVCcLLfhW2SFJ3UJxa/Q0j6++2UBAISXvFe+ey?= =?us-ascii?Q?28ILsr/6HbQZuKrr6XJFvAwjmb6gkSTAW31uA6FZymzNqpNnGR0prfgpePNe?= =?us-ascii?Q?YOBz0gbghhdqc3CZucHEHAywVkilkxgDLkcrELTjnOdpGfeIwh5AKyxMyYjB?= =?us-ascii?Q?2jS8QYXBl2IZaoPsEazCwJugWEOUmANDiIL1V4JRaLOjhX7NJG5t6QuF07X1?= =?us-ascii?Q?fLGB/3XUyrtvrzxBZSKBZi7x2UlWw5RmL9eOCYpt?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d5791e7c-7751-4235-0d4d-08daf4779fff X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jan 2023 08:33:04.8455 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: YIczPUe83mOGXj6cJHq0ow5EHsmOlPAu5ovlD0HKHFGIBSP9X9h6Lu5msuAFZgJ4jGRfHniBYH84gxgsPhLQTw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB7541 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] OK, I see. So Isaac, could you please help to check below series of patch? https://edk2.groups.io/g/devel/message/97769?p=3D%2C%2C%2C20%2C0%2C0%2C0%3A= %3ACreated%2C%2CAdd+NULL+instance+library%2C20%2C2%2C0%2C95915689 I will check with MdeMoudulePkg maintainers to see if they are ok with thes= e IPMI patch sets once you give the reviewed-by to above one. We will need = them to merge the code. Thanks Abner > -----Original Message----- > From: Oram, Isaac W > Sent: Thursday, January 12, 2023 7:15 AM > To: Chang, Abner ; devel@edk2.groups.io > Cc: Desimone, Nathaniel L ; Kinney, > Michael D ; Gao, Liming > ; Liu, Zhiguang ; > Nickle Wang ; Igor Kulchytskyy > Subject: RE: [edk2-devel] [edk2-platforms][PATCH V2] IPMI changes for > Redfish >=20 > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. >=20 >=20 > I believe that this edk2-platforms series is dependent on the changes in > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fedk > 2.groups.io%2Fg%2Fdevel%2Fmessage%2F98051&data=3D05%7C01%7CAbner. > Chang%40amd.com%7C1e8dfb9b78f245437e6f08daf4299d00%7C3dd8961fe4 > 884e608e11a82d994e183d%7C0%7C0%7C638090756807764009%7CUnknown > %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1ha > WwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3DXZQBaA%2FaxIWEbRSD > DVpO7qznlraJEh4UjeHAV30qu1E%3D&reserved=3D0 and they have not been > merged yet. > I had those changes under review in the branch I used for testing this pa= tch > series for edk2-platforms so my testing missed this. >=20 > Regards, > Isaac >=20 > -----Original Message----- > From: Chang, Abner > Sent: Thursday, January 5, 2023 6:27 PM > To: Oram, Isaac W ; devel@edk2.groups.io > Cc: Desimone, Nathaniel L ; Kinney, > Michael D ; Gao, Liming > ; Liu, Zhiguang ; > Nickle Wang ; Igor Kulchytskyy > Subject: RE: [edk2-devel] [edk2-platforms][PATCH V2] IPMI changes for > Redfish >=20 > [AMD Official Use Only - General] >=20 > Hi Isaac, > I am not quite understand, this patch set should be independent of edk2. > What do you mean the edk2 changes were pushed first? Or IpmiFeaturePkg > is good now? >=20 > Abner >=20 > > -----Original Message----- > > From: Oram, Isaac W > > Sent: Friday, January 6, 2023 1:42 AM > > To: devel@edk2.groups.io; Oram, Isaac W ; > > Chang, Abner > > Cc: Desimone, Nathaniel L ; Kinney, > > Michael D ; Gao, Liming > > ; Liu, Zhiguang ; > > Nickle Wang ; Igor Kulchytskyy > > Subject: RE: [edk2-devel] [edk2-platforms][PATCH V2] IPMI changes for > > Redfish > > > > Caution: This message originated from an External Source. Use proper > > caution when opening attachments, clicking links, or responding. > > > > > > Series pushed as: 28f3ce4a6a251de327b8d19c3316a654887f4f13.. > > f5da8af6befbfc655fd3e4cb899eda158dd9ede5 > > > > My apologies, I was sloppy and didn't ensure the edk2 changes were > > pushed first, so IpmiFeaturePkg build is currently broken pending > > > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fedk > % > > > 2F&data=3D05%7C01%7CAbner.Chang%40amd.com%7C1e8dfb9b78f245437e6f > 08daf429 > > > 9d00%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C6380907568077 > 64009%7 > > > CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJ > BTiI6Ik1 > > > haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3DdqY%2FUy5q88%2B3 > GOiVpSkPSxHF > > Wlqma7DQKrgQiStT3ng%3D&reserved=3D0 > > > 2.groups.io%2Fg%2Fdevel%2Fmessage%2F97789being&data=3D05%7C01%7Ca > > > bner.chang%40amd.com%7C6301c092067c4f19a1b208daef441af4%7C3dd896 > > > 1fe4884e608e11a82d994e183d%7C0%7C0%7C638085373047816357%7CUnkn > > > own%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik > > > 1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3DtBhHMIQhVL8AI3bof > > YIPHcTIzobpQ7lgZgwFJa0z0Gc%3D&reserved=3D0 being pushed. > > > > Regards, > > Isaac > > > > > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Isaac > > Oram > > Sent: Thursday, January 5, 2023 9:05 AM > > To: abner.chang@amd.com; devel@edk2.groups.io > > Cc: Desimone, Nathaniel L ; Kinney, > > Michael D ; Gao, Liming > > ; Liu, Zhiguang ; > > Nickle Wang ; Igor Kulchytskyy > > Subject: Re: [edk2-devel] [edk2-platforms][PATCH V2] IPMI changes for > > Redfish > > > > Series Reviewed-by: Isaac Oram > > > > -----Original Message----- > > From: abner.chang@amd.com > > Sent: Thursday, January 5, 2023 8:01 AM > > To: devel@edk2.groups.io > > Cc: Oram, Isaac W ; Desimone, Nathaniel L > > ; Kinney, Michael D > > ; Gao, Liming ; > > Liu, Zhiguang ; Nickle Wang > > ; Igor Kulchytskyy > > Subject: [edk2-platforms][PATCH V2] IPMI changes for Redfish > > > > From: Abner Chang > > > > In V2: Addressed the comments from Isaac. > > > > BZ# 4214 > > This patch adds IPMI functions for building up SMBIOS 42 record for > > the USB NIC host interface exposed by BMC. > > The corresponding updates on edk2 is in the separate pacth. > > > > This is the part I of upstream, the follow up patche sets are: > > - RedfishPlatformCredentialLib contributed by NVidia. > > - Relocate IpmiCommandLib.h from edk2-platforms > > to edk2/MdePkg. A NULL instance of IpmiCommandLib is created > > and located under MdePkg. With above, RedfishPkg doesn't have the > > dependence with edk2-platforms. The implementation of > IpmiCommandLib > > stays in edk2-platforms without relocation, which can be pulled in > > to platform DSC as needed. > > - PlatformHostInterfaceBmcUsbNic would be upstream to edk2-staging > > temporarily because some requirements are necessray to be spec out > > in the Redfish section in UEFI spec. > > > > Signed-off-by: Abner Chang > > Cc: Isaac Oram > > Cc: Nate DeSimone > > Cc: Michael D Kinney > > Cc: Liming Gao > > Cc: Zhiguang Liu > > Cc: Nickle Wang > > Cc: Igor Kulchytskyy > > > > Abner Chang (3): > > Features/IpmiFeaturePkg: Add IPMI functions > > IpmiFeaturePkg/IpmiCommandLib: Add IPMI functions > > IpmiFeaturePkg: Add reference of IpmiBaseLib > > > > .../IpmiFeaturePkg/IpmiFeaturePkg.dec | 5 ++ > > .../Include/Library/IpmiCommandLib.h | 62 +++++++++++++ > > .../IpmiCommandLib/IpmiCommandLibNetFnApp.c | 88 > > +++++++++++++++++++ > > .../IpmiCommandLibNetFnTransport.c | 43 +++++++++ > > 4 files changed, 198 insertions(+) > > > > -- > > 2.37.1.windows.1 > > > > > > > >=20 > >