From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (NAM11-DM6-obe.outbound.protection.outlook.com [40.107.223.79]) by mx.groups.io with SMTP id smtpd.web11.4848.1666086648471850025 for ; Tue, 18 Oct 2022 02:50:48 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=y3yqXdbS; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.223.79, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VLCvyofViJTMulwc2F2ZKVcs2dwAlErXSkgxBfSfZLQ352vHHfCJCAAtPkAbqX53vqUkc/Of1/1/9S7waE4phEreGjhvVtyGU/mFH0u7mdO7UYk7XbePcsC87PVswfyQqEaelajtvqpNIr6nqDYr0MavNQj6iKbyFeFFOOOKQci5NlH3hsEksntpnTpwW6hSUvXQ7mE4ndsVrb/W9brlBCYDEOKnHKXbB0Ko708U2t4luzxqlWAgqq9eEDkgGYyI6XtPqJApEA9d6KuE8c01zbJVZXE2EvMAJc3zjWXgZNA1dAj+9e4vbUFgdKnY2mSMr1aaeZnz8ngbMVpWODBTKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Hvh6H53zaQKbapp7dMypJJ4Xz/mzJ1ZTSrAbp5rtQ7k=; b=SJS9uJG0X3Hpuvcc4wMOS/G621MKHGI5MSXO05JykaD9j2IVGeXvkID8Zc68cVmHfhWDzsulS87MX0TqqB6rglj9cmgPUZJrc0w+0d5sQolUkx1qxMEqKivsnIeMZ8cBkhZHOImBpzYc0M1AtFRhdE9WUdvyJLBn13x5AIr1f4kXCH9eNZvmwMJ8xLzBpMR6bKnQmDpdyVDg1R0i1mWoeK825Ipin0d8MxDp90pqvbyuC6LMW2h7BJZALtf/3JhQMCCRFghFYLSCkCLrpoNpCQqQ/++RrzV4vzicJkbWhMU/5QgHM2J7jedg7nx2XbxjMQyR5VyJY20X0lZiaei1uQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Hvh6H53zaQKbapp7dMypJJ4Xz/mzJ1ZTSrAbp5rtQ7k=; b=y3yqXdbS0e1SNaj8ZYq53FwQ6J1bf9C/jr/rRon/rgHu4rsTIFggxpF8BbB/tUQxcDi0KrGF5h1XO3GbNF64GVQ3kMEQjoJv63SP04LYNHb6HpRWF2LorRkD553WNVG+BrrCHsxc0/jpJEQSbZmvl18R0s5mpueBFa+blUzWJrk= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by BL1PR12MB5240.namprd12.prod.outlook.com (2603:10b6:208:319::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.32; Tue, 18 Oct 2022 09:50:46 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::2eab:b851:827c:1d88]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::2eab:b851:827c:1d88%3]) with mapi id 15.20.5723.034; Tue, 18 Oct 2022 09:50:28 +0000 From: "Chang, Abner" To: "Ni, Ray" , "devel@edk2.groups.io" Subject: Re: [edk2-devel] [tianocore-docs][PATCH V2 2/2] edk II C Coding Standard: Updates 4.2 and 4.3 sections Thread-Topic: [edk2-devel] [tianocore-docs][PATCH V2 2/2] edk II C Coding Standard: Updates 4.2 and 4.3 sections Thread-Index: AQHY4rcWPTSlQa6vmkKZa0/ySI3iUK4T5O5Q Date: Tue, 18 Oct 2022 09:50:28 +0000 Message-ID: References: <20221015114757.383-1-abner.chang@amd.com> <20513.1666072896702226815@groups.io> In-Reply-To: <20513.1666072896702226815@groups.io> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2022-10-18T09:50:25Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=78326f6d-fc56-4f8f-94af-d36ea31b7d13; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|BL1PR12MB5240:EE_ x-ms-office365-filtering-correlation-id: 879421f5-888f-409e-1439-08dab0ee300b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: NYFJ2WPrN1lqherEG+DjARxBwiPPhymt6uVu663y278AVTw8V2cR6qweZIe8aVJvebVrZTsNRqU/8R22y5EAqVA6i+/S8SjVkMfct+gXqvpYinq6lT/jx5o6G0wAeR+oTWiTv3B/iojBBgF2Wk5th8R3OGtL8ju5q4nB4aNLZqsxlSk5sI/vJ8Le23xvfQ19Zo7B26lTEaWCBQ44f9rw1NLkr/yVNx13VA9p3cDHbuHYUj0dOFpWTem7PVHkhYL5tk03JB8+gWR9jvn8hFC1oxu1END/SQ3ZvTPbTNCl5uqvOwx0oVQUCtdF7+OvOIqx8nJPtHO8zpQZ6I1DcQL/k9keagwXzWpXDRzbOuOjqDBAIbUDhLFg/Xsa4h3raBPsMPkRkN2LSbRaHOL44JLuKl++up5hunR8RpfezGZD5Ci6C726zwebXieNv0E/5BHZwzqN3l47c5gHlgmSrCUZecC/K1TRlfV653Gx4V0dHA4x8mHwkunPRseAMZ9twlmeGREGd7mAB33s1KL056PZFZ8MxuHbvYuO2EIbqYitApHr2P18niZD8VkVRjG3/LG4cIY8voDHe8XzdFtNdXcMqVI+GCAbx3l8UfFoiOd26NyIXAS3wF1XBtZgy80/g+wzDgxUr5Ca6srJXBYC+vK1T/jHJmYVO8iiKpGe2dAxi0+5wbVc11Io5GKlDlYSUyw2o7kHdIJZOljG5y6WLQ7pnUPfTorPXpClJYlC8uj0+u1D6bsfFcqcNuu4s/6k1Ic0WGCUR3BDrRUVQ2Ya9FkmhQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(346002)(376002)(136003)(396003)(39860400002)(451199015)(53546011)(186003)(38070700005)(83380400001)(86362001)(5660300002)(38100700002)(122000001)(2906002)(15650500001)(52536014)(64756008)(8936002)(55016003)(8676002)(41300700001)(478600001)(26005)(9686003)(7696005)(316002)(6506007)(66446008)(66476007)(66556008)(66946007)(76116006)(71200400001)(110136005)(33656002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?0YoXynV1C0MzqtwMDh5/BqrK23UW8WHqKyTfWe5u1io3y7VEvIWWHeJRQGYe?= =?us-ascii?Q?h6MbzydFalirsSwNWA+AuNjP+LE+3S04ilK5hFHNPiIJv+4tl3/050BKJQJ6?= =?us-ascii?Q?p5vo5d55HLt3mxgDa8Ggq/myPdGi8I+eAveCZ9kj2tS9EexB7lbaA+WjtSmf?= =?us-ascii?Q?LXVxsNtCqR972CvX7A0w0HQ96ry7yFStOmODSUU458EuLfzs3xG93BeR7Eo3?= =?us-ascii?Q?ouNB2Fn2PV2knVBvOV0rGNcrn+8nnuNTGAJyB/BkNHlacmfmo/S9izHIC0FF?= =?us-ascii?Q?HwBpdX9B0Qw2Ns3bTCWqSRbyNwK1AOKNBO2DJLq1yfSRhkvwdJz0bG2X2LJc?= =?us-ascii?Q?GIU+yybcO0VIyO8vo3BD0Ti7EMo0NN71N4qAhMp3z8/UZXnReSQydmpLDMw3?= =?us-ascii?Q?dLXCxBLnxXtUeA2UeQuPBHX5aYj0vL9LGmRoF8/7sjstlTV/kjMaNCyzqww5?= =?us-ascii?Q?isbMlVoAmkRznJc9yGxQ6F7XP8/5g/IaE3V9x5t3UWIk3AiCPfGtzvRUD40S?= =?us-ascii?Q?HpBCsBJwX0gnTmcW8YSlrU/DsEoqA12OvBcQ0Ft95V9geuLLa/iMBHBHYiqp?= =?us-ascii?Q?SgkZsaDmDqnXRD5S+zuPgwL46X+6PWIuFHseL8JtZ2o2IYHjDFs77q7mod70?= =?us-ascii?Q?Vw1A9LvuVwQLWywBWWk7kZ0h5s78wII02bTqWloQsl1c4h14PWySdsGmrwbW?= =?us-ascii?Q?+jb2z6IoaEWWVyekPnLDQw+Yau6MrjomJ6r30WnGFj5sPzMQesSaSXbEHRSW?= =?us-ascii?Q?AvaceQ26skx0MHfc2pU0vZ1MgQb88Z1hGngcr1p9Y5boUT8sA3hVXf3EnvHD?= =?us-ascii?Q?tltBvdEXl8PX3ahbVIOS5Xi8xUq4cBU6KvHNSVKgnGsSQWSHlNJnPL+9J7Gx?= =?us-ascii?Q?pgh982p2lSPo3QtsYSd25/GAeB3DRuj+hkJSswyF0hOlLESaJTH9Zl4zneEP?= =?us-ascii?Q?GExVVCicWs6qMmnCO0Lhg2JS0fDWkH+fHK8ccDbptqImXWt9mavyQbh5TApY?= =?us-ascii?Q?Wf/d9GiWCLAQar8iouDiQ+HHuVo6/PXZ/2paCBI9UGFAi37fVLgbl9s7A7qp?= =?us-ascii?Q?oshrmWZDEzqt80dxgWBh17OovuU8T9uKtpZt6doyCsLGk2K6z9487nQnmjpV?= =?us-ascii?Q?2QVC2pzgx5hc2naTwWgqWdWnM6A8XgoSLLmmr1eRtpcEevk4USD+bQiAju1W?= =?us-ascii?Q?OTydImTyh8HCY3XprkmMr84UNYshTf1WZjuP87EapiY3o84ucy7+7hpJf5Bq?= =?us-ascii?Q?EymURSAsF+G9CsmYHGrpWV80e+BhCMnK8J8vVudo7TvoRXFRwLXLvffhV308?= =?us-ascii?Q?qKD3YEs++vLNqMYQWpVZC3Do/1Oc2nHIiqOzKTl+B9oHVPJLJT6gmuegZ8EN?= =?us-ascii?Q?s+epZZXWdJa1LDL25g5JKvb7Ys2hqPrhLcW9X1Nrf2nvTTm8+NccicDQGzEa?= =?us-ascii?Q?5Jzi6GjRCNvkagflrWv5oxZBVI+Mz3QaUnYG/+ucIrDeKPUC4p/VUuP/Z5BQ?= =?us-ascii?Q?UBl2iUCycrixoAr5bukDgWBRhbXHeyeUW1WW/1fZamyRHUHC4rrhKg/7xB4x?= =?us-ascii?Q?UQAPWIfxiDNe0rIzxJnoJ9FK2bsouykObFPVynAC?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 879421f5-888f-409e-1439-08dab0ee300b X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Oct 2022 09:50:28.0458 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: V8a3mHuQaif/voHc6WIVLq4r4Zls7CysMQhItCND8Taeqt4jbJDVq2jpeVyedhBhVf9Sgc6SSTmF8T9UsvVs7g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5240 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MN2PR12MB3966B650F0ED43483C45D1D6EA289MN2PR12MB3966namp_" --_000_MN2PR12MB3966B650F0ED43483C45D1D6EA289MN2PR12MB3966namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Hi Ray, ][].* The simple naming rule was already defined in the 4.3.1 to 4.3.= 4 sections. We are not intending for defining the file naming style. This s= ection is mainly for the format of attaching and to the = filename. For example, how do we add AMD to SmmCpuFeaturesLib? Is "Amd"SmmCpuFeatures= Lib or SmmCpuFeaturesLib"Amd"? This is what we would like to define for the= processor archs and vendors. My opinion is we can just leave the file format naming as it was defined in= this spec. Or how about if we say "Refer to 4.3.1 to 4.3.4 sections for the file namin= g format" for in below? [][].* OPTIONAL The is represented with a BNF, ::=3D'Ia32' | 'X64' | 'Arm' | 'AArch64' | = 'RiscV64' | 'LoongArch64' | 'Ebc' ::=3D []* Example: Ia32X64Arm or RiscV64LoongArch64 OPTIONAL * REQUIRED Refer to 4.3.1 to 4.3.4 sections for the file Naming format. Thanks Abner From: Ni, Ray Sent: Tuesday, October 18, 2022 2:02 PM To: Chang; Chang, Abner ; devel@edk2.groups.io Subject: Re: [edk2-devel] [tianocore-docs][PATCH V2 2/2] edk II C Coding St= andard: Updates 4.2 and 4.3 sections Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding. All look good to me. Thanks for addressing my comments regarding simplifyin= g the rules. Except for one minor comment: I still don't think we need to define rules f= or source file names (4.3.5.4 EDK II source files within a Library/Module i= nstance). And the rule "[][].*" doesn't specify what could be. That leads t= o allowing any style of the file name. --_000_MN2PR12MB3966B650F0ED43483C45D1D6EA289MN2PR12MB3966namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

[AMD Officia= l Use Only - General]

 

Hi Ray,

 

<CpuArch>][<Vendor>]<FileName>.*

 

The simple <FileName> naming rule was already =  defined in the 4.3.1 to 4.3.4 sections. We are not intending for defi= ning the file naming style. This section is mainly for the format of attach= ing <CpuArch> and <Vendor> to the filename.

For example, how do we add AMD to SmmCpuFeaturesLib?= Is ”Amd”SmmCpuFeaturesLib or SmmCpuFeaturesLib”Amd”= ;? This is what we would like to define for the processor archs and vendors= .

My opinion is we can just leave the file format nami= ng as it was defined in this spec.

 

Or how about if we say &= #8220;Refer to 4.3.1 to 4.3.4 sectio= ns for the file naming format” for <FileNmae> in below?

 

[<CpuArch>][&l= t;Vendor>]<FileName>.*

 

   <Cpu= Arch>   OPTIONAL   The <CpuArch> is represente= d with a BNF,

   &n= bsp;            = ;          <arch> ::=3D'= Ia32' | 'X64' | 'Arm' | 'AArch64' | 'RiscV64' |

   &n= bsp;            = ;            &n= bsp;       'LoongArch64' | 'Ebc'

   &n= bsp;            = ;          <CpuArch> ::= =3D <arch>[<arch>]*

 

   &n= bsp;            = ;          Example: Ia32X64Arm= or RiscV64LoongArch64

   <Ven= dor>    OPTIONAL   *

   <Fil= eName>  REQUIRED   Refer to 4.3.1 to 4.3.4 sections for t= he file

   &n= bsp;            = ;          Naming format.

 

Thanks

Abner

 

From: Ni, Ray <ray.ni@intel.com>
Sent: Tuesday, October 18, 2022 2:02 PM
To: Chang; Chang, Abner <Abner.Chang@amd.com>; devel@edk2.grou= ps.io
Subject: Re: [edk2-devel] [tianocore-docs][PATCH V2 2/2] edk II C Co= ding Standard: Updates 4.2 and 4.3 sections

 

Caution: This message originated from an External Source. Use proper caution= when opening attachments, clicking links, or responding.

 

All look good to me. Thanks for addressing my comments regarding simplif= ying the rules.

Except for one minor comment: I still don't think we need to define rule= s for source file names (4.3.5.4 EDK II source files within a Library/Modul= e instance). And the rule "[][].*" doesn't specify what could be.= That leads to allowing any style of the file name.

--_000_MN2PR12MB3966B650F0ED43483C45D1D6EA289MN2PR12MB3966namp_--