From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 0DD50940ECD for ; Mon, 2 Oct 2023 02:16:34 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=lnF6C7AIf+BUruScM0ob8JEo7sYZtAziCar/3VHqPzE=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1696212993; v=1; b=f2C5822rn77FDcipWkbb37TMXU9iBR/GI2419kGkC9rvK91tny0MaaD/21mHUrs7NkDjA8R+ U4swnpYk15Gk2ZTmflgzt19wjcwTuA5N6z8fyGrgY2OK+HXLRE5p4H9b00KdFrCtFlVM8RYFjfb Ox3sGda9IFtxl2FT5bsZT0Pw= X-Received: by 127.0.0.2 with SMTP id S1drYY7687511xp2mbfH1rRF; Sun, 01 Oct 2023 19:16:33 -0700 X-Received: from NAM11-DM6-obe.outbound.protection.outlook.com (NAM11-DM6-obe.outbound.protection.outlook.com [40.107.223.73]) by mx.groups.io with SMTP id smtpd.web10.73606.1696212992954834581 for ; Sun, 01 Oct 2023 19:16:33 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lzUrpmaOdaRS97pc7KaUnrtpTaCFp21QSv2EdgKyjdu5gRRKKopdEDvjGwwKvCDwI+TiQNl/qcLWi86iFfzJPItNOEIIfC1aRwZN9Yx2NCehydeqDIWS4ROWcPt/kX5VaxdgQ4mcfWPLyPPBXdGDgDZW4OdlFWxXgxwORWbK2gty1lAO/pt2gHekz72CSlppk/6DreKoaG0vRjxBl0ZUM/1rtO/cA9puE1d7hfxWcJKnnnfrUwdG0DQCN51o17GyN+gAJpKW6uhLEg9jp0IzbznuNXsqJwRfr5ZFQ1T6heShJdGKVJQVy85098TvXXjUXEMM3Pz4QVXZKHCcYjpACg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qT6Gc9VPTjysoKEWJ6FtqLEAjXcU+Zivub3C7CrEfTE=; b=LC9T1gOxfc/iHcjjNOhgGTfNe4+1EF0JmPheWwUd6LMZWEWVzjEC40VPAdaFA1PRO/MhYJGdMptBSQRAvvUht70UrH1hWJ8atvqJzUfB3XQ+p3MBUyNdYLv8mqoMT3A5N7oQvK+y9BKuJxZzj3nc/V3k78G3HOg/h8ts4qGdJWXN35Vl36FTstKIZxrjIGuarPiRFq9GBqIAqPX0Fjx5MivPUEmyHh/H2lWHFleQx/L0Niy3M9H6/IOPtLM1IpN7OxsjV25bYj6Nz5lqhi/cG6HsYdoZ+IcYT1OcKVJAJrHqZ6pGoK/ZMf3yv1chbgvnVwi67KXd0q0dErDqSxiqpw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by DM4PR12MB5118.namprd12.prod.outlook.com (2603:10b6:5:391::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.28; Mon, 2 Oct 2023 02:16:30 +0000 X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::2061:ca33:b659:2c02]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::2061:ca33:b659:2c02%5]) with mapi id 15.20.6838.029; Mon, 2 Oct 2023 02:16:30 +0000 From: "Chang, Abner via groups.io" To: Mike Maslenkin , "devel@edk2.groups.io" CC: "nicklew@nvidia.com" , "igork@ami.com" Subject: Re: [edk2-devel] [PATCH 2/9] RedfishClientPkg: fix DEBUG macro arguments Thread-Topic: [PATCH 2/9] RedfishClientPkg: fix DEBUG macro arguments Thread-Index: AQHZ8yA1cgN97WjLXkyanhTuUBFJzLA1xprw Date: Mon, 2 Oct 2023 02:16:30 +0000 Message-ID: References: <20230929215915.46616-1-mike.maslenkin@gmail.com> <20230929215915.46616-3-mike.maslenkin@gmail.com> In-Reply-To: <20230929215915.46616-3-mike.maslenkin@gmail.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=e554a5ed-7a52-4b6e-8328-ba9f318a44bd;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-10-02T02:16:17Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|DM4PR12MB5118:EE_ x-ms-office365-filtering-correlation-id: d4f742f6-c6af-4658-f701-08dbc2ed9788 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: kRlZpuVunOV7c/f7OjS1e9W3M0IQenDzkTTRci9VRtQrkP6OsEEbhi1C6+yvlykffLmnpaLxvmuFn2ZRiY+wwltVudIARregm8TR9eJRTQNETmRlFLw+GIbTuZBEFQabqUI6BAmBke931FcRihGmKLkX7g3PeQu/WNxzFRyD5V/0+nka0jDyRFYh+haIW/2R2CtFEVtK/5QYHiyVoGvu9LQVXxBPUExYtyQBEuBsZGZ5Yw7yq4BbiigeFplWDCmKrDklJtHAr7JnfuGf4dsQdjYAswZBeSsmbeosfaFRJa1fWPermRMVX8fH2QWE0EVaFaMb65UOowyiPpbo7xqiaUPmYX9snfOYUb84ZRnVNII0WCsgdX4ELzmdm4w9b7uPk7N1FDzEFO0f5Qu5zLJCq7c8hBgos85znCQV8+OdhFo5vqYylC+HaaJLs/nX96cwIU0/gLq2TwbKHLb+ywfYXNX8/RetMACMPxyqvLjZ/aQ/WZjH3ueBC2O1ezgq3G9AMoYIXOd7ELYbhlbkDetGkLtNvybcW87HY7V3/9e1vX44SzrARava/+ZUX3UGqMz0VcCAZ6OIDBBVU1Wb41EAsUsfs8gF4uDLlVPkREnfC5H4pHHIHcNNJuTRjc2ZLMA2 x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?gLx1S/N2Da8UMCx4lk3gaFOLHccJccWd6H8VGjBTEI/z/LnQzPVP/WTuRDVY?= =?us-ascii?Q?vW2CPaza/y8hpNiTHpjJ6rG8wFLOEWzp8aimHXA2nQORRxXWv71qah2KeGNe?= =?us-ascii?Q?64JPmKx6EzYxi05XdUAuxxKtFtmgMha9ZnwKKYOP44BZHx6pGkjV7F9gzUo3?= =?us-ascii?Q?Ke8BkArd8hfBKbOFnSfP0bGXzQnV5ihSoqymJKuqAPY+AiQv4RnGd5Ob5jwS?= =?us-ascii?Q?Qh+a3Z8PxwFyTqBWpI/76mRcuH6FcV3f+soSt8cn+mnj6gvgjB9x84dVgBig?= =?us-ascii?Q?EWKKKTMW1mD1ftnNlriMHaVrq9YOjrpCYnRpLxf2C8qUibA20jVx8Hm0IX2d?= =?us-ascii?Q?k03zq2XmYKj0qg7bGazpcZm9zPVraWeURebkRCDZPEfvVUWSXXrvUCMdBgrx?= =?us-ascii?Q?XdNek4bRO5rf/l/6/YOhZILQxC34u71EaQmKvpMKcdnF+W1cshRrb2qWXFbz?= =?us-ascii?Q?npzGSuJqsOPrcJONFKnDsxD/NC9h1KqOdBEnmBuTZRv72EVENutrXyWTDktO?= =?us-ascii?Q?MygkNGEzcXlOBlXVm2XLfq3JEypDjRqn4m3CSYym9JSMLI7tFONQiORS8bga?= =?us-ascii?Q?zwwRbqYyFzX87Y/rQpuXouDS5vsJWDO/rid0oI9rkr0CE8xga3cvskEy63Xr?= =?us-ascii?Q?wjEKbhQVFqV9bbFFRA7IAdq4EC71DVmjNwZyh4Mz5S1YPVLRk7C83ZG3tQRj?= =?us-ascii?Q?odDv8z0nc+EB0Z4Ebs+xnhNw1ZKsjiRzUw436w2QLYS4Y1PcEpJur50IAXuJ?= =?us-ascii?Q?XzzNwoHGj2JeQMiovpeTj/KiCLpqzJZ4liyzVWJ+uuuUE84+gSEORyCyDevB?= =?us-ascii?Q?wTIaS++97a75kCujmy4uOz85+w79aGjg4P8XVCHr9b3UWH81Rz6T64YDo5JJ?= =?us-ascii?Q?UC7qY/i+B8YshQr1AVQwPsY/Q/RrUAq5FoGFNXDbu/pJV2uSFiFAg+UGOczk?= =?us-ascii?Q?WyioXgjuxBJQrGcMDsxKrxoXWgYPHY/bMdL4LrY/5R21bdtHAqH9teWb6tqB?= =?us-ascii?Q?c9sIIgIyqADXUAmhnWdBpvkTpWQAejIByEmrVqJLFe9gBX/Dq4Ka3LsjWVjc?= =?us-ascii?Q?UXqfSHZ+L0TxBpOGn8Qh3BcCk90n9HEiXd1XHEtExbVwgIKxmgTjRUVo23tR?= =?us-ascii?Q?2ESwXlVhEQQE7JiSe6Q/Zf80TMZErr0tpzrUg5Ea1hgpRdcGm5dFgfafQIB0?= =?us-ascii?Q?sb5jRAJZJ3D7rv2KTxkoo71BaLJchkaa9wEXmxnws0hGouuqwP64PtYFEcp5?= =?us-ascii?Q?iDU1w3QTjn95TQX6xG8hyCjU4bzkVBs9sx9qH5OGctucVAfIJnvmnrcEHRru?= =?us-ascii?Q?DFWyAFqdkGk5arLVZJVISiqaxtTggk+1Lg4qoqdKAjTh+i6SY6tkPZA+fomB?= =?us-ascii?Q?gg2XWtoZRrRVID03nIObU69GiyDvDx8eLJB1YoBeblFLyGlj+7R2cJ3cn+bB?= =?us-ascii?Q?KbwSH4Ajbjl5M0WeE5uGEhUvgn2UmAGYDaBNNQTY9D53RGyQpf038tT5g9np?= =?us-ascii?Q?uq75T3a1cmvJUYPc5fR+In8qgTa/KcZfjKk/cD+hGkna6iPIRlwXm7OZI9wq?= =?us-ascii?Q?0OKoP2ppHDcurGpTP8w=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d4f742f6-c6af-4658-f701-08dbc2ed9788 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Oct 2023 02:16:30.7977 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0pGg4n/TjP+ceMmx7yzsn07s2MdryPNDL+HVebkk5tzmRXDsbqsiM4ZmRk2yLk+mM8tMWiTIQXxDMwK3xDfQgQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5118 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: Ay2NnO3VbHEHYhGsKo9k6Koqx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=f2C5822r; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io [AMD Official Use Only - General] Reviewed-by: Abner Chang > -----Original Message----- > From: Mike Maslenkin > Sent: Saturday, September 30, 2023 5:59 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; nicklew@nvidia.com; > igork@ami.com; Mike Maslenkin > Subject: [PATCH 2/9] RedfishClientPkg: fix DEBUG macro arguments > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > Signed-off-by: Mike Maslenkin > --- > .../RedfishFeatureUtilityLib.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git > a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtility= Lib. > c > b/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtility= Lib. > c > index 1e5c3f110de6..35e342c817b7 100644 > --- > a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtility= Lib. > c > +++ > b/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtility= Lib. > c > @@ -332,7 +332,7 @@ ApplyFeatureSettingsStringType ( > DEBUG ((DEBUG_ERROR, "%a, apply %s to %s failed: %r\n", __func__= , > ConfigureLang, FeatureValue, Status)); > > } > > } else { > > - DEBUG ((DEBUG_ERROR, "%a, %a.%a %s value is: %s\n", __func__, > Schema, Version, ConfigureLang, RedfishValue.Value.Buffer, Status)); > > + DEBUG ((DEBUG_ERROR, "%a, %a.%a %s value is: %a\n", __func__, > Schema, Version, ConfigureLang, RedfishValue.Value.Buffer)); > > } > > } > > > > @@ -462,7 +462,7 @@ ApplyFeatureSettingsBooleanType ( > DEBUG ((DEBUG_ERROR, "%a, apply %s to %a failed: %r\n", __func__= , > ConfigureLang, (FeatureValue ? "True" : "False"), Status)); > > } > > } else { > > - DEBUG ((DEBUG_ERROR, "%a, %a.%a %s value is: %a\n", __func__, > Schema, Version, ConfigureLang, (RedfishValue.Value.Boolean ? "True" : > "False"), Status)); > > + DEBUG ((DEBUG_ERROR, "%a, %a.%a %s value is: %a\n", __func__, > Schema, Version, ConfigureLang, (RedfishValue.Value.Boolean ? "True" : > "False"))); > > } > > } > > > > @@ -585,7 +585,7 @@ ApplyFeatureSettingsVagueType ( > DEBUG ((DEBUG_ERROR, "%a, apply %a to %a failed: %r\n", __fu= nc__, > ConfigureKeyLang, CurrentVagueValuePtr->Value->DataValue.CharPtr, > Status)); > > } > > } else { > > - DEBUG ((DEBUG_MANAGEABILITY, "%a, %a.%a %s value is: %a\n", > __func__, Schema, Version, ConfigureKeyLang, RedfishValue.Value.Buffer, > Status)); > > + DEBUG ((DEBUG_MANAGEABILITY, "%a, %a.%a %s value is: %a\n", > __func__, Schema, Version, ConfigureKeyLang, RedfishValue.Value.Buffer)); > > } > > } else if (PropertyDatatype =3D=3D RedfishValueTypeBoolean) { > > // > > @@ -617,7 +617,7 @@ ApplyFeatureSettingsVagueType ( > DEBUG ((DEBUG_ERROR, "%a, apply %s to %a failed: %r\n", __fu= nc__, > ConfigureKeyLang, (*CurrentVagueValuePtr->Value->DataValue.BoolPtr ? > "True" : "False"), Status)); > > } > > } else { > > - DEBUG ((DEBUG_MANAGEABILITY, "%a, %a.%a %s value is: %a\n", > __func__, Schema, Version, ConfigureKeyLang, (RedfishValue.Value.Boolean = ? > "True" : "False"), Status)); > > + DEBUG ((DEBUG_MANAGEABILITY, "%a, %a.%a %s value is: %a\n", > __func__, Schema, Version, ConfigureKeyLang, (RedfishValue.Value.Boolean = ? > "True" : "False"))); > > } > > } else if (PropertyDatatype =3D=3D RedfishValueTypeInteger) { > > // > > @@ -640,7 +640,7 @@ ApplyFeatureSettingsVagueType ( > DEBUG ((DEBUG_ERROR, "%a, apply %s to 0x%x failed: %r\n", > __func__, ConfigureKeyLang, *CurrentVagueValuePtr->Value- > >DataValue.Int64Ptr, Status)); > > } > > } else { > > - DEBUG ((DEBUG_MANAGEABILITY, "%a, %a.%a %s value is: 0x%x\n", > __func__, Schema, Version, ConfigureKeyLang, RedfishValue.Value.Integer, > Status)); > > + DEBUG ((DEBUG_MANAGEABILITY, "%a, %a.%a %s value is: 0x%x\n", > __func__, Schema, Version, ConfigureKeyLang, RedfishValue.Value.Integer))= ; > > } > > } else { > > DEBUG ((DEBUG_ERROR, "%a, %a.%a %s Unsupported Redfish property > data type\n", __func__, Schema, Version, ConfigureLang)); > > -- > 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109243): https://edk2.groups.io/g/devel/message/109243 Mute This Topic: https://groups.io/mt/101667461/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-