From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 11ACC740038 for ; Thu, 23 Nov 2023 03:05:20 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=/2ugiF75SyDsQnDxV1c8UJp4wgSwgv3M54/TDwloyLE=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1700708719; v=1; b=acWtbFURGT1hX0dy7ZA9nTB2eNC0BZt/xBzPm2DIjuJE1quelOkWgq6fLz0rsGxTmr7qbvqB Xbnws/NXj3BBpdg+/yE0BLNMW6PfI7sJwgWFIO3vFD6TYgJKPWeLYzn7K0AlDdsrpx08jZroQZA PLU5PAP3e9rQG3kPH0G0pmBs= X-Received: by 127.0.0.2 with SMTP id TotZYY7687511xi0LShcwTrx; Wed, 22 Nov 2023 19:05:19 -0800 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.41]) by mx.groups.io with SMTP id smtpd.web10.83693.1700708718914743152 for ; Wed, 22 Nov 2023 19:05:19 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ktYdbrMgF/6WJV0JrZYqgq/p0FkkRmw39QcjrWjFUwMQRvhZ2yfd7Kja1TI0rOXkjsWBmTflCB9aOnxuZY6Uz5WenwZDQpFe73QGLrpm3dTzYZhutNvr79KAL2F+RZyXUj9XUvPbK40aeRw+QF3vH2gtahUu1Il9x3cHc3dWm93DZ0rP9wegMyMKCV7IXlL7dcFu4PapRvDay9Wvw18yZYAG99fYkq3f/TuIdd1TH02TOABiAwgf625+GcSOKZfv0g+vqVMVo46yPAfRGTUiNLk04B7LEnWNGnztlxSG8nQkmIO/bwi1peC7Hlo45uuR/8C1KFf+1ZvGT22sD+CGOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=m4yFg9rbwrf10yLJVydOF7OjSzWpYyERnqZ4xnAl9ps=; b=cSDgCliiWc0wdTC/iBSjpCS5rqghV9v17QUIM6j67YmjO1Rq9GEB1eupN1eurSuZq1T3IThf7AizyyBxuch0zeEqVeO20Ydx1XJ/GlLhtvIqq+kybq5ZisqAyUcJHNPAG4eoA2Z++viN3HoFA26Kqq1qKi509LXY9a49cowPCJbNmpKmqwB/AFp813IeNSKj+sYqET85xnJKKAO5eIxfeIluZfMUSb/KQDKGEgLVLGpdDYdIN9RHKBDXPr8rs/ZVX9+VZAmV9VFOYzKoSx3jn1cZK4BMUU2+s7/yHpC3exmAtPpO4w0u+8KAcDpT1lgTxJ9fysG+7k5o4BaFMpqSjA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by CH3PR12MB8459.namprd12.prod.outlook.com (2603:10b6:610:139::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.20; Thu, 23 Nov 2023 03:05:16 +0000 X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::91d9:e679:32a3:dd05]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::91d9:e679:32a3:dd05%5]) with mapi id 15.20.7025.017; Thu, 23 Nov 2023 03:05:15 +0000 From: "Chang, Abner via groups.io" To: Mike Maslenkin , "devel@edk2.groups.io" CC: "nicklew@nvidia.com" , "igork@ami.com" Subject: Re: [edk2-devel] [PATCH v2 3/3] RedfishPkg: fix searching for the BMC-exposed USB NIC Thread-Topic: [PATCH v2 3/3] RedfishPkg: fix searching for the BMC-exposed USB NIC Thread-Index: AQHaHaAwd+m7wQyEYkCCg9zwhDrJrbCHOCTA Date: Thu, 23 Nov 2023 03:05:15 +0000 Message-ID: References: <20231123000103.31216-1-mike.maslenkin@gmail.com> <20231123000103.31216-4-mike.maslenkin@gmail.com> In-Reply-To: <20231123000103.31216-4-mike.maslenkin@gmail.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=323cf0dd-403c-4b1c-8f4c-d8cce338a287;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-11-23T03:03:55Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|CH3PR12MB8459:EE_ x-ms-office365-filtering-correlation-id: 3ca8e8cd-351e-4504-c1f4-08dbebd10469 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: SyubPnQZ4V9vTkMFkfQ9x4dZ3zFYhr3SadvuurTMMPdKvjl3PJ9ukr8QjHc4XNpm+HGqQ2L3yKoMbIyBG+HdFJfm9/bbdhJRCjWZBt7nt/kkbniR9HqyA5N6Dcp1s7wyic8NKW9b9sQUcq51D9P24BVN4WOOJJHIpx6NO2nVLnF1u/mm/aHXOSpHSt70luadxobOrshvtoD+hDgzeU6rvCyGtIJFXvT8vSQBV82j7WB1kC4hYs9ysVAon0GT1CXyxC8n5t5spNUMBQCdWYUpDGK03WVaO/zod6GsEfhMda9ZsP4p9BudiWaNvDSv5MM/h7KGGA5tkW0TN12nA7RBCU5YtOWjNJt1dMnjglCjvZxqf5tcCgj44/sWMLOj3rGJMLuo2k9Fp00exrAHCdm4xL5Ri8okXDMLirkVlSbvsXsbHKn63slGVVWcmRaZO4xwk6eIRwEw6yUzsR+CBusVA683kl62HPn+FcGHl1UsvXCKP4eysngOHg/lBLvFEtPZ1YQBoqpl6sODEcuZrrbtdcwS+/cfkzBsp6CZZBfaiv6v7yg2TR4yosLEsu+8TVkHFAngM/uM/2wXkWq6KNpJsZN1Vz2e6T7mDuXXUqvFBBs47FpXhNJgGFGLLnxGiX2RAzDHv1srsAkej8jPe/Hh1CcZl2k04BxSQo5EKFVZeA/poy/FUrsp7DEu27EKdjt4 x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?JY642EONrkrBV7n/3bHjZ6y332QMqw5IXpq1t8We+PVWWbd+f7ccWoBGhPeA?= =?us-ascii?Q?CuX9Qf0e0uYziCfYS4ovQM6jcWViva+3QvR6FlfCmfHVKuOKDQoHEKY8cIO5?= =?us-ascii?Q?7I5XzUC0fVEwJzxQbEED6Xh7fcavSGpH5MTSKOuunapOi8rz/3AzT7fuHgHA?= =?us-ascii?Q?E5F0ZZaQxausHIlaeazLQN+20wW2gVSxztyqZPf+AHz7DIxRLmuM5to0+x8t?= =?us-ascii?Q?fSP3uL+h7m/EJtPjFPMwasHi52YYPIEyyA77kUyYza03OMxeGcY6/UppVWYL?= =?us-ascii?Q?Pcox9dV/bnPcm2/8Puz9X3rmYhRnd3wawS4n4qRSiHTsbVj/2U1ch1Kp+QQ/?= =?us-ascii?Q?MylFo5LmS4A+4HHYwr75XxegzGLoLfGgwe1vXpH+YmJeT1glCRb7iqhCokYZ?= =?us-ascii?Q?XjZ6BwAOnl/iCYpkgg8gkCefNuNIzQaO8r7sMgJkjQoDe8akThFU8JrCa4cf?= =?us-ascii?Q?kT6VFVze8HObVRBOES+qdt3Bliq6w66XiURiLDePovsDQDRGywd64cO6D7yk?= =?us-ascii?Q?nK491wnRpvDHm6a1bwHzC97gXYyfrzEGTO6QCRqnD755lJiJZluIpxEmz6Ga?= =?us-ascii?Q?DpHql9KIxOlgOe7MlwlT/4DXR7wc1SBhCgGwBqeTQGi+dE94RyDG3/I2lW1I?= =?us-ascii?Q?hgIjozA5f1UB6L2yLYgCb+1hRBmLhYdKoafP3nZ2i5SzMagtSu+CJcyG4+rI?= =?us-ascii?Q?vtOsHSJo0xZKPwl99IzTGoyxBrdlpWi40bgi+D1/QLUgADwSptQKFmAFTJfb?= =?us-ascii?Q?0mfyzCNhaxeBgyd4W882g9I8sQyZ+h4QIHrJ2T2Nc/hOsXGc7OoU4pqd0p/d?= =?us-ascii?Q?aa8WoxcGfJa/OkxvyYfLmdbEguk7o/QYsgKenR8vkA/uCqsArhWc1Bc5R9Fy?= =?us-ascii?Q?GJL7WMBHwHBGpQvsj1vEAkRPcqBa0Hu2d9xMiRCKNAlYJtPfPw+G8ufEme9H?= =?us-ascii?Q?ltqtK5vyvCrkVr2oDaICXmtqi70x1rzYHC6k0Xnx0cEnMFwHQEVceNSFe2PM?= =?us-ascii?Q?58uLPulAIr10dYXXJK8s8/ejF5ZibJTjvi9MjxUCL61tn9pE5Xf/WaiUdodo?= =?us-ascii?Q?NkZhTgcFXhhLBouFcIBC/BYQnqydiDW2p5cpvXp1KywDxjdUGp3xs31sIuaI?= =?us-ascii?Q?6QuppcGPwDBTpjBZgwap0p6m9bPkb80rj9GjFlmD0fmyJxTmnI6ugYHa469E?= =?us-ascii?Q?WAgualA+UBG9VK1mVJlNsm1J+jkUDDEhbBu49kEDNnmBWOXCSaDm5YXPiRLe?= =?us-ascii?Q?e+Rhs3UGpWa8R3o530lBiptxSQTdxdz1Hd8v8U2pr8PUD+d5PxLxmAdXh06R?= =?us-ascii?Q?dDBlROBApfXW5Yihic6201gBRnGHarg1Rn9OXEnMLvcrX+oPNy8SpTdNrfYu?= =?us-ascii?Q?cYQblFgVz/gOJnxF/rorfTvVZgVBQZJZK3vE/vl3uGTqkkBoAL0NjaIeJo7A?= =?us-ascii?Q?nOwjj/YzuNK79Fw8TfnLk304lIwTmfRI/nNTehpv2A7JjvTCZdA9WmuD8QoC?= =?us-ascii?Q?z3qZaes8Chq7ZVVxU43xOHOJxaXvqRJNEPvOnOBAXzlAz+lOm3mh7eSXgjrb?= =?us-ascii?Q?o5X6/etV+C5fKrGSDs4=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3ca8e8cd-351e-4504-c1f4-08dbebd10469 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Nov 2023 03:05:15.7496 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: VP8vsII273TNty7A9DBWfrSvHgPrwpBJ8y9eaV/NJi9dDcFZ3P83y6yEDVb39AaoKaV2WreRjfu1gWuO7f5WzA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8459 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: kli8hQrJL0GC2EiJcvftOwDIx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=acWtbFUR; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") [AMD Official Use Only - General] Reviewed-by: Abner Chang Mike, could you please create a PR for this patch set? Thanks Abner > -----Original Message----- > From: Mike Maslenkin > Sent: Thursday, November 23, 2023 8:01 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; nicklew@nvidia.com; > igork@ami.com > Subject: [PATCH v2 3/3] RedfishPkg: fix searching for the BMC-exposed USB > NIC > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > According to RedfishPkg/Readme.md document: > "The last byte of host-end USB NIC MAC address is the last byte of > BMC-end USB NIC MAC address minus 1." > > It is necessary to subtract 1 from IpmiLanChannelMacAddress. > > Cc: Abner Chang > Cc: Nickle Wang > Cc: Igor Kulchytskyy > Signed-off-by: Mike Maslenkin > --- > .../PlatformHostInterfaceBmcUsbNicLib.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git > a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInter > faceBmcUsbNicLib.c > b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInter > faceBmcUsbNicLib.c > index 95900579118b..20ec89d4fcb0 100644 > --- > a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInter > faceBmcUsbNicLib.c > +++ > b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInter > faceBmcUsbNicLib.c > @@ -738,8 +738,8 @@ HostInterfaceIpmiCheckMacAddress ( > (VOID *)&IpmiLanChannelMacAddress.Addr, > > IpmiLanMacAddressSize - 1 > > ) !=3D 0) || > > - (IpmiLanChannelMacAddress.Addr[IpmiLanMacAddressSize - 1] !=3D > > - *(UsbNicInfo->MacAddress + IpmiLanMacAddressSize - 1) - 1) > > + (IpmiLanChannelMacAddress.Addr[IpmiLanMacAddressSize - 1] - 1 = !=3D > > + *(UsbNicInfo->MacAddress + IpmiLanMacAddressSize - 1)) > > ) > > { > > DEBUG ((DEBUG_REDFISH_HOST_INTERFACE, " MAC address is not > matched.\n")); > > -- > 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111643): https://edk2.groups.io/g/devel/message/111643 Mute This Topic: https://groups.io/mt/102759080/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-