From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (NAM10-MW2-obe.outbound.protection.outlook.com [40.107.94.79]) by mx.groups.io with SMTP id smtpd.web10.6399.1687307382155390959 for ; Tue, 20 Jun 2023 17:29:42 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=GweKP/a4; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.94.79, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A+Ql+gzmn45DMpsiKhfXRGRUL2NIeO7IoiuxJTgd/CWNlW2AQLMcJh208d2PMgYdZWNgWeDH4NRo//HR/Tq/G3hw9VzQIpLu/U5hVmkaI1v+zABh9FCfpyxgdn++NXwT3e8a1HKkDb+0zKL6A4DGg/CFdfIHoasaKCri1YqUe4HZixbjXnyQbB0hde53M37CxvQ9SnAVIhiMfvQHsnGFS5ATeWg8mkzHUKh9HVUt/XUoqrw+rFTMsRJkVJpgJ2/yNTzQ7F43mLUIUlrLKzJZERInq50MyQsy5gl2tX52mr4WJOpHEnp2IvamXDrTXx65X6/7EHZjWft3UoSREQfY7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2iGhBvW3WQgPwBo0KovuhYBWS4IyQ3uxQPKVWvZdNsA=; b=F2gTUMEVDfoApzK2+w/Lj8HlquFQDqY6h0QmifFr+rQvz4gNEGMI+SV+V5m4roVMzBuNUxQ00kbaJb54ZBLgodhBF9X/98/MTu3gM+VhHNM3LxYgoNhJExk+U0dpNWp5AQb367yuPE3mZqVLEPjljW0eBBgbdQzLjNjWWwneR4PBWpNmi3PeyR+MPfnr5uJWAI35E6FlQ8zKv4SJ/R3fsJSW1VUY3bj4lu4xyBuIGpL6KYhoX+RHPFsiesBW4vrt2sIZmLSHjysEO8I53B+j6x6n8cYpGae0NHAgIVbt8ClK2u35JCqF6pnP3LVvYV6uFL7+N8+0ESMzndSvjp5bDA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2iGhBvW3WQgPwBo0KovuhYBWS4IyQ3uxQPKVWvZdNsA=; b=GweKP/a4HcclBG+764R+JaI7FYVdng0SbgfOUsESXzEuSGVmygXbwGuHh0ogNteL/vVrR5CWd7B82CGBJj3e9c0wlrS/M8sOE/kT2smnOCmPmXP3zE34XuyvTxZFJuTsAH66Fspo8atvlzyRlLEOPqH8zhc9cHKfZQQ2DrA6Gbk= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by MN2PR12MB4048.namprd12.prod.outlook.com (2603:10b6:208:1d5::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.21; Wed, 21 Jun 2023 00:29:40 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::edb0:bed8:c650:5040]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::edb0:bed8:c650:5040%6]) with mapi id 15.20.6500.036; Wed, 21 Jun 2023 00:29:40 +0000 From: "Chang, Abner" To: Mike Maslenkin , "devel@edk2.groups.io" CC: "nicklew@nvidia.com" , "igork@ami.com" Subject: Re: [PATCH] [edk2-redfish-client] Remove reference to BaseSortLib library Thread-Topic: [PATCH] [edk2-redfish-client] Remove reference to BaseSortLib library Thread-Index: AQHZo76cR/9dtQ/ubES8roUVH/38E6+UZy7g Date: Wed, 21 Jun 2023 00:29:40 +0000 Message-ID: References: <20230620213137.28235-1-mike.maslenkin@gmail.com> In-Reply-To: <20230620213137.28235-1-mike.maslenkin@gmail.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=c5ac4b7f-0773-4523-900d-dcef528a171b;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-06-21T00:28:44Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|MN2PR12MB4048:EE_ x-ms-office365-filtering-correlation-id: b05f6f07-ee6d-4687-084f-08db71ee99e3 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: hJwiRmIcNHV1dIUG1uMZZpFQXWyFbsDVsFYk6ASumdPFF4ycp9ABYTzXsH0EjcwOM8mGk8q5xjkxG6v+/lfmMGCbRCaiSPrcXZh4TV5vny8fY4b3ATuODvGK+XY45nRXldbQCoPPmAGKyHotLh5V38GF3LrHE0tEOeNfdiKoAOaXs/askfEh+I5emuirF6k4RiHY+6zUueXt3ATSkngplrFj5buxCS9qvwJqSWdLMxCO0CYT5CW1AK54JKVQTDiOunQDZwGItIJETRXJgXyBFLhv8zrhCx/XAS8bUBZAtRC+fyw46JUWddkdIM4oLktWljvjccIpQHGwsO9gGQZUOv2yC4eRnihFFwV9lpx6HLn65uiFDDQpwSsd738sWvUG/xEvkynDRJ0Jgy/OX1pE1y0tsURW2Ld48pe3IijJblhmoKFeV7+A3Lw7TqS4chGp3NkUow+ftV+QN5TgnqGNbxVHedIRUrziOdQTz14vAUX3W0T6qUnYSiW3sWesr6HT+CaZ67BBPztgkE3CCYQpjKDUXSfOI5dNMXFg73Tcb6ULpqc6SlY4UnKW3+OI2fBG4vOEOIj9ubzolqr63/TCJ6j+LvitN8soTMmWjgmAtMM2rhb1uVA9EiRvRtq+Tnbf x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(396003)(346002)(376002)(136003)(39860400002)(451199021)(55016003)(2906002)(83380400001)(66476007)(76116006)(66946007)(8676002)(478600001)(7696005)(54906003)(5660300002)(9686003)(53546011)(6506007)(8936002)(66556008)(316002)(186003)(52536014)(66446008)(64756008)(71200400001)(4326008)(41300700001)(26005)(110136005)(38100700002)(122000001)(86362001)(38070700005)(33656002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?OxS6Nn6ioR25h4bEoGVbMZByEtrgwqFWk3MnvoT4OcJLmqZYIBjEAF1CUdNa?= =?us-ascii?Q?OehBsMivE7EE0E3V49/Lj1zlblZLTXC2xhFKwSMfxIN97dk5/AFQviOUmriq?= =?us-ascii?Q?x9j1otnUjxWP+rjg9JzJ5JH3uzsHODJ2LlYJoKyKOl898HEPEBIMndEy+OTH?= =?us-ascii?Q?z1MMIK2TDL90eI/0SIy/2+oWoB5jE4ET2hT99ka/XhZMfWQRjMcxPUUgiX40?= =?us-ascii?Q?neGxpOZeNSVxWepbQ8IpKZEpHOE8H/+oG6xTIqFdXxFFkst4HsFI17VjhAqk?= =?us-ascii?Q?HeIOV8CaGuxaf2iYrAbGIOCs5wzNebE90qjoifCV/Fj1F6FMojo2rFGrvh5s?= =?us-ascii?Q?wRCOBTmP6fnA+7MZmwQH+0nMwCzFaqd+iR1jl4dAu19s2XMwAIax7fkCI9Eu?= =?us-ascii?Q?PlsfXsGusRZxtaNAqIdXKR7tyDTwbl+3mNIuV3b7XPV/MKXq08aulImSTbl6?= =?us-ascii?Q?RqqSPokIw+riquCWKz2x+jQ9ZgcOnF+LnOZDpOKKYCsx3L6oTxsDiyKfdzXN?= =?us-ascii?Q?iDbmwlhz2DqVnzWRxxmgbtpVkoEhFe2ptxsAKWscuZvCPB9vGRsygkOsGn4v?= =?us-ascii?Q?TCXvQ5XV9EvOgV3nnKKATJd1KN7gVvp3ykE4oG3C2Zy5FkU4rKPb/gNPJwfo?= =?us-ascii?Q?dHx5Hexbwp/gETvbp8iTo47ULp11B6IJOEtp3JmRzp5VHd0yC8mDPT4W5HJh?= =?us-ascii?Q?zR+TIGtT3UPatIfQUZjYFFgqoBlTPEaJyes0yeJnMQp69dY4g5IOoTa7LjC+?= =?us-ascii?Q?HqwJYL/wWqd4NY+JfdvarwAON/8OHlu4q51nqB2coXEsN7oJ1rEMZasS1/7n?= =?us-ascii?Q?mNyvADdueTYS7ie8RSCr1j5O0OsbpiGwc8/qkj+hKe0oBnFIG9xdV9F8P56+?= =?us-ascii?Q?5nogbJh+JZKYzT1qq1+sYy//uRS+5Cz2eyE/7j8QgGElMASjhlIQqcahYi0D?= =?us-ascii?Q?PIthe5v0oT2bniyrmQVre1pz3T8W2Ptc3M8sZtApEo7UCPz9oMvoaFrhmZ0w?= =?us-ascii?Q?CYs3dET1FtTntDoAXWtKnSGXM5cEYL2u99uTFNofjnbT62/OXNoBhlqD2slD?= =?us-ascii?Q?D811NNGIUz0Bx99UkjChdatDJ92se4yCmpa2C6rxeNstUj/jzqekbNFgLWKh?= =?us-ascii?Q?VB7zcOo2BioNEHO9FLoJVfGfv2QfJ46pMtDoystm/DpUARkXnD3Sd8y/9sKV?= =?us-ascii?Q?5B26ZGVZtVONdul7nc4wN234LnA4TWbcTfCintG1yOpOWO3Ga33jF4vJi0dN?= =?us-ascii?Q?FbDBJg40lLhGS+9uflPZK8g5dN4RCzlY3mPrFHxjboZEoERLmG7tkr6mb8Cp?= =?us-ascii?Q?FTvyIjzNypkP9v8ZoY7iDRKFLMeJewGbR4gq5ogtqBC6F+HDtVH9MATwKBpa?= =?us-ascii?Q?McU5iPcOq3B+6skKf6lfUA/WQ34he6VkfZNLMdWaVNX7WLA8KOgllxZ4DQuD?= =?us-ascii?Q?xH1Tw7bx2H2/HH9eGcHjhM9/YC7KjUuFd6hFoXFrrIN/tlxscG1AQHcNzth6?= =?us-ascii?Q?jJmHkKO0Wcy/Fog0Mp9WJf/iiBeTECbwkeXLCVf0uqYmhR2ErgCu7gOGUkqM?= =?us-ascii?Q?dr55/BX2IrVQSGoFfSs=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b05f6f07-ee6d-4687-084f-08db71ee99e3 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jun 2023 00:29:40.0920 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HcyOTV8Rj2EyFCCQS7QsJ+gpjuvPKdWgIkicb6kVSUF/k3hWMn4rkx2iHtZM6MbCC0mrR5SBDSPkzpID7yy+Rw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4048 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] > -----Original Message----- > From: Mike Maslenkin > Sent: Wednesday, June 21, 2023 5:32 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; nicklew@nvidia.com; > igork@ami.com; Mike Maslenkin > Subject: [PATCH] [edk2-redfish-client] Remove reference to BaseSortLib li= brary > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > There are two problems with BaseSortLib reference: > 1 BaseSortLib is the library instance name not the class name. > 2 UefiSortLib instance from MdeModulePkg is also referenced below. > > Let's use only one reference to SortLib. > Even though Redfish Client uses only quick sort for char* elements, > UefiSortLib is preferred as it allows to sort DevicePath instances and > wide strings. Sure, thanks for the input. Reviewed-by: Abner Chang Abner > > Signed-off-by: Mike Maslenkin > Cc: Abner Chang > Cc: Nickle Wang > Cc: Igor Kulchytskyy > --- > RedfishClientPkg/RedfishClientPkg.dsc | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/RedfishClientPkg/RedfishClientPkg.dsc > b/RedfishClientPkg/RedfishClientPkg.dsc > index edc387ac72dc..e16c91b83196 100644 > --- a/RedfishClientPkg/RedfishClientPkg.dsc > +++ b/RedfishClientPkg/RedfishClientPkg.dsc > @@ -36,7 +36,6 @@ > JsonLib|RedfishPkg/Library/JsonLib/JsonLib.inf > > Ucs2Utf8Lib|RedfishPkg/Library/BaseUcs2Utf8Lib/BaseUcs2Utf8Lib.inf > > RedfishCrtLib|RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.in= f > > - BaseSortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf > > HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf > > > UefiHiiServicesLib|MdeModulePkg/Library/UefiHiiServicesLib/UefiHiiService= sL > ib.inf > > > UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBoot > ManagerLib.inf > > -- > 2.32.0 (Apple Git-132)