[PATCH] [edk2-redfish-client] Remove reference to BaseSortLib library

[PATCH] [edk2-redfish-client] Remove reference to BaseSortLib library

[Mike Maslenkin]

There are two problems with BaseSortLib reference:
1 BaseSortLib is the library instance name not the class name.
2 UefiSortLib instance from MdeModulePkg is also referenced below.

Let's use only one reference to SortLib.
Even though Redfish Client uses only quick sort for char* elements,
UefiSortLib is preferred as it allows to sort DevicePath instances and
wide strings.

Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
Cc: Abner Chang <abner.chang@amd.com>
Cc: Nickle Wang <nicklew@nvidia.com>
Cc: Igor Kulchytskyy <igork@ami.com>
---
 RedfishClientPkg/RedfishClientPkg.dsc | 1 -
 1 file changed, 1 deletion(-)

diff --git a/RedfishClientPkg/RedfishClientPkg.dsc b/RedfishClientPkg/RedfishClientPkg.dsc
index edc387ac72dc..e16c91b83196 100644
--- a/RedfishClientPkg/RedfishClientPkg.dsc
+++ b/RedfishClientPkg/RedfishClientPkg.dsc
@@ -36,7 +36,6 @@
   JsonLib|RedfishPkg/Library/JsonLib/JsonLib.inf
   Ucs2Utf8Lib|RedfishPkg/Library/BaseUcs2Utf8Lib/BaseUcs2Utf8Lib.inf
   RedfishCrtLib|RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
-  BaseSortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
   HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf
   UefiHiiServicesLib|MdeModulePkg/Library/UefiHiiServicesLib/UefiHiiServicesLib.inf
   UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
-- 
2.32.0 (Apple Git-132)

Re: [PATCH] [edk2-redfish-client] Remove reference to BaseSortLib library

[Chang, Abner]

[AMD Official Use Only - General]

> -----Original Message-----
> From: Mike Maslenkin <mike.maslenkin@gmail.com>
> Sent: Wednesday, June 21, 2023 5:32 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner <Abner.Chang@amd.com>; nicklew@nvidia.com;
> igork@ami.com; Mike Maslenkin <mike.maslenkin@gmail.com>
> Subject: [PATCH] [edk2-redfish-client] Remove reference to BaseSortLib library
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> There are two problems with BaseSortLib reference:
> 1 BaseSortLib is the library instance name not the class name.
> 2 UefiSortLib instance from MdeModulePkg is also referenced below.
>
> Let's use only one reference to SortLib.
> Even though Redfish Client uses only quick sort for char* elements,
> UefiSortLib is preferred as it allows to sort DevicePath instances and
> wide strings.

Sure, thanks for the input.
Reviewed-by: Abner Chang <abner.chang@amd.com>

Abner

>
> Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Nickle Wang <nicklew@nvidia.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
> ---
>  RedfishClientPkg/RedfishClientPkg.dsc | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/RedfishClientPkg/RedfishClientPkg.dsc
> b/RedfishClientPkg/RedfishClientPkg.dsc
> index edc387ac72dc..e16c91b83196 100644
> --- a/RedfishClientPkg/RedfishClientPkg.dsc
> +++ b/RedfishClientPkg/RedfishClientPkg.dsc
> @@ -36,7 +36,6 @@
>    JsonLib|RedfishPkg/Library/JsonLib/JsonLib.inf
>
>    Ucs2Utf8Lib|RedfishPkg/Library/BaseUcs2Utf8Lib/BaseUcs2Utf8Lib.inf
>
>    RedfishCrtLib|RedfishPkg/PrivateLibrary/RedfishCrtLib/RedfishCrtLib.inf
>
> -  BaseSortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf
>
>    HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf
>
>
> UefiHiiServicesLib|MdeModulePkg/Library/UefiHiiServicesLib/UefiHiiServicesL
> ib.inf
>
>
> UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBoot
> ManagerLib.inf
>
> --
> 2.32.0 (Apple Git-132)