From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id A823CD804B7 for ; Tue, 28 Nov 2023 03:19:29 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=3ivLe4zjtyNachLv9OMTjSDfybembnfjwq/SMW+3m54=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1701141568; v=1; b=JQ7CvcHjvEoLL2bHyqYH1Fn0aITFuUt0n84pd2DzwmRCsLz4N8npSd8AXE/oh+DhjvlAcWT2 rfboeNebe+uMON2y8ZQhA8/+9nzK7zoB5Pjr+npi/dvm1UjKcGNoVgQpn9mhTUME1JzYGrnioH5 kZ+Z4en0Nqo4ZPUf9/eEVMEs= X-Received: by 127.0.0.2 with SMTP id hiINYY7687511xaIebJZVcQW; Mon, 27 Nov 2023 19:19:28 -0800 X-Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.43]) by mx.groups.io with SMTP id smtpd.web11.24388.1701141567569495103 for ; Mon, 27 Nov 2023 19:19:27 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WzAdPcABYNS848hQF1J6Jof9Uq0sDtmKvGjH9FHhRu93PYcm86BwQ9Z3tS5qZijvJEZvto5Ffo5L/Lwsox0HWOKPaRUWeDSuWdaUATibDWYewIC2AqD7PEXVn7iV5ePzB/0ipMWJBa9lFMwW0+/jBn6fMsLSSjz63tYrIA5LHgaSyEg6+cxcYHgQ3PTfvKly4ueBlv33KqIyODotqPZZMkFBrM4RJkn6GUmDBg44BxsQ+aZI2X8p63Sgre9vxfKWUhSb2UWhug2VmhRe+ncoQnXEmB/xwKGJrYWV9KJjum5WWX6ySmYEfpErQs2oWhXnb8QNjNPPaOCbcSbH2XrUOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Bg8XxZ/nUg9iWZsGYy3ADkAr8B5kv9wXz9RtfHf2UY0=; b=PJXbMZZsXZ8rNYWNZAtJdEiwZ+79U25f24dgBInKPjbRqLrmvj1iPLXRSvgu59rG19rL6YeX52JpfWsrfiAYGQ8Ctv03MjQ3JkyIyikDw9cLqJmLucLPKxAw5Fe3PB06LR4U0Bbv7a4ye8YDitTBP3XF3JyjT/1uTCiLYzYPRKv8P+k4JYx6j/BxVTHdO5FHe0eOiyD2m0v3tyebztFQ3f0Ga6a/Grs0ZXfy4xV7SlKMzMEzgy4EnfMfcF8nx2UdwDe4r2/lQzBj6sKVDrG9S8yuq4T5Ht2TgYMMYgCvQi9dZudAslEUs0CbMRnYC/+9kq8U2/Hp0holB0VB6CzMhA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by DM6PR12MB4122.namprd12.prod.outlook.com (2603:10b6:5:214::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.29; Tue, 28 Nov 2023 03:19:24 +0000 X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::91d9:e679:32a3:dd05]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::91d9:e679:32a3:dd05%5]) with mapi id 15.20.7025.022; Tue, 28 Nov 2023 03:19:24 +0000 From: "Chang, Abner via groups.io" To: Nickle Wang , "devel@edk2.groups.io" CC: Igor Kulchytskyy , Nick Ramirez Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH 2/6] RedfishClientPkg/RedfishConfigLangMapDxe: fix issue and enhancement. Thread-Topic: [edk2-redfish-client][PATCH 2/6] RedfishClientPkg/RedfishConfigLangMapDxe: fix issue and enhancement. Thread-Index: AQHaHhoeMd9dGOERsEed6ejgNNSdGrCPFx/A Date: Tue, 28 Nov 2023 03:19:24 +0000 Message-ID: References: <20231123143355.3276-1-nicklew@nvidia.com> In-Reply-To: <20231123143355.3276-1-nicklew@nvidia.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=c2e1be90-8b4b-4f72-a45b-af742bee8557;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-11-28T03:19:14Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|DM6PR12MB4122:EE_ x-ms-office365-filtering-correlation-id: 78e8d43f-b8cd-431a-4bb3-08dbefc0d276 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: J/N5RLKv2p6meAm4SqF0uyyQRfMsPFD/VITRjX+qJjrASuNy7FHI7ph5rOs8t/CrphOtBpK5T2wPkjhuHzGlaXqEQj3019ZnrIwcD5itNh4pjCK0Wx6B3mCxwmnDR0zoI5aA7FlXG8yRNFuMFGxi65m0ajbaUI1Tdotqc4W0PUdseM4i1O7M/pgB0F6ILEWM7sWY8bmTUUvGHby0lH1Sw+VaiET4HvPBI0pzfdcaqDtAt6/FZt6oe0iMNxPyMy0AKuFIW1fps54SIXiPBZR5nC3jsUSGTan9UXI4u1cx1IvbS82tBrGKRwKAyWThEmCK6r5b3myzAxhbJSMUaoNY/4UjYe9c+UT9DwnQVnU4Dn8jLZrNj08PAECzNpRT3Pq9kg0jYsYic9u6SQPm2WV82BYDdzFDNGo3LtOFQnLCqoRC7NgyUr7twijJsibIY2+enMKiUGXMVUkkpVh1nFnMhAXfeCE5xJXBc+lXgjGpYvLuyq90jdJMb9dcX0ujYUbNIg/+uUcMozll/R6iWZt883Yync4qGiAJZHfmsj+a/kF+G/Pmw82pZFycckLe3zQ0v0L94K3TSu8mKx1jnXkVcSxyfqx198aQjBJFIOjZYV27bvClzToJ81DVGmr7pOZKsoWxUk60lns6Ih+1zCb8grQt3QXsqXhkieypEZMG7OB9Dp2sVDmas1BBwMkl3td9 x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Gwqkn3rLpn1tOuhoPwK2YxK0QG8Y69dKpDE3NxMaLvgKi3udu8mewygq2v4O?= =?us-ascii?Q?jtoRZx63ZO6uPqbYlfw9qZtAM/A/D1iR3Ro3QEv0g3byN7NIFYqynfh46Cvi?= =?us-ascii?Q?auUm9LCPCPn3IGYPDYFsJ1+MhK3+OnpcEKR+k793RYv84Vy2CNMWnrDmScLt?= =?us-ascii?Q?Ku7fkgKu9qW0g7vuCVc9o713ksmDaXEWZo1FHV2ViMN/+nbCjsfR60q+RWxu?= =?us-ascii?Q?NtoO2WZ61Yz9weMDT+puZMOQ/Oz/hBODIsnJeb724xd0DHyIdxb/30/1LIa9?= =?us-ascii?Q?CCvVJro5asXo/3uwliluRnT3+q03FKXZ4Ax8ER0A4J4GmVvPyqlb+zTm08YV?= =?us-ascii?Q?opZiFAkzHkahNRBKetC6x3FenYP3/qKa6t2KMn3u7yG38KYH2aZ2B2Xs+H9y?= =?us-ascii?Q?9RlBJmzKMj/kL5uedM/WehkUbrUtAhMg6h3cpkGaebbv64jaaLK/PCHvLbKN?= =?us-ascii?Q?5Tx00EO6fBTGwtnDHke/DbwgRD1aa+MFZjf+oNpiMM3VM100awTkJas6LCyS?= =?us-ascii?Q?yVDhLiciPI/Lkt4v4VhF49U6+/ABLZ0TKKjFgA8XIiWQXhWSQ4zYx5+CJLlV?= =?us-ascii?Q?Xh4BrZpyh4Pn9RzJYRNCJ6rGuiXZM33lE1pLNw/EbB66DdeeVVVy8c4uOta1?= =?us-ascii?Q?7ATS0ROSlzAqV1VfnrdcNe5KvFpuHEdFsdjxiCKgto7K+t6uFTm7sCdBGKou?= =?us-ascii?Q?XhZLUxS7OgHhYe9sP7wJKkE41H2wEJ8W0PpeBe/VdHdTqBTI3s5OrrbV/g/v?= =?us-ascii?Q?o2XyqmtKKaAQdm22n+Suk9xiGYNGv0B7ffY7Q7Grt3bA8UPOdUsAmvrXYATk?= =?us-ascii?Q?lNEY6Ni2YzTdnQI1WJTJip3lezWSErusmPNN71GaDp6XKrKBHe8s4ueVT6mT?= =?us-ascii?Q?XRPwt8Dafa8kUGX7bOWs0kPDZq3M8svIXU+GpR27EQHs2lt7TYwNY5Y+dwF0?= =?us-ascii?Q?wXi9YSGEjXbLkPeR4XFRe+qFoU07V6rrewkQaSkWLRJdZYBLXl61x/I29YXH?= =?us-ascii?Q?J0h8ZSdNzlbz6/EBruSINvt/mvq7bjlCYf8l2EA5bGNhE/wxvLGwnhcXI3rW?= =?us-ascii?Q?I8iDZ4W5NaMCjeFHAb+1wOyM6LUFusQamWSREg53s8Km75XltpZhWWTxTWuN?= =?us-ascii?Q?ypuLVV+0eFyqEC8PoBAqWtdoDysnkiBwSWmoLl3o5/dHXereBxBQ/HN+5rqH?= =?us-ascii?Q?lfgmzuFOdMiet27nqBNzlNxKElbqR/WvFMBUu5/TiPctdVXASIPHTfOK4EsD?= =?us-ascii?Q?L6UuL65lXcMGG628BxMUimU1MT1a5HTyKWDDHA6NsMBhmBexYmte+EqT1Cdm?= =?us-ascii?Q?r69SdF5Fq3rh09WTXIwhRdcFshjm/gfh84Rz/443aa1ySdnc2wsmWUP3T/Po?= =?us-ascii?Q?rPcaDH6y/DO4tl66ggG3wHEGy05g0949RqYlJWTSF1LuBUED42oixW5EpC9n?= =?us-ascii?Q?NHHWb0TaKWA6zWglnZYz92tyRRKdjZoOmrP49Vh+wre6aQC5NYrcK9WQfHgA?= =?us-ascii?Q?VnjzNqvaXiHoMML22HRj90XxvlMqAQermQxTnU/1jqa21wHDdy9l+/WlRZra?= =?us-ascii?Q?oyhz8ZnFEC+f0scLjO/1M0qhalXGB0x1QUoVzJXe?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 78e8d43f-b8cd-431a-4bb3-08dbefc0d276 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Nov 2023 03:19:24.6703 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 74ugHguHNgwGVULHnpFeR9PICgYhG9vF/Om9qkzc6E4fVYN2yu8PQ+F+Po6CyKZCu1iJwcMwvivt22IN9eRKgQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4122 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: Gq44c36uiJO6SQGURE1jSIywx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=JQ7CvcHj; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=none; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") [AMD Official Use Only - General] Reviewed-by: Abner Chang > -----Original Message----- > From: Nickle Wang > Sent: Thursday, November 23, 2023 10:34 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [edk2-redfish-client][PATCH 2/6] > RedfishClientPkg/RedfishConfigLangMapDxe: fix issue and enhancement. > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > -Fix typo (replace Listheader to ListHeader). > -Replace "%a," to "%a:". > -Add more debug message. > -Fix issue of assigning ASCII character to Unicode string pointer. > -Remove the exit-boot-service callback since data is saved at > after-provisioning event. There is no need to save data to variable > again. > > Signed-off-by: Nickle Wang > Cc: Abner Chang > Cc: Igor Kulchytskyy > Cc: Nick Ramirez > --- > .../RedfishConfigLangMapDxe.inf | 1 - > .../RedfishConfigLangMapDxe.h | 2 +- > .../RedfishConfigLangMapDxe.c | 89 +++++++++---------- > 3 files changed, 41 insertions(+), 51 deletions(-) > > diff --git > a/RedfishClientPkg/RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.in > f > b/RedfishClientPkg/RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.in > f > index 42d9daf2..02346745 100644 > --- > a/RedfishClientPkg/RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.in > f > +++ > b/RedfishClientPkg/RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.in > f > @@ -41,7 +41,6 @@ > gEdkIIRedfishConfigLangMapProtocolGuid ## PRODUCED ## > > [Guids] > - gEfiEventExitBootServicesGuid ## CONSUMED ## > gEfiRedfishClientVariableGuid ## CONSUMED ## > > [Depex] > diff --git > a/RedfishClientPkg/RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.h > b/RedfishClientPkg/RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.h > index efa27d4d..4ac55941 100644 > --- > a/RedfishClientPkg/RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.h > +++ > b/RedfishClientPkg/RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.h > @@ -49,7 +49,7 @@ typedef struct { > // Definition of REDFISH_CONFIG_LANG_MAP_LIST > // > typedef struct { > - LIST_ENTRY Listheader; > + LIST_ENTRY ListHeader; > UINTN TotalSize; > UINTN Count; > } REDFISH_CONFIG_LANG_MAP_LIST; > diff --git > a/RedfishClientPkg/RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.c > b/RedfishClientPkg/RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.c > index 97f29549..8c930445 100644 > --- > a/RedfishClientPkg/RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.c > +++ > b/RedfishClientPkg/RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.c > @@ -102,7 +102,7 @@ ON_ERROR: > @param[in] Uri The URI string matching to this ConfigLang. > @param[in] ConfigLang ConfigLang string. > > - @retval EFI_SUCCESS config language map recourd is added. > + @retval EFI_SUCCESS config language map record is added. > @retval Others Fail to add config language map. > > **/ > @@ -124,7 +124,7 @@ AddConfigLangMapRecord ( > return EFI_OUT_OF_RESOURCES; > } > > - InsertTailList (&List->Listheader, &NewRecord->List); > + InsertTailList (&List->ListHeader, &NewRecord->List); > ++List->Count; > List->TotalSize +=3D NewRecord->Size; > > @@ -137,7 +137,7 @@ AddConfigLangMapRecord ( > @param[in] List Target config language map list to be removed. > @param[in] Record Pointer to the instance to be deleted. > > - @retval EFI_SUCCESS config language map recourd is removed. > + @retval EFI_SUCCESS config language map record is removed. > @retval Others Fail to add config language map. > > **/ > @@ -237,20 +237,20 @@ DumpConfigLangMapList ( > DEBUG ((DEBUG_ERROR, "%s\n", Msg)); > } > > - if (IsListEmpty (&ConfigLangMapList->Listheader)) { > + if (IsListEmpty (&ConfigLangMapList->ListHeader)) { > DEBUG ((DEBUG_MANAGEABILITY, "ConfigLangMap list is empty\n")); > return EFI_NOT_FOUND; > } > > DEBUG ((DEBUG_MANAGEABILITY, "Count: %d Total Size: %d\n", > ConfigLangMapList->Count, ConfigLangMapList->TotalSize)); > Record =3D NULL; > - List =3D GetFirstNode (&ConfigLangMapList->Listheader); > - while (!IsNull (&ConfigLangMapList->Listheader, List)) { > + List =3D GetFirstNode (&ConfigLangMapList->ListHeader); > + while (!IsNull (&ConfigLangMapList->ListHeader, List)) { > Record =3D REDFISH_CONFIG_LANG_MAP_RECORD_FROM_LIST (List); > > DEBUG ((DEBUG_MANAGEABILITY, "ConfigLang: %s Uri: %s Size: %d\n", > Record->ConfigLang, Record->Uri, Record->Size)); > > - List =3D GetNextNode (&ConfigLangMapList->Listheader, List); > + List =3D GetNextNode (&ConfigLangMapList->ListHeader, List); > } > > return EFI_SUCCESS; > @@ -317,16 +317,16 @@ ReleaseConfigLangMapList ( > return EFI_INVALID_PARAMETER; > } > > - if (IsListEmpty (&ConfigLangMapList->Listheader)) { > + if (IsListEmpty (&ConfigLangMapList->ListHeader)) { > return EFI_SUCCESS; > } > > Record =3D NULL; > Next =3D NULL; > - List =3D GetFirstNode (&ConfigLangMapList->Listheader); > - while (!IsNull (&ConfigLangMapList->Listheader, List)) { > + List =3D GetFirstNode (&ConfigLangMapList->ListHeader); > + while (!IsNull (&ConfigLangMapList->ListHeader, List)) { > Record =3D REDFISH_CONFIG_LANG_MAP_RECORD_FROM_LIST (List); > - Next =3D GetNextNode (&ConfigLangMapList->Listheader, List); > + Next =3D GetNextNode (&ConfigLangMapList->ListHeader, List); > > DeleteConfigLangMapRecord (ConfigLangMapList, Record); > > @@ -365,12 +365,12 @@ SaveConfigLangMapList ( > return EFI_INVALID_PARAMETER; > } > > - if (IsListEmpty (&ConfigLangMapList->Listheader)) { > + if (IsListEmpty (&ConfigLangMapList->ListHeader)) { > return EFI_SUCCESS; > } > > // > - // Caculate the total size we need to keep ConfigLangMap list. > + // Calculate the total size we need to keep ConfigLangMap list. > // > VarSize =3D ConfigLangMapList->TotalSize + sizeof (CHAR16); // termina= tor > character > VarData =3D AllocateZeroPool (VarSize); > @@ -380,29 +380,29 @@ SaveConfigLangMapList ( > > Seeker =3D (EFI_STRING)VarData; > Record =3D NULL; > - List =3D GetFirstNode (&ConfigLangMapList->Listheader); > - while (!IsNull (&ConfigLangMapList->Listheader, List)) { > + List =3D GetFirstNode (&ConfigLangMapList->ListHeader); > + while (!IsNull (&ConfigLangMapList->ListHeader, List)) { > Record =3D REDFISH_CONFIG_LANG_MAP_RECORD_FROM_LIST (List); > > StringSize =3D StrSize (Record->Uri); > CopyMem (Seeker, Record->Uri, StringSize); > > Seeker +=3D (StringSize / sizeof (CHAR16) - 1); > - *Seeker =3D '|'; > + *Seeker =3D L'|'; > ++Seeker; > > StringSize =3D StrSize (Record->ConfigLang); > CopyMem (Seeker, Record->ConfigLang, StringSize); > > Seeker +=3D (StringSize / sizeof (CHAR16) - 1); > - *Seeker =3D '\n'; > + *Seeker =3D L'\n'; > > ++Seeker; > > - List =3D GetNextNode (&ConfigLangMapList->Listheader, List); > + List =3D GetNextNode (&ConfigLangMapList->ListHeader, List); > } > > - *Seeker =3D '\0'; > + *Seeker =3D L'\0'; > > #if CONFIG_LANG_MAP_DEBUG_ENABLED > DumpRawBuffer (VarData, VarSize); > @@ -481,7 +481,7 @@ InitialConfigLangMapList ( > // > Seeker =3D StrStr (UriPointer, L"|"); > if (Seeker =3D=3D NULL) { > - DEBUG ((DEBUG_ERROR, "%a, data corrupted\n", __func__)); > + DEBUG ((DEBUG_ERROR, "%a: data corrupted\n", __func__)); > Status =3D EFI_DEVICE_ERROR; > goto ON_ERROR; > } > @@ -494,7 +494,7 @@ InitialConfigLangMapList ( > // > Seeker =3D StrStr (ConfigLangPointer, L"\n"); > if (Seeker =3D=3D NULL) { > - DEBUG ((DEBUG_ERROR, "%a, data corrupted\n", __func__)); > + DEBUG ((DEBUG_ERROR, "%a: data corrupted\n", __func__)); > Status =3D EFI_DEVICE_ERROR; > goto ON_ERROR; > } > @@ -548,11 +548,13 @@ RedfishConfigLangMapGet ( > return EFI_INVALID_PARAMETER; > } > > + DEBUG ((DEBUG_MANAGEABILITY, "%a: type: 0x%x %s\n", __func__, > QueryStringType, QueryString)); > + > Private =3D REDFISH_CONFIG_LANG_MAP_PRIVATE_FROM_THIS (This); > > *ResultString =3D NULL; > > - Target =3D FindConfigLangMapRecord (&Private->ConfigLangList.Listheade= r, > QueryString, (QueryStringType =3D=3D RedfishGetTypeUri)); > + Target =3D FindConfigLangMapRecord (&Private->ConfigLangList.ListHeade= r, > QueryString, (QueryStringType =3D=3D RedfishGetTypeUri)); > if (Target =3D=3D NULL) { > #if CONFIG_LANG_MAP_DEBUG_ENABLED > DumpConfigLangMapList (&Private->ConfigLangList, L"EFI_NOT_FOUND"); > @@ -597,10 +599,12 @@ RedfishConfigLangMapSet ( > return EFI_INVALID_PARAMETER; > } > > + DEBUG ((DEBUG_MANAGEABILITY, "%a: %s -> %s\n", __func__, ConfigLang, > (Uri =3D=3D NULL ? L"NULL" : Uri))); > + > Private =3D REDFISH_CONFIG_LANG_MAP_PRIVATE_FROM_THIS (This); > > Status =3D EFI_NOT_FOUND; > - Target =3D FindConfigLangMapRecord (&Private->ConfigLangList.Listheade= r, > ConfigLang, FALSE); > + Target =3D FindConfigLangMapRecord (&Private->ConfigLangList.ListHeade= r, > ConfigLang, FALSE); > if (Target !=3D NULL) { > // > // Remove old one and create new one. > @@ -609,7 +613,7 @@ RedfishConfigLangMapSet ( > } > > // > - // When Uri is NULL, it means that we want to remov this record. > + // When Uri is NULL, it means that we want to remove this record. > // > if (Uri =3D=3D NULL) { > return Status; > @@ -644,14 +648,16 @@ RedfishConfigLangMapFlush ( > > Status =3D SaveConfigLangMapList (&Private->ConfigLangList, Private- > >VariableName); > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "%a, save ConfigLangMap list to variable: %s > failed: %r\n", __func__, Private->VariableName, Status)); > + DEBUG ((DEBUG_ERROR, "%a: save ConfigLangMap list to variable: %s > failed: %r\n", __func__, Private->VariableName, Status)); > } > > + DEBUG ((DEBUG_MANAGEABILITY, "%a: save Config Language map to > variable: %s\n", __func__, Private->VariableName)); > + > return Status; > } > > /** > - Callback function executed when the ExitBootService event group is sig= naled. > + Callback function executed when the AfterProvisioning event group is > signaled. > > @param[in] Event Event whose notification function is being invok= ed. > @param[out] Context Pointer to the Context buffer > @@ -659,13 +665,13 @@ RedfishConfigLangMapFlush ( > **/ > VOID > EFIAPI > -RedfishConfigLangMapOnExitBootService ( > +RedfishConfigLangMapOnAfterProvisioning ( > IN EFI_EVENT Event, > OUT VOID *Context > ) > { > // > - // Memory is about to be released. Keep list into variable. > + // Redfish provisioning is finished. Keep list into variable. > // > RedfishConfigLangMapFlush (&mRedfishConfigLangMapPrivate->Protocol); > } > @@ -694,7 +700,7 @@ RedfishConfigLangMapDriverUnload ( > (VOID *)&mRedfishConfigLangMapPrivate->Protocol > ); > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "%a, can not uninstall > gEdkIIRedfishConfigLangMapProtocolGuid: %r\n", __func__, Status)); > + DEBUG ((DEBUG_ERROR, "%a: can not uninstall > gEdkIIRedfishConfigLangMapProtocolGuid: %r\n", __func__, Status)); > ASSERT (FALSE); > } > > @@ -753,7 +759,7 @@ RedfishConfigLangMapDriverEntryPoint ( > return EFI_OUT_OF_RESOURCES; > } > > - InitializeListHead (&mRedfishConfigLangMapPrivate- > >ConfigLangList.Listheader); > + InitializeListHead (&mRedfishConfigLangMapPrivate- > >ConfigLangList.ListHeader); > mRedfishConfigLangMapPrivate->VariableName =3D AllocateCopyPool (StrSi= ze > (CONFIG_LANG_MAP_VARIABLE_NAME), > CONFIG_LANG_MAP_VARIABLE_NAME); > if (mRedfishConfigLangMapPrivate->VariableName =3D=3D NULL) { > Status =3D EFI_OUT_OF_RESOURCES; > @@ -770,40 +776,25 @@ RedfishConfigLangMapDriverEntryPoint ( > (VOID *)&mRedfishConfigLangMapPrivate->Protocol > ); > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "%a, can not install > gEdkIIRedfishConfigLangMapProtocolGuid: %r\n", __func__, Status)); > + DEBUG ((DEBUG_ERROR, "%a: can not install > gEdkIIRedfishConfigLangMapProtocolGuid: %r\n", __func__, Status)); > ASSERT (FALSE); > goto ON_ERROR; > } > > - // > - // Create Exit Boot Service event. > - // > - Status =3D gBS->CreateEventEx ( > - EVT_NOTIFY_SIGNAL, > - TPL_CALLBACK, > - RedfishConfigLangMapOnExitBootService, > - NULL, > - &gEfiEventExitBootServicesGuid, > - &mRedfishConfigLangMapPrivate->ExitBootEvent > - ); > - if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "%a: Fail to register Exit Boot Service event."= , > __func__)); > - goto ON_ERROR; > - } > - > // > // Read existing record from variable. > // > + DEBUG ((DEBUG_MANAGEABILITY, "%a: Initial ConfigLangMap List from > variable: %s\n", __func__, mRedfishConfigLangMapPrivate->VariableName)); > Status =3D InitialConfigLangMapList (&mRedfishConfigLangMapPrivate- > >ConfigLangList, mRedfishConfigLangMapPrivate->VariableName); > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_MANAGEABILITY, "%a, Initial ConfigLangMap List: %r\n", > __func__, Status)); > + DEBUG ((DEBUG_MANAGEABILITY, "%a: Initial ConfigLangMap List: %r\n", > __func__, Status)); > } > > // > // Register after provisioning event > // > Status =3D CreateAfterProvisioningEvent ( > - RedfishConfigLangMapOnExitBootService, > + RedfishConfigLangMapOnAfterProvisioning, > NULL, > &mRedfishConfigLangMapPrivate->ProvisionEvent > ); > -- > 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111783): https://edk2.groups.io/g/devel/message/111783 Mute This Topic: https://groups.io/mt/102767542/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-