From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (NAM02-DM3-obe.outbound.protection.outlook.com [40.107.95.82]) by mx.groups.io with SMTP id smtpd.web11.25259.1683612597626835057 for ; Mon, 08 May 2023 23:09:57 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=bNJXCi6r; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.95.82, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IHVBt05TwIIbNtf43LFs9DNyXWrYHkvxNdZKCH7LjSZQMUwX3IhhCsSnNgNf563+hfw4kDUn2vFKljK+mJdAioxKpHSZxlZ68IZVGyleiUlMyb77dy4dG+Mw2hLbQZaX6PTYRVtC8b9oQYoOvvL5u717p5EL8Oz+hU9kRLzWAMVTUyNln6PZmSYK9KItON6x3p/D91wdtIwe9WjBJ8p4JlH+UVU6sr0d2JcBAqBeBv8k1Jt6KNnwMGQGkc0tK4k28EAb06t+cad0/r/geZrGBungFpH9Q1oU4zPdA1QjkwlVvxrSdYAATsX8Vv0P5t2838cHLgHoqv+4wKwvA2QPsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Y2/bO4yPkN1JesZftNSECx7reZh8ZLoMTbbmlxm1tBI=; b=Lwv192R6Q+jt9JdbRSmy+2e5N3ZLEQMTBM3hjh1LyAQCWSEufM14xhvDMMa9PZDZ0GkukN4Yea9kE3rikxJhhroh1rsimnuxZVnxeoag/Mb0CPXTjge6aL3QJfvxX7hc3F8BPy4HxLxqXTwQiIGSo0kr2YDPKBcBVyLyBPHX3iGF/ghEY4aXu8hcxLNj7thB0Mixb083RZogH/iQjldUfRoXk2w8RyzjL+cNIz8CqBTVx3NxJZ3julTs5NXfTDMUgYeYmwRmsTktzcHdtThREjSYx6rG60Q+peGautdqLD2YWfUE5PLY5RaeKh7GMFdtkMD13QJm4JlrCTbezMahHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Y2/bO4yPkN1JesZftNSECx7reZh8ZLoMTbbmlxm1tBI=; b=bNJXCi6rzTXP6fXWDBqQB6jWTf+N328sxDnpYlngR83kuNAu5OOVweuGYierFGvvMxdHsCcdtrefAca0SZzwkeiJkn/1yyQ3eYaxZFuSlqKXCCATz9ALTrze2e/xF8bw3bW9UrlZKuOArRrclsNZ0K/qgN7cuEjLxhQ2x5ObNTg= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by BN9PR12MB5065.namprd12.prod.outlook.com (2603:10b6:408:132::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.33; Tue, 9 May 2023 06:09:55 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::46f1:bdce:a4bc:29e3]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::46f1:bdce:a4bc:29e3%3]) with mapi id 15.20.6363.032; Tue, 9 May 2023 06:09:55 +0000 From: "Chang, Abner" To: "Attar, AbdulLateef (Abdul Lateef)" , "devel@edk2.groups.io" , Ray Ni CC: "Attar, AbdulLateef (Abdul Lateef)" , "Grimes, Paul" , Eric Dong , Rahul Kumar , Gerd Hoffmann , Michael D Kinney , Liming Gao , Zhiguang Liu , Ard Biesheuvel , Jiewen Yao , Jordan Justen Subject: Re: [PATCH v11 0/8] Adds AmdSmmCpuFeaturesLib and MmSaveStateLib Thread-Topic: [PATCH v11 0/8] Adds AmdSmmCpuFeaturesLib and MmSaveStateLib Thread-Index: AQHZf9A9JEGxE0NP3EmvZEABoFGnma9RedSg Date: Tue, 9 May 2023 06:09:55 +0000 Message-ID: References: In-Reply-To: Accept-Language: zh-CN, en-US X-Mentions: ray.ni@intel.com X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-05-09T06:09:53Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=b9e1cfa6-dc2c-46d8-a39f-524747d79161; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|BN9PR12MB5065:EE_ x-ms-office365-filtering-correlation-id: 7d4ec7db-17fa-4037-2767-08db505402ba x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /q9vsLAcepxo0oxFDEDW7zuvYhiha83r9VGNq4AUFD2zGPOHm0n4ZzcHqL0XW8bsEX873yA1wCnvcP0+Bhmmp1AQZ075xS4C2g9rcrH6JG7j+Z87fsBTBc/MjMKC380DUNKKTluY3E4vAVipTV897sxjBhS/Pi8fhkbhVXDUCOK8yecheuyaGFLcCDH4z1JwrxuSCsvD4eZddqWSDSKVEuPxw5sg2H2JE8AAU776Siy8YHbbsmZnSeOB7LTS77gbrXy5UFfIkAqQ9RF8KxKHL4OsevfUF6FhDTbIpTlgpUkBSVjh7M0BvTWujhcDOF9yRPSrQ0ZGaIoF4ekVp0ytjd9wNjwpSHBpSRSd+NZfWafkBgVR2ZZlbUay1FlPYjsxa3oV/I5aQFmECsRGYHyZ4plY1n3h/m7kS4sNdwcQtA3OAgns6MjW6gb3DRAhRCDcENzdE6pLC403vPdDEihJ+O8DXNZTC3jgEJLwAcCFhHELyh+S/fdY6XWmpQuGZbUs+jrw9jZGPZfWWfmFjcpBhqSEwPFesalcY67tkEnNLqPfdBHXGUhGnIyXSNGPQ8CVXzzc9ORFnJb+r+/8JttytV26c5OScyMFXGOxJ8MsKVN1QGSGRphJu2GvPMz/a/a2 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(6029001)(4636009)(376002)(136003)(346002)(396003)(39860400002)(366004)(451199021)(38070700005)(4326008)(52536014)(316002)(5660300002)(41300700001)(38100700002)(66446008)(64756008)(86362001)(26005)(122000001)(54906003)(71200400001)(53546011)(9686003)(66476007)(66556008)(66946007)(110136005)(6506007)(2906002)(76116006)(8936002)(19627235002)(8676002)(33656002)(7416002)(186003)(7696005)(478600001)(966005)(83380400001)(55016003)(213903007);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?GeiBXceyMfESbFcSkOVSMiyjbOgF0extRI+nKO9Lm8qof/RyK6u0bWFkLYbi?= =?us-ascii?Q?/DoZ180PMhJBiQRAqeG0OCsy7SgvAys07HK5ylIY5nruYfwx2TmVAH+VJgxr?= =?us-ascii?Q?vnaj7m1szK7AsZ8JTbJOj5LbV0ik06fgSWSo6O7tN0pE+HIlte/BUP16NDN5?= =?us-ascii?Q?X9JORUxv3jmQRzNXVLJjhRqLrEJOyqEMt9EDQ6TgqoDzmwuuGGh3UNEcpMxy?= =?us-ascii?Q?CPWyEPLlFHOa18yTWYU/razEDhyT/1N5SSGMQzpNFn3S/r18qCVQvtf90gxl?= =?us-ascii?Q?tqhm0hh9GHfexoiMmZSiFJhmF2W4ZYn7NgcS+Kphh8UuaBwVEhi2fDPJDGZ3?= =?us-ascii?Q?lq2pqyDrdG0IY4J2iZyxu78ymberizM25ARWH5bOiBxq/g1u7PzFC8HOSqhq?= =?us-ascii?Q?h6dILQQtzImavsoy+HJJoYNeZINIsrMn54X+L8T1aV6O7YHSbpLVzZtYAmAy?= =?us-ascii?Q?rhPlOiMPzHjf1VCZvsmxnYuvUvz3wKakvRtQkk5KuITGNHVU5swfxhKjCBE6?= =?us-ascii?Q?WYRJ+Dd54DcNY3sYlbw2eBREezarVTDkGY47r1+PdD4ToUA1q7/gWeIpKdfB?= =?us-ascii?Q?PIbs7kXr0XBHkouzIODB2N3P60SIN2ogM2P43L3QiINFlRkfXHqqKtSq4cVF?= =?us-ascii?Q?JH9IGfV73XvfwfacvLA+2TUyyWclRVm1s/jKQoy82ZhhGMDBlxcc6V+quoZb?= =?us-ascii?Q?1YoL5xValXbWJb9aYDRVeuZ8GAHzOnEi364jygJNApp7BZmrk/8qUUnOJWT3?= =?us-ascii?Q?hIDvKcfXcYkjvDgMnmm98PhdIDcAX0i1raV/OGmW71aXgvYplJXd/iNTW2hl?= =?us-ascii?Q?rSrFCfx8BfSMiX16ZvDB1Eood1zG3pD7Xb7g9TY01eDpDqL0o0Y1ui6YBmb8?= =?us-ascii?Q?gepLsh32xIk6KwXgWTGZvxlHXkPp9WehMF6lt7XygIlqkAwAQ4ZJdbt9+a4/?= =?us-ascii?Q?qoAl9DRGU+pGYrFZHB25HuuCb04LRWVBeKvrdcJDRJKDe7s4dsXYAzrzPb0r?= =?us-ascii?Q?dt8xD/ed/Jg86mHw65NDATCswtRovR4heZ4tuI0WpMSy73hqxOw40istWIoc?= =?us-ascii?Q?raD6YV+OuRnX3Ti+qmkCOCqBq4P8JvJ405wtjUH9Y84Gny/ho9CMXEUEEJTl?= =?us-ascii?Q?E8i4WCvp2sHZGGK6M95FRa4UX55cCdZxuxM7HwaxHZAS5D5DuY1RYNug5WYm?= =?us-ascii?Q?JD3o8a7VAaQHr3+lj86nolMkjZKu2BrTsA/KnWj923T4CRqR3Vy2W4ZhYi4N?= =?us-ascii?Q?r0ta83b8PuQ1rPsTWwmsYjH15MmhfG9gSXlPVFPGWwGXlVNIO/stuo9DmDk/?= =?us-ascii?Q?lp2c75HFpyMqzsX81IUugBEXgnjhXGl66eqpZ19bKv9MLwNcU6tVcv9Z2EvI?= =?us-ascii?Q?W3nRaoMMWTflKCBHmsaTymncB+mF3Eid6y4e/FKduea6bXH93IhW9NuHx/dO?= =?us-ascii?Q?B33v9bHrmeXqCxcHg7CoAppmGKxLM3iXWM1x5xWXVVTGkay5axaYrB+QykuJ?= =?us-ascii?Q?zYOtIybVCQexn1RDD2PcJlwffsZFevP6pezQqT92eDJAKOAhZvOc2X3mLpOf?= =?us-ascii?Q?cKIml3nUS93mJwQYYA+jE4oPq/eYrQWtnWgD0COw?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7d4ec7db-17fa-4037-2767-08db505402ba X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2023 06:09:55.5769 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HMva9zIsPBOguQPWcET5WxPLwf9mZcj3bGNmSCuEsoHs8RA+2qhjEdtjOywXv1oijS5/ovm2SWwbb75aPcbQ4Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5065 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Hi @Ray Ni, Could you please help to review this patch set as the Hard Freeze is coming= soon? Thanks Abner > -----Original Message----- > From: Abdul Lateef Attar > Sent: Saturday, May 6, 2023 12:07 PM > To: devel@edk2.groups.io > Cc: Attar, AbdulLateef (Abdul Lateef) ; > Grimes, Paul ; Chang, Abner > ; Eric Dong ; Ray Ni > ; Rahul Kumar ; Gerd > Hoffmann ; Michael D Kinney > ; Liming Gao ; > Zhiguang Liu ; Ard Biesheuvel > ; Jiewen Yao ; Jordan > Justen > Subject: [PATCH v11 0/8] Adds AmdSmmCpuFeaturesLib and > MmSaveStateLib >=20 > PR: https://github.com/tianocore/edk2/pull/4341 >=20 > V11: Delta changes > Drop the OVMF implementation of MmSaveStateLib > V10: Delta changes: > Addressed review comments from Abner. > V9: Delta changes: > Addressed review comments. > Rename to MmSaveStateLib. > Also rename SMM_ defines to MM_. > Implemented OVMF MmSaveStateLib. > Removes SmmCpuFeaturesReadSaveStateRegister and > SmmCpuFeaturesWriteSaveStateRegister > function interface. > V8 delta changes: > Addressed review comments from Abner, > Fix the whitespace error. > Seperate the Ovmf changes to another patch > V7 delta changes: > Adds SmmSmramSaveStateLib for Intel processor. > Integrate SmmSmramSaveStateLib library. > V6 delta changes: > Addressed review comments for Ray NI. > removed unnecessary EFIAPI. > V5 delta changes: > rebase to master branch. > updated Reviewed-by > V4 delta changes: > rebase to master branch. > added reviewed-by. > V3 delta changes: > Addressed review comments from Abner chang. > Re-arranged patch order. >=20 > Cc: Paul Grimes > Cc: Abner Chang > Cc: Eric Dong > Cc: Ray Ni > Cc: Rahul Kumar > Cc: Gerd Hoffmann > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc: Jordan Justen > Cc: Abdul Lateef Attar >=20 > Abdul Lateef Attar (8): > MdePkg: Adds AMD SMRAM save state map > UefiCpuPkg: Adds MmSaveStateLib library class > UefiCpuPkg: Implements MmSaveStateLib library instance > UefiCpuPkg/SmmCpuFeaturesLib: Restructure arch-dependent code > UefiCpuPkg: Implements SmmCpuFeaturesLib for AMD Family > UefiCpuPkg: Implements MmSaveStateLib for Intel > UefiCpuPkg: Removes SmmCpuFeaturesReadSaveStateRegister > OvmfPkg: Uses MmSaveStateLib library >=20 > UefiCpuPkg/UefiCpuPkg.dec | 4 + > OvmfPkg/OvmfPkgIa32.dsc | 1 + > OvmfPkg/OvmfPkgIa32X64.dsc | 3 + > OvmfPkg/OvmfPkgX64.dsc | 1 + > UefiCpuPkg/UefiCpuPkg.dsc | 14 + > .../MmSaveStateLib/AmdMmSaveStateLib.inf | 28 + > .../MmSaveStateLib/IntelMmSaveStateLib.inf | 28 + > .../AmdSmmCpuFeaturesLib.inf | 38 + > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf | 2 + > .../Include/Register/Amd/SmramSaveStateMap.h | 194 +++++ > UefiCpuPkg/Include/Library/MmSaveStateLib.h | 70 ++ > .../Include/Library/SmmCpuFeaturesLib.h | 52 -- > .../Library/MmSaveStateLib/MmSaveState.h | 102 +++ > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 56 +- > .../SmmCpuFeaturesLib/SmmCpuFeaturesLib.c | 767 ------------------ > .../Library/MmSaveStateLib/AmdMmSaveState.c | 309 +++++++ > .../Library/MmSaveStateLib/IntelMmSaveState.c | 413 ++++++++++ > .../MmSaveStateLib/MmSaveStateCommon.c | 138 ++++ > .../SmmCpuFeaturesLib/AmdSmmCpuFeaturesLib.c | 387 +++++++++ > .../IntelSmmCpuFeaturesLib.c | 70 ++ > .../SmmCpuFeaturesLibCommon.c | 128 --- > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 11 +- > UefiCpuPkg/PiSmmCpuDxeSmm/SmramSaveState.c | 500 +----------- > MdePkg/MdePkg.ci.yaml | 4 +- > 24 files changed, 1812 insertions(+), 1508 deletions(-) create mode 100= 644 > UefiCpuPkg/Library/MmSaveStateLib/AmdMmSaveStateLib.inf > create mode 100644 > UefiCpuPkg/Library/MmSaveStateLib/IntelMmSaveStateLib.inf > create mode 100644 > UefiCpuPkg/Library/SmmCpuFeaturesLib/AmdSmmCpuFeaturesLib.inf > create mode 100644 > MdePkg/Include/Register/Amd/SmramSaveStateMap.h > create mode 100644 UefiCpuPkg/Include/Library/MmSaveStateLib.h > create mode 100644 UefiCpuPkg/Library/MmSaveStateLib/MmSaveState.h > create mode 100644 > UefiCpuPkg/Library/MmSaveStateLib/AmdMmSaveState.c > create mode 100644 > UefiCpuPkg/Library/MmSaveStateLib/IntelMmSaveState.c > create mode 100644 > UefiCpuPkg/Library/MmSaveStateLib/MmSaveStateCommon.c > create mode 100644 > UefiCpuPkg/Library/SmmCpuFeaturesLib/AmdSmmCpuFeaturesLib.c >=20 > -- > 2.25.1