From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 4C071940885 for ; Tue, 24 Oct 2023 01:50:51 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=/ru8Dv1pOkeAxDxW7AmHLJ7E7zKBD3fF6mNS6t21Wdc=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698112249; v=1; b=CM0ASw3dDHSlG0VJ6gTklxcOvO5eD3+Csw5KM3zyIGxvZOFhi1rftIBMc/C2BzYTxGkQQ9TX vVLJajXCWl/tYp2wzzSVuTb9m7Nm7bQfRXjrmWjmybChEnZkXrQjBaOVDLFNPf/k26df5XU1mpu NKl5XZUTSN7+lj2MrFhVzwoo= X-Received: by 127.0.0.2 with SMTP id yiqsYY7687511xlX0OMsiEtK; Mon, 23 Oct 2023 18:50:49 -0700 X-Received: from NAM04-MW2-obe.outbound.protection.outlook.com (NAM04-MW2-obe.outbound.protection.outlook.com [40.107.101.70]) by mx.groups.io with SMTP id smtpd.web10.138876.1698112248976246578 for ; Mon, 23 Oct 2023 18:50:49 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mdRFaYK8f2dICD63Bc4jhIfbrzeBDNsoa4/z58bM6xZkSKm4YoJ5VWVxVyCqirvp9QXcKB4c8rhli7mTrKZNoNuqI0vSjrhOoqfbk0Hk9A9/qIH7TUbCdEHZtvUBQubikihiRJlsA2JHp1jgE077IHXGHqgjpFViIA/oquX1zHj8YOUFit52XZg/y3Sn3/CsUx9PqEm9kEQBDwFPgQ6UMlaofN/VbVPqhH2i4+aRl7LEkAl2XI/zmK9aZ6PSeXFQ3j5hPf5OEeiOY9ECHKfTztpRwEL2Fk8mTy/oRyo9MDD1lLFe7VtyLxntT8Va0m9r0MxfQTVdqbJCptvmQaCu1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iwxUn6qxSjHHQQOYw4Y8nA5zB0XWLNc8JB6IAgdDYSs=; b=RU+QYIcxKmphfbmxhIRwAETcsFqkONIJlRCZTZxVCk05bXXgQapECI+YNnHAwDsTnpYbREZReB6fsEMnImCTgAQh4XTXcevFv/3Km/T1k2lCETRw30RQnZLW8Vs4DYIbJYNiHGUkP25SYALKGfJFN8761pJXgb8XDK34nKF8yAY+/nSqgEBSIkBNoqHFQ9lFXOOjJ1nIhggrmg8iCsZJ0yW69kKM+n133fVACnMxjMw220QU86gIWyN8ewOO+aLud4WubF6Idyqbkz2uO4w/M04xk9nZ37pleqjEte4PJWZU/vnoya0AydX4jzGN5eJLFYjnUV4k7GE8NZnu/ceaMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by SA0PR12MB4560.namprd12.prod.outlook.com (2603:10b6:806:97::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.33; Tue, 24 Oct 2023 01:50:46 +0000 X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::345a:6816:7343:3e6b]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::345a:6816:7343:3e6b%6]) with mapi id 15.20.6907.025; Tue, 24 Oct 2023 01:50:45 +0000 From: "Chang, Abner via groups.io" To: Nickle Wang , "devel@edk2.groups.io" CC: Igor Kulchytskyy , Nick Ramirez Subject: Re: [edk2-devel] [PATCH] RedfishPkg/RedfishDiscoverDxe: remove Redfish false alarm Thread-Topic: [PATCH] RedfishPkg/RedfishDiscoverDxe: remove Redfish false alarm Thread-Index: AQHaBbvDYzkPrzmVokyWzhPcVtWKe7BYLXrQ Date: Tue, 24 Oct 2023 01:50:45 +0000 Message-ID: References: <20231023141745.259-1-nicklew@nvidia.com> In-Reply-To: <20231023141745.259-1-nicklew@nvidia.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=44a9a879-a24e-4308-acb4-90830335701d;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-10-24T01:50:31Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|SA0PR12MB4560:EE_ x-ms-office365-filtering-correlation-id: c5c90cbb-e43b-4d81-71d0-08dbd433a3cf x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: LVm3jeLG/X42UciUKTt5FqBwC7cOdMBS6mRjpIvjEpdZwjHZM3EFIDm5xrJ9mE9FSjBZwxGFEjy9s4cMWjH2kVZTTWU4RWUwumX7uVLsr7hyzSSjpYF63zb22bKmmeT0hXRJ0xlVdYxR+y9RAlpt8qnvx2+3iLiK62jAY0mH685Ljt6aEW1Odjwq8Znq3ZnfF5EYYhl6txSalYWKtTom+xmjvHLkuaHnXC7aoEq49QqD1LrEtF6DwzPzZjq71BjH2a+Capftwnf+r/RKcZrToKka55wB68IWLTHaT02YxRs4277z6TriMvzOCGixDLy+rzgiLd3ePlBgyXhc1wLkjuw1KS5FY7WxTeWxsZF0PbO1QalMXe44lgJq7HZAtwK77dIrHelaL7bqjIVqmq0kEW0NX5P5lMWWf8ki4qIyD2dNSUYbRWCAunnMh+5saXPw0IT7P51MjTu8MmHehLzBYt0n+y3HpVjQlEIDQgW0kN9UcngNvl1RJtl75kOhB4EGa71R2xshBDdKaMQRKCedPQt6Nvr+l6uvZ2W3C4KhpgqxYvkth1lwuyCsY2a2k2WK88EULq51/Edmb2g03lqRNggi5znFaTkJW0vH3e+cBcFdFLyw33ohz3Z80Znwu8Eq x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?eVasXC+AOaT2Ufo7dsUo6e7F83TKJbJd7nttuZDMz8QmPNymKOaA+DgFL3tF?= =?us-ascii?Q?YzcBfwZ5QJ36qzuncHHmYPbdkFc5Em2P3aEbsdqpA1zIe8nFbbb1RkDpAz0t?= =?us-ascii?Q?CcBj5UVSxIvfi9lFlRKScR3txxVCEPVTroiHH9uzd1ZXR7ET91oyrCCw6spx?= =?us-ascii?Q?pW1EO5FChqbhNb92S/ZoIKpaLLvwRmMFW8Y7pvNK/Y2ugpf1aZyoC4/Jvs3Q?= =?us-ascii?Q?qmJF6MiFjSZlgkScyp6hbw9Xbd82JXJ5pqoKE62J4EA8u7zIRkG1pHPwA+Yc?= =?us-ascii?Q?iT/Q6gItDoXRgBgmGyrFvXmft5Pbh4pxraDpvzvc5G2lzY9WDS1W7V+aK9jK?= =?us-ascii?Q?PWIMBPhGp+dFjEbWLS8Pnrs9IKacxLGvf4UcUklt5rvepNTeGLKrHq+n46Wm?= =?us-ascii?Q?PZIrh557BFrekhcUTJrTiaAj+fuUxwnW7GxgJEC/yLHoymnnmgBAR9Cq8XhT?= =?us-ascii?Q?sUgzsN3vzWtHP2bzEuszCDcmu1KfVEODE0pGTEQequC9Ly16jeO6Iy9Jobkg?= =?us-ascii?Q?KHnItXpa964F1wo0sqVu3EY3dd4VtAQGN2N6quMrN4Lv5tKrSTze+NocYllP?= =?us-ascii?Q?8/sbktv0Wm6QkQLfJaNj7qB+zHi0gSnUYv+6vXIBFkZ5QdTSQqLHRiv9ZTJE?= =?us-ascii?Q?Sv+hZZxnrWNQ/UnRu3ME0dBeZeTyWt9k+VeoAn0LsCJhO2DH0JtiFnUPfgsb?= =?us-ascii?Q?h3dqiSv0JgCNgnlIppq+5Y5U/gNUfnxJFQtm2K/NnfL+ht9MvjweSXf7g4OJ?= =?us-ascii?Q?qM1fEtC2HRLW8URtazb559zbuG3BdkYqm7Q1gb0dAkuO65fLs3Rte/xt47Gg?= =?us-ascii?Q?5cMEvHkH5CZBA4wqjjycy1FicvS2tyFc0QR3fyaIRS79ga4BrCMFi42ClXlJ?= =?us-ascii?Q?7hPQWLx+7bUPjuQLewQ/c74oUNTRK/s6/bhZu0gebfzH8ieDPFYgnPLkkA5B?= =?us-ascii?Q?NKoFo3hzMRMadUAiCaL0ywwe1BXstAStQn5rQU6x8YcC6NsIl+j3j2Z/PwnO?= =?us-ascii?Q?63YzAcNe1+St7CVm1jiT8UisaSYXEevfXCiNlKdR1+aRHza9h1xtsTj0EoUq?= =?us-ascii?Q?1oQLDQJB+y4ETWYLHRJRie+kLlWpBjw1PK/bpvlmV6ZAOxLP3ZKyeins+gYT?= =?us-ascii?Q?7qocRUz9e1v5eHEapuIBH35JNFuAkHDbKRLIQfbJeK059WUV95cpPoUQFxlf?= =?us-ascii?Q?E3C1pJILf3iFbo5BLXs0uKl/j+jPVbTjLtHmpLxCSuYtSDYe9/9zym7YZqUe?= =?us-ascii?Q?xeP6ejD08NjCbO6Y1sJc7ZKT/NvrLsnL3Yk5iJJzdBXgqVX00TRuAqpv7P47?= =?us-ascii?Q?V1j5Mp/Bx0eSPwW3/f53J7hyUVfJNQXjXSiK8+qAyaqSPWbf09VCWbhfjAsB?= =?us-ascii?Q?znBnIzzhy1Nn+NNIYYF3QpIXYKT7HI29BYQGVk68HDcN1KRRdcJwsYx1YulI?= =?us-ascii?Q?zzHuQ2GY6+RKmmgoTiWXIX9QelhyE9nbnxDUTNknnEbBmkYXvR+SsFOhGyCc?= =?us-ascii?Q?kCYULAkk4o34KyhwjU2cqS8GvCi/WfYf7ym8msK5xPrXfW/ZATYDIGyUJR13?= =?us-ascii?Q?zNUvUqgnFZS05PT2ztWyV12c8AohZBhOsm0vPTwu?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c5c90cbb-e43b-4d81-71d0-08dbd433a3cf X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Oct 2023 01:50:45.9420 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rRQ+McpS8kIpdKou6O/9GAJbqVX0OR03vcXpsR2m+bmYvSvoe5CQ2y33Ll7rQpEYVSR8PoWZfvs9x4GlFRbsDw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4560 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: ODclpJijVzaPZQ1EdS1GE5wEx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=CM0ASw3d; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io [AMD Official Use Only - General] Reviewed-by: Abner Chang > -----Original Message----- > From: Nickle Wang > Sent: Monday, October 23, 2023 10:18 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [PATCH] RedfishPkg/RedfishDiscoverDxe: remove Redfish false alar= m > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > - It is expected that caller receives EFI_NO_MAPPING status > when call issues Configure() to unconfigured network interface. > Remove this false alarm in GetSubnetInfo() function. > - Fix typos > > Signed-off-by: Nickle Wang > Cc: Abner Chang > Cc: Igor Kulchytskyy > Cc: Nick Ramirez > --- > .../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 16 ++++++++++------ > 1 file changed, 10 insertions(+), 6 deletions(-) > > diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > index 2f9e604f6cd6..23da3b968f6c 100644 > --- a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > @@ -198,13 +198,17 @@ Tcp4GetSubnetInfo ( > Tcp4Option.EnableNagle =3D TRUE; > Status =3D Tcp4->Configure (Tcp4, &Tcp4CfgData); > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "%a: Can't get subnet information\n", __func__)= ); > + if (Status =3D=3D EFI_NO_MAPPING) { > + return EFI_SUCCESS; > + } > + > + DEBUG ((DEBUG_ERROR, "%a: Can't get subnet information: %r\n", > __func__, Status)); > return Status; > } > > Status =3D Tcp4->GetModeData (Tcp4, NULL, NULL, &IpModedata, NULL, > NULL); > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "%a: Can't get IP mode data information\n", > __func__)); > + DEBUG ((DEBUG_ERROR, "%a: Can't get IP mode data information: %r\n", > __func__, Status)); > return Status; > } > > @@ -267,7 +271,7 @@ Tcp6GetSubnetInfo ( > ZeroMem ((VOID *)&IpModedata, sizeof (EFI_IP6_MODE_DATA)); > Status =3D Tcp6->GetModeData (Tcp6, NULL, NULL, &IpModedata, NULL, > NULL); > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "%a: Can't get IP mode data information\n", > __func__)); > + DEBUG ((DEBUG_ERROR, "%a: Can't get IP mode data information: %r\n", > __func__, Status)); > return Status; > } > > @@ -1002,13 +1006,13 @@ NetworkInterfaceGetSubnetInfo ( > Instance > ); > if (EFI_ERROR (Status)) { > - DEBUG ((DEBUG_ERROR, "%a:Failed to get Subnet infomation.\n", > __func__)); > + DEBUG ((DEBUG_ERROR, "%a:Failed to get Subnet information.\n", > __func__)); > return Status; > } else { > DEBUG ((DEBUG_MANAGEABILITY, "%a:MAC address: %s\n", __func__, > Instance->StrMacAddr)); > if (CheckIsIpVersion6 (Instance)) { > if (Instance->SubnetAddrInfoIPv6Number =3D=3D 0) { > - DEBUG ((DEBUG_ERROR, "%a: There is no Subnet infomation for IP= v6 > network interface.\n", __func__)); > + DEBUG ((DEBUG_WARN, "%a: There is no Subnet information for IP= v6 > network interface.\n", __func__)); > return EFI_NOT_FOUND; > } > > @@ -1554,7 +1558,7 @@ TestForRequiredProtocols ( > ); > if (EFI_ERROR (Status)) { > if (Index =3D=3D ListCount - 1) { > - DEBUG ((DEBUG_ERROR, "%a: all required protocols are found on = this > controller handle: %p.\n", __func__, ControllerHandle)); > + DEBUG ((DEBUG_INFO, "%a: all required protocols are found on t= his > controller handle: %p.\n", __func__, ControllerHandle)); > return EFI_SUCCESS; > } > } > -- > 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109977): https://edk2.groups.io/g/devel/message/109977 Mute This Topic: https://groups.io/mt/102136152/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-