From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 4D2B2740040 for ; Mon, 20 Nov 2023 12:30:13 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=l9Tv9LWi+Q/V7hI6V9NHAu10sH0SeWMVXE9q28sIXM4=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1700483411; v=1; b=lnpmTqqyOb7RhmIU9j1BZ2ENffMg6ZQ62N+TcGc2Y+a/xCv+ooY6/yFeyKC1k9jQFfAqjVwX QwmZpBsdZdRTzVEvohKDtoSwyJczSJEhEbvgnt2HfsXuXCp0Cgy6FgaU8VON2VqIm6wVfZ/DGsn 1Ox2LUaCgcB4xwgCMc3ddNbo= X-Received: by 127.0.0.2 with SMTP id Ilq0YY7687511xCBxAfUWeFz; Mon, 20 Nov 2023 04:30:11 -0800 X-Received: from NAM10-MW2-obe.outbound.protection.outlook.com (NAM10-MW2-obe.outbound.protection.outlook.com [40.107.94.81]) by mx.groups.io with SMTP id smtpd.web11.49042.1700483410859162989 for ; Mon, 20 Nov 2023 04:30:11 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XwqefCBxVzVxXNglm2ADVRgAbraCYRdY/L9zSulk8648YZa85uVNMbqoCE9BU1r+/6SjNUkK30RrvBoCzZhjiSdaE9otbK0jyvg02qxJ5rqNO5y4RsbyBu4SpimBiCorld1mAdXvOaW/kKfKeqrO+ZpxunOj1t+tReIf2S1lzGuCXWDozhOSpdb36scSV9GF0y35k9106g5KI/eELSAv1HX8nzrK4WmdTUccmUBSkxyM1/yZJvg7t4tcY5/JQz6hWIgJX2UOJtMx3dxKtvBQGssULWmzx5ZlTCMuVGP11JTrgYHhebAA5JyPSNUZOuxzoxwgDd7tm+FrCo2SIGLhIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w8A+27cwq6UKamjFxoySTlZL4X55Jp/CK67Pvc1OvYw=; b=Y23AIJs3CoerryrPnf7KfnFE9k3xmPiggErlzVfACooyDf4mc3T4WtcjLs24s4z7PBpBj9g7TJS2S+cLJrvQUCKb2N9mzkqxIAaU6As9jPxy+ul7aDHabjLmrH9jFCSw9UgX0Dww1KQHW455pdekOVH2ARrqoWiTvetV31qrA5IqQrg1jmtUwPG+nz7XRKcrjUIyf6LhQtLzOGhZlU85GEFAfXgpuFsYVYRjaQbrmw+YKiQ+WQdHFa48sd1n6xXkvm7YfJcQwPO8t7HlftaSAHgJHTE9JVgLa3F4h5vE1wdv0juU85p9oSxnCnJF7amTLXdhgEbAsNWBIooc2/XkrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by MN0PR12MB6269.namprd12.prod.outlook.com (2603:10b6:208:3c3::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.26; Mon, 20 Nov 2023 12:30:08 +0000 X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::91d9:e679:32a3:dd05]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::91d9:e679:32a3:dd05%4]) with mapi id 15.20.7002.027; Mon, 20 Nov 2023 12:30:07 +0000 From: "Chang, Abner via groups.io" To: Ashish Singhal , "devel@edk2.groups.io" , "quic_llindhol@quicinc.com" , "ardb+tianocore@kernel.org" , "git@danielschaefer.me" , "jbrasen@nvidia.com" Subject: Re: [edk2-devel] [PATCH v2 2/2] EmbeddedPkg: Allow longer android kernel command line Thread-Topic: [PATCH v2 2/2] EmbeddedPkg: Allow longer android kernel command line Thread-Index: AQHaF3GYZ+tR9dsPD0OOnIsCWS44GrCDKm3g Date: Mon, 20 Nov 2023 12:30:07 +0000 Message-ID: References: <3ab879ada6d9f2b01496ecc05102510564888044.1700008662.git.ashishsingha@nvidia.com> <888db180ae77070619a13ec4e6d6356a97a03176.1700008662.git.ashishsingha@nvidia.com> In-Reply-To: <888db180ae77070619a13ec4e6d6356a97a03176.1700008662.git.ashishsingha@nvidia.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=6341a878-0281-45d6-ad22-c6b8e4b9edfb;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-11-20T12:25:33Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|MN0PR12MB6269:EE_ x-ms-office365-filtering-correlation-id: ab6e33e3-d72d-4f8d-aebe-08dbe9c46e76 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: ugJS0k4pQJyarpHUirFIh1QA1glmflaXR+75DY3+kXk75uYlAi1Wxb8lzaw7Dd4HWqMkFiJj4xNHo+8GJLO7Ozs10PHz8wD+whQF5oW7e20+zzo2qN0e/kf28XIoNowqqe9vfGpcIEGOedE8TO/RHZ5z7DsZxtdyQqDyyHXHmjHWsApJWUHiSg2dBZ7LsrlGBVu3PrN7a+rv+LcPCm35ZX/DsFr0Yiv2hFYVIeGdAZqCt8WRPdAgJXVENK8cSlwo6aSYxNG/2uUMih7xDr3z5ibtlpMl0LOFkejphKilIPgaJUe9GpSDmdjkR2nkkMKR5EGfcEg+ttnmR4QVenA51KNy361wZZ2GhpX6mQnvvK/EvH1vEmg9Zq3MlkMXlJBX/eaBxERKSMI37dqg7v3ZP3429FeNN7h2Izv+Q9OoN3z+dAC16xmEUk1Nu3mMJIw8bZHtonQ4VpP93vrqz/VyR3GqWpReMZVnR8QJdkDMtdBtC7De3zBwj1xZGVA821KZxVRGZfCC1TWEN2kLnLTyvN5Z/55WyQcfW31T/tg4A2ldU9e4OL5MpysfWZaI7r7elj3cicQPyiCVVEz10cuPDKHu7sKJuiyCSu+3M2NPlCS69OjferboO1W6o4xJa3Vw0EBpcQpY+IkfHYYzpsq8dqocXMJ7uWFTE98uIksYIN6n4eKwwTI2awQ8631MLdRe x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?NnERy6IKMw4KpzD6zi8DGqL4SKO9IJtFL6SLeQGl+bT3+Cc5XSZZrxvm44SA?= =?us-ascii?Q?7K9ifjtGY8SU7002QTFiFAJhDGIO3/LJhwLrKO4NPiNbftc4kvvQjZFkYvzU?= =?us-ascii?Q?e8q8caiUaSqGyvBTreVNdPW7pec+zWoBYmhX9ddJrSSmIIY81YhMGS+eol/K?= =?us-ascii?Q?CVwPY2o6VCzF2mdVclZt8x1GJWw2GjwvNtYm1pCwwPus6PT26CUUoTh1SAwd?= =?us-ascii?Q?FKQXzwSe2F/hJtEUN/g+8A4Lm1V7jrhXbQ9pmL0lvNZWhggkVL/gxyHuwxPA?= =?us-ascii?Q?a+zJo4xM+wLcwBEw7c84Jq92tcarE2krv4As8MgtAy61vyyLC99bePWrkn4R?= =?us-ascii?Q?GbQTuKWP+Tm+VHKufbYLavVcdIjy67I3/ARkYBTA90zSbxg5dFxBocgEFIFa?= =?us-ascii?Q?N+7TxV3QE/tuHj5A/09cK/FaFEkvq8kKPmavUBt6Oe7oZYrLlYiLuea0DkHI?= =?us-ascii?Q?fEqJfuYE9TvZbkQ7Y2WEsfyIUETVpBs29VWDgTowgYkCRWX1LjrUnX71PSAT?= =?us-ascii?Q?laHfgaHA5BA0Fu922MYOQCNQqEl/mSKj3jCIneGNXO8m66dk/lBCLNM2KNY7?= =?us-ascii?Q?Z122TyNteJjIGB/us+MzKfaTllgMC+7JlNrkbtvM0XgCDe0c0oF3RWv1qw3d?= =?us-ascii?Q?3GYfvaZT/+WITqdV1MdQ4hQp0HBJ5lnVMKWf2qJtwcsF8/CCQQ/o5B04Lm1Q?= =?us-ascii?Q?4LvAMJnknBvRzazI72MOU1opTu0D9ZEN6Dab1UjZMRHlYER4k+hG7EvJmOHx?= =?us-ascii?Q?bII3cRDAArMuDBmYHah5hlYbpwsKbxrllpyMKIURTDCrY4BHap7V21tW2Ij2?= =?us-ascii?Q?lkrwtHY3xH3JQlpLagaUd5kebpYrkXoELP7Mtaa0kwehxtJMe1HgZA7Tw7KC?= =?us-ascii?Q?9tn7E0R+YztlvcxFv/k69ze1ARUF0ANgi43XClOVRUD3cHQJ/p6N9D41reR1?= =?us-ascii?Q?+PLvR48KyzkGG/Dvw6vQpf94afrl6rt/Q10SUVUSRrpamQufTomerjGsZrXh?= =?us-ascii?Q?5lW/Sk1h+/lFGESO38700FyMHF32T8pRFVkyqfDmESVFTJDwbAMwgi6D51Ye?= =?us-ascii?Q?NvkHuiu2AEezDAd8o9n+wfuuGbYE5t6KEBw3pYcXzFx1j7l3eO+fMEztRCPA?= =?us-ascii?Q?9fSRgGgEYq5MYIuEtmmbQJemRAopzYcwQubaW4NaQx2UFWbVhOLt41VSwzxq?= =?us-ascii?Q?uMymTR8W8Q6hmrDtPZo/n5qUXvsCpaw3odNv3WCAtHnciwmYFzsWWsC2KQ3Y?= =?us-ascii?Q?6K/WyU3qAgSzSefrm2hrdgFzQT9O842uFAOLwrCaHU7NzuvMH/ekHisv8P7Y?= =?us-ascii?Q?op/xfZF5O3s6zgdd/5G3MZTkLUB7dO+1o3c6n+abM3HhUL2jR8EHNdi/rk4r?= =?us-ascii?Q?vd8goB0E+If3wI84lRI1nt7UHrV0WaIDVNCLsjPlLlxKwgqmniYIjlFHlIMr?= =?us-ascii?Q?tRiQO8MvAPuD5S9IcEohpzh/nPqxIfJCiQNOicmySwvbbNZVGMiOV3CgT2ts?= =?us-ascii?Q?9crgBVCIY8c9ErsEtu33w8j+C/F42Q54g5JvYoWNUfHp2gJ8HvsYqX6cQrMS?= =?us-ascii?Q?UzE1vZ2zcoMd/jBvcaQ=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ab6e33e3-d72d-4f8d-aebe-08dbe9c46e76 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Nov 2023 12:30:07.9122 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: FhclsIzAR8KJsn/viHVncq430QOovWeOKTwv7p14M+cCqdedi6YD/sNeIpeQL7q5RJvuqntkI19J1U2tN2LPng== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6269 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: X6tTS8siMCG5CchYXuCy5YwQx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=lnpmTqqy; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") [AMD Official Use Only - General] > -----Original Message----- > From: Ashish Singhal > Sent: Wednesday, November 15, 2023 11:12 AM > To: devel@edk2.groups.io; quic_llindhol@quicinc.com; > ardb+tianocore@kernel.org; Chang, Abner ; > git@danielschaefer.me; jbrasen@nvidia.com > Cc: Ashish Singhal > Subject: [PATCH v2 2/2] EmbeddedPkg: Allow longer android kernel command > line > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > AndroidBootImgLib allows for platforms to append to kernel command > line but does not allow for the overall kernel command line to go > beyond the limit set by the image header. Address this limitation > by adding a pcd where platform can tell how many extra characters > they expect on their platform in addition to what the image header > specifies. > > Signed-off-by: Ashish Singhal > --- > EmbeddedPkg/EmbeddedPkg.dec | 5 +++++ > EmbeddedPkg/Library/AndroidBootImgLib/AndroidBootImgLib.c | 2 +- > EmbeddedPkg/Library/AndroidBootImgLib/AndroidBootImgLib.inf | 3 ++- > 3 files changed, 8 insertions(+), 2 deletions(-) > > diff --git a/EmbeddedPkg/EmbeddedPkg.dec > b/EmbeddedPkg/EmbeddedPkg.dec > index 341ef5e6a6..94dc3c9b76 100644 > --- a/EmbeddedPkg/EmbeddedPkg.dec > +++ b/EmbeddedPkg/EmbeddedPkg.dec > @@ -183,3 +183,8 @@ > # Selection between DT and ACPI as a default > # > gEmbeddedTokenSpaceGuid.PcdDefaultDtPref|TRUE|BOOLEAN|0x0000059 > + > + # > + # Expected Overflow Android Kernel Command Line Characters > + # > + > gEmbeddedTokenSpaceGuid.PcdAndroidKernelCommandLineOverflow|0|UI > NT32|0x000005C > diff --git a/EmbeddedPkg/Library/AndroidBootImgLib/AndroidBootImgLib.c > b/EmbeddedPkg/Library/AndroidBootImgLib/AndroidBootImgLib.c > index f63648e60d..d16929f2bb 100644 > --- a/EmbeddedPkg/Library/AndroidBootImgLib/AndroidBootImgLib.c > +++ b/EmbeddedPkg/Library/AndroidBootImgLib/AndroidBootImgLib.c > @@ -335,7 +335,7 @@ AndroidBootImgUpdateArgs ( > return Status; > } > > - NewKernelArgSize =3D ANDROID_BOOTIMG_KERNEL_ARGS_SIZE; > + NewKernelArgSize =3D ANDROID_BOOTIMG_KERNEL_ARGS_SIZE + PcdGet32 > (PcdAndroidKernelCommandLineOverflow); I don't know the history of ANDROID_BOOTIMG_KERNEL_ARGS_SIZE, however, I am= a little bit confused. Is this PCD introduced for the case the string size may greater than ANDROI= D_BOOTIMG_KERNEL_ARGS_SIZE? If yes, then why don't we just use StrSize (Ima= geKernelArgs) * sizeof(UINT16) as the buffer size? Regards, Abner > *KernelArgs =3D AllocateZeroPool (sizeof (CHAR16) * NewKernelArgS= ize); > if (*KernelArgs =3D=3D NULL) { > DEBUG ((DEBUG_ERROR, "Fail to allocate memory\n")); > diff --git a/EmbeddedPkg/Library/AndroidBootImgLib/AndroidBootImgLib.inf > b/EmbeddedPkg/Library/AndroidBootImgLib/AndroidBootImgLib.inf > index 8eefeef4f9..9754664df5 100644 > --- a/EmbeddedPkg/Library/AndroidBootImgLib/AndroidBootImgLib.inf > +++ b/EmbeddedPkg/Library/AndroidBootImgLib/AndroidBootImgLib.inf > @@ -45,5 +45,6 @@ > gEfiAcpiTableGuid > gFdtTableGuid > > -[FeaturePcd] > +[Pcd] > gEmbeddedTokenSpaceGuid.PcdAndroidBootLoadFile2 > + gEmbeddedTokenSpaceGuid.PcdAndroidKernelCommandLineOverflow > -- > 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111470): https://edk2.groups.io/g/devel/message/111470 Mute This Topic: https://groups.io/mt/102598723/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-