From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (NAM02-BN1-obe.outbound.protection.outlook.com [40.107.212.78]) by mx.groups.io with SMTP id smtpd.web09.744.1668388206863576910 for ; Sun, 13 Nov 2022 17:10:07 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=tE4Qjnem; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.212.78, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lPQAernYxFJlQRRgjHIht0zqjLcepbKw9sMQSNMUx9oAi6ui7qGdJpvIvIzmE/zLRlX5LyC/BSM2zxy1Hi3C07Sj0rP3dx0S6fn9sF+XfSJQ2l/IcRTLP6zBG1Q3mDsJGKdTeQuoWBX3EI+cQmOVkOAuo7Q2jF72TUVmBF2aSjlgRWVablAJiBVOP1QttPgXe9fnniBGh+QnElszrr+IeIAhHUFoKpaQtULdNhaNGvm/6V1XZfgIKzvY5cjAp0cAjRWZY1GdIfHd9W8hbCmh8+DpL3fhcvGQfoLL5AJK0hQj8Unhcf8ttUnaTh86SzY7xJuYzCADqv9G8fXjAdpXuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1tzjYt/3M7gbiE/wWDcA0KAB92CBHLA5z2d8dlXvsY8=; b=B/o9YlvAJJHYuHdEbr/hgioFA6AjmrYPzKZCkpJhqSTHcdw9Wn22ldpzhfPvVnAb8UdDYdzwcvkNGCxTY81ZZLULaSDM045JuUZbSBaYUk6FsH1lOOBnOmQ9GoNmZWwRFR5U10nlEu/X0kMxUCCMziMsQoBZh0IIz6wTW0eLkQiImA+qaIkptzidbuWMbARlCGb31VLJ1rJLV0iPV3ZLM+nq7fVz0qv0BjRY4gtsluF1On7zKwSiIReKR+YfCmsHRiEXU0psAgM/wCMDYcGoPeSSvTahUatRWqJkyl6VjnfGiFPbeEvLYGgSf7TjTz5jiyY5tzPz/mbroUfrRUe4yQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1tzjYt/3M7gbiE/wWDcA0KAB92CBHLA5z2d8dlXvsY8=; b=tE4Qjnem2pXuYmAPFRf/qTX96Uzj0Z55jI7I/GzRfAziUJ2qG62s+cu2ybZWk4JxbcgtoOIDNE6j1UEBOaCt9tpMR86IeIQkq4MaMpQUFQ+qwkrMZaZWzutvJ1GS7SA163ZHQCqRmYHjNKUdSNo/zQ6jVzX0mquL4Cg9esr2WrM= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by SJ1PR12MB6218.namprd12.prod.outlook.com (2603:10b6:a03:457::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17; Mon, 14 Nov 2022 01:09:57 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::ce0a:283e:839:34bd]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::ce0a:283e:839:34bd%3]) with mapi id 15.20.5813.017; Mon, 14 Nov 2022 01:09:57 +0000 From: "Chang, Abner" To: "devel@edk2.groups.io" , "michael.d.kinney@intel.com" , Laszlo Ersek , "Kubacki, Michael" Subject: Re: [edk2-devel] [edk2-CCodingStandardsSpecification PATCH 2/2] Source Files / Spacing / Multi-line func. calls: allow condensed arguments Thread-Topic: [edk2-devel] [edk2-CCodingStandardsSpecification PATCH 2/2] Source Files / Spacing / Multi-line func. calls: allow condensed arguments Thread-Index: AQHY9wA8eJ5V+X7WCU6R4R6Zrs8Iy648GJaAgABv7YCAAJZGAIAAe85Q Date: Mon, 14 Nov 2022 01:09:57 +0000 Message-ID: References: <922996c2-e60a-80ec-6d4a-8b2e5a639c9b@redhat.com> <25893.1668303336748921539@groups.io> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2022-11-14T01:09:54Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=a823d5ea-e6b2-4ad6-a190-9262fa7416a7; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|SJ1PR12MB6218:EE_ x-ms-office365-filtering-correlation-id: c5a7a7ab-c424-42e8-3604-08dac5dcf275 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: O3qUCsbkjc0pKwEkRs0coc2gyHaKEOCzPptxFxqMOd0U577gyk/NGyxTpohjEpwg6jRpu1lXrkAU/sfQg+VbzAH2LCjSc3/Yp/ST6TfBUScXUhR3E2fqJ1SXPqJpBGRtqqbER0EZP8Iwd80pgBEj7ShKRgBaxG6TCi1T8XcB3YpWf65BoYH3Xn9GWpOJfBq5JIrkeHI+zGUWC+W+wy04efUh01CuYq1o2thCREYsLSva6kKiTG4zcioIR3d7wkjthB+W2TDbBAhmwXNQ6x+kwf5ApqVbG6139zi3+nuQ978fUQjm3vzuXZDKkADV8YJj2afB0nA16wjSNc23qctRga4JClktHJHLmQnr8/hVXGDIFPsxhTUSrIjEMro/xQUwRuQLGLJlAdlZpTZrgWcT5SkMaCC+u30PUwAqy2JXW6709JhHfhs1GY0FxgGGVtRjiMYvz3k+WyP8uyK5iNrkuDO47aNNoFzD7+G/jiQJPf2xkUt3FQ73OZaRA/9C9hznJ5ze78HDKKdt3OS7vqW5L/apebqaElcYeYgGcs14W0kbJ5Nm6j7qTsoA9bQ0rrKWHUbWzcaRmLaduYJaZuwMPHSv272OMP+oWkO+3T6s4U0JNpNk3sTQpPX0AJwSEzxT+hkOekxUvjsXBkksOEhPIA0O35U5Yc3xesvrjvAQW9jfOB+TLbuTUln9L+eFigPjTqJSCoEuVvXe1OjEY4NglRLCHjl32NrQO9GHn2lwXAsurzvP4V09MlfQt7c7cisRD6y0dmkwtDCbPYRhtVPubxP1Om/Dpb3CwtXfRTO0fOs= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(346002)(396003)(39860400002)(366004)(451199015)(33656002)(38070700005)(86362001)(166002)(66899015)(122000001)(53546011)(7696005)(6506007)(55016003)(83380400001)(186003)(38100700002)(26005)(9686003)(478600001)(76236004)(71200400001)(45080400002)(110136005)(316002)(41300700001)(64756008)(66556008)(66446008)(52536014)(66476007)(66946007)(76116006)(8936002)(8676002)(5660300002)(2906002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?bwvMOrHEnrRsYi+gCcwaOe+/98/0l96lmBMEiAnwAQzmQtsBFJHc/YfynTJ+?= =?us-ascii?Q?4ETw/E4Zde4FL+5GxPeuzWjD/lkzaom7dgGxkJHYgN0CNbc8L6a67TPQ4Kgh?= =?us-ascii?Q?BxjOLWsUAuZMzSVH0i+gg/5UAkdxUH9ZjIsP28C0Tu/CqWuHmfjiFjN3IM+9?= =?us-ascii?Q?NASGeOBOpvGtLrZyKJ6JKkCFkX/bfclbJF3ZUD5/u0LX8zeP9rA9Q4BWCsvK?= =?us-ascii?Q?21Loa3sr8ZNjP7E6qTlO3q8CBeEELAB9w5rehG6c0c2QiNAs+jRQm3c5m9AM?= =?us-ascii?Q?S7Nz5o5hTOKyCCmbgcqrFP9kxdOxfCEBO3pa9MC1CPU2yXbq79ZK7NaOTWVH?= =?us-ascii?Q?ltHkbSssupeEMQLb4koX9U9kyF72ShWZG1z1JEBCEDuUDb5oFS+6RaxI2/yD?= =?us-ascii?Q?em+w4KD4xZ+XMSHPBBtwAXuFNDnfCLfz2+GQBp3aA33IwvWTpvN8qeMITFMJ?= =?us-ascii?Q?kGDJfsVCVnJFUeMKMgV2P1qGZyd5p1byPHJ8n/IhkgqIjGOCYrzm1rH/weD5?= =?us-ascii?Q?nfNtrmy5KKxswHODEmURN1L8DAlMFUE1eGaFrHA+7BGdfgjkLZP7zfxp2t7Z?= =?us-ascii?Q?nYuXzbpNT3Ko/4GzLBurWMjiiKWKM0GC//8new0cMbWPA6fH1yjCxqu+9TNB?= =?us-ascii?Q?CwrSn4MBdHcvpMwmUS+zno5Haj8foFxFC7G0ESC6jnyNGurrkboUspenGHoD?= =?us-ascii?Q?OkGeDqhreaux7pLTHCsnaecHR/9wvv9PK3SJlOt/D5Mby72KVg7GcgJU3CAl?= =?us-ascii?Q?a9RUzXtU95cOv5hGu8c1fiqqmjpBE9rv1rKqkVTgL7J+hijSqiSZet2imqq6?= =?us-ascii?Q?OND4ThfcbBCepwUpkjItwG0p7qNyeWTDll4i3eQeoY+v9e+P7C1kI/kV0oGR?= =?us-ascii?Q?qeMfRYI5Qhxx7NBNFA4Nf5k7SZDzHgit9utWrAyd+oZTjYD6/OXJaI6VDhLq?= =?us-ascii?Q?wtrONFoElRdoSgEg/PN4OBQUlXUHvXE2xbe57wbuNc/JdYLZEJBA8NLJ9/ld?= =?us-ascii?Q?T8s1pcptIJ4xeZQlz5xSx2aV8evnKz4m7DRmm6RvDhRyARmfP3miXjLD27aU?= =?us-ascii?Q?0M1xEu4Hee5sbqo7vbat/rbyp2ZeAZdxtM/p0j3rMcP2R/O50QO68GRLh4vw?= =?us-ascii?Q?hoIt1s0fyplUAvX8ldSdyQBFyR6G4GkCPZGQRMrG/h81A9UAftOy0txRXvit?= =?us-ascii?Q?cWtaPbLN+kXGGHkS+q72FvwlLWtVGpxfqxvyzfRtnV6+/xuCVwY0WmLZqnij?= =?us-ascii?Q?cAQR5E3il/YWdT8k2fU5wkLG7TB4bfNGCazD4JxObQBFpWhE6/ubB60x3cvU?= =?us-ascii?Q?ueuMW5NsMKAzfmfEhbPxKJZGiN9ZAVfzUVuB5rx5waWdXLf5CNmF9xwqoCso?= =?us-ascii?Q?xNbzIh0ZTRmdxpiG9ab9qOWe5ieXTxRfdaixhVq0nlGWF8Ul0DIzH8NyaJ71?= =?us-ascii?Q?N/wRycN/BxAL3MNOlxtmqmNFoP65e1HFtO8SB82WNSgOJd6mc4orpgdf0uyU?= =?us-ascii?Q?cwbZUiSUwzm8fa2YYwD8Mq1uYr591RapGW0fZM9jMZ6r2Abrcprr8uUy9yrX?= =?us-ascii?Q?HMR3PFOeu54bWqKGXQU=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c5a7a7ab-c424-42e8-3604-08dac5dcf275 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Nov 2022 01:09:57.7435 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2/gTdBY/A+U5fxmB8v4164UkNxL4ycaX3wRUYR+Y/DYUcKmoJBpJtSVGIwgWVQv0gf7kv+knfTH9i4w7QsJGsQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6218 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MN2PR12MB3966C7C0566B7FD3A96D38D8EA059MN2PR12MB3966namp_" --_000_MN2PR12MB3966C7C0566B7FD3A96D38D8EA059MN2PR12MB3966namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] For this case, we don't have to take another global reformatting. These two= formats can coexisting without the conflict. We just allow the condense a= rgus format in CSS. Also, update Uncrustify to not forcing each argument at= its own line. The current Uncrustify behavior seems to me match the CCS spec. But this pa= tch was sent to allow the multiple argus at the same line, which was not pr= oposed to fix the issue in current Uncrustify. You sure we just close this = issue? Abner From: devel@edk2.groups.io On Behalf Of Michael D Ki= nney via groups.io Sent: Monday, November 14, 2022 1:36 AM To: devel@edk2.groups.io; Chang, Abner ; Laszlo Ersek = ; Kubacki, Michael ; Kinn= ey, Michael D Subject: Re: [edk2-devel] [edk2-CCodingStandardsSpecification PATCH 2/2] So= urce Files / Spacing / Multi-line func. calls: allow condensed arguments Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding. We do not want another global format change because that make git blame dif= ficult to use. Are any clarifications required to describe the current Uncrustify behavior= ? Or is the description correct? If the current description matches Uncristify behavior, then I recommend we= close this issue as will not fix. Mike From: devel@edk2.groups.io > On Behalf Of Chang, Abner via groups.io Sent: Sunday, November 13, 2022 12:45 AM To: Kinney, Michael D >; devel@edk2.groups.io; Laszlo Ersek= >; Kubacki, Michael > Subject: Re: [edk2-devel] [edk2-CCodingStandardsSpecification PATCH 2/2] So= urce Files / Spacing / Multi-line func. calls: allow condensed arguments [AMD Official Use Only - General] Uncrustify can fix the first argument that is not at the indent with two sp= ace. It also can fix the first argument that is not at the new line. But it also makes each argument a new line if multiple args are condensed i= n one line. That is what we have to update Uncrustify if we have this patch= merged to CCS. +Michael Kubacki in loop. Abner From: Kinney, Michael D > Sent: Sunday, November 13, 2022 9:58 AM To: devel@edk2.groups.io; Chang, Abner >; Laszlo Ersek >; Kinney, Michael D > Subject: RE: [edk2-devel] [edk2-CCodingStandardsSpecification PATCH 2/2] So= urce Files / Spacing / Multi-line func. calls: allow condensed arguments Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding. Is this exactly what Uncrustify does now? Mike From: devel@edk2.groups.io > On Behalf Of Chang, Abner via groups.io Sent: Saturday, November 12, 2022 5:36 PM To: Laszlo Ersek >; devel@edk2.= groups.io Subject: Re: [edk2-devel] [edk2-CCodingStandardsSpecification PATCH 2/2] So= urce Files / Spacing / Multi-line func. calls: allow condensed arguments Hi all, As we are going to release CCS 2.3, we would like to address some pending i= ssues of CCS. For this, I think we can, - Still keep the one line per argument style in CCS although the multi-argu= ments in the one line style can cover this. This avoids confusion from read= ers and questions about if they can do the one-line per argument style. - If the arguments are in different lines, the first argument must be inden= ted with two spaces from the start of the function name or the member funct= ion name. How is this? Abner --_000_MN2PR12MB3966C7C0566B7FD3A96D38D8EA059MN2PR12MB3966namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

[AMD Officia= l Use Only - General]

 

For this case, we don’t have to take another g= lobal reformatting. These two formats can coexisting without the conflict. =  We just allow the condense argus format in CSS. Also, update Uncrusti= fy to not forcing each argument at its own line.

The current Uncrustify behavior seems to me match th= e CCS spec. But this patch was sent to allow the multiple argus at the same= line, which was not proposed to fix the issue in current Uncrustify. You s= ure we just close this issue?

Abner

 

 

From: devel@edk2.groups.io <devel@edk2.gro= ups.io> On Behalf Of Michael D Kinney via groups.io
Sent: Monday, November 14, 2022 1:36 AM
To: devel@edk2.groups.io; Chang, Abner <Abner.Chang@amd.com>; = Laszlo Ersek <lersek@redhat.com>; Kubacki, Michael <michael.kuback= i@microsoft.com>; Kinney, Michael D <michael.d.kinney@intel.com> Subject: Re: [edk2-devel] [edk2-CCodingStandardsSpecification PATCH = 2/2] Source Files / Spacing / Multi-line func. calls: allow condensed argum= ents

 

Caution: This message originated from an External Source. Use proper caution= when opening attachments, clicking links, or responding.

 

We do not want another global format change because = that make git blame difficult to use.

 

Are any clarifications required to describe the curr= ent Uncrustify behavior?  Or is the description correct?

 

If the current description matches Uncristify behavi= or, then I recommend we close this issue as will not fix.

 

Mike

 

From: devel@edk2.groups.io <devel= @edk2.groups.io> On Behalf Of Chang, Abner via groups.io
Sent: Sunday, November 13, 2022 12:45 AM
To: Kinney, Michael D <michael.d.kinney@intel.com>; devel@edk2.groups.io; Laszlo Er= sek <lersek@redhat.com>; Kub= acki, Michael <michael.= kubacki@microsoft.com>
Subject: Re: [edk2-devel] [edk2-CCodingStandardsSpecification PATCH = 2/2] Source Files / Spacing / Multi-line func. calls: allow condensed argum= ents

 

[AMD Officia= l Use Only - General]

 

Uncrustify can fix the first argument that is not at= the indent with two space. It also can fix the first argument that is not = at the new line.

But it also makes each argument a new line if multip= le args are condensed in one line. That is what we have to update Uncrustif= y if we have this patch merged to CCS.

 

+Michael Kubacki in loop.

 

Abner

 

From: Kinney, Michael D <michael.d.kinney@intel.com>
Sent: Sunday, November 13, 2022 9:58 AM
To: devel@edk2.groups.io= ; Chang, Abner <Abner.Chang@amd.c= om>; Laszlo Ersek <lersek@re= dhat.com>; Kinney, Michael D <michael.d.kinney@intel.com>
Subject: RE: [edk2-devel] [edk2-CCodingStandardsSpecification PATCH = 2/2] Source Files / Spacing / Multi-line func. calls: allow condensed argum= ents

 

Caution: This message originated from an External Source. Use proper caution= when opening attachments, clicking links, or responding.

 

Is this exactly what Uncrustify does now?=

 

Mike

 

From: devel@edk2.groups.io <devel= @edk2.groups.io> On Behalf Of Chang, Abner via groups.io
Sent: Saturday, November 12, 2022 5:36 PM
To: Laszlo Ersek <lersek@red= hat.com>; devel@edk2.groups.io
Subject: Re: [edk2-devel] [edk2-CCodingStandardsSpecification PATCH = 2/2] Source Files / Spacing / Multi-line func. calls: allow condensed argum= ents

 

Hi all,
As we are going to release CCS 2.3, we would like to address some pending i= ssues of CCS. For this, I think we can,
- Still keep the one line per argument style in CCS although the multi-argu= ments in the one line style can cover this. This avoids confusion from read= ers and questions about if they can do the one-line per argument style.
- If the arguments are in different lines, the first argument must be inden= ted with two spaces from the start of the function name or the member funct= ion name.
How is this?

Abner

--_000_MN2PR12MB3966C7C0566B7FD3A96D38D8EA059MN2PR12MB3966namp_--