From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (NAM02-BN1-obe.outbound.protection.outlook.com [40.107.212.42]) by mx.groups.io with SMTP id smtpd.web11.5236.1667184980396167726 for ; Sun, 30 Oct 2022 19:56:20 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=ZBauc+W3; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.212.42, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BI5AI0sqWpglsUbkWF9T5s6yNUKDRl2cy4SipaYhq7qZFHJTcY1/dCSYrwuWXg7977eC8TV23nzRlo9oiHaK+3LP3SI/p4wxxG78sv6bSGcLEusisCaTMxaRYz20dRV+e6D2SpMI6GfkgpBeJ7vxdOMkGh42RMTNESgYWvy6YvPgWhRdjhIzWk+i0LSKqGBTiy3lkuE/ZUGKgGH18SttY5gJvWJUhKkCqS8vbzvHjx9f84bjmZF1PXIul4KutktLJwqwPm+LOT+N2FLshgR6Rc9BUNUOyt869DE9pxR3/GYQrZoTeBx8pB2r1PRyaq//HijjvaoYCOvpLlBd+l2jVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F+I+Cj4uSTB9n2X7xlt8Is1HfIyyr2iCpX4ltxyjlTQ=; b=oZs+gAnIQSMnkimRwUE4neJTD3W4fd7K0ftVJUKE+WUPEM4HmSdx1heE+sI8kH+3dF6AM2Qm05h3yPBXUf2GKhLZdPUmwuA1niAXJBiKuLeIYjUB3OH+8xiVJDGr0+7eKpVcD9Kk6JjlCRyd8PjYwkw3FSufL9TAha4EWILgDoMzITqrb6MdbwumgVa6LwRT3soIUmWXj6CN58EqlDFp+OrYbhdICRb4BGlG8jo2+NvV3jORmuM5pkw4LjFqxtbQ5f6jboQ42GkhB7WODW6SM80hsv/2fVpMMuStX1oSrxamVlKiuZ3KZ4Yr/HI0gfrw88JDhRxKhX4kIDfotw8kMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F+I+Cj4uSTB9n2X7xlt8Is1HfIyyr2iCpX4ltxyjlTQ=; b=ZBauc+W3yebRREwxZH4BqI1wpD4Z36nk457X+r3QeUOwvVYl11H+1y1BTSLWvGimXvRnBnKi9prKQEEPmEiuJY3oCDWisfwMm1PkGEVIRUQUiF5m344aDsQXZ7hC/2J7r9tTCOOrwodC7F1RnochUtPVCn12mycVZcJFNyRJDzU= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by DM6PR12MB4108.namprd12.prod.outlook.com (2603:10b6:5:220::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.16; Mon, 31 Oct 2022 02:56:18 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::2547:627:78b9:cd63]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::2547:627:78b9:cd63%3]) with mapi id 15.20.5769.019; Mon, 31 Oct 2022 02:56:18 +0000 From: "Chang, Abner" To: "Ni, Ray" , "devel@edk2.groups.io" CC: "Attar, AbdulLateef (Abdul Lateef)" , "Kirkendall, Garrett" , "Grimes, Paul" , "Dong, Eric" , "Kumar, Rahul R" Subject: Re: [edk2-devel] [PATCH V2 1/3] UefiCpuPkg/SmmCpuFeaturesLib: Rename the common C file Thread-Topic: [edk2-devel] [PATCH V2 1/3] UefiCpuPkg/SmmCpuFeaturesLib: Rename the common C file Thread-Index: AQHY7F/g92+lEIurI0uT87+ot1RH5a4nv/2AgAAOCxA= Date: Mon, 31 Oct 2022 02:56:18 +0000 Message-ID: References: <20221030130147.1143-1-abner.chang@amd.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2022-10-31T02:56:16Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=b5a033b0-c8a2-4abf-a557-cf5f117b201b; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|DM6PR12MB4108:EE_ x-ms-office365-filtering-correlation-id: bd553c46-f6a3-4ad9-1b9f-08dabaeb7bb3 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 4CFSBi3k2EIn07b95A7KR6rParKFD6Qs1ISKYSZp0LAYhAHuBBodrXca0O1SA9mQZlyHgJhDRwcpp+jUFgUTpWQ2TI2QDunNSJA2Yw74Kb89mqIsELFEGP6xpQsOro9/OeybVu/7R3Es+v13O2H720fFE23fOd4Xv/i6rvoCAz3Jz2Ija5T3O6G20BtfzxXD6p7DTCPNxr8ZfRCBdoZgYhKFjGPjIp5OHHb8MFSGPvUdGuUglop0dxybgkMEiH+audMyFCShf8kID3aHOy6L9bojF0PHSHMJ4E0mL928PgZTAw12wwL686PkqbErGYZvzdnEcoh0Zp8IbgMLSzbjsYmYLAaxWTfJSbVxR2PK2kPzCFmWd/6G7p0B7/Kximid+i2dtVFInVR6DDhmigkfuYX1qRJnVgeli9WzH3cHBlHFWWlcQFDgnhriX56cJ+HdM7FwABvKf+EleelACd+PCNuOtpWZP5SQnDXYhqSefve+94ki7v/kj7IBowAUK+PKnjKeEPaMjexOqmjygkipMRg5CWt3iDe56jxIrAIBcQuFDRAtwkzTBQDYq4gcen9FMt6wVK1kRjWl6HC1aBxNfhFhELTX/SjKaHdQYFKidvQqYvH/YX0o4Fn4BLcOiIyiUp3PhEo2gVR/zYprz53qS5U03LcjdsJXtJCBNubtWvf8E8WyTdYwe09hW+mTO7u6Kob+B7TPjwlmPv+8m+E7DK6CXOSrq78qrMFyFTyP/9zH+x9ajlBRIHd6XJ6V4+RZtwOTCg8zRoRgA7VVGNF1bnp3xv0F9IdHNzqq7KAfBFVgLVVvKGSyVEtdmxABBj5DyOUgwXh7b/ydacSjFc0neQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(346002)(136003)(366004)(376002)(39860400002)(451199015)(66899015)(64756008)(66446008)(66476007)(8676002)(66556008)(4326008)(86362001)(52536014)(5660300002)(8936002)(41300700001)(66946007)(76116006)(110136005)(54906003)(45080400002)(71200400001)(38070700005)(6506007)(7696005)(478600001)(966005)(316002)(2906002)(55016003)(122000001)(33656002)(83380400001)(38100700002)(26005)(186003)(9686003)(53546011);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?t73kAT9IhWC2kMzsp3/ekY6c457Bq2z9EkzL6xEzsKaFGVyi/X0/7aJjFGCJ?= =?us-ascii?Q?NpsXLO58OFAwt2OFJ0tOzld5Cww9Q21UZbZzSlAkmN62JnHWJVxcYvBdQA1j?= =?us-ascii?Q?+/4PkkvwNuNNu9PnMAUV3AmI3LkRpHCuMC9tIl3rprn+HHcXxjcsUMY2cFvn?= =?us-ascii?Q?F0eAGLctU1LTEXN8ACVi4XSRgDq5f7pXMoOL8r1zYwmJbhhABAf0qF89A8Ns?= =?us-ascii?Q?qrPrM2rHG54FVEQ7T1oYB7kBghnbKAks6FkSgFecLNrFOYE194GK72js18Me?= =?us-ascii?Q?TAiUV7ugJnpk1M9bbTxA4ZQoNLA1PeoPNnDEN/JGR7vyDAKPNbbWtEbXfzfM?= =?us-ascii?Q?CFkbWcQPAjsPUNNxJR27DwFdKGxr6eOmJhztGeqpI9SPLMbsovjwjTx42srS?= =?us-ascii?Q?/sV9WL77n2WyPZ5hI0zWlYUZZ4mr9m7iYAir5C5Z9x9APgm6zer27ONratsN?= =?us-ascii?Q?zOwV077tEOWgsux8HzXliofwowmS/MxSacS5tVw2eNv34X7GvNX8weGgjd4f?= =?us-ascii?Q?LS+zabrPscqsm/gsBxFHhmXq7+M3NmLm5B4l6vYIQpjYLNyuyXsbaTOsvqSJ?= =?us-ascii?Q?QcgesjwXLSX3rCJXkhv1SOsFUkNbpSFQpfhQND8NyJfj4QoYaUMkZUcdS6Bf?= =?us-ascii?Q?GWMQaTl6G9IaQkMp8yiwAqmvOFWAsLVwBYqFmxsCWt3spnvj7L6FLIpKWgtz?= =?us-ascii?Q?tY8XzMlsOKb61D5CDUs2dFEJIMl0AuwCDagkfrrI6JGVtF30yDzA6UuWHL2e?= =?us-ascii?Q?m0/nEXp5mmLuyWW1hFbF+P0IUzRsQN/uvJehJ3IBlip+xSKsZbkenOQzfHrE?= =?us-ascii?Q?AbTFimL9GI4rfDlTsUjHG0HhCQbeKjzByGWY8ijTkkiCbFw6pSNHhC1xT1kw?= =?us-ascii?Q?pvM94nCp2ha8O+To7Fu2hTb8rMUVWnB0UuRdqI/85voiPxjhPlcxGLtjJVyC?= =?us-ascii?Q?pLstsfsN+XqHsqTwe3XWQK3d4FlUQ/RRjnc9uRLKCTkQQs9bRzu1VT/sOHb/?= =?us-ascii?Q?SPmmWrxXzgdb11GVFHhFlD7c0FUQztmoX3dmsqpivxjm8e+uoZ/HG28wDtpA?= =?us-ascii?Q?YyRtKqNZ8x+lZedBHnFAdRTsPT0UegplzlX74hr4s82WqeJulXsqg/0hSkOq?= =?us-ascii?Q?N4jj/p7GDRkoJnsPXaqnKbXYr0lr10w7O6Dd9VQb2HP9S+c+3mbrChxFlfL+?= =?us-ascii?Q?mXCSabswbx7xzO/ihxAwlDuQ2GKQkDrRe0dLbehxutD+NzAn4DrdbLop9IQ3?= =?us-ascii?Q?9WnkwfR7YyHXNVk1st8686X5nUIX21aUx8G9EropRMLLhasnZMCTCWEb1C6B?= =?us-ascii?Q?4mYkvIC/ncarDleEcybL2ruHJgPYtPf/rZ0TeYqKmIcHJCUd+TcE7T5q25DH?= =?us-ascii?Q?ayoCcj6U83CT/zT50hlWr/roOY8QZgyKGyHl9jjCxbm7Z6+umhSxsA7URzH0?= =?us-ascii?Q?4p8d3Xt4lvp0F+ZdCk+/g5t4ix9Jdj0opei/4NzgREUAgVSAADKRk+BF+Irf?= =?us-ascii?Q?gvY/5VOF80ApS9EWCdP9Nx2gBxwnbunzOWTXVpFw1a7wCaKSAfhFNQTgFo/G?= =?us-ascii?Q?xVHV3gAkQ1pkC9/BA7Xf+4EHUPQGBBZ+/XYyesZv?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bd553c46-f6a3-4ad9-1b9f-08dabaeb7bb3 X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Oct 2022 02:56:18.1138 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: eU0f4dwzCK6+WTxr5ME5yWwUlRcXp/ThNpElDzM1EPWKFbLB+pgIyrGeHlKjkuUFe1K/+Xg5ABoJ4CED2Gidyw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4108 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Thanks for catching this!. V3 patch sent. Abner > -----Original Message----- > From: Ni, Ray > Sent: Monday, October 31, 2022 9:59 AM > To: devel@edk2.groups.io; Chang, Abner > Cc: Attar, AbdulLateef (Abdul Lateef) ; > Kirkendall, Garrett ; Grimes, Paul > ; Dong, Eric ; Kumar, Rahul > R > Subject: RE: [edk2-devel] [PATCH V2 1/3] UefiCpuPkg/SmmCpuFeaturesLib: > Rename the common C file >=20 > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. >=20 >=20 > This patch will cause build failure because the INF file is not updated a= fter > rename. >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Chang, > > Abner via groups.io > > Sent: Sunday, October 30, 2022 9:02 PM > > To: devel@edk2.groups.io > > Cc: Abdul Lateef Attar ; Garrett Kirkendall > > ; Paul Grimes ; > Dong, > > Eric ; Ni, Ray ; Kumar, Rahul R > > > > Subject: [edk2-devel] [PATCH V2 1/3] UefiCpuPkg/SmmCpuFeaturesLib: > > Rename the common C file > > > > From: Abner Chang > > > > BZ# 4093: Abstract SmmCpuFeaturesLib for sharing common code > > > > Rename SmmCpuFeaturesLiCommon.c to > > IntelSmmCpuFeaturesLib, because it was developed specifically for > > Intel implementation. The code that can be shared by other archs or > > vendors will be stripped away and put in the common file in the next > > patch. > > > > Signed-off-by: Abner Chang > > Cc: Abdul Lateef Attar > > Cc: Garrett Kirkendall > > Cc: Paul Grimes > > Cc: Eric Dong > > Cc: Ray Ni > > Cc: Rahul Kumar > > --- > > .../{SmmCpuFeaturesLibCommon.c =3D> IntelSmmCpuFeaturesLib.c} | = 0 > > 1 file changed, 0 insertions(+), 0 deletions(-) rename > > UefiCpuPkg/Library/SmmCpuFeaturesLib/{SmmCpuFeaturesLibCommon.c > =3D> > > IntelSmmCpuFeaturesLib.c} (100%) > > > > diff --git > > > a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLibCommon.c > > b/UefiCpuPkg/Library/SmmCpuFeaturesLib/IntelSmmCpuFeaturesLib.c > > similarity index 100% > > rename from > > UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLibCommon.c > > rename to > > UefiCpuPkg/Library/SmmCpuFeaturesLib/IntelSmmCpuFeaturesLib.c > > -- > > 2.37.1.windows.1 > > > > > > > >=20 > >