Re: [PATCH v2 0/3] Add IPMI SSIF definitions

["Chang, Abner" <abner.chang@amd.com>]

[AMD Official Use Only - General]

Hi Tinh,
Thanks for this effort. I have no problem with this patch set but you still have to get R-B from maintainers. Two feedbacks here,
- Please put BZ # in commit message in the patch 1/3-3/3.
   Ex: BZ#: 4434 - Add IPMI SSIF definitions
- As the feedback I gave to patch 1/3. I think we better have maintainers Cc in the commit message.

Thanks
Abner

> -----Original Message-----
> From: Tinh Nguyen <tinhnguyen@os.amperecomputing.com>
> Sent: Wednesday, May 3, 2023 1:40 AM
> To: devel@edk2.groups.io
> Cc: patches@amperecomputing.com; michael.d.kinney@intel.com;
> gaoliming@byosoft.com.cn; zhiguang.liu@intel.com; Chang, Abner
> <Abner.Chang@amd.com>; Tinh Nguyen
> <tinhnguyen@os.amperecomputing.com>
> Subject: [PATCH v2 0/3] Add IPMI SSIF definitions
> 
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
> 
> 
> Change from v1:
>   - Separate the commit for the IPMI SSIF header and IPMI SSIF PCDs
>   - Correct some indent and comment style.
>   - Change the PCDs name for a more readable.
>   - Support KCS/SMIC Interface Capabilities too.
> 
> Tinh Nguyen (3):
>   MdePkg/IndustryStandard: Add definitions for IPMI SSIF
>   MdePkg: Add new PCDs for IPMI SSIF
>   MdePkg/IndustryStandard: Add Interface Capabilities definitions
> 
>  MdePkg/MdePkg.dec                              | 26 ++++++
>  MdePkg/Include/IndustryStandard/IpmiNetFnApp.h | 46 +++++++++
>  MdePkg/Include/IndustryStandard/IpmiSsif.h     | 98
> ++++++++++++++++++++
>  3 files changed, 170 insertions(+)
>  create mode 100644 MdePkg/Include/IndustryStandard/IpmiSsif.h
> 
> --
> 2.40.0