From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.48]) by mx.groups.io with SMTP id smtpd.web10.8865.1683077190115635309 for ; Tue, 02 May 2023 18:26:30 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=Hh2h3z9M; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.92.48, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ogo4wUwB4GzrA7/1fRfNJONfXtyEiGrkrysVRhV+yNaGbMA7G1V9hHQmqnHXzwkPl5bVY91FCxMh/vvZbA2CrvnbSG9FiQ+Ax3TbyIwhElAAmVs2TOpaP4PVkqPd1picLNkdJ3g/nFfPCATK2uOMAUYf4HkO95Ay+9pSEnc4oJRp+fxZpY1vxZ2a/dVhgBPCLNQmRseWkBrK37BmudEJgzJsx4HnlPVzNNFfAPaNViZ5+jg6sFSXKWLqQwpiEO0fjIdsC4H49FsdCYnYqNQgqqd+9o5qdr3w4yXj7gvNgyp0KtQbILiIFbku1jECgj9UKpyUd7Plb7GL3dEZocqFsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=M2A4p2sLTgHSDmnvj6XwBfKMBsTCMUZ9Pjh/rnj+e+Q=; b=Plnh/VbEt6tzvLfGbHsQAs8vzMewVxmdJkVSwmKob0ubdFJzAprcKnw5Amr93RRYKEXDJ9YJ3/9VHZJ1AK3AXCXOt2kz6J+MmGiQxXsTS5RZcZp52/J4QKHVb2F/hf03JoU/AUCd6bGQgw6vCzeyESXp5V/6ySLY5fcKqESk9weVOq97S4EheiDw/evk3fq1imNZ06PljOI06mLkq33a/pWRsEWdNr/ztMLh94urGm5kXpW5buvwsw2Ui3nkn0CVjuQP9pET15hCLwSpMDECD7ad29ASsV2xbjlXukpMTgk259xK76xCj3Ta++VcOzjt8686mnbVLzGCQamoyOAQmg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M2A4p2sLTgHSDmnvj6XwBfKMBsTCMUZ9Pjh/rnj+e+Q=; b=Hh2h3z9M5Advd5Lj5tDWL7YUs9lX9/AYdZhPaUJVSFPlk/SG87kaAo0GEmMSeKJuLrphSKqujxo/3qK/+myR49I0l7I4bf2XfdTE34NWS5bm8WhKV00Fxed9r8RVLwH3LJm3NxF8Kbw6eq98T1CuuAz64FdJJTYUyK9ZGr/4V0w= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by DS0PR12MB9040.namprd12.prod.outlook.com (2603:10b6:8:f5::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Wed, 3 May 2023 01:26:26 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::46f1:bdce:a4bc:29e3]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::46f1:bdce:a4bc:29e3%3]) with mapi id 15.20.6340.031; Wed, 3 May 2023 01:26:26 +0000 From: "Chang, Abner" To: Tinh Nguyen , "devel@edk2.groups.io" CC: "patches@amperecomputing.com" , "michael.d.kinney@intel.com" , "gaoliming@byosoft.com.cn" , "zhiguang.liu@intel.com" Subject: Re: [PATCH v2 0/3] Add IPMI SSIF definitions Thread-Topic: [PATCH v2 0/3] Add IPMI SSIF definitions Thread-Index: AQHZfR0+cxxLRX+6SUyl7+aJ/szIOK9Hvqdw Date: Wed, 3 May 2023 01:26:25 +0000 Message-ID: References: <20230502173945.2016719-1-tinhnguyen@os.amperecomputing.com> In-Reply-To: <20230502173945.2016719-1-tinhnguyen@os.amperecomputing.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-05-03T01:26:24Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=87f1bc63-c0d8-4cda-9f8f-e0f06ad8a04d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|DS0PR12MB9040:EE_ x-ms-office365-filtering-correlation-id: 23691bc8-fd33-4f3b-075d-08db4b7569ad x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ioHWh/LayEAIlS9PjP3d5UVN9YOH7RKHajzZ2G8jeAp976e+YNO3z/UmNGPD3QfgCRIpRXg4a5++02XbROyDkHdd0h1YJege4H3EWXwDullBaQ+c7nQCD3KyqxpIq5zBG+UvmXB861JZQtUiapczCcQPUKlhUnJrX03LbpOmniNrnYXOwdh+IrBUFDrrqMHD9CyW2/I4BqpKNH3J9yVap7DY25dM4gYuo6LUMDCYcPwJgMpWbV/W0OyK/SOo8WZ28eq2oGJPpKzq8bGQrpWagVDbY6PIYzfpgfNKeZLIIh4BKua5dDB+YJ/cqsvnGzZQkZpmWlOCE0967s+Z2yx9gt14jIqhWQxrUReE69edM6NmSlZuTHtdqUdbm6zyZ2IlRA+w/2iTxkTTNZyI3FyTJKqPUjrLj4WOFnfslocGhU1zyzVwwsW0eN/b3dUAuN2InvNfD53kkC76opwcOxqgbjiusGZf5nwYhabzFBUALbtawS4ZVHnMNjjtfJsx0aesYmBBd0l55kcy9N9IynikEqvaRRxYianXDqcryHfhnODuFxPOtjrpmaW7bC191uFneHcoHALfmXUsCb4xtzyg/3jetIN32k6zK02QF98lOi+M/YeAwE54YPGD1/9plK0U x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(136003)(376002)(366004)(396003)(39860400002)(451199021)(4326008)(76116006)(64756008)(66556008)(66476007)(66446008)(66946007)(6506007)(2906002)(8676002)(8936002)(5660300002)(52536014)(478600001)(7696005)(71200400001)(316002)(41300700001)(33656002)(54906003)(110136005)(55016003)(86362001)(38070700005)(26005)(53546011)(38100700002)(9686003)(186003)(122000001)(83380400001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?5jIvZuVqmlt1V729ZJX4MhpAhU28DTHB3yfRUqZLuPHjz+DX5taYGSPvDgAn?= =?us-ascii?Q?XmMuqgnrLBpKjg8XvV99NwRaj3Lex+jsryO9QdcjCSpdhwP/Zyme2f0gWRwn?= =?us-ascii?Q?UNrAXHLcKxnSRYEa5WXC5s0IYceOCVd41/iDJ8e+crfpY7XPSE0DHruUZrMX?= =?us-ascii?Q?YmFDa+z6b6iOQsDxtG/tpSlDna+1IkzGcEC6gCy2m2mEjha/eFLis3scq2g9?= =?us-ascii?Q?gc14PaI70P41EK/DbNLO8FONPuKzh6TMPYJz4kQApKq8wCgGfOfC6rqShIvp?= =?us-ascii?Q?pGe8+40CT4bfP4VcgpeC2jHR7jUF6vi2PBe9ukUNiahfto6qd1Uqzm5e0qTI?= =?us-ascii?Q?jX2a2dBw69updlhkYRVF4pPPRmQCEIPO7Y9NMto9aWASkofwQBNAGAw8Tdcg?= =?us-ascii?Q?xtVC/f/d5o3s45ZPazEOP6EATzU8QOBdn0YvY9kQUr/I+rBuF9kgf3HnPXrB?= =?us-ascii?Q?KpsBkFHilEiXa8MkRbpAaDFQBzXFstKqk9TXoljnfwsGc3fi5toHYFSw1i0D?= =?us-ascii?Q?BrDvuUF0ivtZhKlUlMrfJ80iIurtqZ1QtvE0RjoYFBTgWFybUQP17g2q1VFx?= =?us-ascii?Q?F6oHm3MPdGZLp0NVk3DeFkXVc3i2smgYFhhl/mEoTm1FL8Hn9LxuQIhVmucB?= =?us-ascii?Q?66hKjU67dCEQ/Z3Y5ib0iGxs9/nU+Eo090WC2hZon+xHTuoJFBfwKSIcUMly?= =?us-ascii?Q?PGOEtkLMhKUr7FSk9NzyQXKrOdCvsOMDxUOMMatBPOQDv1Ko9gHurGXbYE9y?= =?us-ascii?Q?kgXDj7La3QOM2DaWz5ERGGrNPYlSUW58vGRqQdyRu7b2k2ycOMczRJdV1Xlu?= =?us-ascii?Q?X0dYBwyby1OPRX/7HcXIdzhWTZ0/980rWu5pji9lyppDQTBkIBsznXRYpKGM?= =?us-ascii?Q?5jFMVHxOi+ROJdqoF4CBDwhrMqduk/0OUz6tmlxAQGm2uHN1oA5bJ22YYhNE?= =?us-ascii?Q?40NS1IQs369Vgx9Q9jEev5hVigfOohV9Gtf9GXdZYklMh/YC9P0scWvNddjX?= =?us-ascii?Q?et9JkJE1sUjj1JapqalStcPgv5CiWT+2Z2vNcfiVzdGmvgMxY/qjh2vtHcL7?= =?us-ascii?Q?jCPsLVsoDL4T0wcA7wtovcII7/w46ghnfnQacBEWFracQJVW4FivvTG45Ist?= =?us-ascii?Q?BnGOqeUx5riao2NpjN0vNiSzU3pjJU5PlWEfrlbCLZxGN2CNRWLtPraYXedd?= =?us-ascii?Q?Z+paqro9B1YzEVB4S0SRLjlEZ4gy/e4ZBGEJXxiYgCMrLEm+zlrzpzoBvg3W?= =?us-ascii?Q?Vp4QPAoBcjns+/GNPhS6bctqqvLLZPc6EoYhRC6ZOo5HkmUGoFDFVWRo7ySW?= =?us-ascii?Q?FuVGnLKD4MBRMO/VCcf10MuaeemfXTty6tWKST7gMS1p1Dg8j7lWoKPez7qJ?= =?us-ascii?Q?OHNcP+QHY6oYPvTpW3f0i/z41+2oGk1rueYM7KxchGb1/o/FjICpXlNsDg69?= =?us-ascii?Q?1P+PtbK3kowTxTBOGGQRuqbBI/LD3W/rHllNN1GztYpzITnXrBaHKko+ZHTa?= =?us-ascii?Q?ZqmFgSlGMCZc5Zh3Fvv9XOeM+NO9XsPPwYZrpmkQe6U4WR1RwDr9X6ZTp8wW?= =?us-ascii?Q?m/b0B0DMBs1cr8kdQdEDvA3zcfrM68W8czPUs36A?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 23691bc8-fd33-4f3b-075d-08db4b7569ad X-MS-Exchange-CrossTenant-originalarrivaltime: 03 May 2023 01:26:25.9190 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 79Q8Vt9S6203RHOIYPfWqEjR84O3rSMJF1XBapdefGaM1mbCO9W967qZJJktQdCWkxmE2ItC9z648k0+Yv7y4Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB9040 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Hi Tinh, Thanks for this effort. I have no problem with this patch set but you still= have to get R-B from maintainers. Two feedbacks here, - Please put BZ # in commit message in the patch 1/3-3/3. Ex: BZ#: 4434 - Add IPMI SSIF definitions - As the feedback I gave to patch 1/3. I think we better have maintainers C= c in the commit message. Thanks Abner > -----Original Message----- > From: Tinh Nguyen > Sent: Wednesday, May 3, 2023 1:40 AM > To: devel@edk2.groups.io > Cc: patches@amperecomputing.com; michael.d.kinney@intel.com; > gaoliming@byosoft.com.cn; zhiguang.liu@intel.com; Chang, Abner > ; Tinh Nguyen > > Subject: [PATCH v2 0/3] Add IPMI SSIF definitions >=20 > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. >=20 >=20 > Change from v1: > - Separate the commit for the IPMI SSIF header and IPMI SSIF PCDs > - Correct some indent and comment style. > - Change the PCDs name for a more readable. > - Support KCS/SMIC Interface Capabilities too. >=20 > Tinh Nguyen (3): > MdePkg/IndustryStandard: Add definitions for IPMI SSIF > MdePkg: Add new PCDs for IPMI SSIF > MdePkg/IndustryStandard: Add Interface Capabilities definitions >=20 > MdePkg/MdePkg.dec | 26 ++++++ > MdePkg/Include/IndustryStandard/IpmiNetFnApp.h | 46 +++++++++ > MdePkg/Include/IndustryStandard/IpmiSsif.h | 98 > ++++++++++++++++++++ > 3 files changed, 170 insertions(+) > create mode 100644 MdePkg/Include/IndustryStandard/IpmiSsif.h >=20 > -- > 2.40.0