From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (NAM04-BN8-obe.outbound.protection.outlook.com [40.107.100.77]) by mx.groups.io with SMTP id smtpd.web08.990.1668329095107505201 for ; Sun, 13 Nov 2022 00:44:55 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=YWIlZVmG; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.100.77, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Uur/9JEUNgibrNcTenZOaYMRvJBj/lGnkeE600BApZMqoU/VyEJM5Y9vodK2CNFEWzrEMivJDj9IMyivmYt1f4vXyTOVU9au7uH7H7CoOQ+FN98qrlEamLFsbE/clXTUTh/fHRYwBzeMY2f7zGdx2yjInFgjrcSSDYgV2F1vkiIPlx+IgSz561Wz1GYiRRkLmQPuBVKhRFdJO933om+GPXMCFs89les2ICsFpcMuLq7xrbSgyQAfeNkHNbfnH2rOgaPvpSqM5uLu581MJFZUjJpFKf8RrbrSearCKRw/DKeyn7+UbxYSGJFEISgFO3F2fjqB5+UR+VndqPBVIQeZIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+gbWtuI2QMPgvQQkv4crpMoj8hQxZYaSTEmPnKOkS2Y=; b=Dvl9ZaKuK5K4gSQoaI/mZToN2bPUcJ8X8hOoYd0TYAMa/wybxODEDCVhiAaBiCjVulqkKGFuJ+/uZPFP+mAhpuq8PhBZyB3ZowyNGuYzFG/nkdCP6EYZiIJ5nNyWq+espPhwFPxdksmkOlan2zdjYZDRvouwq7EI8eQWdFy5XYUjut2cNV4Y9mraWUWx7GqMc68SpnGsZgF5mPSCpeX2pG66bSxblPVnFAqBliiov7gdC3j/k8tqqdrBl7mczWnRgsgIiju9aL6nUe+0xxVwzKSyKBfRx+HoJXQ44RBOasrzNzoBk664lMEQbqdTnviY0M6Bn+Z0DLrsVmXhj4/W7Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+gbWtuI2QMPgvQQkv4crpMoj8hQxZYaSTEmPnKOkS2Y=; b=YWIlZVmG30PAx3YKYsL2BivFZ8Ke7HXgdhu0yGVLcHFyVA2Sd3KISx7/romoKzUlNJvYhjiYFw5d+gF4mNxJX+Xx9eUZpdMVI2SmHoxd5JbibyFLD/lGxouM7fQDhKbimeO3/cWoZOU1Njmkm/wVNHAhzUQANAfBx6eSjZP1bd4= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by SN7PR12MB6958.namprd12.prod.outlook.com (2603:10b6:806:262::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.16; Sun, 13 Nov 2022 08:44:50 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::ce0a:283e:839:34bd]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::ce0a:283e:839:34bd%3]) with mapi id 15.20.5813.016; Sun, 13 Nov 2022 08:44:50 +0000 From: "Chang, Abner" To: "Kinney, Michael D" , "devel@edk2.groups.io" , Laszlo Ersek , "Kubacki, Michael" Subject: Re: [edk2-devel] [edk2-CCodingStandardsSpecification PATCH 2/2] Source Files / Spacing / Multi-line func. calls: allow condensed arguments Thread-Topic: [edk2-devel] [edk2-CCodingStandardsSpecification PATCH 2/2] Source Files / Spacing / Multi-line func. calls: allow condensed arguments Thread-Index: AQHY9wA8eJ5V+X7WCU6R4R6Zrs8Iy648GJaAgABv7YA= Date: Sun, 13 Nov 2022 08:44:50 +0000 Message-ID: References: <922996c2-e60a-80ec-6d4a-8b2e5a639c9b@redhat.com> <25893.1668303336748921539@groups.io> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2022-11-13T08:44:46Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=5ebc2ce8-1468-460f-80cb-fb210110eeff; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|SN7PR12MB6958:EE_ x-ms-office365-filtering-correlation-id: 4e3ae27b-8542-4d19-8212-08dac55353b1 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 2OouA2nY7FmvkFHuCMGks2YexIZX/54VlQwIcWz9b5KzOAw1HU4b8t3Y+eNEG0IHFP3OK46kWsZ3hciAuEG/fnS+Ymlo5/AzW2G7H1mTe83j6gSRKjcjPBTuF742etg3kLDIk3LvURv01mNgBy0lmVktY33SanAiLGebarF0iKmTJuB6b73Ujq/1UyJmsrMpIohKas0jc87hN68Qr5KsMplWDcfVau797SV2DzWpXYx4dj2GhR+oc+LA2zUhwCyxkEhdWA3yFhaiV2vbnzO8By6l4An0O8S/RnfDxLCTrUDob6OummmcjFrB/OSN01pyhwD+n3Wmu96GaCuPFh9VCx8sMEmQW+o7TCFvchtyltCIp8WBT/GOrjOFPJwmLqt0tqbRqmy9DhdJBB8axKKgf29TjMTF/CCIydrLjh6MGVCeWoAfHE4aphwdcfwlz1F3UoUvFjpPnV4IP+TCXD1ucU1QVWOagf5vJEx9/osFIAEVCcr8tmFc+DSpELXxQdvakQmWaTuzkSTAsvab0EoZX5lxAl5QilFV12l74X4xsi2j+7CU8Hg4tpozaWyZ2SBaeRQWLFzb8sOb527FZBnFbcQ/d3AdDlT41SIWzcJkOIfCUXTflzqqNQ7bA0oqDtpTnvbvDsD5ipRD8Asx2Iv7G+KmnorJeJV6jMI8YxV6MQN7ot8kK7dCSTryHrDXW9mKdhAaUfHTbc3K2mSQUymPDxssCGfHKUNo9UYKn4sdcE9NXuAAubmzvYq+Cwno6WVCJJsmEpu6/Aa2Gx0DqCIooi9ftqAHn36S1Do+Suu68vw= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(346002)(366004)(396003)(39860400002)(451199015)(33656002)(66899015)(38100700002)(122000001)(38070700005)(41300700001)(2906002)(166002)(83380400001)(316002)(64756008)(86362001)(66946007)(76116006)(186003)(8676002)(110136005)(478600001)(6506007)(76236004)(8936002)(5660300002)(52536014)(53546011)(26005)(71200400001)(7696005)(66446008)(9686003)(66556008)(66476007)(55016003);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?RtSISRo96QiYVGfWFkb0mYDTS+5IV+LglIRtLw7tUD7l8VU07VS7sWvmBetY?= =?us-ascii?Q?dlL/UznsEwx5/M9YrXqMp1uDsRYkA0ikafwCPBRdh0jWnNpcbz4f4kiKtR5w?= =?us-ascii?Q?j2Qe4MKFDL4ZMQ+8jYoHl2sW3xNb0f6AL8HpECgHwF7lNsUGAPGr77t1/OMW?= =?us-ascii?Q?cIYPe3FFirimHUloVYMpOQ1JN52I8DXgIJyIlOFUjzrLSdQAWY5wpI0GYfMn?= =?us-ascii?Q?/R7MdcH96CwujlNNDuNHDgSp12d6s8Fi3VCzbQPqFFhv6xzs1SMveynp6md+?= =?us-ascii?Q?5KziouM3l5Jw/qUvAPKN9TSvsnxg6DA4+GRaYtm0Klg+3LhGP2Py3RRQLrB2?= =?us-ascii?Q?rrGQ6WBSunRz0GYNIog2rp34lOALWcBXdmdjP7Stq2wcmp9lgE12bCazkbaD?= =?us-ascii?Q?uuOkfrtX3UZM2mR/47l+FD7JPH0lDnyX0No/0smJ5gAsHP+3h+pWB2kIHXnC?= =?us-ascii?Q?JuKZ89KVUrOsO1fviT6BK2kbvWzp29CdXR0Msd8vz+S3vVe8nAixVERqXnlH?= =?us-ascii?Q?ZTmZxGqLgxcUH9FC0OaaidKzdV5fveV5WSs3fa2WEZwEyugsMcgVhm7844X+?= =?us-ascii?Q?oFf5TY5YtLekdKx5i84KQFJV0w7uaBbaXMXcLp3m8PYWZgejqvPUWbCHw3g3?= =?us-ascii?Q?p8T+VMGyoKsF8d/XH6mWRdNhW4ceW45CSyD585QO0D1zxg6360NTBGZYGM3x?= =?us-ascii?Q?jdXqIs9Ogwh8k1g58pjSioy6nVRVS/lnr2KmlErd0wB9Rw+NIZbmtFChZpUK?= =?us-ascii?Q?Xvr8cw1JJAAwzIY9TeOk2Nrf+G0qzuEDvQNjFyBb/ZxMi4clR+qivxyNdoUo?= =?us-ascii?Q?G/GjDcHaFKj3ZXhHtcQc2WueaxCYxGmQkpuDJPaUw+YV5ujgMXKLgiudUdwt?= =?us-ascii?Q?U2UopDs0vrwjHRkTwjVvRCzMx3xi6391iJ93+nNMwpgN1bBqH4u3vzoWn6+Q?= =?us-ascii?Q?eJMl9kE8wznXr87PjZ5Dj043aRZGXcVotYgTfxbm8HsvnHW8CnQSGrChGINu?= =?us-ascii?Q?zxz27veCGE5vJEV7dkHlg/ZOPKc/m5hhILcXUkcyAwSgKSGCzLcTA8UzsS2r?= =?us-ascii?Q?SkTlKHL+9VFIuaj+wH+g18h2E8BOO4J4oQca+wmo0btgJ899D+0srfLWs0AS?= =?us-ascii?Q?XG5psCtIH3Xb2oTkzchsMX/k3l4V5K/ThpuQxm3b1E94FYCPnpg6B4QN6JcN?= =?us-ascii?Q?Dn5WPNhF4MeY1ZEXZPOiuP5YdBLY3S3tLmGYq4nrxEQrEzco5VVRwN8n40BK?= =?us-ascii?Q?SB0B8nlkYG2lIFCUoBqVqEfiyHnqXa673SD/Q/6QoXa9rO42SWM9s5hi2Per?= =?us-ascii?Q?NnXvJhS92W2MK5zbB0fp+DV2kMmT2IUlhlzrTU7SbkhNH4LlUcPjhEzWK97+?= =?us-ascii?Q?B9lg1ECPkdhkzRVOxt/YcInomFHGr6C3ugUiLpyVGmdGTon2xdXpU6ADC7qK?= =?us-ascii?Q?8jb8dhC0ldduUw74JPMDJLCGheyOZ648jdvukmD929l5O0yzcQZNtBPD4nWp?= =?us-ascii?Q?2uxtb2xiMbNzmgGI9cOZ+9Xk4Qc0TDWvmDL0k+qch7FhCq5DDD16OX3KyC8F?= =?us-ascii?Q?KMjOg1ac4BSHK3OAK3U=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4e3ae27b-8542-4d19-8212-08dac55353b1 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Nov 2022 08:44:50.3289 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: sJ8WR/oDcOh2wGWjtKn2mR9QNcdcCDazVOGZ2d63WPpTpHzC0YDfhdxvTz6+tb+1Lfw1scEAdCURzD747mXIOg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6958 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MN2PR12MB3966D4F92D6DFDFA629FF576EA029MN2PR12MB3966namp_" --_000_MN2PR12MB3966D4F92D6DFDFA629FF576EA029MN2PR12MB3966namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Uncrustify can fix the first argument that is not at the indent with two sp= ace. It also can fix the first argument that is not at the new line. But it also makes each argument a new line if multiple args are condensed i= n one line. That is what we have to update Uncrustify if we have this patch= merged to CCS. +Michael Kubacki in loop. Abner From: Kinney, Michael D Sent: Sunday, November 13, 2022 9:58 AM To: devel@edk2.groups.io; Chang, Abner ; Laszlo Ersek = ; Kinney, Michael D Subject: RE: [edk2-devel] [edk2-CCodingStandardsSpecification PATCH 2/2] So= urce Files / Spacing / Multi-line func. calls: allow condensed arguments Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding. Is this exactly what Uncrustify does now? Mike From: devel@edk2.groups.io > On Behalf Of Chang, Abner via groups.io Sent: Saturday, November 12, 2022 5:36 PM To: Laszlo Ersek >; devel@edk2.= groups.io Subject: Re: [edk2-devel] [edk2-CCodingStandardsSpecification PATCH 2/2] So= urce Files / Spacing / Multi-line func. calls: allow condensed arguments Hi all, As we are going to release CCS 2.3, we would like to address some pending i= ssues of CCS. For this, I think we can, - Still keep the one line per argument style in CCS although the multi-argu= ments in the one line style can cover this. This avoids confusion from read= ers and questions about if they can do the one-line per argument style. - If the arguments are in different lines, the first argument must be inden= ted with two spaces from the start of the function name or the member funct= ion name. How is this? Abner --_000_MN2PR12MB3966D4F92D6DFDFA629FF576EA029MN2PR12MB3966namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

[AMD Officia= l Use Only - General]

 

Uncrustify can fix the first argument that is not at= the indent with two space. It also can fix the first argument that is not = at the new line.

But it also makes each argument a new line if multip= le args are condensed in one line. That is what we have to update Uncrustif= y if we have this patch merged to CCS.

 

+Michael Kubacki in loop.

 

Abner

 

From: Kinney, Michael D <michael.d.kinney@= intel.com>
Sent: Sunday, November 13, 2022 9:58 AM
To: devel@edk2.groups.io; Chang, Abner <Abner.Chang@amd.com>; = Laszlo Ersek <lersek@redhat.com>; Kinney, Michael D <michael.d.kin= ney@intel.com>
Subject: RE: [edk2-devel] [edk2-CCodingStandardsSpecification PATCH = 2/2] Source Files / Spacing / Multi-line func. calls: allow condensed argum= ents

 

Caution: This message originated from an External Source. Use proper caution= when opening attachments, clicking links, or responding.

 

Is this exactly what Uncrustify does now?=

 

Mike

 

From: devel@edk2.groups.io <devel= @edk2.groups.io> On Behalf Of Chang, Abner via groups.io
Sent: Saturday, November 12, 2022 5:36 PM
To: Laszlo Ersek <lersek@red= hat.com>; devel@edk2.groups.io
Subject: Re: [edk2-devel] [edk2-CCodingStandardsSpecification PATCH = 2/2] Source Files / Spacing / Multi-line func. calls: allow condensed argum= ents

 

Hi all,
As we are going to release CCS 2.3, we would like to address some pending i= ssues of CCS. For this, I think we can,
- Still keep the one line per argument style in CCS although the multi-argu= ments in the one line style can cover this. This avoids confusion from read= ers and questions about if they can do the one-line per argument style.
- If the arguments are in different lines, the first argument must be inden= ted with two spaces from the start of the function name or the member funct= ion name.
How is this?

Abner

--_000_MN2PR12MB3966D4F92D6DFDFA629FF576EA029MN2PR12MB3966namp_--