From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (NAM10-MW2-obe.outbound.protection.outlook.com [40.107.94.84]) by mx.groups.io with SMTP id smtpd.web10.15279.1684823738946384824 for ; Mon, 22 May 2023 23:35:39 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=TQCc+8I5; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.94.84, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hJyKt+fyGife8ipcYO4XBIiuups2IZ5Xg7QxFRCPaCbsCBbwTSpt+aBRTcdMsB1+r5l60jrVLukss5i9WHWLI3Gy363DTHEXMuYrflqADHhTfX9vuqtuzrtBt+9X2aOquuqvydVxnTml2Zuf420FMAo5bKsLF5MOKVb/4k3kWv2bW+Ig2GhZWjzK4RunQtyWUvpXd1lBBqI0eKYmBdW96uW0lS44bSxt6/nqlAPm45JqnrcBEULbQ+4xQe7il4Y8p6/2yMTvrGo1Mhvr7pbiq0/8Ksw4wlrh9SOK/IJdAV+cPusbDDqvzUWj6SPvpuOumG9LaCWfIgAe6aZiJq5HEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OEIEtnna91Z5dgngcnykMrkOjebDJsEO6kunIFC2GeM=; b=cZYVJWc7yVqFHA7sED1Pq5+vLTQL/5MzuYqtDw83lkl9zfZuXlGI6VxOR9H3ta1PL+gOSpIAtOLfsnY80j/zM64FvsdgyfWKDkV/zBFUhmBe1ULHA7DZNEPhH6QJbpnbtFTYsFBHj7ZJgzmSG5I/KVtmbXW7ERLYCVv5kE0zkcaglq72HgsKZdkOm44UJZ7rEeDn6tjmfJlX770AtNcBkx+Sw8QCI116epDfUWx7Igi+8ac0hP7L6n2wVRyfjUnQyBVo+cFFQhwGsP3bFwbENz4+hJYHbj1DoCtifVsA4KjjTpK+ctvt3Ad7YF8IwLACsL42X9t2esDbwPAon8FVkA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OEIEtnna91Z5dgngcnykMrkOjebDJsEO6kunIFC2GeM=; b=TQCc+8I5Y2PQwCWd54fyq4ODN4DcpphpjohhVMaYEPaqBK6V9PGsqi27ig+Bm7po60T1x6zqazPuIDU9/S7L00f/oKNdgqGeCAODo3y90pow5G/hfuDtQ7yS4iHQ5eutkxmTvXtzfJY9G6qKxGxnblIgN6+K93X3vIRpHom21gA= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by PH7PR12MB7916.namprd12.prod.outlook.com (2603:10b6:510:26a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.28; Tue, 23 May 2023 06:35:36 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::edb0:bed8:c650:5040]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::edb0:bed8:c650:5040%6]) with mapi id 15.20.6411.028; Tue, 23 May 2023 06:35:35 +0000 From: "Chang, Abner" To: "Ni, Ray" , "Attar, AbdulLateef (Abdul Lateef)" , "devel@edk2.groups.io" CC: "Attar, AbdulLateef (Abdul Lateef)" , "Grimes, Paul" , "Dong, Eric" , "Kumar, Rahul R" , Gerd Hoffmann , "Kinney, Michael D" , "Gao, Liming" , "Liu, Zhiguang" , Ard Biesheuvel , "Yao, Jiewen" , "Justen, Jordan L" Subject: Re: [PATCH v13 0/8] Adds AmdSmmCpuFeaturesLib and MmSaveStateLib Thread-Topic: [PATCH v13 0/8] Adds AmdSmmCpuFeaturesLib and MmSaveStateLib Thread-Index: AQHZhM3TjIZwTFXAgku0S65Be5MRHK9ndS4AgAABRgCAAABnsA== Date: Tue, 23 May 2023 06:35:35 +0000 Message-ID: References: In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=478c6dbc-e316-401d-a0df-7b5093ac5fd4;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-05-23T06:25:39Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|PH7PR12MB7916:EE_ x-ms-office365-filtering-correlation-id: 479cd642-4d57-4be2-e01f-08db5b57ea8c x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /yEIPTE2Wn8NPHS3iuxrqZhc0b1IUgWMLuC65qvLkNjTSKln09OA3KWQk+e6ymzchpobksvCzToXlqD1ftJE6el4H8VKdH3ujzaw4qcYWpjHHQjUK2lQgmVfdE/P+4GbE3VUgk+RfFKr02rIgRxkbfi9Rn+N97Aiyugg6jnyy1nPnDPPoDcbr36eK6IX2zJY/b4m8Ysp3rZ9KjINcLcHXR6WGdyXWy3h4Je8Ihgj8NkTomER+PvGz7uZw4E31OxC99eNiMEefvifN5M3oxhHVM0X+COTGmJzJcMrsJ8JGLhSyvNrZHNo85Fvy2uc69Zua4/EiYdsvRayWWA33Rn8C7GrjyHV+yzZ8LFsm+F4BHthxQxuZFbjJ7cTuW42qwReVZPHKMf5ea6Hc/Wn05xzYFLwCe/D/QlV9l36AISoDp4pOqehIUpjFCubi8sKurd6W36JCnS8muUSPfVukJ/Mehbz9yFxcky9SWcChcwJjaQX6q+wpZmHXgQDhRX44j7xPt4/EgxCvDLg2a0TY3LM1+SMfwwk/8pVf4YV/kSRq1bUJzYO7XvGPFWFEUeowcgsYP+Ln3cpqMHzFUV1eLajqROm0K6W42yk82jutjVcqE+Yl8o/0S+xx0+h9WOUpiAe x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(6029001)(4636009)(376002)(346002)(396003)(366004)(136003)(39860400002)(84040400005)(451199021)(38070700005)(122000001)(38100700002)(33656002)(86362001)(55016003)(53546011)(9686003)(52536014)(7696005)(6506007)(478600001)(8936002)(8676002)(7416002)(2906002)(186003)(54906003)(19627235002)(4326008)(64756008)(316002)(110136005)(26005)(66446008)(71200400001)(5660300002)(41300700001)(66476007)(966005)(76116006)(66556008)(66946007)(83380400001)(213903007);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?0Vco9auOcjOqn7AuZnILPkpjhYeuhN2gwGQOZI8fzog97XmH/AO5SvkZQzYn?= =?us-ascii?Q?/ari1Nx7DH8owuADHX+Ibe22EdFZnAZzjctYzdiZ1LNW6chzzsjsPFX1urZf?= =?us-ascii?Q?qkadb/woPv8rpLu5GI0iO1IeUb+LAOo1dJkaa5Kfe11rfULA/b8CPoZlGLlt?= =?us-ascii?Q?/QBjfPQ5YHqry94Uxjx2U1TT7meEufd0CAq8lP/vNPINOoQ4nGjcD2SvmqCx?= =?us-ascii?Q?+k9JPChsWgOM0E2wbdIalV1/ELDyvzCuutmWxjdHhgA/OV4NNWEUYT2kRN9B?= =?us-ascii?Q?eDPDzZbey9q8OLVNeSB+IHR1G/MzLoezDJCXVAnvC96DXDYk5CBIqQqPB02F?= =?us-ascii?Q?lQWrmZixz2BTGhF6WxiZZHeSrAJxllmaLpB/PoeWpgtTTwGbJ5gVlGeupGAL?= =?us-ascii?Q?q3mCReJSca6CkG5sHMw7HCmivnxobM/Jiz5qo/oietA1ELkHVECrxSWJ8oOM?= =?us-ascii?Q?rpT3rfZ3Un29lPtDRnsuyWLqzl03Z7cPIoLohrTdTCFo9RAc3VyGnSIXdstB?= =?us-ascii?Q?wVQV5XlxNMHGE9Vnb4FuZwKIjNZ13G7DhRpMl7JN3sG6tPuaqpjUeDM92Bds?= =?us-ascii?Q?TyryIlpiVL9UeWc3z/wdWG+SKGk7nEr9Wpa6qYnPJMxwqDiV2Tjbp0Vnuokh?= =?us-ascii?Q?pJmzRifjTVAGCy1bXE/D2Xb9kS1l25S40P99R5gb8UPFcB73/7anpSGMU3Hs?= =?us-ascii?Q?LD/ZqZeon+v1u6ZG7u8CwTcImbyN0UkgS3Q80DTVRGo12Q7W99T8lvHfn5CV?= =?us-ascii?Q?NanDpNUVUhQk2k8iujWgyvmj8srHUhQyUinVDocqquxSm8OpEQ17S6838h1e?= =?us-ascii?Q?NXOsrDl0gk+55dyGU4mZHLTRtg8k2z+osnOdMaFwSUA4x71J9yfLXOWT9unM?= =?us-ascii?Q?HojBnMAnh28MKfRhiuNowKrdsMmRXbHD5w5QrIM0GgD3ZMw3QgVVBEn+M4VO?= =?us-ascii?Q?18YZg5OBq8lAPYSSiz6IPdqorauLYVEgHxN587MOdoWg1oseOFmuOTtHNApW?= =?us-ascii?Q?h1uIqzl5UKXiiwbHXMNiCJqziYD8ZgfJwSJOdo8fbKXcTUiFy7xbsEvpzK4L?= =?us-ascii?Q?Qo0yIvDaaXCT/akmnTMwOllMdshLXSiYOBtxLL0SzSDRXB0Ukl6Zjpthw4Ib?= =?us-ascii?Q?q5WlSkGTnhXxNvPnNAzws65QkVM5/udWsLOCaZssXbuvOZAL8Lyqh1tD1aQ0?= =?us-ascii?Q?niuMcUbb570WcuZrkfD9gtVcsmO9v9pjZrE2s8j3bJLAxoA70aTPNK7NcyL4?= =?us-ascii?Q?DRHf/eF9x3bHm7BZ+hd8N30oE1FAIzGlHbZ5O96cjKa4StUJcCypNsW8wVgW?= =?us-ascii?Q?eF677mtJKg8RdMHeZ7HZ1bBbvagZYllWWp2zpqzo5DHzcey/1/UEoZQNyFf9?= =?us-ascii?Q?jwQKLTPSYWhDRAf5Pn4O5BsodrTyNBrtPRt0fkiG0ZJ5gtZ1l+6WxXOjgLSd?= =?us-ascii?Q?r0AKfMPxGF8j1MSX0DG+DKlr1EjftEdMyujzMUmb+pAhqEKjyXzbNz0ABEsY?= =?us-ascii?Q?7l9bnAXdktrD2VYWAiuyOcFMUOnzthqlM2cH9qABaE0dWXhYmAz41saThH32?= =?us-ascii?Q?C54nwkQWOSxDsauDf4Y=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 479cd642-4d57-4be2-e01f-08db5b57ea8c X-MS-Exchange-CrossTenant-originalarrivaltime: 23 May 2023 06:35:35.8385 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hZVZ+UsRzsCOH+cylt7BNflxvK5qFYqNJEDaiMyK4sfORQ0JDE3dEo50ODrOxbWBfIvlEnPjKQbXyuma/53/zA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7916 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Let's talk to Liming to see if we have chance to make this included in 2023= 05 as the review process of this patch set looks to me close to finish. Thanks Abner > -----Original Message----- > From: Ni, Ray > Sent: Tuesday, May 23, 2023 2:30 PM > To: Chang, Abner ; Attar, AbdulLateef (Abdul > Lateef) ; devel@edk2.groups.io > Cc: Attar, AbdulLateef (Abdul Lateef) ; Grimes= , > Paul ; Dong, Eric ; Kumar, > Rahul R ; Gerd Hoffmann ; > Kinney, Michael D ; Gao, Liming > ; Liu, Zhiguang ; Ard > Biesheuvel ; Yao, Jiewen > ; Justen, Jordan L > Subject: RE: [PATCH v13 0/8] Adds AmdSmmCpuFeaturesLib and > MmSaveStateLib > > [AMD Official Use Only - General] > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > Abner, > Sure. I will review the new patch set. > > But I am afraid this patch set cannot be included in 202305 stable releas= e > because the edk2 repo > has been locked for quite a while for 202305 release and is about to unlo= cked. > > Thanks, > Ray > > > -----Original Message----- > > From: Chang, Abner > > Sent: Tuesday, May 23, 2023 2:28 PM > > To: Attar, AbdulLateef (Abdul Lateef) ; > > devel@edk2.groups.io; Ni, Ray > > Cc: Attar, AbdulLateef (Abdul Lateef) ; > Grimes, > > Paul ; Dong, Eric ; Kumar, > Rahul > > R ; Gerd Hoffmann ; > Kinney, > > Michael D ; Gao, Liming > > ; Liu, Zhiguang ; Ard > > Biesheuvel ; Yao, Jiewen > ; > > Justen, Jordan L > > Subject: RE: [PATCH v13 0/8] Adds AmdSmmCpuFeaturesLib and > MmSaveStateLib > > > > [AMD Official Use Only - General] > > > > Hi @Ray Ni, > > We are almost there... We need your help to review this patch set as we > need > > this library to be part of 202305 stable release. > > > > Thanks > > Abner > > > > > > > > > -----Original Message----- > > > From: Abdul Lateef Attar > > > Sent: Friday, May 12, 2023 8:32 PM > > > To: devel@edk2.groups.io > > > Cc: Attar, AbdulLateef (Abdul Lateef) ; > Grimes, > > > Paul ; Chang, Abner ; > Eric > > > Dong ; Ray Ni ; Rahul Kumar > > > ; Gerd Hoffmann ; > Michael D > > > Kinney ; Liming Gao > > > ; Zhiguang Liu ; Ar= d > > > Biesheuvel ; Jiewen Yao > > > ; Jordan Justen > > > Subject: [PATCH v13 0/8] Adds AmdSmmCpuFeaturesLib and > > > MmSaveStateLib > > > > > > Backward-compatibility changes: > > > This patch series removes the SmmCpuFeaturesReadSaveStateRegister > > > and SmmCpuFeaturesWriteSaveStateRegister interface/function. > > > SmmReadSaveState() and SmmWriteSaveState() now directly invokes > > > MmSaveStateLib > > > routines to save/restore registers. > > > > > > PR: https://github.com/tianocore/edk2/pull/4392 > > > > > > V13: Delta changes > > > Address review comments from Ray Ni > > > Changed the BASE _NAME of AmdSmmCpuFeaturesLib. > > > Removed EFIAPI from local function. > > > Removed CpuIndex parameter from MmSaveStateGetRegisterLma > > > Modifed MmSaveStateGetRegisterIndex () to accept RegOffset > > > as second parameter. > > > Removed FILE_GUID library instance for intel implemention from > > > UefiCpuPkg.dsc. > > > > > > V12: > > > Addressed review comments from Michael. > > > Added LibraryClasses to .inf file. > > > removed duplicate MACRO definations. > > > Moved related MACRO defination to respective file. > > > V11: Delta changes > > > Drop the OVMF implementation of MmSaveStateLib > > > V10: Delta changes: > > > Addressed review comments from Abner. > > > V9: Delta changes: > > > Addressed review comments. > > > Rename to MmSaveStateLib. > > > Also rename SMM_ defines to MM_. > > > Implemented OVMF MmSaveStateLib. > > > Removes SmmCpuFeaturesReadSaveStateRegister and > > > SmmCpuFeaturesWriteSaveStateRegister > > > function interface. > > > V8 delta changes: > > > Addressed review comments from Abner, > > > Fix the whitespace error. > > > Seperate the Ovmf changes to another patch > > > V7 delta changes: > > > Adds SmmSmramSaveStateLib for Intel processor. > > > Integrate SmmSmramSaveStateLib library. > > > V6 delta changes: > > > Addressed review comments for Ray NI. > > > removed unnecessary EFIAPI. > > > V5 delta changes: > > > rebase to master branch. > > > updated Reviewed-by > > > V4 delta changes: > > > rebase to master branch. > > > added reviewed-by. > > > V3 delta changes: > > > Addressed review comments from Abner chang. > > > Re-arranged patch order. > > > > > > Cc: Paul Grimes > > > Cc: Abner Chang > > > Cc: Eric Dong > > > Cc: Ray Ni > > > Cc: Rahul Kumar > > > Cc: Gerd Hoffmann > > > Cc: Michael D Kinney > > > Cc: Liming Gao > > > Cc: Zhiguang Liu > > > Cc: Ard Biesheuvel > > > Cc: Jiewen Yao > > > Cc: Jordan Justen > > > Cc: Abdul Lateef Attar > > > > > > Abdul Lateef Attar (8): > > > MdePkg: Adds AMD SMRAM save state map > > > UefiCpuPkg: Adds MmSaveStateLib library class > > > UefiCpuPkg: Implements MmSaveStateLib library instance > > > UefiCpuPkg/SmmCpuFeaturesLib: Restructure arch-dependent code > > > UefiCpuPkg: Implements SmmCpuFeaturesLib for AMD Family > > > UefiCpuPkg: Implements MmSaveStateLib for Intel > > > UefiCpuPkg: Removes SmmCpuFeaturesReadSaveStateRegister > > > OvmfPkg: Uses MmSaveStateLib library > > > > > > UefiCpuPkg/UefiCpuPkg.dec | 4 + > > > OvmfPkg/OvmfPkgIa32.dsc | 1 + > > > OvmfPkg/OvmfPkgIa32X64.dsc | 3 + > > > OvmfPkg/OvmfPkgX64.dsc | 1 + > > > UefiCpuPkg/UefiCpuPkg.dsc | 13 + > > > .../MmSaveStateLib/AmdMmSaveStateLib.inf | 34 + > > > .../MmSaveStateLib/IntelMmSaveStateLib.inf | 34 + > > > .../AmdSmmCpuFeaturesLib.inf | 38 + > > > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf | 2 + > > > .../Include/Register/Amd/SmramSaveStateMap.h | 194 +++++ > > > UefiCpuPkg/Include/Library/MmSaveStateLib.h | 70 ++ > > > .../Include/Library/SmmCpuFeaturesLib.h | 52 -- > > > .../Library/MmSaveStateLib/MmSaveState.h | 94 +++ > > > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 56 +- > > > .../SmmCpuFeaturesLib/SmmCpuFeaturesLib.c | 767 ----------------= -- > > > .../Library/MmSaveStateLib/AmdMmSaveState.c | 309 +++++++ > > > .../Library/MmSaveStateLib/IntelMmSaveState.c | 410 ++++++++++ > > > .../MmSaveStateLib/MmSaveStateCommon.c | 132 +++ > > > .../SmmCpuFeaturesLib/AmdSmmCpuFeaturesLib.c | 387 +++++++++ > > > .../IntelSmmCpuFeaturesLib.c | 70 ++ > > > .../SmmCpuFeaturesLibCommon.c | 128 --- > > > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 11 +- > > > UefiCpuPkg/PiSmmCpuDxeSmm/SmramSaveState.c | 500 +----------- > > > MdePkg/MdePkg.ci.yaml | 4 +- > > > 24 files changed, 1806 insertions(+), 1508 deletions(-) > > > create mode 100644 > > > UefiCpuPkg/Library/MmSaveStateLib/AmdMmSaveStateLib.inf > > > create mode 100644 > > > UefiCpuPkg/Library/MmSaveStateLib/IntelMmSaveStateLib.inf > > > create mode 100644 > > > UefiCpuPkg/Library/SmmCpuFeaturesLib/AmdSmmCpuFeaturesLib.inf > > > create mode 100644 > MdePkg/Include/Register/Amd/SmramSaveStateMap.h > > > create mode 100644 UefiCpuPkg/Include/Library/MmSaveStateLib.h > > > create mode 100644 > UefiCpuPkg/Library/MmSaveStateLib/MmSaveState.h > > > create mode 100644 > > > UefiCpuPkg/Library/MmSaveStateLib/AmdMmSaveState.c > > > create mode 100644 > > > UefiCpuPkg/Library/MmSaveStateLib/IntelMmSaveState.c > > > create mode 100644 > > > UefiCpuPkg/Library/MmSaveStateLib/MmSaveStateCommon.c > > > create mode 100644 > > > UefiCpuPkg/Library/SmmCpuFeaturesLib/AmdSmmCpuFeaturesLib.c > > > > > > -- > > > 2.25.1