[AMD Official Use Only - General]

Hi Ray and module maintainers,
I think this patch set should be no problem as we agreed with the guidance added to edk2 coding standard for the module source file naming that support different processor archs/vendors.
Patches are attached, please help to review it.
Thanks
Abner

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Chang,
> Abner via groups.io
> Sent: Saturday, October 1, 2022 11:40 PM
> To: Kinney, Michael D <michael.d.kinney@intel.com>; devel@edk2.groups.io
> Cc: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>;
> Kirkendall, Garrett <Garrett.Kirkendall@amd.com>; Grimes, Paul
> <Paul.Grimes@amd.com>; Dong, Eric <eric.dong@intel.com>; Ni, Ray
> <ray.ni@intel.com>; Kumar, Rahul R <rahul.r.kumar@intel.com>
> Subject: Re: [edk2-devel] [PATCH 0/2] Reconstruction on
> SmmCpuFeaturesLib
> 
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
> 
> 
> [AMD Official Use Only - General]
> 
> Hi Mike,
> I think we don't need to git mv for this case. IntelSmmCpuFeaturesLib.c is a
> new file and the content is moved from SmmCpuFeatureslibCommon.c.
> SmmCpuFeatureslibCommon.c still has the complete history. Did I miss
> something?
> 
> Abner
> 
> > -----Original Message-----
> > From: Kinney, Michael D <michael.d.kinney@intel.com>
> > Sent: Friday, September 30, 2022 11:11 PM
> > To: devel@edk2.groups.io; Chang, Abner <Abner.Chang@amd.com>;
> Kinney,
> > Michael D <michael.d.kinney@intel.com>
> > Cc: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>;
> > Kirkendall, Garrett <Garrett.Kirkendall@amd.com>; Grimes, Paul
> > <Paul.Grimes@amd.com>; Dong, Eric <eric.dong@intel.com>; Ni, Ray
> > <ray.ni@intel.com>; Kumar, Rahul R <rahul.r.kumar@intel.com>
> > Subject: RE: [edk2-devel] [PATCH 0/2] Reconstruction on
> > SmmCpuFeaturesLib
> >
> > Caution: This message originated from an External Source. Use proper
> > caution when opening attachments, clicking links, or responding.
> >
> >
> > Hi Abner,
> >
> > Did you use git mv to rename the file.  It can help track history of changes.
> >
> > Mike
> >
> > > -----Original Message-----
> > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > > Chang, Abner via groups.io
> > > Sent: Friday, September 30, 2022 2:52 AM
> > > To: devel@edk2.groups.io
> > > Cc: Abdul Lateef Attar <abdattar@amd.com>; Garrett Kirkendall
> > > <garrett.kirkendall@amd.com>; Paul Grimes <paul.grimes@amd.com>;
> > > Dong, Eric <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Kumar,
> > > Rahul R <rahul.r.kumar@intel.com>
> > > Subject: [edk2-devel] [PATCH 0/2] Reconstruction on
> > > SmmCpuFeaturesLib
> > >
> > > From: Abner Chang <abner.chang@amd.com>
> > >
> > > This patch set is part of below BZ 3860:
> > >
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbu
> > > gz
> > >
> >
> illa.tianocore.org%2Fshow_bug.cgi%3Fid%3D3860&amp;data=05%7C01%7Ca
> bn
> > er
> >
> > .chang%40amd.com%7C8e21740be3a54f50521708daa2f5f70d%7C3dd8961f
> e
> > 4884e60
> > >
> >
> 8e11a82d994e183d%7C0%7C0%7C638001474543728133%7CUnknown%7CTW
> F
> > pbGZsb3d8
> > >
> >
> eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3
> D%
> > 7C3
> > >
> >
> 000%7C%7C%7C&amp;sdata=tJUZ5hTCB0sBXd4bx5HG5XDV%2FWyU1dKwID
> DzI
> > KNjegA%3
> > > D&amp;reserved=0
> > >
> > > This is the reconstruction on SmmCpuFeaturesLib to accommodate AMD
> > > implementation of SmmCpuFeaturesLib. Intel specific implementation
> > > is stripped away from SmmCpuFeaturesLibCommon.c and put into
> > > IntelSmmCpuFeaturesLib.c.
> > >
> > > This patch set is the preparation for AMD SmmCpuFeaturesLib upstream.
> > > In the follow up pacthes, AMD will create a new INF file
> > > SmmAmdSmmCpuFeaturesLib.inf under \SmmCpuFeaturesLib,
> > > AmdSmmCpuFeaturesLib.c for the AMD specific implementation.
> > >
> > > Signed-off-by: Abner Chang <abner.chang@amd.com>
> > > Cc: Abdul Lateef Attar <abdattar@amd.com>
> > > Cc: Garrett Kirkendall <garrett.kirkendall@amd.com>
> > > Cc: Paul Grimes <paul.grimes@amd.com>
> > > Cc: Eric Dong <eric.dong@intel.com>
> > > Cc: Ray Ni <ray.ni@intel.com>
> > > Cc: Rahul Kumar <rahul1.kumar@intel.com>
> > >
> > > Abner Chang (2):
> > >   UefiCpuPkg/SmmCpuFeaturesLib: Abstract arch dependent code
> > >   UefiCpuPkg/SmmCpuFeaturesLib: Clean up header file inclusion in
> > >     SmmStm.c
> > >
> > >  .../SmmCpuFeaturesLib/SmmCpuFeaturesLib.inf   |   1 +
> > >  .../SmmCpuFeaturesLibStm.inf                  |   1 +
> > >  .../StandaloneMmCpuFeaturesLib.inf            |   1 +
> > >  .../SmmCpuFeaturesLib/CpuFeaturesLib.h        |   6 +
> > >  .../IntelSmmCpuFeaturesLib.c                  | 403 ++++++++++++++++++
> > >  .../SmmCpuFeaturesLibCommon.c                 | 391 +----------------
> > >  UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.c |   3 -
> > >  7 files changed, 413 insertions(+), 393 deletions(-)  create mode
> > > 100644
> UefiCpuPkg/Library/SmmCpuFeaturesLib/IntelSmmCpuFeaturesLib.c
> > >
> > > --
> > > 2.37.1.windows.1
> > >
> > >
> > >
> > >
> > >
> 
> 
> 
>