From: "Chang, Abner" <abner.chang@amd.com>
To: "Attar, AbdulLateef (Abdul Lateef)" <AbdulLateef.Attar@amd.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Attar, AbdulLateef (Abdul Lateef)" <AbdulLateef.Attar@amd.com>,
"Grimes, Paul" <Paul.Grimes@amd.com>,
"Kirkendall, Garrett" <Garrett.Kirkendall@amd.com>,
Eric Dong <eric.dong@intel.com>, Ray Ni <ray.ni@intel.com>,
Rahul Kumar <rahul1.kumar@intel.com>,
Michael D Kinney <michael.d.kinney@intel.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
Zhiguang Liu <zhiguang.liu@intel.com>
Subject: Re: [PATCH v3 0/6] Adds AmdSmmCpuFeaturesLib for AMD Family
Date: Thu, 19 Jan 2023 04:17:08 +0000 [thread overview]
Message-ID: <MN2PR12MB3966D9A248830EC7B96BF6EAEAC49@MN2PR12MB3966.namprd12.prod.outlook.com> (raw)
In-Reply-To: <cover.1674060385.git.abdattar@amd.com>
[AMD Official Use Only - General]
Hi Abdul,
Thanks for contributing this and addressing the comments. Please just add the review tag to each commit message and send out the V4. So maintainers know AMD has agreed with this change. We still need maintainers to review this patch set and merge it if they have no problem with it.
Thanks
Abner
> -----Original Message-----
> From: Abdul Lateef Attar <abdattar@amd.com>
> Sent: Thursday, January 19, 2023 1:01 AM
> To: devel@edk2.groups.io
> Cc: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>;
> Grimes, Paul <Paul.Grimes@amd.com>; Kirkendall, Garrett
> <Garrett.Kirkendall@amd.com>; Chang, Abner <Abner.Chang@amd.com>;
> Eric Dong <eric.dong@intel.com>; Ray Ni <ray.ni@intel.com>; Rahul Kumar
> <rahul1.kumar@intel.com>; Michael D Kinney
> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Zhiguang Liu <zhiguang.liu@intel.com>
> Subject: [PATCH v3 0/6] Adds AmdSmmCpuFeaturesLib for AMD Family
>
> V3 delta changes:
> Addressed review comments from Abner Chang.
>
> PR: https://github.com/tianocore/edk2/pull/3925
>
> Cc: Paul Grimes <paul.grimes@amd.com>
> Cc: Garrett Kirkendall <garrett.kirkendall@amd.com>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Rahul Kumar <rahul1.kumar@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
>
> Abdul Lateef Attar (6):
> MdePkg: Adds AMD SMRAM save state map
> UefiCpuPkg: Adds SmmSmramSaveStateLib library class
> UefiCpuPkg: Implements SmmSmramSaveStateLib library class
> UefiCpuPkg/SmmCpuFeaturesLib: Restructure arch-dependent code
> UefiCpuPkg: Initial implementation of AMD's SmmCpuFeaturesLib
> UefiCpuPkg: Implements SmmCpuFeaturesLib for AMD Family
>
> UefiCpuPkg/UefiCpuPkg.dec | 4 +
> UefiCpuPkg/UefiCpuPkg.dsc | 11 +
> .../AmdSmmCpuFeaturesLib.inf | 39 ++
> .../AmdSmmSmramSaveStateLib.inf | 28 ++
> .../Include/Register/Amd/SmramSaveStateMap.h | 194 ++++++++
> .../Include/Library/SmmSmramSaveStateLib.h | 70 +++
> .../SmmSmramSaveStateLib/SmramSaveState.h | 102 ++++
> .../SmmCpuFeaturesLib/AmdSmmCpuFeaturesLib.c | 445
> ++++++++++++++++++
> .../IntelSmmCpuFeaturesLib.c | 128 +++++
> .../SmmCpuFeaturesLibCommon.c | 128 -----
> .../SmmSmramSaveStateLib/AmdSmramSaveState.c | 319 +++++++++++++
> .../SmramSaveStateCommon.c | 124 +++++
> MdePkg/MdePkg.ci.yaml | 4 +-
> 13 files changed, 1467 insertions(+), 129 deletions(-) create mode 100644
> UefiCpuPkg/Library/SmmCpuFeaturesLib/AmdSmmCpuFeaturesLib.inf
> create mode 100644
> UefiCpuPkg/Library/SmmSmramSaveStateLib/AmdSmmSmramSaveStateLib.
> inf
> create mode 100644
> MdePkg/Include/Register/Amd/SmramSaveStateMap.h
> create mode 100644 UefiCpuPkg/Include/Library/SmmSmramSaveStateLib.h
> create mode 100644
> UefiCpuPkg/Library/SmmSmramSaveStateLib/SmramSaveState.h
> create mode 100644
> UefiCpuPkg/Library/SmmCpuFeaturesLib/AmdSmmCpuFeaturesLib.c
> create mode 100644
> UefiCpuPkg/Library/SmmSmramSaveStateLib/AmdSmramSaveState.c
> create mode 100644
> UefiCpuPkg/Library/SmmSmramSaveStateLib/SmramSaveStateCommon.c
>
> --
> 2.25.1
prev parent reply other threads:[~2023-01-19 4:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 17:01 [PATCH v3 0/6] Adds AmdSmmCpuFeaturesLib for AMD Family Abdul Lateef Attar
2023-01-18 17:01 ` [PATCH v3 1/6] MdePkg: Adds AMD SMRAM save state map Abdul Lateef Attar
2023-01-19 4:05 ` Chang, Abner
2023-01-18 17:01 ` [PATCH v3 2/6] UefiCpuPkg: Adds SmmSmramSaveStateLib library class Abdul Lateef Attar
2023-01-19 4:05 ` Chang, Abner
2023-01-18 17:01 ` [PATCH v3 3/6] UefiCpuPkg: Implements " Abdul Lateef Attar
2023-01-19 3:44 ` Chang, Abner
2023-01-18 17:01 ` [PATCH v3 4/6] UefiCpuPkg/SmmCpuFeaturesLib: Restructure arch-dependent code Abdul Lateef Attar
2023-01-19 4:06 ` [edk2-devel] " Chang, Abner
2023-01-18 17:01 ` [PATCH v3 5/6] UefiCpuPkg: Initial implementation of AMD's SmmCpuFeaturesLib Abdul Lateef Attar
2023-01-19 4:08 ` Chang, Abner
2023-01-18 17:01 ` [PATCH v3 6/6] UefiCpuPkg: Implements SmmCpuFeaturesLib for AMD Family Abdul Lateef Attar
2023-01-19 4:10 ` Chang, Abner
2023-01-19 4:17 ` Chang, Abner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR12MB3966D9A248830EC7B96BF6EAEAC49@MN2PR12MB3966.namprd12.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox