From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 600B8940FDC for ; Mon, 18 Dec 2023 02:58:14 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=ZwoD71k7yY86a+3AVx8umDLeVhTFGGrvqE9Sxbg5haw=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1702868293; v=1; b=ut7zE5AvO3u11XqiIympV4sudUiQ53mt55hz1wGpiEiSi+KDDl2LBFRSxlWJaQIX5skkJl52 Kba70vxaAFefXH2msmj8AR5VQ2sbRUx35wy2Hob3ZM1KITBgJT+UlyYFw3nQhd9kA+6uGy/VC1O pYMMiw1dfogCOxFVdAzI6lq0= X-Received: by 127.0.0.2 with SMTP id WTRCYY7687511xYAHBrd9KyR; Sun, 17 Dec 2023 18:58:13 -0800 X-Received: from NAM10-DM6-obe.outbound.protection.outlook.com (NAM10-DM6-obe.outbound.protection.outlook.com [40.107.93.75]) by mx.groups.io with SMTP id smtpd.web10.34085.1702868292352390453 for ; Sun, 17 Dec 2023 18:58:12 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fXfFfNbqv35kETavM1tq3vlCrF7rlpPRqaGGxlTDUzMKaizMkJwG44/EVQxu5v7/cuISlci403/Ri0IgHkbiqmcL4wcztXV4TGBf7lZBu/2jmS8ECTPje2Rjp4Oajp5TU74jc5IRZ+cpvSlIVx3dhiy6HmfayId4HJb4FlC3ydQaaGwKZNf3bR+eNw6uJu964G9AibA6wSsUfRlNUu1WvJxFnl41qk1AARFJl3nW5TJoqSfkA+PlEIoga1k8KONB7ieq7rLNlEJamfdtu4GVNa9I9seZp7zYZJAMgxoeUAUVKaUBaNeOhUaIr3WDecUEWYtNMi3nRsPgpNWrWbAOtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rTMe0bkEaxTVW70UzerWQpx4BtIkBrdBYShEoHRE7ZM=; b=JW03xbC+f0kjYYP03b13wNWEPf6fZc43n8ArUVh71UNRS6tjO9o+niFkjvie87EKWoii8e/1vIsoTIMZU0H8WFSA8lkNvjsiE3zKI3OSrEj+IGY3rfeRy2XUVqFOSD2V8Hmh3ivj9zoqDq5EnPLrOClpyGT4PlNTnp2L++aTyMZdb2HiIqqdJavMv5AJzQ+vvFFii6T2Cvir9lcWTW71KuSExQVuhMlBt1qnpDb2/wJaRZLWufDuxom4Hl0ZaYuSJqXSj/8O/924thlddyUlXc2od2QKI4CPbkCON/RU38GXyKSA6LeDflQR88Vqin8pD+rXgY6wQx7omchlntbwfA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by DM4PR12MB5246.namprd12.prod.outlook.com (2603:10b6:5:399::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.37; Mon, 18 Dec 2023 02:58:07 +0000 X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::91d9:e679:32a3:dd05]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::91d9:e679:32a3:dd05%5]) with mapi id 15.20.7091.034; Mon, 18 Dec 2023 02:58:06 +0000 From: "Chang, Abner via groups.io" To: Mike Maslenkin , "devel@edk2.groups.io" CC: "nicklew@nvidia.com" , "igork@ami.com" Subject: Re: [edk2-devel] [PATCH v2 06/14] RedfishPkg: add Component Name protocols to RedfishConfigHandler driver Thread-Topic: [PATCH v2 06/14] RedfishPkg: add Component Name protocols to RedfishConfigHandler driver Thread-Index: AQHaLuTIOiBP7QlhXkC7RwQSTF08XrCuXZ8g Date: Mon, 18 Dec 2023 02:58:06 +0000 Message-ID: References: <20231214232458.4636-1-mike.maslenkin@gmail.com> <20231214232458.4636-7-mike.maslenkin@gmail.com> In-Reply-To: <20231214232458.4636-7-mike.maslenkin@gmail.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=33da28cf-f8af-451a-8679-8e9b05e8256a;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-12-18T02:55:48Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|DM4PR12MB5246:EE_ x-ms-office365-filtering-correlation-id: 9108bc80-8d6e-40bd-5702-08dbff7528da x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 3zCLb97KhyLK2fPAiK8wTFBohKtCLcleMos7H1vnr2lOa9tMZIEESGDSmcIEnBiXOufGYBLJ9/0Rw4g1HapbeQb9CoHYHZLFLiV/+m6j1UNCqGsAlhaAgAvQi/UFr2AEhsukpW3DTR4fOLzXjWG06BItoMHHJT6bB4/ZXmuiq6yvQ7Msb0pw0qGIULrNU1joZ+kAslHqtfEBAimRseUIR4xg4MsowKhmdeSp51Vou+N7UXTuGUjGAh+G/zof/tr2A7vHx7X8miXdikyUvw1ASi+W6lIOX70d1e7TV1PuGsnDrP0PBEcIHAi8kcccg1KxAQsnNYT9rC0alGqHxWsHzGPxjcc+ykeX6s/yxBoiYXlME6hAaLH7tt8SKaU2wBQiDVy26sIWiwNxMK2QEJgx4cAt4AxtV0uRjcRsx0Xb+CLa9GwXmhrlNB/+EV0ol3tRhkloSYRffS1puHKolm5FFIbzMbnQHAOwbhlvoalLzDqYrSo2e8qyUYYhRVArZZA+OeTurJDMev2lNw9jNGcfhZ2ncqAR/VqoLLx5/G8saHh/TFX6aPCEPg02EDkHLlkhrdKYzwk9NsJjfRMmm7wSYKbLkGxpB5TGRyk8/9DpyaJix9pTn3YVnP2MqdAnOzU6mFgC6jTt5jRrzjcyZ07BwJbUEZbyG0wmbMOk+TUkL8k= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?tV6gEWqUn1OiiFpCpHTZXzvR6jPdbXoQCUj7zsh1JMcVJAAJh8WH3ZEUoCjI?= =?us-ascii?Q?dDPLU7kXqNdcNI/QzvjXiDQspHegXm5AgHrCqf9hdEgg14UcNTD/hD9e8nUW?= =?us-ascii?Q?rr6x+9c8/1ykr1tsvfpCiNmUekGDoLV4dfGEXLKy9k9ENjTj2XUNVO6Su0fL?= =?us-ascii?Q?58i5orjspCxWibd9THiz1au8XSbXoD5+cysayJjSJHVhkQHkBz2bqjtK/947?= =?us-ascii?Q?pAB4BrEZP6aGcyBZwDVn5EBJdPzLFEZT+qqzL95LqpPR4przf0+PbpXNyc6/?= =?us-ascii?Q?2FS2ANZhuheJTOmG+RwBFsEuV/DJGgtAbtmh8RftTGQcETe17gWPTpq6Psdq?= =?us-ascii?Q?aXAA0tkSZCbtRfUWotz3aGo1SnHr8QFX+bdbUjAzd5/8ET0shsmHFFli6UIR?= =?us-ascii?Q?XWgvff3HDQc9DQuydCfIVlJ9lN1+2jD5FZwzK+xazdKW8yd427Xg4dzYQf/u?= =?us-ascii?Q?UGwJJ/LmJuxGI8oryhaedQghNAKX4fo9+xwKWbaJBaFzrgorKDOngY4V5NEW?= =?us-ascii?Q?XahMpZobMsrwmoEMdldY32roBlSml5/dgR1DziHDtJ/e296YvkEpurcTjEFQ?= =?us-ascii?Q?UwahYksGjA6aCe5PhsVa08INcAa/tirGyJ4EvQ7Kcs2srdiCjN1T3bTLtUcd?= =?us-ascii?Q?EpA56gQyURTxCzd9DljrihN+1QOZrzh25vesy9l2APGSi50YxxtOhuzR58II?= =?us-ascii?Q?7++Ms2SbYE1Q8Fcb2KbIS1Ow2sWWMSPpgtXYq1bf/H8WJ2xbCPDPTMGFgVcH?= =?us-ascii?Q?f2GENPWazrXHPw5CuzpcYje8ClXDIbsVfYRd8gJZlR4ETqc4nlo7ka5hdPnI?= =?us-ascii?Q?CbpRaceKK5Hb+M3jS9h6XOaaEpeM6WfPAjMgscwrl4RlacG1tx5kxJ8+YmSg?= =?us-ascii?Q?XO/tlV0+yPR2tlWzHY6uosXE+jQ+5euX/EomNsxbt0w1QU9CLGf4uZcDx1HR?= =?us-ascii?Q?K4+38EoB6K/fkVMJFx7HLLhR9shmmPiHu+nhRDFXTUcOdDZP02WsqpghnsXa?= =?us-ascii?Q?sRVQI1cJ4xyQPYZWmutcSgDUJuU55CmQ+/MSvPTqnrWCHRMkYGJB25NP+KqM?= =?us-ascii?Q?yn07nY+s4ml7XQuEseVl23XqnzXYxabfYDEs8ZaJU5cwLBQVUan6BtjiwCp/?= =?us-ascii?Q?Bc9pya3GA4Z3F6sQv57YSLIH+CcNW0vBaiKZROJbcvDeK6enUYj7YCdMbzHB?= =?us-ascii?Q?/VSHTRLN59VY0HDzv31dsGeaOqhyohlk0D1U6J+MshkQBGiGE4y/33Bzb/RK?= =?us-ascii?Q?jyEFHvx+tHv/76knGTJuyW85UYNfO8d7NHCeTsLg576WbWpaWSBxY1cefsK3?= =?us-ascii?Q?uM1e3MvE49pl/pOD4P327lhLZxNzQzWH0ttouo0qowj5HKfXZj2XYQNsxxLM?= =?us-ascii?Q?9JYeqfW18uVjuoovIPvflDeYHBB1BQr34mFdFt4ZkpLk1i7EP0LyfAGGKwPd?= =?us-ascii?Q?61K3FVXhPvxye12mt/zHJCKzQTRdDWAngwJHTS9THrqnahkQgN0for8z0ui5?= =?us-ascii?Q?Mtb+Mz/ovi7Ulnlmbeu6ZyTwSHbP1m3GCfwewNFnzTAzyaYvb9fU8x8IKPdJ?= =?us-ascii?Q?Zg9FhaHeXYwutCVhhUDNa2UPuO0IZ8AQJI4hCMnT?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9108bc80-8d6e-40bd-5702-08dbff7528da X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Dec 2023 02:58:06.4347 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: bU4W7msaPFpz+e+ivCaCBiwvJydQLK2ZxvJ41RMSXQGTzDYXXHB7NFvyiqyHBQsraaBXhWqzotIuFqB/rAxh7A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5246 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: KTO3qfO8ZeyQAbfouQVBFx23x7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=ut7zE5Av; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io [AMD Official Use Only - General] Hi Mike, Not sure how do we have the copyright for individual contributor. Let me ch= eck with community. And btw, you can in the patch format in below, there are additional blank l= ine for each line. I believe you can use option " --transfer-encoding=3D8bi= t" to git send-email to resolve this problem. Thanks Abner > -----Original Message----- > From: Mike Maslenkin > Sent: Friday, December 15, 2023 7:25 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; nicklew@nvidia.com; > igork@ami.com; Mike Maslenkin > Subject: [PATCH v2 06/14] RedfishPkg: add Component Name protocols to > RedfishConfigHandler driver > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > Currently there is no description for RedfishConfigHandler driver. > This leads to in the "DRIVER NAME" column of a `drivers` > command for example. > > Cc: Abner Chang > Cc: Nickle Wang > Cc: Igor Kulchytskyy > Signed-off-by: Mike Maslenkin > --- > .../RedfishConfigHandler/ComponentName.c | 216 > ++++++++++++++++++ > .../RedfishConfigHandlerDriver.c | 10 +- > .../RedfishConfigHandlerDriver.h | 4 +- > .../RedfishConfigHandlerDriver.inf | 1 + > 4 files changed, 228 insertions(+), 3 deletions(-) > create mode 100644 RedfishPkg/RedfishConfigHandler/ComponentName.c > > diff --git a/RedfishPkg/RedfishConfigHandler/ComponentName.c > b/RedfishPkg/RedfishConfigHandler/ComponentName.c > new file mode 100644 > index 000000000000..c6b8b189f3e1 > --- /dev/null > +++ b/RedfishPkg/RedfishConfigHandler/ComponentName.c > @@ -0,0 +1,218 @@ > +/** @file > > + Implementation of EFI_COMPONENT_NAME_PROTOCOL and > EFI_COMPONENT_NAME2_PROTOCOL protocol > > + for EFI Refish Config Handler Protocol > > + > > + Copyright (c) 2023, Mike Maslenkin > > + > > + SPDX-License-Identifier: BSD-2-Clause-Patent > > + > > +**/ > > + > > +#include "RedfishConfigHandlerCommon.h" > > + > > +// > > +// EFI Component Name Functions > > +// > > + > > +/** > > + Retrieves a Unicode string that is the user-readable name of the EFI D= river. > > + > > + @param[in] This A pointer to the EFI_COMPONENT_NAME_PROTOCOL > instance. > > + @param[in] Language A pointer to a three-character ISO 639-2 langua= ge > identifier. > > + This is the language of the driver name that th= e caller > > + is requesting, and it must match one of the lan= guages specified > > + in SupportedLanguages. The number of languages= supported by > a > > + driver is up to the driver writer. > > + @param[out] DriverName A pointer to the Unicode string to return. Thi= s > Unicode string > > + is the name of the driver specified by This in = the language > > + specified by Language. > > + > > + @retval EFI_SUCCESS The Unicode string for the Driver specif= ied by This > > + and the language specified by Language w= as returned > > + in DriverName. > > + @retval EFI_INVALID_PARAMETER Language is NULL. > > + @retval EFI_INVALID_PARAMETER DriverName is NULL. > > + @retval EFI_UNSUPPORTED The driver specified by This does not > support the > > + language specified by Language. > > + > > +**/ > > +EFI_STATUS > > +EFIAPI > > +RedfishConfigHandlerComponentNameGetDriverName ( > > + IN EFI_COMPONENT_NAME_PROTOCOL *This, > > + IN CHAR8 *Language, > > + OUT CHAR16 **DriverName > > + ); > > + > > +/** > > + Retrieves a Unicode string that is the user readable name of the contr= oller > > + that is being managed by an EFI Driver. > > + > > + @param[in] This A pointer to the > EFI_COMPONENT_NAME_PROTOCOL instance. > > + @param[in] ControllerHandle The handle of a controller that the drive= r > specified by > > + This is managing. This handle specifies = the controller > > + whose name is to be returned. > > + @param[in] ChildHandle The handle of the child controller to ret= rieve the > name > > + of. This is an optional parameter that m= ay be NULL. It > > + will be NULL for device drivers. It will= also be NULL > > + for a bus drivers that wish to retrieve t= he name of the > > + bus controller. It will not be NULL for = a bus driver > > + that wishes to retrieve the name of a chi= ld controller. > > + @param[in] Language A pointer to a three character ISO 639-2 > language > > + identifier. This is the language of the = controller name > > + that the caller is requesting, and it mus= t match one > > + of the languages specified in SupportedLa= nguages. The > > + number of languages supported by a driver= is up to the > > + driver writer. > > + @param[out] ControllerName A pointer to the Unicode string to return= . > This Unicode > > + string is the name of the controller spec= ified by > > + ControllerHandle and ChildHandle in the l= anguage specified > > + by Language, from the point of view of th= e driver specified > > + by This. > > + > > + @retval EFI_SUCCESS The Unicode string for the user-readable= name in > the > > + language specified by Language for the d= river > > + specified by This was returned in Driver= Name. > > + @retval EFI_INVALID_PARAMETER ControllerHandle is NULL. > > + @retval EFI_INVALID_PARAMETER ChildHandle is not NULL and it is not a > valid EFI_HANDLE. > > + @retval EFI_INVALID_PARAMETER Language is NULL. > > + @retval EFI_INVALID_PARAMETER ControllerName is NULL. > > + @retval EFI_UNSUPPORTED The driver specified by This is not curr= ently > managing > > + the controller specified by ControllerHa= ndle and > > + ChildHandle. > > + @retval EFI_UNSUPPORTED The driver specified by This does not > support the > > + language specified by Language. > > + > > +**/ > > +EFI_STATUS > > +EFIAPI > > +RedfishConfigHandlerComponentNameGetControllerName ( > > + IN EFI_COMPONENT_NAME_PROTOCOL *This, > > + IN EFI_HANDLE ControllerHandle, > > + IN EFI_HANDLE ChildHandle OPTIONAL, > > + IN CHAR8 *Language, > > + OUT CHAR16 **ControllerName > > + ); > > + > > +/// > > +/// Component Name Protocol instance > > +/// > > +GLOBAL_REMOVE_IF_UNREFERENCED > > +EFI_COMPONENT_NAME_PROTOCOL > gRedfishConfigHandlerComponentName =3D { > > + RedfishConfigHandlerComponentNameGetDriverName, > > + RedfishConfigHandlerComponentNameGetControllerName, > > + "eng" > > +}; > > + > > +/// > > +/// Component Name 2 Protocol instance > > +/// > > +GLOBAL_REMOVE_IF_UNREFERENCED > > +EFI_COMPONENT_NAME2_PROTOCOL > gRedfishConfigHandlerComponentName2 =3D { > > + > (EFI_COMPONENT_NAME2_GET_DRIVER_NAME)RedfishConfigHandlerComp > onentNameGetDriverName, > > + > (EFI_COMPONENT_NAME2_GET_CONTROLLER_NAME)RedfishConfigHandler > ComponentNameGetControllerName, > > + "en" > > +}; > > + > > +/// > > +/// Table of driver names > > +/// > > +GLOBAL_REMOVE_IF_UNREFERENCED > > +EFI_UNICODE_STRING_TABLE mRedfishConfigHandlerDriverNameTable[] =3D { > > + { "eng;en", (CHAR16 *)L"Redfish Configuration UEFI Driver" }, > > + { NULL, NULL } > > +}; > > + > > +GLOBAL_REMOVE_IF_UNREFERENCED EFI_UNICODE_STRING_TABLE > *gRedfishConfigHandlerControllerNameTable =3D NULL; > > + > > +/** > > + Retrieves a Unicode string that is the user-readable name of the EFI D= river. > > + > > + @param[in] This A pointer to the EFI_COMPONENT_NAME_PROTOCOL > instance. > > + @param[in] Language A pointer to a three-character ISO 639-2 langu= age > identifier. > > + This is the language of the driver name that t= he caller > > + is requesting, and it must match one of the la= nguages specified > > + in SupportedLanguages. The number of language= s supported > by a > > + driver is up to the driver writer. > > + @param[out] DriverName A pointer to the Unicode string to return. Th= is > Unicode string > > + is the name of the driver specified by This in= the language > > + specified by Language. > > + > > + @retval EFI_SUCCESS The Unicode string for the Driver specif= ied by This > > + and the language specified by Language w= as returned > > + in DriverName. > > + @retval EFI_INVALID_PARAMETER Language is NULL. > > + @retval EFI_INVALID_PARAMETER DriverName is NULL. > > + @retval EFI_UNSUPPORTED The driver specified by This does not > support the > > + language specified by Language. > > + > > +**/ > > +EFI_STATUS > > +EFIAPI > > +RedfishConfigHandlerComponentNameGetDriverName ( > > + IN EFI_COMPONENT_NAME_PROTOCOL *This, > > + IN CHAR8 *Language, > > + OUT CHAR16 **DriverName > > + ) > > +{ > > + return LookupUnicodeString2 ( > > + Language, > > + This->SupportedLanguages, > > + mRedfishConfigHandlerDriverNameTable, > > + DriverName, > > + (BOOLEAN)(This =3D=3D &gRedfishConfigHandlerComponentName) > > + ); > > +} > > + > > +/** > > + Retrieves a Unicode string that is the user readable name of the contr= oller > > + that is being managed by an EFI Driver. > > + > > + @param[in] This A pointer to the > EFI_COMPONENT_NAME_PROTOCOL instance. > > + @param[in] ControllerHandle The handle of a controller that the drive= r > specified by > > + This is managing. This handle specifies = the controller > > + whose name is to be returned. > > + @param[in] ChildHandle The handle of the child controller to ret= rieve the > name > > + of. This is an optional parameter that m= ay be NULL. It > > + will be NULL for device drivers. It will= also be NULL > > + for a bus drivers that wish to retrieve t= he name of the > > + bus controller. It will not be NULL for = a bus driver > > + that wishes to retrieve the name of a chi= ld controller. > > + @param[in] Language A pointer to a three character ISO 639-2 > language > > + identifier. This is the language of the = controller name > > + that the caller is requesting, and it mus= t match one > > + of the languages specified in SupportedLa= nguages. The > > + number of languages supported by a driver= is up to the > > + driver writer. > > + @param[out] ControllerName A pointer to the Unicode string to return= . > This Unicode > > + string is the name of the controller spec= ified by > > + ControllerHandle and ChildHandle in the l= anguage specified > > + by Language, from the point of view of th= e driver specified > > + by This. > > + > > + @retval EFI_SUCCESS The Unicode string for the user-readable= name in > the > > + language specified by Language for the d= river > > + specified by This was returned in Driver= Name. > > + @retval EFI_INVALID_PARAMETER ControllerHandle is NULL. > > + @retval EFI_INVALID_PARAMETER ChildHandle is not NULL and it is not a > valid EFI_HANDLE. > > + @retval EFI_INVALID_PARAMETER Language is NULL. > > + @retval EFI_INVALID_PARAMETER ControllerName is NULL. > > + @retval EFI_UNSUPPORTED The driver specified by This is not curr= ently > managing > > + the controller specified by ControllerHa= ndle and > > + ChildHandle. > > + @retval EFI_UNSUPPORTED The driver specified by This does not > support the > > + language specified by Language. > > + > > +**/ > > +EFI_STATUS > > +EFIAPI > > +RedfishConfigHandlerComponentNameGetControllerName ( > > + IN EFI_COMPONENT_NAME_PROTOCOL *This, > > + IN EFI_HANDLE ControllerHandle, > > + IN EFI_HANDLE ChildHandle OPTIONAL, > > + IN CHAR8 *Language, > > + OUT CHAR16 **ControllerName > > + ) > > +{ > > + return EFI_UNSUPPORTED; > > +} > > diff --git a/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.c > b/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.c > index 2d0170d88614..5e03132695d6 100644 > --- a/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.c > +++ b/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.c > @@ -601,11 +601,17 @@ RedfishConfigHandlerDriverEntryPoint ( > // > > // Install UEFI Driver Model protocol(s). > > // > > - Status =3D EfiLibInstallDriverBinding ( > > + Status =3D EfiLibInstallAllDriverProtocols2 ( > > ImageHandle, > > SystemTable, > > &gRedfishConfigDriverBinding, > > - ImageHandle > > + ImageHandle, > > + &gRedfishConfigHandlerComponentName, > > + &gRedfishConfigHandlerComponentName2, > > + NULL, > > + NULL, > > + NULL, > > + NULL > > ); > > if (EFI_ERROR (Status)) { > > gBS->CloseEvent (gEndOfDxeEvent); > > diff --git a/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.h > b/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.h > index 07214875bd5a..51701c05c697 100644 > --- a/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.h > +++ b/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.h > @@ -24,7 +24,9 @@ > // > > // Protocol instances > > // > > -extern EFI_DRIVER_BINDING_PROTOCOL gRedfishConfigDriverBinding; > > +extern EFI_DRIVER_BINDING_PROTOCOL gRedfishConfigDriverBinding; > > +extern EFI_COMPONENT_NAME_PROTOCOL > gRedfishConfigHandlerComponentName; > > +extern EFI_COMPONENT_NAME2_PROTOCOL > gRedfishConfigHandlerComponentName2; > > > > extern REDFISH_CONFIG_DRIVER_DATA gRedfishConfigData; > > extern EDKII_REDFISH_CREDENTIAL_PROTOCOL *gCredential; > > diff --git a/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.i= nf > b/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.inf > index aed93f570cf9..40ce0561379f 100644 > --- a/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.inf > +++ b/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.inf > @@ -30,6 +30,7 @@ > RedfishPkg/RedfishPkg.dec > > > > [Sources] > > + ComponentName.c > > RedfishConfigHandlerDriver.h > > RedfishConfigHandlerDriver.c > > RedfishConfigHandlerCommon.h > > -- > 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112622): https://edk2.groups.io/g/devel/message/112622 Mute This Topic: https://groups.io/mt/103181041/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-