From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.41]) by mx.groups.io with SMTP id smtpd.web08.5017.1662969358879619056 for ; Mon, 12 Sep 2022 00:55:59 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=ZO1kzGR6; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.236.41, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GhfI+lvO1WkGL91HgG36ip6Ni4sG8Grlkzx5w5dADP1XhUHrAxagBia+mjvORDWENElec+L6j0RTvLlU33IMYgnv9F2baVjZKYNpVCHndpsKu84wFdxvO2iMCnIitJLWT5fET7QjirbyQrCbE6a9Q0XQrOlFmNSPju2EYbuaH7tybXmRbSil+t6aA9j7WEfkBbaOyNzCgiYN7sbwMb+h9X0qhI694BLSQEZZ8tFRs/I4HUiCXY1n0tKz1fzZ0YA4A8QHhgOZAAMS/9BKiTRBLUGWYxvBbO+AgQtzhYVId33SYWVJdLvDLKEZxMnL7YCTcTGVA2tzimiuhaQ5Fba6Dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SXR5IE1ds9a+9G3tbHi/oqvzipJ6Wp1FyJ2qdMCqvm0=; b=QfiG4gVAFMS83an8anTcmqVVZvztXMwEDcrrmSZlP0VOVuqDSfuLPDPZFG0iqVuDGPUUhOvNBQr3RmpgTIfvvXYtv/KTqsc6TowG5zJ2lu/1mhDfFdNPQgRV3TnUr/x9RR65O9hY8ChEkyVY+c8Xul48n35O4GmQ6MMNmAPhV+PjvhpQVI0L89LdV8xqkLiZMaZPVwBaKP+9fEd5+9ro5yV2KwoT5dstsOalNXIlYKmY4rBffsZFuIqMVJh0GJNbeoISnl/gagxckLIJItWJNc4KGi1ttuK4n9fiKRUOo43h3xX3erc4Oyw7jSuN//twDm9daw4F3S2deL9pTaKbVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SXR5IE1ds9a+9G3tbHi/oqvzipJ6Wp1FyJ2qdMCqvm0=; b=ZO1kzGR6tO2piNbew81bbrebohTeQZEB06XA0AEiJd8V3BXo7GRi+Pjad7nqV+rs9O/BcrY/KeosZwiGsPfx674CfRoTz84RTU1Ms3NwdNK4LbXw1KxTgSnFfIjX4QII/I9pd3UFd/+IDqZ9nnsfoMid4M7CKoPOJNvUNMQQ7o4= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by CH0PR12MB5281.namprd12.prod.outlook.com (2603:10b6:610:d4::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Mon, 12 Sep 2022 07:55:56 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::9c44:17db:7f29:1fa8]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::9c44:17db:7f29:1fa8%7]) with mapi id 15.20.5612.022; Mon, 12 Sep 2022 07:55:56 +0000 From: "Chang, Abner" To: =?iso-2022-jp?B?UmljaGFyZEhvIFsbJEIyP0xAQ2kbKEJd?= , "devel@edk2.groups.io" , "quic_rcran@quicinc.com" CC: Andrew Fish , Leif Lindholm , Michael D Kinney , Michael Kubacki , Zhiguang Liu , Liming Gao , =?iso-2022-jp?B?VG9ueUxvIFsbJEJNZTZiPj4bKEJd?= Subject: Re: [edk2-devel] [PATCH] UsbNetworkPkg: add USB network devices support Thread-Topic: [EXTERNAL] RE: [edk2-devel] [PATCH] UsbNetworkPkg: add USB network devices support Thread-Index: AQHYvoxJHCaS+XfGmkKn0h/vNPlrZ63MrkMAgAoAM9CABHir8IAATFFw Date: Mon, 12 Sep 2022 07:55:55 +0000 Message-ID: References: <20220902052418.2253-1-richardho@ami.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2022-09-12T07:55:52Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=1f56ead5-c03e-484c-9b09-88011bb4db9f; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|CH0PR12MB5281:EE_ x-ms-office365-filtering-correlation-id: 38a38b08-0481-4617-645f-08da9494391a x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ZND9mkw1tQ8vncm6dOuBvz2k24Op8cPO2ScQjVyBZA9stFIuvn08X+HPqKn8somXEQ0qNL5Bb6QXjXSfM5w+WD+2O8z4BQXvvu1v42xqW/1BHDYYfjFMV9Rph9d9hOy4Y5Axxi65/jbavemd8czMS2utJTVLPq1puTbkzBLLBa+1h8K3U8yB6+tdTAt5wyyQdnbHqMAD9sQAwBhmCmtV0W0qip0wc6256pBsdb2mEA0M9SDa3lqRCdymxuR9MSs2WmL3bEoLoh5bwyqmu3JUgtIc/E4i3t3B+o6cDy4IQdaURWko2YERNOjY+1KyJLZVTJL4vh4f+HPaClt5JQ545wfGs86R3lXkEFhIvIQOa86AZm176OZi7818clg2b5sbYc9ui0Xbh3acEAyYIGGq04K1WWVNwik/QWaOqf0UoGK8qo8EJ85bISD5vLsbSftr+heKAhltMQb9Y5YELGDFploUTiLVcIKV93aURfgzk/n3cMCyeD6qIef62bqRXfZCzOUIViinsUIw+JYpB4MF5gNsvUbkWlT2b05SUmTxxuE36SQuSKuD2X7I0s+6DGmytLM8S7Z4DiKn8IKK7BmPUPOsTo7U+he5RrUGmyPsFmByi4CzUrw8DDb9Vt64Bptl1dw3K1aabcCicQEHXTAtI9jCUNlpuwXY5JSeh41G6MrLMz+ukLxfq3niKNE/LM1tFo5EMQmZL90vLIfu9COX768n2c2jEhJxCX62IqFe4P/+vB4tP+8TAVwYWH8TNRzTe87+T/Hjh68f4LTHnS2FOAHehbzW8tnxlEdgyqDc7zE= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(346002)(376002)(39860400002)(366004)(136003)(6506007)(186003)(30864003)(2906002)(5660300002)(8936002)(76116006)(52536014)(4326008)(7416002)(8676002)(64756008)(66446008)(66556008)(66476007)(66946007)(53546011)(7696005)(86362001)(33656002)(40140700001)(83380400001)(55016003)(41300700001)(26005)(478600001)(9686003)(966005)(38070700005)(122000001)(110136005)(54906003)(71200400001)(45080400002)(316002)(38100700002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-2022-jp?B?SDlkNHJvSEZyZWxsZWlDNTJaMWZuckpqN3VRT0cvOEdrUkY2Z1RVTVJO?= =?iso-2022-jp?B?cFRkYkkwVzFHUGZlbXl3aUZ4aUdIQ0N4a3NOQjVOblliS0JIZmQxdUpI?= =?iso-2022-jp?B?Y1c3QWpLOTF3aWdaQ1pEZmsyc2pmZ2NoN1g4NXRrUVkyR0tiVXpJVm5S?= =?iso-2022-jp?B?ZG9KOGFzc0xxeU1VR3U0T1dwbjJVYjlnakpMMTBEWXVhUGIrVGhLdVVU?= =?iso-2022-jp?B?NVFyVnFSVmZVY3JnOTdTYXlZYkpXRFdVN0srdzg5RGN4VnJoWkF2ejZq?= =?iso-2022-jp?B?VFBNemtQRmRWUkdxMS9USEphSmxjbkRWbHlrMjcwTGxTbm4xT1BMTWVM?= =?iso-2022-jp?B?NjhDV2NqVFlCVHBhTVF5azhkbkJJTWRKaG05SGYvOUFQdlVHNDBMK1NB?= =?iso-2022-jp?B?b1M2cjNMWXZDQnhtYjBXZjBlY2RZM0JmZmZpN2ZTN3NUcENBU3BYaHIx?= =?iso-2022-jp?B?Q25YcTl6NEJzME5zRXpDR0xCcVgrZFRNOFo0N1JoSjlsekNNN214UDVB?= =?iso-2022-jp?B?d2FqZDhGNHdZb3o3WVkyYzFXVG1hMjR4d0loVDIwVHpuT0hYRjVtalJZ?= =?iso-2022-jp?B?cnB0dDVxSUJrbUZXaTBNT1hUMEc4bGg4WXRxSmpZbmJUYzV4dHhQNkFU?= =?iso-2022-jp?B?VFBZeTQvcFZQM1BuZFJhdi9TbE5HNXdYWnBiWFdWTWhvREk1V1ZKUkZG?= =?iso-2022-jp?B?Yngyd00vbGNxNWV2aW02SDNhQjNmS0xBRC9oV2d4MjU1T3V3bjlZbzN0?= =?iso-2022-jp?B?SlFMRUFaYTZrTE41Y2tuRWhoUGszK2FvcUM5WU5HcWVTbmxkOFQ0NU9m?= =?iso-2022-jp?B?czdlOWRyUWhXMW5GV2NDR0dLeVNSQXRGTUtYRkxOMmdaS0RvZ25qR3lp?= =?iso-2022-jp?B?UFVvQ25qZzRZaXVjbFNOUzljaVlOc2pjc21BZ3dUajZvb3QrTGlDRFds?= =?iso-2022-jp?B?c2FSdWtZcGF2aHY4Z0o1cCtKTVFyVVI3dTcwZjUvdHArQ3RUL2c4WFdC?= =?iso-2022-jp?B?Q3FUdXQ4a09BR1ZwZWQxc0JHZnRXUkk0azFLTkpENFpPTHJGWlZUT0RZ?= =?iso-2022-jp?B?aVA4OWpNL0owNTh6cy96Uy9QTW9CTk1oYStsYmI5Tm51SGIrcmEwZmM3?= =?iso-2022-jp?B?emFWV2ZRbGFxZitpSkw4bkFQOHdJUW5jZ1Z6bU5MaFJNT2FTK2loRHJJ?= =?iso-2022-jp?B?YjVaUlViRFcxZmt0cUpid3BxbkUvOTRSemRkdnV0NnkzMkNYQ0JxNm9q?= =?iso-2022-jp?B?UGV0aTRJWE02MEdHWS9SbzJxWE9ZTmgvMWlPLzlHUFlXL3Y0K0J1S1o3?= =?iso-2022-jp?B?bUNscmJKaEM0MHVsY0pJSFBzTzZ4OXVScjhCWGEySWVRZ0dJSCtSK1Iv?= =?iso-2022-jp?B?eFZ0TDhIajNQeG90dk1GdUlRTUFTcFJjc0VEVFBXSG5HTWdLbldXZjla?= =?iso-2022-jp?B?aG44LzVqbXZxSnRQMmlWdi9sdVB4RjJleEVaY2ZLdDhOeXM1ZzBCaXVE?= =?iso-2022-jp?B?OFV6amlDR3FXc3kvMUZvdTZGK3d0RWZ6b1NyUldTRTFlRzJSWVVadk9l?= =?iso-2022-jp?B?MkRJNmNhdlFnVThIeUE0L3l1eEVNS0JxZHpBM1BiY1NSLytYTmV1ZWVt?= =?iso-2022-jp?B?THVhLzVEYWpYUHN3T2hJQmZVeUlzeTkzME13SVRoM0l0djRNdW45ZjNE?= =?iso-2022-jp?B?QjZlQUtxRU1waXR2b21leVpFT3NieUM1Z1hlTjMvUEVsU05DQzRkT3I5?= =?iso-2022-jp?B?Wk8rK1ZKKy8yYk5xOU5oQm1SRUlLZXdNc2hyZUE0ZldRUkhxcUtyTlZj?= =?iso-2022-jp?B?dUpuVHB3NTBPRTBVWk5GbWM0bDFBQ1lPK2RVR0UxMFpHWjAyZmVoRnVP?= =?iso-2022-jp?B?ajk3a1pPWjNCTTRBOGx2Mk15T2ZqS2sxSVNMVVNBVnZIVWZXK1l1ajNT?= =?iso-2022-jp?B?OUpVTnpucjhBTGpNZVpaWFZyM2g3d0VvZ2xYZFYrb2RkakN2TWhCZzZ6?= =?iso-2022-jp?B?TkxQT1RhYXlpV2tZZ2NrM3ZndjlIOWFQOHJ3QS9sVnVzY3QvZDhOYWFX?= =?iso-2022-jp?B?c1MveXZnb3A2b2VIZHBWR2pabmE4cU9CckM4TVYzcXhEaTNFY2ovWUx3?= =?iso-2022-jp?B?OUVHZkhXU1R6Sk9jZGtmVERXaXRHamErSEJEZWcwZzdwVDRuZERrU0l5?= =?iso-2022-jp?B?cER6VlhodDRiemtiNENCZnVqRVBiU244TEliM2NFc3M4Ti9aS0NkT3o0?= =?iso-2022-jp?B?REFDdHFOajFobkluOVJJOVlBNWtBMzIxYz0=?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 38a38b08-0481-4617-645f-08da9494391a X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Sep 2022 07:55:55.9823 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JGELymtlEUUhxzwO8dYqvHiE4VZ7CUy1wa4/Mk13jVDUmrSTXI22lZqU3lLa4r0SXjXmRvwoZIaQiZMkU39qnw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5281 Content-Language: en-US Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Hi Richard, thanks for the reply. My feedback in line below, > -----Original Message----- > From: RichardHo [=1B$B2?L@Ci=1B(B] > Sent: Monday, September 12, 2022 11:48 AM > To: Chang, Abner ; devel@edk2.groups.io; > quic_rcran@quicinc.com > Cc: Andrew Fish ; Leif Lindholm > ; Michael D Kinney > ; Michael Kubacki > ; Zhiguang Liu ; > Liming Gao ; TonyLo [=1B$BMe6b>>=1B(B] > > Subject: RE: [EXTERNAL] RE: [edk2-devel] [PATCH] UsbNetworkPkg: add USB > network devices support >=20 > [CAUTION: External Email] >=20 > Hi Abner, >=20 > Ans #1. I think the USB network feature is better in the UsbNetworkPkg. I= t is > easy to control USB network stack in this package. > The package is same as NetworkPkg(The NetworkPkg gathers al= l > network stack features). The UsbNetworkPkg could gather the USB network > stack. UsbNetworkPkg has the feature that overlaps with Bus\Usb and \NetworkPkg in= my opinion, that is the reason I think we can have these modules in the ex= isting package. Plus as I know from the edk2 community view point, we only = create a new package when necessary for a totally new feature. However, thi= s is at the discretion of edk2 stewards. You can confirm this with them. > Ans #2. OK. I will rename it next. > Ans #4 Other driver could use EFI_OPEN_PROTOCOL_BY_DRIVER with > USB_ETHERNET_PROTOCOL to own on the specific USB CDC device. > But, the specific USB CDC driver need to install the bindin= g driver > before NetworkCommon driver. My question was USB_ETHERNET_PROTOCOL is designed as an abstract protocol, = with this the underlying transport (UsbIo or PciIo) is agnostic to the uppe= r layer driver. Upper layer driver (e.g., USB_ETHERNET_PROTOCOL based SNP d= river) can check whether USB_ETHERNET_PROTOCOL is installed on the given Co= ntroller handle at Supported() function. However, seems the upper layer dri= ver has no way to distinguish the USB CDC driver interface class if I read = your code right; then manages the right device (in the case of multiple USB= CDC devices are attached to the system). We can either attach USB Class De= vice Path to the device path in Usb CDC driver or provide a function to ret= rieve the USB CDC interface class/subclass/protocol via USB_ETHERNET_PROTOC= OL. I would prefer the former one. Thanks Abner > Ans #5 NetworkCommon driver build a Mac device path that link PciIo devi= ce > path. > So, SNP driver could found PciIo device path when NetworkCo= mmon > driver to install the EFI_NETWORK_INTERFACE_IDENTIFIER_PROTOCOL. >=20 > Thanks, > Richard >=20 > -----Original Message----- > From: Chang, Abner > Sent: 2022=1B$BG/=1B(B9=1B$B7n=1B(B9=1B$BF|=1B(B 3:07 PM > To: devel@edk2.groups.io; quic_rcran@quicinc.com; RichardHo [=1B$B2?L@Ci= =1B(B] > > Cc: Andrew Fish ; Leif Lindholm > ; Michael D Kinney > ; Michael Kubacki > ; Zhiguang Liu ; > Liming Gao ; TonyLo [=1B$BMe6b>>=1B(B] > > Subject: [EXTERNAL] RE: [edk2-devel] [PATCH] UsbNetworkPkg: add USB > network devices support >=20 >=20 > **CAUTION: The e-mail below is from an external source. Please exercise > caution before opening attachments, clicking links, or following guidance= .** >=20 > [AMD Official Use Only - General] >=20 > Hi Richard, > That is pretty hard to give the in-line comment in this huge patch email.= You > would be also hard to find the comments given to each module or the > protocol header file. > So fist all of, please organize your change into several patches. For exa= mple, > 1. UsbEthernetProtocol.h 2. UsbRndis module 3. UsbCdcNcm module 4. > UsbCdcEcm module 5. NetworkCommon module >=20 > Some rough feedbacks to this change before I giving the comments to each > patch after you resending the new patch set. > 1. I suggest having UsbNetwork folder under MdeModulePkg/Usb/. Then > under UsbNetwork, you can have those four USB network related modules. > However, we can Rename NetwrokCommon to UsbNetwork if your are ok > with it. > 2. UsbEhernetProtocol is not an EFI protocol, so please add EdkII as the = prefix > to UsbEthernetProtocol, it would be EdkIIUsbEthernetProtocol. And we can > have UsbEthernetProtocol.h under MdeModulePkg/Include/Protocol 4. > From this change, NetwrokCommon driver listens to > USB_ETHERNET_PROTOCOL and install EFI NII protocol for each instance. > However, the upper layer driver wouldn't know the CDC interface > class/subclass/protocol if it only listen to USB_ETHERNET_PROTOCOL and > install its own SNP on the specific USB CDC device; in the case if there = are > multiple USB CDC devices attached on the system. Is my understanding > correct? > 5. I don=1B$B!G=1B(Bt see the UsbEthernetProtocol based SNP protocol is i= nstalled and > the SNP driver under NetworkPkg has the dependency with PciIo. Do we > have to implement UsbEthernetProtocol based SNP by our own? >=20 > I will check the functionality on our platform if I get the chance. > Thanks > Abner >=20 >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of > Rebecca > > Cran via groups.io > > Sent: Saturday, September 3, 2022 5:48 AM > > To: devel@edk2.groups.io; richardho@ami.com > > Cc: Andrew Fish ; Leif Lindholm > > ; Michael D Kinney > > ; Michael Kubacki > > ; Zhiguang Liu > > ; Liming Gao ; > > TonyLo [=1B$BMe6b>>=1B(B] > > > > Subject: Re: [edk2-devel] [PATCH] UsbNetworkPkg: add USB network > > devices support > > > > [CAUTION: External Email] > > > > I've pushed this patch to a branch at > > > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fnam > 1 > > > 2.safelinks.protection.outlook.com%2F%3Furl%3Dhttps%253A%252F%252Fn > am1 > > > &data=3D05%7C01%7CAbner.Chang%40amd.com%7C92e0dc34ec2a4c9a9f > 6908da94 > > > 71a29e%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C63798551306 > 1024727 > > > %7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiL > CJBTiI6I > > > k1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3D78%2FyX9SBP > 4wrftOYrmnP > > muF5e%2F3NsmqY7JVw4atcoGM%3D&reserved=3D0 > > > 1.safelinks.protection.outlook.com%2F%3Furl%3Dhttps%253A%252F%252Fgi > th > > > &data=3D05%7C01%7Crichardho%40ami.com%7C1ffd2a8dbf6f4cda9da908 > da9231 > > > e426%7C27e97857e15f486cb58e86c2b3040f93%7C1%7C0%7C63798304023249 > 3161%7 > > > CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJ > BTiI6Ik1 > > > haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3DXK3dw8vGMtln2 > Ig6Rcieyw6l > > orLdsvy2Oko9gAllSK0%3D&reserved=3D0 > > ub.com%2Fbcran%2Fedk2%2Ftree%2Fusb- > > > net&data=3D05%7C01%7Cabner.chang%40amd.com%7C2c812dc15b9542b > > > 8a64308da8d2cdf2b%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C > > > 637977521120662673%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwM > > > DAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7 > > > C&sdata=3DZFcSw3AL0MnljvyODrv1dYAL8LuadwCYe65xhE1hXWY%3D&a > > mp;reserved=3D0 . > > > > -- > > Rebecca Cran > > > > On 9/1/22 23:24, RichardHo [=1B$B2?L@Ci=1B(B] via groups.io wrote: > > > UsbNetworkPkg provides network functions for USB ACM, USB NCM, > and > > USB > > > RNDIS network device. > > > > > > Signed-off-by: Richard Ho > > > Cc: Andrew Fish > > > Cc: Leif Lindholm > > > Cc: Michael D Kinney > > > Cc: Michael Kubacki > > > Cc: Zhiguang Liu > > > Cc: Liming Gao > > > Reviewed-by: Tony Lo > > > --- > > > UsbNetworkPkg/Config/UsbNetworkPkg.inc.dsc | 9 + > > > .../Config/UsbNetworkPkgComponentsDxe.inc.dsc | 20 + > > > .../Config/UsbNetworkPkgComponentsDxe.inc.fdf | 20 + > > > .../Config/UsbNetworkPkgDefines.inc.dsc | 23 + > > > .../Include/Protocol/UsbEthernetProtocol.h | 872 +++++++++ > > > UsbNetworkPkg/NetworkCommon/ComponentName.c | 264 +++ > > > UsbNetworkPkg/NetworkCommon/DriverBinding.c | 583 ++++++ > > > UsbNetworkPkg/NetworkCommon/DriverBinding.h | 263 +++ > > > UsbNetworkPkg/NetworkCommon/NetworkCommon.inf | 43 + > > > UsbNetworkPkg/NetworkCommon/PxeFunction.c | 1734 > > +++++++++++++++++ > > > UsbNetworkPkg/ReadMe.md | 65 + > > > UsbNetworkPkg/ReleaseNotes.md | 11 + > > > UsbNetworkPkg/UsbCdcEcm/ComponentName.c | 170 ++ > > > UsbNetworkPkg/UsbCdcEcm/UsbCdcEcm.c | 504 +++++ > > > UsbNetworkPkg/UsbCdcEcm/UsbCdcEcm.h | 211 ++ > > > UsbNetworkPkg/UsbCdcEcm/UsbCdcEcm.inf | 41 + > > > UsbNetworkPkg/UsbCdcEcm/UsbEcmFunction.c | 861 ++++++++ > > > UsbNetworkPkg/UsbCdcNcm/ComponentName.c | 170 ++ > > > UsbNetworkPkg/UsbCdcNcm/UsbCdcNcm.c | 508 +++++ > > > UsbNetworkPkg/UsbCdcNcm/UsbCdcNcm.h | 245 +++ > > > UsbNetworkPkg/UsbCdcNcm/UsbCdcNcm.inf | 41 + > > > UsbNetworkPkg/UsbCdcNcm/UsbNcmFunction.c | 946 +++++++++ > > > UsbNetworkPkg/UsbNetworkPkg.dec | 32 + > > > UsbNetworkPkg/UsbRndis/ComponentName.c | 172 ++ > > > UsbNetworkPkg/UsbRndis/UsbRndis.c | 848 ++++++++ > > > UsbNetworkPkg/UsbRndis/UsbRndis.h | 569 ++++++ > > > UsbNetworkPkg/UsbRndis/UsbRndis.inf | 41 + > > > UsbNetworkPkg/UsbRndis/UsbRndisFunction.c | 1587 > > +++++++++++++++ > > > 28 files changed, 10853 insertions(+) > > > create mode 100644 UsbNetworkPkg/Config/UsbNetworkPkg.inc.dsc > > > create mode 100644 > > UsbNetworkPkg/Config/UsbNetworkPkgComponentsDxe.inc.dsc > > > create mode 100644 > > UsbNetworkPkg/Config/UsbNetworkPkgComponentsDxe.inc.fdf > > > create mode 100644 > > UsbNetworkPkg/Config/UsbNetworkPkgDefines.inc.dsc > > > create mode 100644 > > UsbNetworkPkg/Include/Protocol/UsbEthernetProtocol.h > > > create mode 100644 > > UsbNetworkPkg/NetworkCommon/ComponentName.c > > > create mode 100644 UsbNetworkPkg/NetworkCommon/DriverBinding.c > > > create mode 100644 UsbNetworkPkg/NetworkCommon/DriverBinding.h > > > create mode 100644 > > UsbNetworkPkg/NetworkCommon/NetworkCommon.inf > > > create mode 100644 UsbNetworkPkg/NetworkCommon/PxeFunction.c > > > create mode 100644 UsbNetworkPkg/ReadMe.md > > > create mode 100644 UsbNetworkPkg/ReleaseNotes.md > > > create mode 100644 UsbNetworkPkg/UsbCdcEcm/ComponentName.c > > > create mode 100644 UsbNetworkPkg/UsbCdcEcm/UsbCdcEcm.c > > > create mode 100644 UsbNetworkPkg/UsbCdcEcm/UsbCdcEcm.h > > > create mode 100644 UsbNetworkPkg/UsbCdcEcm/UsbCdcEcm.inf > > > create mode 100644 UsbNetworkPkg/UsbCdcEcm/UsbEcmFunction.c > > > create mode 100644 UsbNetworkPkg/UsbCdcNcm/ComponentName.c > > > create mode 100644 UsbNetworkPkg/UsbCdcNcm/UsbCdcNcm.c > > > create mode 100644 UsbNetworkPkg/UsbCdcNcm/UsbCdcNcm.h > > > create mode 100644 UsbNetworkPkg/UsbCdcNcm/UsbCdcNcm.inf > > > create mode 100644 UsbNetworkPkg/UsbCdcNcm/UsbNcmFunction.c > > > create mode 100644 UsbNetworkPkg/UsbNetworkPkg.dec > > > create mode 100644 UsbNetworkPkg/UsbRndis/ComponentName.c > > > create mode 100644 UsbNetworkPkg/UsbRndis/UsbRndis.c > > > create mode 100644 UsbNetworkPkg/UsbRndis/UsbRndis.h > > > create mode 100644 UsbNetworkPkg/UsbRndis/UsbRndis.inf > > > create mode 100644 UsbNetworkPkg/UsbRndis/UsbRndisFunction.c > > > > > > > >=20 > > > -The information contained in this message may be confidential and > proprietary to American Megatrends (AMI). This communication is intended > to be read only by the individual or entity to whom it is addressed or by= their > designee. If the reader of this message is not the intended recipient, yo= u are > on notice that any distribution of this message, in any form, is strictly > prohibited. Please promptly notify the sender by reply e-mail or by > telephone at 770-246-8600, and then delete or destroy all copies of the > transmission.