Re: [PATCH v1 1/2] DynamicTablesPkg: Define a SMBIOS Structure/Table type

["Chang, Abner" <abner.chang@amd.com>]

[AMD Official Use Only - General]

Acked-by: Abner Chang <abner.chang@amd.com>

> -----Original Message-----
> From: Sami Mujawar <sami.mujawar@arm.com>
> Sent: Tuesday, October 18, 2022 11:34 PM
> To: devel@edk2.groups.io
> Cc: Sami Mujawar <sami.mujawar@arm.com>; Alexei.Fedorov@arm.com;
> pierre.gondois@arm.com; gmahadevan@nvidia.com; Chang, Abner
> <Abner.Chang@amd.com>; jbrasen@nvidia.com; ashishsingha@nvidia.com;
> nramirez@nvidia.com; wwatson@nvidia.com; Matteo.Carlini@arm.com;
> Akanksha.Jain2@arm.com; Ben.Adderson@arm.com; Samer.El-Haj-
> Mahmoud@arm.com; nd@arm.com
> Subject: [PATCH v1 1/2] DynamicTablesPkg: Define a SMBIOS Structure/Table
> type
> 
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
> 
> 
> SMBIOS Structure Types 0 through 127 (7Fh) are reserved for and defined by
> the SMBIOS specification. Types 128 through 256 (80h to FFh) are available
> for system and OEM-specific information.
> 
> Therefore, define a new type 'SMBIOS_TABLE_TYPE' that represents a
> SMBIOS structure type and include it in the definition of
> CM_STD_OBJ_SMBIOS_TABLE_INFO.
> 
> Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Alexei Fedorov <Alexei.Fedorov@arm.com>
> Cc: Pierre Gondois <pierre.gondois@arm.com>
> Cc: Girish Mahadevan <gmahadevan@nvidia.com>
> Cc: Jeff Brasen <jbrasen@nvidia.com>
> Cc: Ashish Singhal <ashishsingha@nvidia.com>
> Cc: Nick Ramirez <nramirez@nvidia.com>
> Cc: William Watson <wwatson@nvidia.com>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>
> ---
>  DynamicTablesPkg/Include/StandardNameSpaceObjects.h | 17
> +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/DynamicTablesPkg/Include/StandardNameSpaceObjects.h
> b/DynamicTablesPkg/Include/StandardNameSpaceObjects.h
> index
> 8ec3238225abe4fc16a7337c29ecd655590b408f..c81efbc237779c305abc3c4dd0
> 7f6b705563e2a1 100644
> --- a/DynamicTablesPkg/Include/StandardNameSpaceObjects.h
> +++ b/DynamicTablesPkg/Include/StandardNameSpaceObjects.h
> @@ -40,6 +40,20 @@
>  **/
>  typedef UINTN CM_OBJECT_TOKEN;
> 
> +/**
> +  A type representing a SMBIOS structure/table type.
> +
> +  Types 0 through 127 (7Fh) are reserved for and defined by the  SMBIOS
> + specification.
> +  Types 128 through 256 (80h to FFh) are available for system and
> + OEM-specific information.
> +
> +  Note: This Dynamic SMBIOS table generation implementation defines
> +  TableType FFh as a NULL table which is used by the Dynamic
> +  SMBIOS table dispatcher to terminate the dependency sequence.
> +*/
> +typedef UINT8 SMBIOS_TABLE_TYPE;
> +
>  /** The ESTD_OBJECT_ID enum describes the Object IDs
>      in the Standard Namespace.
>  */
> @@ -127,6 +141,9 @@ typedef struct CmAStdObjAcpiTableInfo {
>    to NULL.
>  */
>  typedef struct CmStdObjSmbiosTableInfo {
> +  /// SMBIOS Structure/Table Type
> +  SMBIOS_TABLE_TYPE            TableType;
> +
>    /// The SMBIOS Table Generator ID
>    SMBIOS_TABLE_GENERATOR_ID    TableGeneratorId;
> 
> --
> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'