From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.62]) by mx.groups.io with SMTP id smtpd.web10.1956.1666659416544841054 for ; Mon, 24 Oct 2022 17:56:56 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=Z+2JMKKd; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.220.62, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L0aXdXrDhaadZzFxkCN6N+nEcu8hDZDzZ/UMLuRbkmrFGG6DPaVopaMhG/OrIsavJcu6UW1jIbiBzKKaPBdq6AL9UzVq8hIQ3aWZeA0tD2QduUrM+eCw/W+CQEHX+dPOFIPeEsGwx0Vugnp/vUkYnEOTJX32rJtxwD4h58zGrOh31G9eMSSoqsoztyWanEoJrXKGHziFd+gYyjqZyjRTnED/4QwvnyI0ZyQ6gN+y12vnp6IgOp2XFTLVHkQHJeOuS0UYNXB8gZAIRHMef1Jmck+0BSfRzSUMbL15fML3oE9MOf0qWUhZ+80osNUfYygXf9FjQGrwCtesjtl3+LSzLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yfiX1H2p6YIFD5eGOunDqrMLdN8FRzfDol/oc9bYZ78=; b=O3v4R2DB/metYILCur3YhlrJQQMv5K8ej/SQpwNFbIsr8WKcBen0mmm+S+G55L9DBb4tRLyFPWIQ0hkT2WkrCKRj1wLoBlE4R8dbGZLYqS2qzdBUgwSg3OHgSQWVmDQaa7dZHUrTTLQQ9IymRViZysucFwA7eOmzRToEBH/bJOqzDFKa6fUHWr/dKebOXOzCxq1xclDlXRYgcFHR8IVf3oc08leSFlxv6hg5IOLqDrzuM1C+L/X67P6o0ROkJD88zjNwZhUajx1e3PgMa3xgj3Q3BSk6G02mLbaJFmgfu/qScSqLkmasPf8iBOT1thbajMURCUtqG/DtVXQ1KR+djQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yfiX1H2p6YIFD5eGOunDqrMLdN8FRzfDol/oc9bYZ78=; b=Z+2JMKKdhE7JdKDE5DiTk05ivLG9QUCA7d0Jt6JTaG4G/yC9WXhPZwHQmSMCQgwBrc1pj4SAt1VasNLPLEm4J8rgVo/N/JW8A//FDSix2WPvU3xz47wCtiUfAghGsznzq1FvEvaB0kxdyb1jVn21KJAny44SqEgFpMUpmy+FDI8= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by CY8PR12MB7146.namprd12.prod.outlook.com (2603:10b6:930:5e::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.33; Tue, 25 Oct 2022 00:56:53 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::2eab:b851:827c:1d88]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::2eab:b851:827c:1d88%3]) with mapi id 15.20.5746.028; Tue, 25 Oct 2022 00:56:51 +0000 From: "Chang, Abner" To: Sami Mujawar , "devel@edk2.groups.io" CC: "Alexei.Fedorov@arm.com" , "pierre.gondois@arm.com" , "gmahadevan@nvidia.com" , "jbrasen@nvidia.com" , "ashishsingha@nvidia.com" , "nramirez@nvidia.com" , "wwatson@nvidia.com" , "Matteo.Carlini@arm.com" , "Akanksha.Jain2@arm.com" , "Ben.Adderson@arm.com" , "Samer.El-Haj-Mahmoud@arm.com" , "nd@arm.com" Subject: Re: [PATCH v1 1/2] DynamicTablesPkg: Define a SMBIOS Structure/Table type Thread-Topic: [PATCH v1 1/2] DynamicTablesPkg: Define a SMBIOS Structure/Table type Thread-Index: AQHY4wcNElgyCju6qECtzp45DyiX864eU0FA Date: Tue, 25 Oct 2022 00:56:51 +0000 Message-ID: References: <20221018153344.16876-1-sami.mujawar@arm.com> <20221018153344.16876-2-sami.mujawar@arm.com> In-Reply-To: <20221018153344.16876-2-sami.mujawar@arm.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2022-10-25T00:56:49Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=a4e5a6ad-0f5b-45f2-a239-a3f35eac73dc; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|CY8PR12MB7146:EE_ x-ms-office365-filtering-correlation-id: ee6b06e9-f1ed-4e80-660c-08dab623cdb4 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: owXoT0wILbS5cqHuSpkvr2RRpy1vqwecyJ64zIhdsexXP8jp6pa2lAkr6Zc0K7YfMUnJ8YYPqJEeQ2aPNl/CC9e3riVTWWoIO6YEW9OU9tYa09CQcLsLsc1b9A7+QOTtZfx7FH7vZQ4SPlfnloI7Vevd+AxKMAD+gwBQbmtdFOJOD515ZeLHEsu4AaIwa7daG6b5uA5L7sk0l7SvVfxT43g/2NWWaJaQkHqgVUm+HRKIA0annSQWj6diXbEQ+mpGFtZ8JZO0+9JWylttHt/3ePR5AniWcXmey00nkFAZeiHr2CcLFL8q24iblrY3UQzPBcyUghLVYGWw8XoCeM8UVNOZey5hQUJr0CFXkEgbYeCHOdkviJa/Hf9t/6sKlVDNDUrDxFnnBWr8ZYxX+z5QkOcb3qqF1okjFycL1raGO+H60YUFzgIE1sHXeXBZUpbJwhQtyJxxDBWjQHFbUreupYeNX4TpVqTWHRZULYsWiJwEx2jcZLYqv2JOSe3tz+ezEMHKZfbSpZZSRWZrBFI1OBzfNGwUwMFerGr9d1qaMHU9K9u+dxEM0vMKILsLoENiwceM0zW4QRrixj6V83sIEp3YxXOYWR3DEnUTj7+JXwZzk3ShSce2gPnZS3uw9NMo+ruLvAi+cSDw38mCBsV4YEJGOjKldVEl/vKC18e4IJKB3kiIQHy2CTKYQ3HbCDMTEwt5jMdpC1+iPCmS8eIVatjpGipu0XtGw8BQ5zvu84oyxYYC4FodgP9vODjS7Gp/38Yv8fYQ6f6G/ifXAmfX8A== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(396003)(346002)(366004)(376002)(451199015)(33656002)(86362001)(122000001)(38100700002)(38070700005)(26005)(186003)(9686003)(2906002)(83380400001)(7696005)(53546011)(7416002)(5660300002)(6506007)(55016003)(4326008)(8936002)(66946007)(316002)(478600001)(66556008)(76116006)(64756008)(110136005)(8676002)(41300700001)(71200400001)(54906003)(66476007)(52536014)(66446008);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?OmtXzZs6hxf/bkFpVOwk/uVVtzSkEbQod6W35XipPFJLrh+Gcvuhmx+askmj?= =?us-ascii?Q?V9GOfg8qk+wfhnmFGyc9yxR7F84QkIceaz/6Fz0cqpvgONiplk4vAdd44Jp4?= =?us-ascii?Q?cuG0uhZE2yEVA+3ws/zijbxJo0jOgkJomlUAZEuad7ARveIgcMF24pz3CSTh?= =?us-ascii?Q?VrL2+Mq08anIW3OMWpSqY4F0noKVLDeKugwVSAnZk9AQ3rXqSuji+31Z0BWV?= =?us-ascii?Q?pqaZWUvaZbONZk+j7nHqWEgVtokFvsTBEQw0IPZhN0my22Igquh4aqoy79A+?= =?us-ascii?Q?udLXWDdNOX7rBg2j3EA58XQkOT3aS7rQSgiFLvzr0nVzNJ6+nixAhAaPyv79?= =?us-ascii?Q?Hra879I2hTa3vEK5e8q5uXaSO9pKy0XqkFOxDQ7w7PLRVdlLh9fUVr5ri8IE?= =?us-ascii?Q?kuiCySelr/mjgLnuAIdbxuau6AUSTdJ8KAJ5MXGpkRGawwK32Lp1OS1+Sh+M?= =?us-ascii?Q?2C00Vfb66aLybwJ0FlvOPJEZpK0jDSU6MhsABd1e6qWmiWIQEl64KlUtT2eX?= =?us-ascii?Q?jLMGl+UMC5puNdZFoxGSMr5YhOHTe3fc5flrJPpoi6w8CdS1CShWyUUD7P8a?= =?us-ascii?Q?Gho7owTvTMn505sSLHNXfCYcqHrzJsmUNe0/j3AtPk3fOcvSzZnVRiI3FmBL?= =?us-ascii?Q?7avWThTdjQo6qc05pEsO5l5rd72UoNGm2JL5b7tkoQEF1h/tyhX5RW93aFOD?= =?us-ascii?Q?jnfj0JSyqXaDAumFUMnNIU25hlS74mYtQpkIZYJDHWQZmac+1hSrwmgxTEVg?= =?us-ascii?Q?Pq/NAiDTKcPWh4Sd+UvJPKy9mAMJzrN5Je2zANndQIjGoRCIT0+oqCl39VBm?= =?us-ascii?Q?nYX86PuV+ldJtvuQP+cMeUuTWLo0j8+4LHyg78K6sYBbgbzHRaMbi20Ru3Dm?= =?us-ascii?Q?camHXqMMPwMvm6DYan5/FjS+7U81MgMOHs7GXJkK0y03UkrypcQoeScKY0tT?= =?us-ascii?Q?IKLZx0fUd0DugS/NCsG7PYkmJa/4TIfHAQA6gxVYDWV1iHzq33p5WC61AhMt?= =?us-ascii?Q?ZvB/vN7lMNW3pBEZYmxsT9rNXjbhBzPwKZUQ4JnIaXvmpzOPrvcuNEXgmp1+?= =?us-ascii?Q?9a6E0aciNNzEqxvYFmEqK0yOJFwOqpSDqBvr6QYbac+lTU4cmAeT5HR9Djfx?= =?us-ascii?Q?Zbc3RjDFUuZCoW7ZGW9d9HPPraKTrtswIzoJh2VkckMXBwJQv/4Fo1tdt6LX?= =?us-ascii?Q?vNlZ7vG1x47KHhm1GC13sKQbRPSQzx6lm4OsL+gdLXgl15nZLnzywtyOTtNJ?= =?us-ascii?Q?e/Bxu+O3s96/aLK9spA9p2lj22Qb5zSURaypOWjQymueR8xWY/RubEFnYTi3?= =?us-ascii?Q?01CGfNuBYzRPhCkHf9tf8kmF8USclaekJMrL3c0E3tCMCBHzla3HrWtafq0/?= =?us-ascii?Q?QIuFe+TG0qexu7WcE57XkkQkIa2dJoeGsTtzojuv4yXYhjLyxLim/B5l+mqX?= =?us-ascii?Q?TG+Qz/oJ7c4biLex9Fsqs0BiC3gKx96OuZIOo6J+ou0NgLH224I1J8fCZ9VY?= =?us-ascii?Q?EkhB7jkJ5cWHE2xxVRiyyNklQwyjJqYoeAivF262zuvyP9ntbIkYp9LddaFZ?= =?us-ascii?Q?qDbvxBMsU3Wq37HrO6s=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ee6b06e9-f1ed-4e80-660c-08dab623cdb4 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Oct 2022 00:56:51.6984 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: obUgdh2u5tacyDn8cQaU6gE7BkD48iyvOafD7EA8j5TDLex7YudutjLyb58chKcmc6Fe4YZQ1opLPagpaCmCbw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7146 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Acked-by: Abner Chang > -----Original Message----- > From: Sami Mujawar > Sent: Tuesday, October 18, 2022 11:34 PM > To: devel@edk2.groups.io > Cc: Sami Mujawar ; Alexei.Fedorov@arm.com; > pierre.gondois@arm.com; gmahadevan@nvidia.com; Chang, Abner > ; jbrasen@nvidia.com; ashishsingha@nvidia.com; > nramirez@nvidia.com; wwatson@nvidia.com; Matteo.Carlini@arm.com; > Akanksha.Jain2@arm.com; Ben.Adderson@arm.com; Samer.El-Haj- > Mahmoud@arm.com; nd@arm.com > Subject: [PATCH v1 1/2] DynamicTablesPkg: Define a SMBIOS Structure/Table > type >=20 > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. >=20 >=20 > SMBIOS Structure Types 0 through 127 (7Fh) are reserved for and defined b= y > the SMBIOS specification. Types 128 through 256 (80h to FFh) are availabl= e > for system and OEM-specific information. >=20 > Therefore, define a new type 'SMBIOS_TABLE_TYPE' that represents a > SMBIOS structure type and include it in the definition of > CM_STD_OBJ_SMBIOS_TABLE_INFO. >=20 > Signed-off-by: Sami Mujawar > Cc: Alexei Fedorov > Cc: Pierre Gondois > Cc: Girish Mahadevan > Cc: Jeff Brasen > Cc: Ashish Singhal > Cc: Nick Ramirez > Cc: William Watson > Cc: Abner Chang > Cc: Samer El-Haj-Mahmoud > --- > DynamicTablesPkg/Include/StandardNameSpaceObjects.h | 17 > +++++++++++++++++ > 1 file changed, 17 insertions(+) >=20 > diff --git a/DynamicTablesPkg/Include/StandardNameSpaceObjects.h > b/DynamicTablesPkg/Include/StandardNameSpaceObjects.h > index > 8ec3238225abe4fc16a7337c29ecd655590b408f..c81efbc237779c305abc3c4dd0 > 7f6b705563e2a1 100644 > --- a/DynamicTablesPkg/Include/StandardNameSpaceObjects.h > +++ b/DynamicTablesPkg/Include/StandardNameSpaceObjects.h > @@ -40,6 +40,20 @@ > **/ > typedef UINTN CM_OBJECT_TOKEN; >=20 > +/** > + A type representing a SMBIOS structure/table type. > + > + Types 0 through 127 (7Fh) are reserved for and defined by the SMBIOS > + specification. > + Types 128 through 256 (80h to FFh) are available for system and > + OEM-specific information. > + > + Note: This Dynamic SMBIOS table generation implementation defines > + TableType FFh as a NULL table which is used by the Dynamic > + SMBIOS table dispatcher to terminate the dependency sequence. > +*/ > +typedef UINT8 SMBIOS_TABLE_TYPE; > + > /** The ESTD_OBJECT_ID enum describes the Object IDs > in the Standard Namespace. > */ > @@ -127,6 +141,9 @@ typedef struct CmAStdObjAcpiTableInfo { > to NULL. > */ > typedef struct CmStdObjSmbiosTableInfo { > + /// SMBIOS Structure/Table Type > + SMBIOS_TABLE_TYPE TableType; > + > /// The SMBIOS Table Generator ID > SMBIOS_TABLE_GENERATOR_ID TableGeneratorId; >=20 > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'