[edk2-redfish-client][PATCH v2 0/3] Introduce resource addendum protocol

[edk2-redfish-client][PATCH v2 0/3] Introduce resource addendum protocol

[Nickle Wang]

v2:
Update protocol and library function description.

v1:
Introduce EDKII_REDFISH_RESOURCE_ADDENDUM_PROTOCOL to Redfish feature driver.
Feature driver uses this protocol to query OEM resource from platform in
order to support Redfish OEM property. This protocol is also used to get
addendum data that is required by BMC to manage Redfish BIOS service.

Signed-off-by: Nickle Wang <nicklew@nvidia.com>
Cc: Abner Chang <abner.chang@amd.com>
Cc: Igor Kulchytskyy <igork@ami.com>

*** BLURB HERE ***

Nickle Wang (3):
  RedfishClientPkg: Add Redfish Resource Addendum Protocol
  RedfishClientPkg: Add Redfish Resource Addendum Library
  RedfishClientPkg: Utilize RedfishAddendumLib

 RedfishClientPkg/RedfishClientPkg.dec         |   2 +
 RedfishClientPkg/RedfishClientLibs.dsc.inc    |   4 +-
 RedfishClientPkg/RedfishClientPkg.dsc         |   2 +
 .../Features/Bios/v1_0_9/Dxe/BiosDxe.inf      |   2 +
 .../RedfishAddendumLib/RedfishAddendumLib.inf |  40 +++
 .../Include/Library/RedfishAddendumLib.h      |  67 +++++
 .../EdkIIRedfishResourceAddendumProtocol.h    |  94 +++++++
 .../Include/RedfishResourceCommon.h           |   2 +
 .../Features/Bios/v1_0_9/Common/BiosCommon.c  | 100 +++++++
 .../RedfishAddendumLib/RedfishAddendumLib.c   | 265 ++++++++++++++++++
 10 files changed, 577 insertions(+), 1 deletion(-)
 create mode 100644 RedfishClientPkg/Library/RedfishAddendumLib/RedfishAddendumLib.inf
 create mode 100644 RedfishClientPkg/Include/Library/RedfishAddendumLib.h
 create mode 100644 RedfishClientPkg/Include/Protocol/EdkIIRedfishResourceAddendumProtocol.h
 create mode 100644 RedfishClientPkg/Library/RedfishAddendumLib/RedfishAddendumLib.c

-- 
2.17.1

Re: [edk2-redfish-client][PATCH v2 0/3] Introduce resource addendum protocol

[Chang, Abner]

[AMD Official Use Only - General]

Thanks for addressing my concerns.
Reviewed-by: Abner Chang <abner.chang@amd.com> with below issues addressed.

1.  "__FUNCTION__" to "__func__" in debug macro.
2. The description of parameter JsonWithAddendum may confuse user.

>+/**
>+  This function calls EDKII_REDFISH_RESOURCE_ADDENDUM_PROTOCOL to get
>+  addendum data. It's call's responsibility to release JsonWithAddendum.
>+
>+  @param[in]   Uri              Uri of input resource.
>+  @param[in]   Schema           Redfish schema string.
>+  @param[in]   Version          Schema version string.
>+  @param[in]   JsonText         Input resource in JSON format string.
>+  @param[out]  JsonWithAddendum The input resource with addendum value attached.

The output resource with addendum value attached or is replaced in EDKII_REDFISH_RESOURCE_ADDENDUM_PROTOCOL.

Thanks
Abner

>+
>+  @retval EFI_SUCCESS              Addendum data is attached.
>+  @retval EFI_NOT_FOUND            No addendum protocol is found in system.
>+  @retval EFI_UNSUPPORTED          No addendum data is required in given schema.
>+  @retval Others                   Some error happened.
>+
+**/
>+EFI_STATUS
>+RedfishGetAddendumData (

> -----Original Message-----
> From: Nickle Wang <nicklew@nvidia.com>
> Sent: Monday, May 15, 2023 3:38 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner <Abner.Chang@amd.com>; Igor Kulchytskyy
> <igork@ami.com>
> Subject: [edk2-redfish-client][PATCH v2 0/3] Introduce resource addendum
> protocol
> 
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
> 
> 
> v2:
> Update protocol and library function description.
> 
> v1:
> Introduce EDKII_REDFISH_RESOURCE_ADDENDUM_PROTOCOL to Redfish
> feature driver.
> Feature driver uses this protocol to query OEM resource from platform in
> order to support Redfish OEM property. This protocol is also used to get
> addendum data that is required by BMC to manage Redfish BIOS service.
> 
> Signed-off-by: Nickle Wang <nicklew@nvidia.com>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
> 
> *** BLURB HERE ***
> 
> Nickle Wang (3):
>   RedfishClientPkg: Add Redfish Resource Addendum Protocol
>   RedfishClientPkg: Add Redfish Resource Addendum Library
>   RedfishClientPkg: Utilize RedfishAddendumLib
> 
>  RedfishClientPkg/RedfishClientPkg.dec         |   2 +
>  RedfishClientPkg/RedfishClientLibs.dsc.inc    |   4 +-
>  RedfishClientPkg/RedfishClientPkg.dsc         |   2 +
>  .../Features/Bios/v1_0_9/Dxe/BiosDxe.inf      |   2 +
>  .../RedfishAddendumLib/RedfishAddendumLib.inf |  40 +++
>  .../Include/Library/RedfishAddendumLib.h      |  67 +++++
>  .../EdkIIRedfishResourceAddendumProtocol.h    |  94 +++++++
>  .../Include/RedfishResourceCommon.h           |   2 +
>  .../Features/Bios/v1_0_9/Common/BiosCommon.c  | 100 +++++++
>  .../RedfishAddendumLib/RedfishAddendumLib.c   | 265
> ++++++++++++++++++
>  10 files changed, 577 insertions(+), 1 deletion(-)
>  create mode 100644
> RedfishClientPkg/Library/RedfishAddendumLib/RedfishAddendumLib.inf
>  create mode 100644
> RedfishClientPkg/Include/Library/RedfishAddendumLib.h
>  create mode 100644
> RedfishClientPkg/Include/Protocol/EdkIIRedfishResourceAddendumProtocol
> .h
>  create mode 100644
> RedfishClientPkg/Library/RedfishAddendumLib/RedfishAddendumLib.c
> 
> --
> 2.17.1