From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (NAM04-DM6-obe.outbound.protection.outlook.com [40.107.102.84]) by mx.groups.io with SMTP id smtpd.web10.83533.1684137976022308637 for ; Mon, 15 May 2023 01:06:16 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=aBzeCzP0; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.102.84, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K4U6X4qVwkl+oiXZBp0HBwNXKeunOf0IjMD3pY0eldvWwOcC/t6iMO/4pN+3qqv+afTyqAvSOONkGtIYLKFBg+2evjamv/iHPBHgV0XIJK+3LVjEOfpQ+RSovUuzd+vYVHiPlCM9wbRA9sfQqBECd8WN8tJ+yeqpfdE7sBttanya14IGul8JpTJMv5HYqBMKnbXzpjd9DiwzlZUD3XtAeaNRV19InjgfzMH+DQhq6rt//Uak3YKR5EJOrFhKR/pHL+bdJib3E1VuS0iP17HuvVQcQL2ZkomanwN9pzpszQpsXUHYXpdVGeVD+Tvqnom354fgA1u41x0lUXVIiDJtyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NNpEoMBuM1mH2xtEyl+8j4cAh35DSzk4Mdo9BqVwRA8=; b=XE2xXIRyACn2iuqVMR7Qh5bg3ME8poqojKTwrc6LWQ5aOaWFQ6tqW41cHEH8MDSQu7/TARy/BHuGscWJW+eGxa/sN230Lg4gdiY8ajX0kcJbnhqIfHioyWC8GtcglUHJdk6t/rviEvO1pfMEhmd3ggpoXjyEJd3FFgYbiRyfSpYiPJJIdYaw7ME6La4cZ/ggYtUysQ8M6sXioykTto2XrMgejP9MdlGr7ndvrwnjuykwJKXoYV1Sc85D7T2hEbesuqXPYiVIR2jtRgR1CKkRDpi6Yxu9ARYNOyKqWjfiH1I8KNDRPU5j8U8yVWVPm8QsTBxcbURPMb9eHyr3ibAk9w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NNpEoMBuM1mH2xtEyl+8j4cAh35DSzk4Mdo9BqVwRA8=; b=aBzeCzP0yehvtG4N0d7gS9nnywA1PYJseA2sxYggT6tmSELiB5ERZbRvD+voPCZzqt+kdqiMFGvIQ3yjjUuRtzf439ogzjEb2FNTfzqOCztJJDfovqxhv3X3Z+YcftkRFRzvv4sRrZivaeCZCJuT+hMICCKPRm7lxlJWfYYSTgw= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by DM6PR12MB4577.namprd12.prod.outlook.com (2603:10b6:5:2aa::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.30; Mon, 15 May 2023 08:06:14 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::edb0:bed8:c650:5040]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::edb0:bed8:c650:5040%5]) with mapi id 15.20.6387.030; Mon, 15 May 2023 08:06:13 +0000 From: "Chang, Abner" To: Nickle Wang , "devel@edk2.groups.io" CC: Igor Kulchytskyy Subject: Re: [edk2-redfish-client][PATCH v2 0/3] Introduce resource addendum protocol Thread-Topic: [edk2-redfish-client][PATCH v2 0/3] Introduce resource addendum protocol Thread-Index: AQHZhwA0Y85nsceMVEyORJmTdghNQK9a+Qrg Date: Mon, 15 May 2023 08:06:13 +0000 Message-ID: References: <20230515073754.13467-1-nicklew@nvidia.com> In-Reply-To: <20230515073754.13467-1-nicklew@nvidia.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-05-15T08:06:11Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=32c14292-2786-41f5-8d9f-03718fa622e0; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|DM6PR12MB4577:EE_ x-ms-office365-filtering-correlation-id: 9c542b88-7d09-4b53-a960-08db551b4072 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: pjQ0WjlZgqIotVXf7Z9NS45JzZkveycBNwcLqDceuKgPfFS4VFB6ld0eYxVwF3kg7FbLVLIDgFvCcK1HCvSmks3WzRXVYXa4sN/SFiGFvWfDf91JtuxTNv+FvRHdMdy2K1XuKSTTa3wWDU+QFaramueIlbgRZZjmU+wcfkhLeMttOaKhen+ula9gdCk90l4V8qp9N+Mp6QTXAmBmMXLX+MJFUVJ8cJV+bn8NFCoP+b+ySEnp7CglVxX2EENhmZnKJbECj/130lNCUcGginz2F+rZgyM9C/IiJ3Zna7zRJaN4Me8fz+z6+pLv4jEYcSuubrf2jRE2dWdawtv4eTy/r9hJgYRYAqO6yO7wRQdcjzvWIIRI639k8WilvuVeE+1m4VSKoBzMeMgaZ0xqancdcSm4yc/hdQotVW1hrLhxs2F2w2SvjsaE9PsboTv+GeBX+s8/pI2F/SFdKZxyTN/3txzul3sY770GtEXH47acqeTwASm1lJXG+0Kx7dRaf1fnslDm2BfGvzeKieb1JkIxTO1FCEtSJi+lnTAhPU+X64sYXJflFpLvwIZf0sXv+sO2KGjA7+POtWWvfkbKGIT6wuCKrdQ2llgOKX8zGApcQWLG21/lDkyykwJ8dcd/U5Wp x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(396003)(346002)(376002)(366004)(136003)(451199021)(66556008)(4326008)(64756008)(66446008)(66476007)(478600001)(76116006)(66946007)(19627235002)(110136005)(6506007)(186003)(53546011)(9686003)(38070700005)(38100700002)(83380400001)(8936002)(8676002)(2906002)(55016003)(71200400001)(7696005)(316002)(122000001)(86362001)(33656002)(5660300002)(41300700001)(52536014);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?BgP8PcgRMD4rhclRYXK5Fo0osFISy74evKeb3bQwskFpBBDKL/XVqnx3m38s?= =?us-ascii?Q?1/9bniOoL1+6LZUZ8+blEXmN4uC6D2MfJk9aMOLS+sameXSqo/L3UDMFBOMz?= =?us-ascii?Q?ou/iqVwX54DMKHZXZ32P7YaWZZ7CkUIywN18uuH7c23q62WsCngNwj8g0ftr?= =?us-ascii?Q?eKu4cUdGAvULRtramWiTVkj/KZt9+pxj+Ip3VVsqGXUBLJiZOS4RDzbxhYY6?= =?us-ascii?Q?A2gzMcxZu7MSAAoXiaz3ZwysUQnPGuaNhsF6HAneEse6n9EwzDYX+I6Kev8+?= =?us-ascii?Q?xCcq5sem56QrF+i8zL4pprjsuLPxBobwV2hxVllRBKki1iYsflj2F5JkGQNC?= =?us-ascii?Q?jhAsKc2yMkr+6sNHVCP41AXOwPz53NLuaW+XaUnx5onU5rnNJhsFZF35a3s+?= =?us-ascii?Q?1NE7K5jIpWHbr7pgN344/VRT7FNxvi2RCdiTRAVePYA0YlwtKVDPm8VPkg3Q?= =?us-ascii?Q?BmIGz/+kXUma+1/Ymhi49/tA17ILsbFN+tIkWChHwptIGL5BnpT0wNoHqlKz?= =?us-ascii?Q?JFkFnDFmb82XdDXJnJXGIRaypKLXPH5LPsY6ANqT+vSF+/RCZ3k+IoUAeWz4?= =?us-ascii?Q?r/QbQVsQeRTdFBcb9IBtOlnZT3JVfOlvQ1x4QwZ0f/O67UxIMpRsVeVHnvs8?= =?us-ascii?Q?8i52raTPbrcPbcDa3OLqe7+aHzIqeBig2lJdoAX0RqEnskJjQXG+6alVPSEB?= =?us-ascii?Q?kJINrCh/vdDolddFXZmLLSh+uD9XsZvg+LiRZZ/dTspE2McMD3yMUJfKimGV?= =?us-ascii?Q?YZHp8GetQdKGEHndGrgBHWPZiJ+Fsu857SeFK4qHnH+bocU2V47CG33Hluyd?= =?us-ascii?Q?7SlO4iX4zs4NERR8W+GwNHyEqRE/OfSDG/X22qjXMMUAYd+FabiuxsHOLb+d?= =?us-ascii?Q?UaGL0s90wbu3gzJRFv6CZ6wl6ryhfW2tbGfZfr58lXoZ7ewW1mlWtgyWFCIm?= =?us-ascii?Q?0zRnR80rYigrFmvx/x8CB20KD+fYZMhRMpQLHyOCJ/U9qFFBrXXjNY+Ibjtw?= =?us-ascii?Q?yPvfnMf1yzjQbr86jB+CZE4VPfidQnsdsujLv8Rd04YHXZJO3jFESVPKusOx?= =?us-ascii?Q?tQC4r6ePqooJmfgzsNIgpSjBWuf3yfdi0m1jBiZEKgvdONh1kCbti2GJqX6n?= =?us-ascii?Q?z6eUAHSFRlqq64Ug257ZHj5AA12JCUsssgVKx+ZGWHtbvgUBQhdoMR0gVqw9?= =?us-ascii?Q?GgZgMs9O4NbYODcgU2KxZ+/qftDPqNxBc5OHTMHMk2DAtOcOocp+Fp/FO5bI?= =?us-ascii?Q?dY8o+QNxTyK/GxN2L65P7eVX5DVYKyIyLpTZpwPfjnHzw8Pzs2KDGNFk+diP?= =?us-ascii?Q?+3Jbwy/GSEqskIALMqFQrm1AbAW6qJy+jITpIt4Pmtli8bBEl6LDJgPfYFim?= =?us-ascii?Q?84LQjX25EnFzqGPovai6Ugy245X/AohV16r3UgRJflOk1uqofaGsJQrw/auD?= =?us-ascii?Q?+DBgDvYi0uEPT7v5tGNKv6MG1nRXGuKrWUQNJUEFFT5chfq1sL37Um5pWEQE?= =?us-ascii?Q?DCc7K/8W1YKxv/BifQQYDoDbTMel32k8KdJ7M8IzP1UpC8NF+ANyG4rKLQ?= =?us-ascii?Q?=3D=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9c542b88-7d09-4b53-a960-08db551b4072 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 May 2023 08:06:13.6198 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: lsKY5PGSJgRBcAdR2BEAAUxYeiCHclMxHP0UHQv5/C4w0d0hkf6s/ztRW/C9iQpuPrcy2dZjezG/UibOk3VLDg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4577 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Thanks for addressing my concerns. Reviewed-by: Abner Chang with below issues addressed. 1. "__FUNCTION__" to "__func__" in debug macro. 2. The description of parameter JsonWithAddendum may confuse user. >+/** >+ This function calls EDKII_REDFISH_RESOURCE_ADDENDUM_PROTOCOL to get >+ addendum data. It's call's responsibility to release JsonWithAddendum. >+ >+ @param[in] Uri Uri of input resource. >+ @param[in] Schema Redfish schema string. >+ @param[in] Version Schema version string. >+ @param[in] JsonText Input resource in JSON format string. >+ @param[out] JsonWithAddendum The input resource with addendum value at= tached. The output resource with addendum value attached or is replaced in EDKII_RE= DFISH_RESOURCE_ADDENDUM_PROTOCOL. Thanks Abner >+ >+ @retval EFI_SUCCESS Addendum data is attached. >+ @retval EFI_NOT_FOUND No addendum protocol is found in syste= m. >+ @retval EFI_UNSUPPORTED No addendum data is required in given = schema. >+ @retval Others Some error happened. >+ +**/ >+EFI_STATUS >+RedfishGetAddendumData ( > -----Original Message----- > From: Nickle Wang > Sent: Monday, May 15, 2023 3:38 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > > Subject: [edk2-redfish-client][PATCH v2 0/3] Introduce resource addendum > protocol >=20 > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. >=20 >=20 > v2: > Update protocol and library function description. >=20 > v1: > Introduce EDKII_REDFISH_RESOURCE_ADDENDUM_PROTOCOL to Redfish > feature driver. > Feature driver uses this protocol to query OEM resource from platform in > order to support Redfish OEM property. This protocol is also used to get > addendum data that is required by BMC to manage Redfish BIOS service. >=20 > Signed-off-by: Nickle Wang > Cc: Abner Chang > Cc: Igor Kulchytskyy >=20 > *** BLURB HERE *** >=20 > Nickle Wang (3): > RedfishClientPkg: Add Redfish Resource Addendum Protocol > RedfishClientPkg: Add Redfish Resource Addendum Library > RedfishClientPkg: Utilize RedfishAddendumLib >=20 > RedfishClientPkg/RedfishClientPkg.dec | 2 + > RedfishClientPkg/RedfishClientLibs.dsc.inc | 4 +- > RedfishClientPkg/RedfishClientPkg.dsc | 2 + > .../Features/Bios/v1_0_9/Dxe/BiosDxe.inf | 2 + > .../RedfishAddendumLib/RedfishAddendumLib.inf | 40 +++ > .../Include/Library/RedfishAddendumLib.h | 67 +++++ > .../EdkIIRedfishResourceAddendumProtocol.h | 94 +++++++ > .../Include/RedfishResourceCommon.h | 2 + > .../Features/Bios/v1_0_9/Common/BiosCommon.c | 100 +++++++ > .../RedfishAddendumLib/RedfishAddendumLib.c | 265 > ++++++++++++++++++ > 10 files changed, 577 insertions(+), 1 deletion(-) > create mode 100644 > RedfishClientPkg/Library/RedfishAddendumLib/RedfishAddendumLib.inf > create mode 100644 > RedfishClientPkg/Include/Library/RedfishAddendumLib.h > create mode 100644 > RedfishClientPkg/Include/Protocol/EdkIIRedfishResourceAddendumProtocol > .h > create mode 100644 > RedfishClientPkg/Library/RedfishAddendumLib/RedfishAddendumLib.c >=20 > -- > 2.17.1