From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 73AF9740035 for ; Fri, 27 Oct 2023 01:49:07 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=1qcwHlssHOpzO6ubQjayaSKF8deyArQJCaqe/UfZv0w=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698371345; v=1; b=N/CIQfuFs3I76+iiAr/gRTLPXcWTfhaUuozFIsMYsoj1GLQB7w37eCniPhCVFFS26XjMuJJp K4gXpfNyfgfN8WFCxz6mMe3/zRbSNORa5iAoBMlhdFowC7AMW1u+Q7nnWHjcK7/UsITk/yU9u/D 4SI1rsEd9FoXzchmTfUKNsBs= X-Received: by 127.0.0.2 with SMTP id 5JjtYY7687511xBJunFXsFLw; Thu, 26 Oct 2023 18:49:05 -0700 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.73]) by mx.groups.io with SMTP id smtpd.web11.87847.1698371345030238229 for ; Thu, 26 Oct 2023 18:49:05 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WyrR5c5B48nFOn9B15V7CHGg7jImvOr2dmgEavRSDAnpaD8jdet3ReThXeQ45mcJgrmgoYmnmATuxyK1kqg8g3oyLGTBp2HU2NXl8/In/eCWRi+IevfQw5v9UYMYa/t5KdDzmLPJKRJ4J2RNc2Kp5On1tCpXO9nZr3m16Xq+q7fjYI3vM2TNgeUDYe/F+o6gL89lGIPn/OKnZulPQwaj6kOL02H7MeUoFPJPt0EodISiXHb8L3/I6+oOx/r0IrvNVBK2TvtDUTOl/YM2kYvf3TuOZuKv6z8L7W+98g1wLDIT2DpG2ixOfYFaVfTsiByjRr5rv5tNnZMyZvgPxspj/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8sVkwyWE5jtsR3gG70cxLs5amcgAAoau8dv8RcAmOiU=; b=C4cdu5dbBzg3VjtQgCILHeRQsmQoQEDvJRaDf0FGy52SdFYorTZEvDok/oTylqSi0uCRVafl+knq9VeBh6kj0QJCkqHTOlcRUOfGEDT5Os6zQ6rL3AYVbLgeKdvaBwnpqvc6LP0TK82KWDMSYNY2npuOS0ztGBZm+7uuSU7w4hE3mE8O5Cow6HPGz0y408ss7ji5HrVKD31w2mywuVsNNStTTYKgHUPpjhxlLpbWJVdhNDkGSmy5apR+Ri3S6N0gkKTbjVzHjuwb/IACqOLqQnizJU92vTDzFZw6i3KAksCdc41pHSLqvxYf3W+KzkMGjpRojRWCjdBISJd0Xlcqig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by BL1PR12MB5110.namprd12.prod.outlook.com (2603:10b6:208:312::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.19; Fri, 27 Oct 2023 01:49:02 +0000 X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::e670:e45f:fa32:2420]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::e670:e45f:fa32:2420%6]) with mapi id 15.20.6933.019; Fri, 27 Oct 2023 01:49:02 +0000 From: "Chang, Abner via groups.io" To: "devel@edk2.groups.io" , Nate DeSimone , Liming Gao CC: "Attar, AbdulLateef (Abdul Lateef)" , Nickle Wang Subject: Re: [edk2-devel] [edk2-platforms][PATCH 2/2] OutOfBandManagement/IpmiFeaturePKg: Remove IpmiCommandLib.h from IpmiFeaturePkg Thread-Topic: [edk2-devel] [edk2-platforms][PATCH 2/2] OutOfBandManagement/IpmiFeaturePKg: Remove IpmiCommandLib.h from IpmiFeaturePkg Thread-Index: AQHZ+1L9z8DqZjyq+0G/Q4BBjCa/Y7BPBtzAgA3xS5A= Date: Fri, 27 Oct 2023 01:49:02 +0000 Message-ID: References: <20231010082223.1421-1-abner.chang@amd.com> <178CB15EC6448604.24994@groups.io> <178F1A8A0B9F4787.14388@groups.io> In-Reply-To: <178F1A8A0B9F4787.14388@groups.io> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=685fa825-2f3f-48c3-93dd-682c8fb07ca5;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-10-18T04:51:28Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|BL1PR12MB5110:EE_ x-ms-office365-filtering-correlation-id: cfb93f82-3dc5-4a73-034b-08dbd68ee52c x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: dg8V4c6L8hami7cy2jEAvNCMQ0CCHp1rT4IcwwE44I/4rW3I6a0c2GZRHH5pzCDNrEtZNc+aS0Vz8WtRLsjbamQLU0Fy0t8bTUeZM4ncpsz98ryU8l96I0iPBbRoVTlAgPR4mRZn8gBKsaYoMjhjCy7GHz/jcLhuyUSQ8LN6FKgqxbBQBWNFfHBhoty9al4YA6yKGmUksHV5RrRoLAoF6k1UXHp3hLdm8pdN0TZ8jlJJ+f5ivvJ79qc00F0D64FGgSgXimMiFDlSiIZ5ek2Mj7TD2wVr0r/oMyKMigMUBJhkGGivltSM7TRwdoZNhUsizwM6SU3XyUsU4snYDlMIlzg66gK8q74Nkbjv4YOoHVcFr7MSBm0e6DQqwTwMTiSxjEPH0r6Zf/A3QXET77lW/+yebPXdHA04v43wBtyY50e/y8os6328tSgWGqKbmp5xGt5MEUbZmt5kA7PSUz3geaD396frG8aa5+M1nbGMo+XcPU4Br1x4YcZRYFgoMKVZdYOm3dJ56YewOcXBBSdkkXA+59TRg4QpmDMkKimEM7ZpowdowTZSHNFtJ6CurTGaAtRaw7EPCA1GjkYiV/98g1537sJdSrp9N60Hgujz2/j9Z6o/ONczevYOdPjmAnxIB7Z0XuUuhoSerx1RtY/4oA== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?v0/ElkHBRceyJNgyuWt4vykJOXHboC2r52FqyCCgvz+JsyXy/MBmHAF40BWp?= =?us-ascii?Q?i2Ry91jwg9AjUQ8jpE6JLdaA7m+WBi76+B5sxqXo7WJ4Wzu68cwJba8Ms/Eq?= =?us-ascii?Q?9kL4A9RDaorjoy6wBps4KJ3Ht9/EV2BpuI4JYO7/utgMA0qA3FKWv7X5ZsII?= =?us-ascii?Q?UAjLncYpPAzDlD0DSd4g1T7DEVz+i2SyMrPRwiFP5juzJjB1XLALtxbRKJKe?= =?us-ascii?Q?dt4dFTEmS8gdF/ZNfx0ieON1qS5x4dNuNE8YKrTN8y6Nj7Hq+zFVGCeLFG8O?= =?us-ascii?Q?Ar8LWwN9Z+rhzQ7s7PBi01+lKntbnRDktJUJup69oQEB0G3nfIQMHen0qWib?= =?us-ascii?Q?99GRbv/U+A6g0tpr2zSiy9KL3evial4VYjHdlQHSjgn3CWOYT1XbFrwqjEiJ?= =?us-ascii?Q?dN2Z3yPQHtuVENfZ8fTATckdxOzVuJ8ts2wO7BLdMBaM2vmWrf5J8N5MdN0t?= =?us-ascii?Q?IA97x2HQNBZmVRSlXC54OPMKB3LWKrhkfKRRKn1RCqRVz8yAldFQNW5Yx1qP?= =?us-ascii?Q?srKCE4U2k2+X+iEUHWS/Z2C11P5OSeFlH+5vN4hGQv05SHIe04Wa5YoMbiOW?= =?us-ascii?Q?pdI0tOuk2GNXOe7ocIa5xLNbKWGX2GoemNW3KQN5f2uNK9BmT+V+ydSIeywh?= =?us-ascii?Q?Zh8efwwgxXnA2qqB3UNuMx12leyiCAloQYEv9lZ1J8wvSGBf7LprH4EjiX4c?= =?us-ascii?Q?JGwFiUmE7Q/1kpDXfwrEl8V52DR72u2sn2JBPqaniPpBRtJiFsHATYfAMiGi?= =?us-ascii?Q?AbtF8Z212rUZGR5hVNnyLutXrOH6bI6oJmrS9xVZDoAD+/nMFaNcujZOzML0?= =?us-ascii?Q?DMHOZmkm+6QU/6VDvN8h/3MNPH8XxDihzVk6eUZr4wQNqKfMsZbKkfcFdaZ/?= =?us-ascii?Q?dbP7TRV2uS2tivQ1xOWpqjBr1WfktGfmKj2UjvzML4ZJ5AIbbIqUMyRpzsWl?= =?us-ascii?Q?nS2Yx4blMfZBPZINhJRJExDTjGsEjmXNVESw32em1OjAiwfqrcLHfmoUwGif?= =?us-ascii?Q?Y/ZbPctYkOtmOhpnRL6KgyJ1wuFwzz+R7JqWdUbRiEfdt/xs6YKpnwGUqmXY?= =?us-ascii?Q?5Qs6tWvghIMiqstz/MC58mTFFCq+IdsynuW0jfGcBKHtwMtNCo7zfcDj7vXX?= =?us-ascii?Q?oHm9Qha6F08oiNqU+0XUD9vJv9hS/Mm+KdyYH2fSlJAWq96cb2wUYYjT05iL?= =?us-ascii?Q?eJCyPDf3cN1Rutn14E0yRJV+6KJDU5EDuysey+CAQeWj+tHZvHJzHMGwh4XU?= =?us-ascii?Q?kN4Qtk59xp5yvQzAtI0HB1b6U3C0/2taYV6kVXemzM+v4n6POJ3tuxEMdQbR?= =?us-ascii?Q?USG7/18a+jIT76SkY6oercfOwDtD9dhFvanh4ArvElB7P02QTIBGSnlKkv8s?= =?us-ascii?Q?rzFPThB2fD81AfX5x38CEVykhYcj+/RTX8MQjbHJKQrsqIdft0s4F0qCzYOQ?= =?us-ascii?Q?ffX6w1x8nsYm+Fu8kaXCpMwcWD6r8x7yeuzDuZARqjAjF9LNsY0AaWvvajLY?= =?us-ascii?Q?v3MM4MKv3M85xcVVYLtjMl0CEWjw0xij3SiS5CeHgTIr0BPxjhgMCH+bj78j?= =?us-ascii?Q?1V18XuI6nlBM+VRA32xIgWbEFzljWoqm1YFvLg5x?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cfb93f82-3dc5-4a73-034b-08dbd68ee52c X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2023 01:49:02.1352 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: FxaScuBr04DL6BeniJQBiwvDE+SAHI98WtQe9f0UTrvwJi3191dvGbNFtR3aRdznBzsQMOYkDyM2CpwKjlN+pQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5110 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 8BigLtaqWWcZy7EqIG585Pg1x7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="N/CIQfuF"; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") [AMD Official Use Only - General] Hi Liming and Nate Please review this change, which removes duplicated IpmiCommandLib.h from I= pmiFeaturePkg. This is also similar to the patch that removes IpmiCommandLi= b.h from ManageabilityPkg. Thanks Abner > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Chang, > Abner via groups.io > Sent: Wednesday, October 18, 2023 12:53 PM > To: devel@edk2.groups.io; Chang, Abner > Cc: Attar, AbdulLateef (Abdul Lateef) ; Isaac > Oram ; Nickle Wang ; Nate > DeSimone ; Liming Gao > > Subject: Re: [edk2-devel] [edk2-platforms][PATCH 2/2] > OutOfBandManagement/IpmiFeaturePKg: Remove IpmiCommandLib.h from > IpmiFeaturePkg > > [AMD Official Use Only - General] > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > [AMD Official Use Only - General] > > Hi Nate and Liming, > Please help to review this patch. > > Thanks > Abner > > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Chang, > > Abner via groups.io > > Sent: Tuesday, October 10, 2023 4:22 PM > > To: devel@edk2.groups.io > > Cc: Attar, AbdulLateef (Abdul Lateef) ; Isaa= c > > Oram ; Nickle Wang ; Nate > > DeSimone > > Subject: [edk2-devel] [edk2-platforms][PATCH 2/2] > > OutOfBandManagement/IpmiFeaturePKg: Remove IpmiCommandLib.h > from > > IpmiFeaturePkg > > > > Caution: This message originated from an External Source. Use proper > caution > > when opening attachments, clicking links, or responding. > > > > > > From: Abner Chang > > > > Remove duplicate IpmiCommandLib.h and use the one > > under MdeModulePKg instead. > > > > Signed-off-by: Abner Chang > > Cc: Abdul Lateef Attar > > Cc: Isaac Oram > > Cc: Nickle Wang > > Cc: Isaac Oram > > Cc: Nate DeSimone > > --- > > .../IpmiFeaturePkg/BmcElog/BmcElog.inf | 1 + > > .../IpmiFeaturePkg/Frb/FrbPei.inf | 1 + > > .../GenericIpmi/Dxe/GenericIpmi.inf | 1 + > > .../GenericIpmi/Pei/PeiGenericIpmi.inf | 1 + > > .../GenericIpmi/Smm/SmmGenericIpmi.inf | 1 + > > .../IpmiFeaturePkg/IpmiFru/IpmiFru.inf | 1 + > > .../IpmiFeaturePkg/OsWdt/OsWdt.inf | 1 + > > .../IpmiFeaturePkg/SolStatus/SolStatus.inf | 1 + > > .../Include/Library/IpmiCommandLib.h | 314 ------------------ > > 9 files changed, 8 insertions(+), 314 deletions(-) > > delete mode 100644 > > > Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Library/Ipm > > iCommandLib.h > > > > diff --git > > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcElog/BmcElo > > g.inf > > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcElog/BmcElo > > g.inf > > index 388dd2740c..1e7a7658b7 100644 > > --- > > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcElog/BmcElo > > g.inf > > +++ > > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcElog/BmcElo > > g.inf > > @@ -21,6 +21,7 @@ > > > > [Packages] > > MdePkg/MdePkg.dec > > + MdeModulePkg/MdeModulePkg.dec > > IpmiFeaturePkg/IpmiFeaturePkg.dec > > > > [LibraryClasses] > > diff --git > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Frb/FrbPei.inf > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Frb/FrbPei.inf > > index 797dbe6a07..bfd80d4a98 100644 > > --- > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Frb/FrbPei.inf > > +++ > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Frb/FrbPei.inf > > @@ -20,6 +20,7 @@ > > > > [Packages] > > MdePkg/MdePkg.dec > > + MdeModulePkg/MdeModulePkg.dec > > IpmiFeaturePkg/IpmiFeaturePkg.dec > > > > [LibraryClasses] > > diff --git > > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/ > > GenericIpmi.inf > > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/ > > GenericIpmi.inf > > index 1564ceb08a..d37d1c5046 100644 > > --- > > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/ > > GenericIpmi.inf > > +++ > > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/ > > GenericIpmi.inf > > @@ -37,6 +37,7 @@ > > > > [Packages] > > MdePkg/MdePkg.dec > > + MdeModulePkg/MdeModulePkg.dec > > IpmiFeaturePkg/IpmiFeaturePkg.dec > > > > [LibraryClasses] > > diff --git > > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/ > P > > eiGenericIpmi.inf > > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/ > > PeiGenericIpmi.inf > > index 3a73180ce6..d7fb7f1c5b 100644 > > --- > > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/ > P > > eiGenericIpmi.inf > > +++ > > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/ > > PeiGenericIpmi.inf > > @@ -36,6 +36,7 @@ > > > > [Packages] > > MdePkg/MdePkg.dec > > + MdeModulePkg/MdeModulePkg.dec > > IpmiFeaturePkg/IpmiFeaturePkg.dec > > > > [LibraryClasses] > > diff --git > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Sm > > m/SmmGenericIpmi.inf > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Sm > > m/SmmGenericIpmi.inf > > index 12dc17ae84..75162007ce 100644 > > --- > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Sm > > m/SmmGenericIpmi.inf > > +++ > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Sm > > m/SmmGenericIpmi.inf > > @@ -28,6 +28,7 @@ > > > > [Packages] > > MdePkg/MdePkg.dec > > + MdeModulePkg/MdeModulePkg.dec > > IpmiFeaturePkg/IpmiFeaturePkg.dec > > > > [LibraryClasses] > > diff --git > > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFru/IpmiFru.i > > nf > > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFru/IpmiFru.i > > nf > > index 322f061a0f..f5778f3468 100644 > > --- > > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFru/IpmiFru.i > > nf > > +++ > > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFru/IpmiFru.i > > nf > > @@ -21,6 +21,7 @@ > > > > [Packages] > > MdePkg/MdePkg.dec > > + MdeModulePkg/MdeModulePkg.dec > > IpmiFeaturePkg/IpmiFeaturePkg.dec > > > > [LibraryClasses] > > diff --git > > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/OsWdt/OsWdt.in > > f > > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/OsWdt/OsWdt.in > > f > > index 3fd1078271..e90cd4d55e 100644 > > --- > > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/OsWdt/OsWdt.in > > f > > +++ > > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/OsWdt/OsWdt.in > > f > > @@ -20,6 +20,7 @@ > > > > [Packages] > > MdePkg/MdePkg.dec > > + MdeModulePkg/MdeModulePkg.dec > > IpmiFeaturePkg/IpmiFeaturePkg.dec > > > > [LibraryClasses] > > diff --git > > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/SolStatus/SolStat > > us.inf > > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/SolStatus/SolStat > > us.inf > > index 9019b849ac..8690c493a1 100644 > > --- > > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/SolStatus/SolStat > > us.inf > > +++ > > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/SolStatus/SolStat > > us.inf > > @@ -21,6 +21,7 @@ > > > > [Packages] > > MdePkg/MdePkg.dec > > + MdeModulePkg/MdeModulePkg.dec > > IpmiFeaturePkg/IpmiFeaturePkg.dec > > > > [Pcd] > > diff --git > > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Library/I > > pmiCommandLib.h > > > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Library/I > > pmiCommandLib.h > > deleted file mode 100644 > > index d5f8f1d01b..0000000000 > > --- > > > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Library/I > > pmiCommandLib.h > > +++ /dev/null > > @@ -1,314 +0,0 @@ > > -/** @file > > - This library abstract how to send/receive IPMI command. > > - > > -Copyright (c) 2018-2021, Intel Corporation. All rights reserved.
> > -Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved. > > - > > -SPDX-License-Identifier: BSD-2-Clause-Patent > > - > > -**/ > > - > > -#ifndef _IPMI_COMMAND_LIB_H_ > > -#define _IPMI_COMMAND_LIB_H_ > > - > > -#include > > -#include > > - > > -// > > -// NetFnApp > > -// > > -EFI_STATUS > > -EFIAPI > > -IpmiGetDeviceId ( > > - OUT IPMI_GET_DEVICE_ID_RESPONSE *DeviceId > > - ); > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiGetSelfTestResult ( > > - OUT IPMI_SELF_TEST_RESULT_RESPONSE *SelfTestResult > > - ); > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiResetWatchdogTimer ( > > - OUT UINT8 *CompletionCode > > - ); > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiSetWatchdogTimer ( > > - IN IPMI_SET_WATCHDOG_TIMER_REQUEST *SetWatchdogTimer, > > - OUT UINT8 *CompletionCode > > - ); > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiGetWatchdogTimer ( > > - OUT IPMI_GET_WATCHDOG_TIMER_RESPONSE *GetWatchdogTimer > > - ); > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiSetBmcGlobalEnables ( > > - IN IPMI_SET_BMC_GLOBAL_ENABLES_REQUEST *SetBmcGlobalEnables, > > - OUT UINT8 *CompletionCode > > - ); > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiGetBmcGlobalEnables ( > > - OUT IPMI_GET_BMC_GLOBAL_ENABLES_RESPONSE > *GetBmcGlobalEnables > > - ); > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiClearMessageFlags ( > > - IN IPMI_CLEAR_MESSAGE_FLAGS_REQUEST *ClearMessageFlagsRequest, > > - OUT UINT8 *CompletionCode > > - ); > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiGetMessageFlags ( > > - OUT IPMI_GET_MESSAGE_FLAGS_RESPONSE *GetMessageFlagsResponse > > - ); > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiGetMessage ( > > - OUT IPMI_GET_MESSAGE_RESPONSE *GetMessageResponse, > > - IN OUT UINT32 *GetMessageResponseSize > > - ); > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiSendMessage ( > > - IN IPMI_SEND_MESSAGE_REQUEST *SendMessageRequest, > > - IN UINT32 SendMessageRequestSize, > > - OUT IPMI_SEND_MESSAGE_RESPONSE *SendMessageResponse, > > - IN OUT UINT32 *SendMessageResponseSize > > - ); > > - > > -/** > > - This function gets the system UUID. > > - > > - @param[out] SystemGuid The pointer to retrieve system UUID. > > - > > - @retval EFI_SUCCESS UUID is returned. > > - @retval EFI_INVALID_PARAMETER SystemGuid is a NULL pointer. > > - @retval Others Other errors. > > - > > -**/ > > -EFI_STATUS > > -EFIAPI > > -IpmiGetSystemUuid ( > > - OUT EFI_GUID *SystemGuid > > - ); > > - > > -/** > > - This function gets the channel information. > > - > > - @param[in] GetChannelInfoRequest The get channel informat= ion > > request. > > - @param[out] GetChannelInfoResponse The get channel informat= ion > > response. > > - @param[out] GetChannelInfoResponseSize When input, the expected > size > > of response. > > - When output, the exact s= ize of the returned > > - response. > > - > > - @retval EFI_SUCCESS Get channel information successfully. > > - @retval EFI_INVALID_PARAMETER One of the given input parameters is > > invalid. > > - @retval Others Other errors. > > - > > -**/ > > -EFI_STATUS > > -EFIAPI > > -IpmiGetChannelInfo ( > > - IN IPMI_GET_CHANNEL_INFO_REQUEST *GetChannelInfoRequest, > > - OUT IPMI_GET_CHANNEL_INFO_RESPONSE *GetChannelInfoResponse, > > - OUT UINT32 *GetChannelInfoResponseSize > > - ); > > - > > -// > > -// NetFnTransport > > -// > > -EFI_STATUS > > -EFIAPI > > -IpmiSolActivating ( > > - IN IPMI_SOL_ACTIVATING_REQUEST *SolActivatingRequest, > > - OUT UINT8 *CompletionCode > > - ); > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiSetSolConfigurationParameters ( > > - IN IPMI_SET_SOL_CONFIGURATION_PARAMETERS_REQUEST > > *SetConfigurationParametersRequest, > > - IN UINT32 SetConfigurationP= arametersRequestSize, > > - OUT UINT8 *CompletionCode > > - ); > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiGetSolConfigurationParameters ( > > - IN IPMI_GET_SOL_CONFIGURATION_PARAMETERS_REQUEST > > *GetConfigurationParametersRequest, > > - OUT IPMI_GET_SOL_CONFIGURATION_PARAMETERS_RESPONSE > > *GetConfigurationParametersResponse, > > - IN OUT UINT32 > > *GetConfigurationParametersResponseSize > > - ); > > - > > -/** > > - This function gets the LAN configuration parameter. > > - > > - @param[in] GetLanConfigurationParametersRequest Request data > > - @param[out] GetLanConfigurationParametersResponse Response data > > - @param[in,out] GetLanConfigurationParametersSize When input, th= e > > expected size of response data. > > - When out, the = exact size of response data. > > - > > - @retval EFI_SUCCESS Lan configuration parameter is return= ed in the > > response. > > - @retval EFI_INVALID_PARAMETER One of the given input parameters is > > invalid. > > - @retval Others Other errors. > > - > > -**/ > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiGetLanConfigurationParameters ( > > - IN IPMI_GET_LAN_CONFIGURATION_PARAMETERS_REQUEST > > *GetLanConfigurationParametersRequest, > > - OUT IPMI_GET_LAN_CONFIGURATION_PARAMETERS_RESPONSE > > *GetLanConfigurationParametersResponse, > > - IN OUT UINT32 *GetLanConfigu= rationParametersSize > > - ); > > - > > -// > > -// NetFnChasis > > -// > > -EFI_STATUS > > -EFIAPI > > -IpmiGetChassisCapabilities ( > > - OUT IPMI_GET_CHASSIS_CAPABILITIES_RESPONSE > > *GetChassisCapabilitiesResponse > > - ); > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiGetChassisStatus ( > > - OUT IPMI_GET_CHASSIS_STATUS_RESPONSE *GetChassisStatusResponse > > - ); > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiChassisControl ( > > - IN IPMI_CHASSIS_CONTROL_REQUEST *ChassisControlRequest, > > - OUT UINT8 *CompletionCode > > - ); > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiSetPowerRestorePolicy ( > > - IN IPMI_SET_POWER_RESTORE_POLICY_REQUEST > *ChassisControlRequest, > > - OUT IPMI_SET_POWER_RESTORE_POLICY_RESPONSE > > *ChassisControlResponse > > - ); > > - > > -// > > -// NetFnStorage > > -// > > -EFI_STATUS > > -EFIAPI > > -IpmiSetSystemBootOptions ( > > - IN IPMI_SET_BOOT_OPTIONS_REQUEST *BootOptionsRequest, > > - OUT IPMI_SET_BOOT_OPTIONS_RESPONSE *BootOptionsResponse > > - ); > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiGetSystemBootOptions ( > > - IN IPMI_GET_BOOT_OPTIONS_REQUEST *BootOptionsRequest, > > - OUT IPMI_GET_BOOT_OPTIONS_RESPONSE *BootOptionsResponse > > - ); > > - > > -// > > -// NetFnStorage > > -// > > -EFI_STATUS > > -EFIAPI > > -IpmiGetFruInventoryAreaInfo ( > > - IN IPMI_GET_FRU_INVENTORY_AREA_INFO_REQUEST > > *GetFruInventoryAreaInfoRequest, > > - OUT IPMI_GET_FRU_INVENTORY_AREA_INFO_RESPONSE > > *GetFruInventoryAreaInfoResponse > > - ); > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiReadFruData ( > > - IN IPMI_READ_FRU_DATA_REQUEST *ReadFruDataRequest, > > - OUT IPMI_READ_FRU_DATA_RESPONSE *ReadFruDataResponse, > > - IN OUT UINT32 *ReadFruDataResponseSize > > - ); > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiWriteFruData ( > > - IN IPMI_WRITE_FRU_DATA_REQUEST *WriteFruDataRequest, > > - IN UINT32 WriteFruDataRequestSize, > > - OUT IPMI_WRITE_FRU_DATA_RESPONSE *WriteFruDataResponse > > - ); > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiGetSelInfo ( > > - OUT IPMI_GET_SEL_INFO_RESPONSE *GetSelInfoResponse > > - ); > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiGetSelEntry ( > > - IN IPMI_GET_SEL_ENTRY_REQUEST *GetSelEntryRequest, > > - OUT IPMI_GET_SEL_ENTRY_RESPONSE *GetSelEntryResponse, > > - IN OUT UINT32 *GetSelEntryResponseSize > > - ); > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiAddSelEntry ( > > - IN IPMI_ADD_SEL_ENTRY_REQUEST *AddSelEntryRequest, > > - OUT IPMI_ADD_SEL_ENTRY_RESPONSE *AddSelEntryResponse > > - ); > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiPartialAddSelEntry ( > > - IN IPMI_PARTIAL_ADD_SEL_ENTRY_REQUEST > *PartialAddSelEntryRequest, > > - IN UINT32 PartialAddSelEntryRequestSi= ze, > > - OUT IPMI_PARTIAL_ADD_SEL_ENTRY_RESPONSE > > *PartialAddSelEntryResponse > > - ); > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiClearSel ( > > - IN IPMI_CLEAR_SEL_REQUEST *ClearSelRequest, > > - OUT IPMI_CLEAR_SEL_RESPONSE *ClearSelResponse > > - ); > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiGetSelTime ( > > - OUT IPMI_GET_SEL_TIME_RESPONSE *GetSelTimeResponse > > - ); > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiSetSelTime ( > > - IN IPMI_SET_SEL_TIME_REQUEST *SetSelTimeRequest, > > - OUT UINT8 *CompletionCode > > - ); > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiGetSdrRepositoryInfo ( > > - OUT IPMI_GET_SDR_REPOSITORY_INFO_RESPONSE > > *GetSdrRepositoryInfoResp > > - ); > > - > > -EFI_STATUS > > -EFIAPI > > -IpmiGetSdr ( > > - IN IPMI_GET_SDR_REQUEST *GetSdrRequest, > > - OUT IPMI_GET_SDR_RESPONSE *GetSdrResponse, > > - IN OUT UINT32 *GetSdrResponseSize > > - ); > > - > > -#endif > > -- > > 2.37.1.windows.1 > > > > > > > > > > > > > >=20 > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110165): https://edk2.groups.io/g/devel/message/110165 Mute This Topic: https://groups.io/mt/102213342/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-