[PATCH v3 0/3] Add IPMI SSIF definitions

[PATCH v3 0/3] Add IPMI SSIF definitions

[Tinh Nguyen]

Change from v2:
  - Add the carbon copy (Cc) in the commit message.
  - Add Bugzilla ID in the commit message.
  - Mention why I set the number of retries as 250.

Change from v1:
  - Separate the commit for the IPMI SSIF header and IPMI SSIF PCDs
  - Correct some indent and comment style.
  - Change the PCDs name for a more readable.
  - Support KCS/SMIC Interface Capabilities too.


Tinh Nguyen (3):
  MdePkg/IndustryStandard: Add definitions for IPMI SSIF
  MdePkg: Add new PCDs for IPMI SSIF
  MdePkg/IndustryStandard: Add Interface Capabilities definitions

 MdePkg/MdePkg.dec                              | 27 ++++++
 MdePkg/Include/IndustryStandard/IpmiNetFnApp.h | 46 +++++++++
 MdePkg/Include/IndustryStandard/IpmiSsif.h     | 98 ++++++++++++++++++++
 3 files changed, 171 insertions(+)
 create mode 100644 MdePkg/Include/IndustryStandard/IpmiSsif.h

--
2.40.0

[PATCH v3 1/3] MdePkg/IndustryStandard: Add definitions for IPMI SSIF

[Tinh Nguyen]

BZ#: 4434 - Add IPMI SSIF definitions.

Specification reference:
https://www.intel.com/content/www/us/en/products/docs/servers/ipmi/ipmi-second-gen-interface-spec-v2-rev1-1.html

Signed-off-by: Tinh Nguyen <tinhnguyen@os.amperecomputing.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Cc: Abner Chang <abner.chang@amd.com>
Reviewed-by: Abner Chang <abner.chang@amd.com>
---
 MdePkg/Include/IndustryStandard/IpmiSsif.h | 98 ++++++++++++++++++++
 1 file changed, 98 insertions(+)

diff --git a/MdePkg/Include/IndustryStandard/IpmiSsif.h b/MdePkg/Include/IndustryStandard/IpmiSsif.h
new file mode 100644
index 000000000000..a5bfa14a9dfa
--- /dev/null
+++ b/MdePkg/Include/IndustryStandard/IpmiSsif.h
@@ -0,0 +1,98 @@
+/** @file
+  IPMI SSIF Definitions
+
+  Copyright (c) 2023, Ampere Computing LLC. All rights reserved.<BR>
+  SPDX-License-Identifier: BSD-2-Clause-Patent
+
+  @par Revision Reference:
+    - IPMI Specification
+      Version 2.0, Rev. 1.1
+
+  https://www.intel.com/content/www/us/en/products/docs/servers/ipmi/ipmi-second-gen-interface-spec-v2-rev1-1.html
+**/
+
+#ifndef IPMI_SSIF_H_
+#define IPMI_SSIF_H_
+
+///
+/// Definitions for SMBUS Commands for SSIF
+/// Table 12 - Summary of SMBUS Commands for SSIF
+///
+
+/// Write block
+#define IPMI_SSIF_SMBUS_CMD_SINGLE_PART_WRITE        0x02
+#define IPMI_SSIF_SMBUS_CMD_MULTI_PART_WRITE_START   0x06
+#define IPMI_SSIF_SMBUS_CMD_MULTI_PART_WRITE_MIDDLE  0x07
+#define IPMI_SSIF_SMBUS_CMD_MULTI_PART_WRITE_END     0x08
+
+/// Read block
+#define IPMI_SSIF_SMBUS_CMD_SINGLE_PART_READ        0x03
+#define IPMI_SSIF_SMBUS_CMD_MULTI_PART_READ_START   0x03
+#define IPMI_SSIF_SMBUS_CMD_MULTI_PART_READ_MIDDLE  0x09
+#define IPMI_SSIF_SMBUS_CMD_MULTI_PART_READ_END     0x09
+#define IPMI_SSIF_SMBUS_CMD_MULTI_PART_READ_RETRY   0x0A
+
+///
+/// Definitions for Multi-Part Read Transactions
+/// Section 12.5
+///
+#define IPMI_SSIF_MULTI_PART_READ_START_SIZE      0x1E
+#define IPMI_SSIF_MULTI_PART_READ_START_PATTERN1  0x00
+#define IPMI_SSIF_MULTI_PART_READ_START_PATTERN2  0x01
+#define IPMI_SSIF_MULTI_PART_READ_END_PATTERN     0xFF
+
+///
+/// IPMI SSIF maximum message size
+///
+#define IPMI_SSIF_INPUT_MESSAGE_SIZE_MAX   0xFF
+#define IPMI_SSIF_OUTPUT_MESSAGE_SIZE_MAX  0xFF
+
+///
+/// IPMI SMBus system interface maximum packet size in byte
+///
+#define IPMI_SSIF_MAXIMUM_PACKET_SIZE_IN_BYTES  0x20
+
+typedef enum {
+  IpmiSsifPacketStart = 0,
+  IpmiSsifPacketMiddle,
+  IpmiSsifPacketEnd,
+  IpmiSsifPacketSingle,
+  IpmiSsifPacketMax
+} IPMI_SSIF_PACKET_ATTRIBUTE;
+
+#pragma pack (1)
+///
+/// IPMI SSIF Interface Request Format
+/// Section 12.2 and 12.3
+///
+typedef struct {
+  UINT8    NetFunc;
+  UINT8    Command;
+} IPMI_SSIF_REQUEST_HEADER;
+
+///
+/// IPMI SSIF Interface Response Format
+/// Section 12.4 and 12.5
+///
+typedef struct {
+  UINT8    StartPattern[2];
+  UINT8    NetFunc;
+  UINT8    Command;
+} IPMI_SSIF_RESPONSE_PACKET_START;
+
+typedef struct {
+  UINT8    BlockNumber;
+} IPMI_SSIF_RESPONSE_PACKET_MIDDLE;
+
+typedef struct {
+  UINT8    EndPattern;
+} IPMI_SSIF_RESPONSE_PACKET_END;
+
+typedef struct {
+  UINT8    NetFunc;
+  UINT8    Command;
+} IPMI_SSIF_RESPONSE_SINGLE_PACKET;
+
+#pragma pack ()
+
+#endif /* IPMI_SSIF_H_ */
-- 
2.40.0

[PATCH v3 2/3] MdePkg: Add new PCDs for IPMI SSIF

[Tinh Nguyen]

BZ#: 4434 - Add IPMI SSIF definitions.

This change adds new PCDs for IPMI SSIF.

Specification reference:
https://www.intel.com/content/www/us/en/products/docs/servers/ipmi/ipmi-second-gen-interface-spec-v2-rev1-1.html

Signed-off-by: Tinh Nguyen <tinhnguyen@os.amperecomputing.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Cc: Abner Chang <abner.chang@amd.com>
Reviewed-by: Abner Chang <abner.chang@amd.com>
---
 MdePkg/MdePkg.dec | 27 ++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec
index 7488ccda7a00..9aeff24a4916 100644
--- a/MdePkg/MdePkg.dec
+++ b/MdePkg/MdePkg.dec
@@ -10,6 +10,7 @@
 # Copyright (c) 2022, Loongson Technology Corporation Limited. All rights reserved.<BR>
 # Copyright (c) 2021 - 2022, Arm Limited. All rights reserved.<BR>
 # Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.<BR>
+# Copyright (c) 2023, Ampere Computing LLC. All rights reserved.<BR>
 #
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 #
@@ -2353,6 +2354,32 @@ [PcdsFixedAtBuild,PcdsPatchableInModule]
   # @Prompt IPMI KCS Interface I/O Base Address
   gEfiMdePkgTokenSpaceGuid.PcdIpmiKcsIoBaseAddress|0xca2|UINT16|0x00000031
 
+  ## This is SMBus slave address for the SSIF to the BMC.
+  #  The recommended value defined by IPMI specification is 0x20 (section 12.12).
+  # @Prompt IPMI SSIF SMBus slave address
+  gEfiMdePkgTokenSpaceGuid.PcdIpmiSsifSmbusSlaveAddr|0x20|UINT8|0x00000032
+
+  ## This is the maximum number of IPMI SSIF request retries.
+  #  The IPMI specification specified min value is 5 (section 12.17).
+  # @Prompt Number of IPMI SSIF request retries.
+  gEfiMdePkgTokenSpaceGuid.PcdIpmiSsifRequestRetryCount|0x05|UINT8|0x00000033
+
+  ## This is the required interval for each IPMI request retry.
+  #  The IPMI specification specified a time range of 60ms to 250ms (section 12.17).
+  #  The default setting is min.
+  # @Prompt Time between IPMI SSIF request retries.
+  gEfiMdePkgTokenSpaceGuid.PcdIpmiSsifRequestRetryIntervalMicrosecond|60000|UINT32|0x00000034
+
+  ## This value is the maximum retries of an IPMI SSIF response
+  #  The default value is the same as the Linux Kernel ipmi_ssif driver.
+  # @Prompt Number of IPMI SSIF response retries.
+  gEfiMdePkgTokenSpaceGuid.PcdIpmiSsifResponseRetryCount|250|UINT8|0x00000035
+
+  ## This is the required interval for each IPMI response retry.
+  #  The IPMI specification specified min value is 60ms (section 12.17).
+  # @Prompt Time-out for a response, internal
+  gEfiMdePkgTokenSpaceGuid.PcdIpmiSsifResponseRetryIntervalMicrosecond|60000|UINT32|0x00000036
+
 [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx]
   ## This value is used to set the base address of PCI express hierarchy.
   # @Prompt PCI Express Base Address.
-- 
2.40.0

[PATCH v3 3/3] MdePkg/IndustryStandard: Add Interface Capabilities definitions

[Tinh Nguyen]

This adds more definitions for the IPMI Get System Interface
Capabilities command.

Signed-off-by: Tinh Nguyen <tinhnguyen@os.amperecomputing.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Cc: Abner Chang <abner.chang@amd.com>
Reviewed-by: Abner Chang <abner.chang@amd.com>
---
 MdePkg/Include/IndustryStandard/IpmiNetFnApp.h | 46 ++++++++++++++++++++
 1 file changed, 46 insertions(+)

diff --git a/MdePkg/Include/IndustryStandard/IpmiNetFnApp.h b/MdePkg/Include/IndustryStandard/IpmiNetFnApp.h
index a5835ba08c00..b6bc91f46c2d 100644
--- a/MdePkg/Include/IndustryStandard/IpmiNetFnApp.h
+++ b/MdePkg/Include/IndustryStandard/IpmiNetFnApp.h
@@ -13,6 +13,7 @@
 
   Copyright (c) 1999 - 2018, Intel Corporation. All rights reserved.<BR>
   Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.<BR>
+  Copyright (c) 2023, Ampere Computing LLC. All rights reserved.<BR>
   SPDX-License-Identifier: BSD-2-Clause-Patent
 **/
 
@@ -1046,6 +1047,51 @@ typedef struct {
 //  Constants and Structure definitions for "Get System Interface Capabilities" command to follow here
 //
 
+#define IPMI_GET_SYSTEM_INTERFACE_CAPABILITIES_INTERFACE_TYPE_SSIF  0x0
+#define IPMI_GET_SYSTEM_INTERFACE_CAPABILITIES_INTERFACE_TYPE_KCS   0x1
+#define IPMI_GET_SYSTEM_INTERFACE_CAPABILITIES_INTERFACE_TYPE_SMIC  0x2
+
+typedef union {
+  struct {
+    UINT8    InterfaceType : 4;
+    UINT8    Reserved      : 4;
+  } Bits;
+  UINT8    Uint8;
+} IPMI_GET_SYSTEM_INTERFACE_CAPABILITIES_REQUEST;
+
+typedef union {
+  struct {
+    UINT8    Version            : 3;
+    UINT8    PecSupport         : 1;
+    UINT8    Reserved           : 2;
+    UINT8    TransactionSupport : 2;
+  } Bits;
+  UINT8    Uint8;
+} IPMI_SYSTEM_INTERFACE_SSIF_CAPABILITIES;
+
+typedef union {
+  struct {
+    UINT8    SystemInterfaceVersion : 3;
+    UINT8    Reserved               : 5;
+  } Bits;
+  UINT8    Uint8;
+} IPMI_SYSTEM_INTERFACE_KCS_SMIC_CAPABILITIES;
+
+typedef struct {
+  UINT8                                      CompletionCode;
+  UINT8                                      Reserved;
+  IPMI_SYSTEM_INTERFACE_SSIF_CAPABILITIES    InterfaceCap;
+  UINT8                                      InputMsgSize;
+  UINT8                                      OutputMsgSize;
+} IPMI_GET_SYSTEM_INTERFACE_SSIF_CAPABILITIES_RESPONSE;
+
+typedef struct {
+  UINT8                                          CompletionCode;
+  UINT8                                          Reserved;
+  IPMI_SYSTEM_INTERFACE_KCS_SMIC_CAPABILITIES    InterfaceCap;
+  UINT8                                          InputMaxMsgSize;
+} IPMI_GET_SYSTEM_INTERFACE_KCS_SMIC_CAPABILITIES_RESPONSE;
+
 //
 //  Definitions for Get System Interface Capabilities command SSIF transaction support
 //
-- 
2.40.0

Re: [PATCH v3 0/3] Add IPMI SSIF definitions

[Chang, Abner]

[AMD Official Use Only - General]

Thanks Tinh,
It looks all good.
Reviewed-by: Abner Chang <abner.chang@amd.com>

> -----Original Message-----
> From: Tinh Nguyen <tinhnguyen@os.amperecomputing.com>
> Sent: Wednesday, May 3, 2023 7:24 PM
> To: devel@edk2.groups.io
> Cc: patches@amperecomputing.com; michael.d.kinney@intel.com;
> gaoliming@byosoft.com.cn; zhiguang.liu@intel.com; Chang, Abner
> <Abner.Chang@amd.com>; Tinh Nguyen
> <tinhnguyen@os.amperecomputing.com>
> Subject: [PATCH v3 0/3] Add IPMI SSIF definitions
> 
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
> 
> 
> Change from v2:
>   - Add the carbon copy (Cc) in the commit message.
>   - Add Bugzilla ID in the commit message.
>   - Mention why I set the number of retries as 250.
> 
> Change from v1:
>   - Separate the commit for the IPMI SSIF header and IPMI SSIF PCDs
>   - Correct some indent and comment style.
>   - Change the PCDs name for a more readable.
>   - Support KCS/SMIC Interface Capabilities too.
> 
> 
> Tinh Nguyen (3):
>   MdePkg/IndustryStandard: Add definitions for IPMI SSIF
>   MdePkg: Add new PCDs for IPMI SSIF
>   MdePkg/IndustryStandard: Add Interface Capabilities definitions
> 
>  MdePkg/MdePkg.dec                              | 27 ++++++
>  MdePkg/Include/IndustryStandard/IpmiNetFnApp.h | 46 +++++++++
>  MdePkg/Include/IndustryStandard/IpmiSsif.h     | 98 ++++++++++++++++++++
>  3 files changed, 171 insertions(+)
>  create mode 100644 MdePkg/Include/IndustryStandard/IpmiSsif.h
> 
> --
> 2.40.0

回复: [ ** SPAMMAIL ** ][edk2-devel] [PATCH v3 3/3] MdePkg/IndustryStandard: Add Interface Capabilities definitions

[gaoliming]

Tinh:
  For the patch subject, I suggest to add IPMI key word to specify this change is for IPMI, such as MdePkg/IndustryStandard: Add IPMI Interface Capabilities definitions

Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Tinh Nguyen
> via groups.io
> 发送时间: 2023年5月3日 19:24
> 收件人: devel@edk2.groups.io
> 抄送: patches@amperecomputing.com; michael.d.kinney@intel.com;
> gaoliming@byosoft.com.cn; zhiguang.liu@intel.com; abner.chang@amd.com;
> Tinh Nguyen <tinhnguyen@os.amperecomputing.com>
> 主题: [ ** SPAMMAIL ** ][edk2-devel] [PATCH v3 3/3]
> MdePkg/IndustryStandard: Add Interface Capabilities definitions
> 
> This adds more definitions for the IPMI Get System Interface
> Capabilities command.
> 
> Signed-off-by: Tinh Nguyen <tinhnguyen@os.amperecomputing.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Abner Chang <abner.chang@amd.com>
> Reviewed-by: Abner Chang <abner.chang@amd.com>
> ---
>  MdePkg/Include/IndustryStandard/IpmiNetFnApp.h | 46
> ++++++++++++++++++++
>  1 file changed, 46 insertions(+)
> 
> diff --git a/MdePkg/Include/IndustryStandard/IpmiNetFnApp.h
> b/MdePkg/Include/IndustryStandard/IpmiNetFnApp.h
> index a5835ba08c00..b6bc91f46c2d 100644
> --- a/MdePkg/Include/IndustryStandard/IpmiNetFnApp.h
> +++ b/MdePkg/Include/IndustryStandard/IpmiNetFnApp.h
> @@ -13,6 +13,7 @@
> 
>    Copyright (c) 1999 - 2018, Intel Corporation. All rights reserved.<BR>
>    Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.<BR>
> +  Copyright (c) 2023, Ampere Computing LLC. All rights reserved.<BR>
>    SPDX-License-Identifier: BSD-2-Clause-Patent
>  **/
> 
> @@ -1046,6 +1047,51 @@ typedef struct {
>  //  Constants and Structure definitions for "Get System Interface
> Capabilities" command to follow here
>  //
> 
> +#define
> IPMI_GET_SYSTEM_INTERFACE_CAPABILITIES_INTERFACE_TYPE_SSIF  0x0
> +#define
> IPMI_GET_SYSTEM_INTERFACE_CAPABILITIES_INTERFACE_TYPE_KCS   0x1
> +#define
> IPMI_GET_SYSTEM_INTERFACE_CAPABILITIES_INTERFACE_TYPE_SMIC  0x2
> +
> +typedef union {
> +  struct {
> +    UINT8    InterfaceType : 4;
> +    UINT8    Reserved      : 4;
> +  } Bits;
> +  UINT8    Uint8;
> +} IPMI_GET_SYSTEM_INTERFACE_CAPABILITIES_REQUEST;
> +
> +typedef union {
> +  struct {
> +    UINT8    Version            : 3;
> +    UINT8    PecSupport         : 1;
> +    UINT8    Reserved           : 2;
> +    UINT8    TransactionSupport : 2;
> +  } Bits;
> +  UINT8    Uint8;
> +} IPMI_SYSTEM_INTERFACE_SSIF_CAPABILITIES;
> +
> +typedef union {
> +  struct {
> +    UINT8    SystemInterfaceVersion : 3;
> +    UINT8    Reserved               : 5;
> +  } Bits;
> +  UINT8    Uint8;
> +} IPMI_SYSTEM_INTERFACE_KCS_SMIC_CAPABILITIES;
> +
> +typedef struct {
> +  UINT8                                      CompletionCode;
> +  UINT8                                      Reserved;
> +  IPMI_SYSTEM_INTERFACE_SSIF_CAPABILITIES    InterfaceCap;
> +  UINT8                                      InputMsgSize;
> +  UINT8                                      OutputMsgSize;
> +} IPMI_GET_SYSTEM_INTERFACE_SSIF_CAPABILITIES_RESPONSE;
> +
> +typedef struct {
> +  UINT8
> CompletionCode;
> +  UINT8                                          Reserved;
> +  IPMI_SYSTEM_INTERFACE_KCS_SMIC_CAPABILITIES    InterfaceCap;
> +  UINT8
> InputMaxMsgSize;
> +} IPMI_GET_SYSTEM_INTERFACE_KCS_SMIC_CAPABILITIES_RESPONSE;
> +
>  //
>  //  Definitions for Get System Interface Capabilities command SSIF
> transaction support
>  //
> --
> 2.40.0
> 
> 
> 
> 
> 

Re: 回复: [ ** SPAMMAIL ** ][edk2-devel] [PATCH v3 3/3] MdePkg/IndustryStandard: Add Interface Capabilities definitions

[Tinh Nguyen]

Hi Liming,

Sorry I missed your comment. I have submitted v4 and here is the pull 
request

https://github.com/tianocore/edk2/pull/4352

Thanks,

Tinh

On 04/05/2023 15:06, gaoliming wrote:
> Tinh:
>    For the patch subject, I suggest to add IPMI key word to specify this change is for IPMI, such as MdePkg/IndustryStandard: Add IPMI Interface Capabilities definitions
>
> Thanks
> Liming
>> -----邮件原件-----
>> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Tinh Nguyen
>> via groups.io
>> 发送时间: 2023年5月3日 19:24
>> 收件人: devel@edk2.groups.io
>> 抄送: patches@amperecomputing.com; michael.d.kinney@intel.com;
>> gaoliming@byosoft.com.cn; zhiguang.liu@intel.com; abner.chang@amd.com;
>> Tinh Nguyen <tinhnguyen@os.amperecomputing.com>
>> 主题: [ ** SPAMMAIL ** ][edk2-devel] [PATCH v3 3/3]
>> MdePkg/IndustryStandard: Add Interface Capabilities definitions
>>
>> This adds more definitions for the IPMI Get System Interface
>> Capabilities command.
>>
>> Signed-off-by: Tinh Nguyen <tinhnguyen@os.amperecomputing.com>
>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
>> Cc: Abner Chang <abner.chang@amd.com>
>> Reviewed-by: Abner Chang <abner.chang@amd.com>
>> ---
>>   MdePkg/Include/IndustryStandard/IpmiNetFnApp.h | 46
>> ++++++++++++++++++++
>>   1 file changed, 46 insertions(+)
>>
>> diff --git a/MdePkg/Include/IndustryStandard/IpmiNetFnApp.h
>> b/MdePkg/Include/IndustryStandard/IpmiNetFnApp.h
>> index a5835ba08c00..b6bc91f46c2d 100644
>> --- a/MdePkg/Include/IndustryStandard/IpmiNetFnApp.h
>> +++ b/MdePkg/Include/IndustryStandard/IpmiNetFnApp.h
>> @@ -13,6 +13,7 @@
>>
>>     Copyright (c) 1999 - 2018, Intel Corporation. All rights reserved.<BR>
>>     Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.<BR>
>> +  Copyright (c) 2023, Ampere Computing LLC. All rights reserved.<BR>
>>     SPDX-License-Identifier: BSD-2-Clause-Patent
>>   **/
>>
>> @@ -1046,6 +1047,51 @@ typedef struct {
>>   //  Constants and Structure definitions for "Get System Interface
>> Capabilities" command to follow here
>>   //
>>
>> +#define
>> IPMI_GET_SYSTEM_INTERFACE_CAPABILITIES_INTERFACE_TYPE_SSIF  0x0
>> +#define
>> IPMI_GET_SYSTEM_INTERFACE_CAPABILITIES_INTERFACE_TYPE_KCS   0x1
>> +#define
>> IPMI_GET_SYSTEM_INTERFACE_CAPABILITIES_INTERFACE_TYPE_SMIC  0x2
>> +
>> +typedef union {
>> +  struct {
>> +    UINT8    InterfaceType : 4;
>> +    UINT8    Reserved      : 4;
>> +  } Bits;
>> +  UINT8    Uint8;
>> +} IPMI_GET_SYSTEM_INTERFACE_CAPABILITIES_REQUEST;
>> +
>> +typedef union {
>> +  struct {
>> +    UINT8    Version            : 3;
>> +    UINT8    PecSupport         : 1;
>> +    UINT8    Reserved           : 2;
>> +    UINT8    TransactionSupport : 2;
>> +  } Bits;
>> +  UINT8    Uint8;
>> +} IPMI_SYSTEM_INTERFACE_SSIF_CAPABILITIES;
>> +
>> +typedef union {
>> +  struct {
>> +    UINT8    SystemInterfaceVersion : 3;
>> +    UINT8    Reserved               : 5;
>> +  } Bits;
>> +  UINT8    Uint8;
>> +} IPMI_SYSTEM_INTERFACE_KCS_SMIC_CAPABILITIES;
>> +
>> +typedef struct {
>> +  UINT8                                      CompletionCode;
>> +  UINT8                                      Reserved;
>> +  IPMI_SYSTEM_INTERFACE_SSIF_CAPABILITIES    InterfaceCap;
>> +  UINT8                                      InputMsgSize;
>> +  UINT8                                      OutputMsgSize;
>> +} IPMI_GET_SYSTEM_INTERFACE_SSIF_CAPABILITIES_RESPONSE;
>> +
>> +typedef struct {
>> +  UINT8
>> CompletionCode;
>> +  UINT8                                          Reserved;
>> +  IPMI_SYSTEM_INTERFACE_KCS_SMIC_CAPABILITIES    InterfaceCap;
>> +  UINT8
>> InputMaxMsgSize;
>> +} IPMI_GET_SYSTEM_INTERFACE_KCS_SMIC_CAPABILITIES_RESPONSE;
>> +
>>   //
>>   //  Definitions for Get System Interface Capabilities command SSIF
>> transaction support
>>   //
>> --
>> 2.40.0
>>
>>
>>
>> 
>>
>
>