From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (NAM10-MW2-obe.outbound.protection.outlook.com [40.107.94.59]) by mx.groups.io with SMTP id smtpd.web11.17963.1683117714448083364 for ; Wed, 03 May 2023 05:41:54 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=CXDu6oxv; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.94.59, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Dfs1QcAMZrlbHRxSQyKPnG3RJCNG0mlYPDfajTIc3RytHaPgX0jE7eUDrwP9NiRuUFMlQ/9CE6yzZR1ASOAwh6o+adTT+wylunHu3Ozr4Q2ZRCyZUlepDsry7GeuAQ6c3YD9GitZhqZz1A4KN0+lpy17IUMJvAvgq2HDmQQbKq2+C6jSsq6KSPUt5HpOveg/LLiEC1RUziL/kIDvS7L7JJb5b1oCjQR09lHDxSwYL2pWt7zmCrLI3Gm2+01Bp59STH2dZK67/n+CNLj//rH+UxrI4zVdLqtD8aQ/HJByvhJXmj7AqhL+XIUye4yDCYWIYPWFSjLz/9t/m9vjsiFkoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GxWZwgwpSxWQJA/4NE+h3iGgo3myQiCQ5KhiXN2bNgg=; b=UhTeyOoSyDqKUpYbh8cFwuejzcyW4G9iqKGuM5lDg65lBVqEsKpPZCOIG7IRJPO0gwZUyuB9K0U+uj6xkFeh9wopaOYM4SMYuXKxXnsPSRIawOfad56VJSWTn1fCbWsi4pnEWH/qrbAA33SnL757NPT3zmaUCFKnOFK8xW3O0rpnifuRriHMeJAbH3GHUL6AhY3Z7fvn/FRToN0mgWMiGPaUEU5DCjqiGr5IxQi8JqLreeDrqPlW/eqysmFtbsm7wDNYBk3b6ncoOjVk/cgzdmHj2UZ6VWlrZ1GMHP1ifBupB1N3slPRb3LnbCg6TJi203/KJqNi8zi7ZFU2Vf1qUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GxWZwgwpSxWQJA/4NE+h3iGgo3myQiCQ5KhiXN2bNgg=; b=CXDu6oxv8dkW/H5m+QTtcT2MKLdUm+J0ESyNid1dsGUEac9Gg+cDcAXnnvyHDR5ztCDkRLBnpvUDE8J6kc1qL1NkNwaki5bkTL8/tzJqqvuuHdx4/QFp9QPRUfnJnIff5EA2yHqaUHZ6Ejjs/KIHZumM9VVoj/3omlz0ycVUvsM= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by MW3PR12MB4506.namprd12.prod.outlook.com (2603:10b6:303:53::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.31; Wed, 3 May 2023 12:41:52 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::46f1:bdce:a4bc:29e3]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::46f1:bdce:a4bc:29e3%3]) with mapi id 15.20.6340.031; Wed, 3 May 2023 12:41:52 +0000 From: "Chang, Abner" To: Tinh Nguyen , "devel@edk2.groups.io" CC: "patches@amperecomputing.com" , "michael.d.kinney@intel.com" , "gaoliming@byosoft.com.cn" , "zhiguang.liu@intel.com" Subject: Re: [PATCH v3 0/3] Add IPMI SSIF definitions Thread-Topic: [PATCH v3 0/3] Add IPMI SSIF definitions Thread-Index: AQHZfbHruDzHNsNJxEmFElM9cOjZhq9Ifavg Date: Wed, 3 May 2023 12:41:51 +0000 Message-ID: References: <20230503112415.2073176-1-tinhnguyen@os.amperecomputing.com> In-Reply-To: <20230503112415.2073176-1-tinhnguyen@os.amperecomputing.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-05-03T12:41:49Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=30289511-ec5e-456f-bd7d-f907c3be0614; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|MW3PR12MB4506:EE_ x-ms-office365-filtering-correlation-id: a1ee6407-7fbe-48ae-e010-08db4bd3c513 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ysCzCVKAcUXcQtKkdOyYZ0aSklUt6heuBk3zix8Kty9lieTkj0PDt2RCs2OtyXopozfO74V/QRnJH6xIJF6loh6f1vY0VBNeljQAV5sV0UpvQh8TjoMLp1Ulyx6qnQeSQtIal+7bc2Ob6b+FtYzKILuqTunJ3Q2v1W1MNQlMp8PIMscGOuxr6YVdp7ZBOzpdUPOj4EpF8U81mvY7VIqTMO+MFIjw4qGBzT7kqZyryuCjY6JizhIKu0RNdAxbTpiamhjkdIQgbsstjByDdCs7JT4u6wgVxoD10KDB05iebyHXMK1uF3ZzMAHp9P9P9tN3IGGs7Ol8V1op+32lOaGKkdxSJeHdt+8EwUFOVZtE2mmFDAjHry439wgObNsDNva1P9r8bGAYJa9wUf4sUMnr8L/OWuHIRA4VV8uWedjkiPAlR0E9w+nxctxHN5AnvxI/IAMguk1MTl9bWa4kaezRURQqNkNxoMRE6BMe6tCwiFfU3oVnLXVKu2UqXAjAdMW+k6wZzDfnX/Fekka81WkiLovGDbuZSYV4Osku89UuaY2ybubjKZKbt1VjfjweZd3G1MkbBETpjx4bT6UedrUaKOGbU7TydOhry8gfO0I23mLnSqNXRjOSo3WaRzDDY3rU x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(136003)(396003)(366004)(39860400002)(346002)(451199021)(38100700002)(86362001)(52536014)(8936002)(5660300002)(4326008)(66476007)(64756008)(66446008)(66946007)(66556008)(76116006)(122000001)(8676002)(41300700001)(316002)(38070700005)(2906002)(53546011)(6506007)(26005)(9686003)(186003)(71200400001)(7696005)(83380400001)(33656002)(55016003)(478600001)(54906003)(110136005);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?SOgjqKEeCe5FQdpK/vD/MFjcd/KMUrkt9zRFJNfPg5HsUGPSkywtpDNe02sy?= =?us-ascii?Q?6fOxx7PiOEBACmSEobgDV0PrQQyoE8X4SsaECQyfNXscmR48XY9L3VlGhYGW?= =?us-ascii?Q?Vj39jyXnXEdYhdmZZ7/WmJrGK1GCw8FycnpcOYcBbHaoyUVM4cwATfZaoMJv?= =?us-ascii?Q?FlOMMgTps8/aDng9ms55JyVppUlDM2e20H9uUVW3i/7uYTz2AvpgwlcSBbAe?= =?us-ascii?Q?evFACoXxQWECLxUpNrlswB29rD217vGKQxWdHflET7OqKrcuAYpuvGG6+kBN?= =?us-ascii?Q?ra/QPFA+QsBlrpNiq9b+6SbkJBKwYsLWe1+vQd2p+hqgMhiCNP+GdCkwtsSX?= =?us-ascii?Q?0K8kl1zyG127CFsCFcRsBejiCihQQae3Z1RNqA64Krb2g+sENvDfUYYA0M8E?= =?us-ascii?Q?nQ+ae7Oxb0OruIJLpnC2yIWdSof6QYQA0XENqbGKAUwmhYM/JLLnc3hf1FRJ?= =?us-ascii?Q?YVILBiQM6n11UH7dZlXQHnwi7zdqVLwvCFc9KmOkgN9D/y/1gy/HQJ9hpV9e?= =?us-ascii?Q?9uBsNf1PQ5JXApBakuT53JHz5/ox7NgHJy9suyjkHtBX+f03Q0TrmubGOmHv?= =?us-ascii?Q?bcwb8UWlqdpgnKjDvRNChSszt2dxhMlVCdb+2XMz1U1dMdU1EF3/kVAn2rLr?= =?us-ascii?Q?5q3Pkazye+Jnv+kohkYKgh/AfItUZKqFjfWafJ0bjjJmxw+jmce1p3NJ0QkE?= =?us-ascii?Q?1Pj1IuK8DzIt/5VGEkFb5lZNZ2avaViBJppbI36Wabu5WGyouEf3MDZq7hTx?= =?us-ascii?Q?wbU2kDl4Vym01BSFF8xn20TdSy0dcIJulU82ME7CmGt/gtzRf80WmUm/sXs9?= =?us-ascii?Q?jcL/vbkRJFGhzgdyrKNsRZuLv1/QW1mNc+Sf13es+3MpuXAQ9LhuOETixstX?= =?us-ascii?Q?eTUK9eUAvNV4ihiPcA9RdZHAKVMFVuFGbvPTNFRCgOw4uefyi7nfa3vQNlZW?= =?us-ascii?Q?FnAaBV8hVmF7U3vzU9/ZAytelnLwpDxX60mU8wUoCbgqvbrpvF0CmQLQdyYN?= =?us-ascii?Q?5Bzy8Y+A/rrMfCPJTl5u2VlavXjb2DQcFy50mOielA9spN/LHN53irpururt?= =?us-ascii?Q?/JU8zBEHylttsYOjDUo+LhVLwrGLaw276CQ7RQxlq8SRKUwX45MWxsKQ600F?= =?us-ascii?Q?2Yg2Ylcity14rTirm7uU4jY31NiEKxOg7c0e6iE/w34IKafMxB7E636Z1+gY?= =?us-ascii?Q?NwwSJNHSW6rM8SKrR3gD0pc4+rQxo80BQx6sxlVSIdIbJN222JI7i7gDsQUh?= =?us-ascii?Q?Ayf48iud8XX28LH4Y01S47qnO5KeDSwQihMWwStxbpOEI++RR7OF0baT918g?= =?us-ascii?Q?WsWeeWEXe+AoZYu8DQ7Vsgoy+Or+Qms9tvgzDiy+5jiTlHdqwULbWVI6bevN?= =?us-ascii?Q?DesR9vHWzN1JUgPmM/7/mBrjXCfoGeQt8K9JuHIYzgJVbQizprtnxeuoeJwM?= =?us-ascii?Q?qrBaafvSxFln2I7rJUQHLhhJtrY286F7719QKWYwx6do5xwl4oF7Ub3j2dJ5?= =?us-ascii?Q?VLR3Yldmzki2EY/kiO11NaWJpiFOJrbkqlncMXbyC3J4bjFO+bpm4A2fGYxH?= =?us-ascii?Q?DOA6RjkSc+/LTvLBjbE=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a1ee6407-7fbe-48ae-e010-08db4bd3c513 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 May 2023 12:41:51.9364 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BF8xNVimkqWist0b+PIqBr/bK/Fk7LbCCF0uTQI2gO1vDYHLCYfApesxujc27pfGbwcuLOWp7TuKPPJ9oTohdg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4506 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Thanks Tinh, It looks all good. Reviewed-by: Abner Chang > -----Original Message----- > From: Tinh Nguyen > Sent: Wednesday, May 3, 2023 7:24 PM > To: devel@edk2.groups.io > Cc: patches@amperecomputing.com; michael.d.kinney@intel.com; > gaoliming@byosoft.com.cn; zhiguang.liu@intel.com; Chang, Abner > ; Tinh Nguyen > > Subject: [PATCH v3 0/3] Add IPMI SSIF definitions >=20 > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. >=20 >=20 > Change from v2: > - Add the carbon copy (Cc) in the commit message. > - Add Bugzilla ID in the commit message. > - Mention why I set the number of retries as 250. >=20 > Change from v1: > - Separate the commit for the IPMI SSIF header and IPMI SSIF PCDs > - Correct some indent and comment style. > - Change the PCDs name for a more readable. > - Support KCS/SMIC Interface Capabilities too. >=20 >=20 > Tinh Nguyen (3): > MdePkg/IndustryStandard: Add definitions for IPMI SSIF > MdePkg: Add new PCDs for IPMI SSIF > MdePkg/IndustryStandard: Add Interface Capabilities definitions >=20 > MdePkg/MdePkg.dec | 27 ++++++ > MdePkg/Include/IndustryStandard/IpmiNetFnApp.h | 46 +++++++++ > MdePkg/Include/IndustryStandard/IpmiSsif.h | 98 ++++++++++++++++++++ > 3 files changed, 171 insertions(+) > create mode 100644 MdePkg/Include/IndustryStandard/IpmiSsif.h >=20 > -- > 2.40.0