From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 24694940FE2 for ; Thu, 23 Nov 2023 03:06:11 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=VAKRWl7F45rR6MTMnVXXJ/RkjnBXLvHZc7QiHBiqUDU=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1700708770; v=1; b=MRCW/Mu8yBjRABcDBhaV6yjh4wmIaJOGoumJjNhl2HrQlVNX4NYvG1QglbTUlBvWXmsD9jpy U2mCeQbLx2O7kx2dz7hk2kv5pnA3nVV03+oC/NcK2v2B0MGRHcF93v2D7//0TYmO7s4Jgjxl3bU quPbQzglIaiwdPKHyt7Cuh/4= X-Received: by 127.0.0.2 with SMTP id gxfrYY7687511xD8b6XRw3JG; Wed, 22 Nov 2023 19:06:10 -0800 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.76]) by mx.groups.io with SMTP id smtpd.web11.83948.1700708769820050774 for ; Wed, 22 Nov 2023 19:06:10 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Os+6nFjuiY1PmxRJZlBxRLFLFwP2COr/0aApoYZGQ9WNiidTIoeMPIxD72sDMeOAVjRFDFVIdgBrmZ6/ptbh0VPULZvdUYuocMNYH1euqa9dyqpIZdCF3RjaojnPL+tiRKSgCfjZ/aQSvuKPrx74gly8RpsFCB2m7atkuudJY840CurP9aoDxaK1+3CsbiE5pwsEHNgeT5F8eiT2To9/PFq9ULUI9W++3DlMy7T5oHglV/UFdkF1dHCZlJu17x799UHiopWAlCQYQo8gzBs6QFIp815mereQzEMLauqYZO9b+F/lsk3L0sJFwxLSRL/9nrGWTwCixRM89vjuwga09w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RGC5nBzne8mqz9PrNXiTxX/rvCWl2+YyBnek2Ebo2gQ=; b=hrQTA7f7XyeSv5TK8w2YndjC68Shuo6uoI2o8MTu7mbSwF7kazrNIS8iHx41H4vZ4IKVfRtOENI+S9mHxBTxEWFHvpTk2W6FwLFed3raFCR3aSAfZgn17bD5wn3wyCJwZkE56qrh2zq+9Q0Dr8Hjbg7SFCX2olOf1KsNpl1IdCv6dxc8gLMDEn1+TaO05fN/lykoXZVnxvdXARcEx9YD6jLgh/JrXYrDihuWlj1f+IjDgK+BXYb7NAdz03r/4N79l8NMXU1CO6HI54yh0ezsdQyEO9PLjAfudET2n2Rw0tll8ii+cfFw7HcIsUGPCfCo5by74dXfE0hUblX+Crz98A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by CH3PR12MB8459.namprd12.prod.outlook.com (2603:10b6:610:139::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.20; Thu, 23 Nov 2023 03:06:07 +0000 X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::91d9:e679:32a3:dd05]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::91d9:e679:32a3:dd05%5]) with mapi id 15.20.7025.017; Thu, 23 Nov 2023 03:06:07 +0000 From: "Chang, Abner via groups.io" To: "devel@edk2.groups.io" , "Chang, Abner" , Nickle Wang , Mike Maslenkin CC: "igork@ami.com" Subject: Re: [edk2-devel] [PATCH v2 3/3] RedfishPkg: fix searching for the BMC-exposed USB NIC Thread-Topic: [edk2-devel] [PATCH v2 3/3] RedfishPkg: fix searching for the BMC-exposed USB NIC Thread-Index: AQHaHaAwd+m7wQyEYkCCg9zwhDrJrbCHC3aAgAAPAACAAB4QEA== Date: Thu, 23 Nov 2023 03:06:07 +0000 Message-ID: References: <20231123000103.31216-1-mike.maslenkin@gmail.com> <20231123000103.31216-4-mike.maslenkin@gmail.com> <179A1BD569EE113B.9514@groups.io> In-Reply-To: <179A1BD569EE113B.9514@groups.io> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=6cffde9f-6d2d-4889-b6ca-edc66c1e6fc3;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-11-23T01:17:42Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|CH3PR12MB8459:EE_ x-ms-office365-filtering-correlation-id: 6f24c48b-376b-4656-9380-08dbebd12325 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: BQsmc43IqYNlV4egJKKWQ9/8El/ttdxsZBAI3wHzH3x0Qc/wRLAo8G2af060xGPl3RRA84+ahi+qQvwaMS9M+36jgZ20MqIBe8N2mIzGdTzJiosgQ1flKJLkqXglh6ccvl8CcoqQjLTdDWaXY8RgVnPzByJin1lPmHue+idt6sy694zDxfkh2EHGv7jcyggGiU/dBFz1ywqPdui3fcb8X7Cs23p/HMGE+lcLB4kz0pwdVr5jMYJ9jJIv9whsgwuUYQ81M/WoI5P643J9d5nepyYSpCd/cthZYxXgxCfpjpqw3SGk02f2pXcp66BU39iDaeTSKEs+j38w5R9Sb8iPBLjQd8DUkp0nOf3xMGrE/vIR/9vVXHlBiILdUd64ZeTxOpCk6lfu1MyIhBTe4hCWLmf22ZsjsSD1D0AUsEV6CwGJonCgPnWKx2n7bbmMTyhmPwdpFIYmJX2gc1Mv0liQkZjpL6jt4xGfxatioQEX2FuUy+57Pfpbr+XHnBq9vWmBoJpXlefmtViKsSva0luBDYEvGAFO7puY43Dir8J6OY+CnUU//mrUuWG2Rvtniei2NgEvZmyG26lTjkqWYnmDlpAs+N2WF1fDBKxkMoLgYXIiczsUyDbfQ7odxqVOW7BQgxxt6ESzq8C2tG425ESm36rO8Mb4NohsWcqnkAoSQ1o= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?gU2YYaG6dEeIUd5mMaz292IW2S5+3KVDe5u4jv3GNDAgHKLOGIfTK3rRm3IH?= =?us-ascii?Q?hV0WJ98n5JP/EUoGbiesn+kLmS6fI4yopK6QefAWYy+aFZPX5u+8zw1hwFwB?= =?us-ascii?Q?LKWmGg9/LxRI4nzJkidl9fCzbJrYZZ+Uv1LvMynb3a8d/xRvnqHwmNbamg7u?= =?us-ascii?Q?TiV6s//La4F/Mf23hAz3iDIZp8N3+rraiuJC3znkgvrGrKKPGpjcCAof1bsW?= =?us-ascii?Q?0dd8eA5fkrwUXl1TeSvOB7B3K24X3RXXVOwom2296ec/8RTA8osZqlqMyzP6?= =?us-ascii?Q?Wx5blwyb3eqGDwyXABfexFLon0frf9ljGXrSPOzjVlLu9ESjKTWUoLOCDwN0?= =?us-ascii?Q?7AkxcXXMmiwX4d3SsGIgTl4d5HJoAYOJQRbw6qFCCIAhdiTxbUrOdCouKO37?= =?us-ascii?Q?Lwq3Q+KHFm3Q7JfkqjssUK6tCvtcyFdVezacmaBWbmyXJrn9Y8qcZoL/1Tur?= =?us-ascii?Q?li2LYUgNQAADrFFMDV0Gzi4FBtJuJxV3RW+HHOxIGK1i5WdkoyhlP953m/u3?= =?us-ascii?Q?Y4QtyZRP6aujAO+5/dQ8XfxLrxeup2AcKD/EW5t+L5b/k0WT+Tdbx7vWpyJ4?= =?us-ascii?Q?9VXiss0/o/G5vKV2C2mOp5qVUI+CGYBth2FTI2B2VS3G7TsbqrhaNeMHT2W1?= =?us-ascii?Q?7O8cyic28Z1zJswXXwKnS09n0WKD39nbmWj69M4Ie8e2bl5V67Cc//F6JN6t?= =?us-ascii?Q?cQ+oUuGdKN8q11lMbKbQS/Rh2oBteHieuBm3yO3sxL9eU+9qlcKZYLdUa9mM?= =?us-ascii?Q?6z1RYYKEd52RduHzknrt0T6yxfD9b+Eb1H4CypH6Mvh4TWqQEewPovGA0lbb?= =?us-ascii?Q?UBNEykB6NVZGYb6SfzXVqoyNOHk6Jyc2MnkvSl+35w5rcKsIRgtTaLgMaqXb?= =?us-ascii?Q?zR3bz5D3ZBNm7IjauBNWzMQHVsHktxOnP4BZN0651AWvN2E4wYR2oBbp8+/o?= =?us-ascii?Q?a9Zwa2dbuJG1fW0Dk0WDPqgZuUbmdj47NVtrd8lgf2I/wwqVmjGvkp1h6p/6?= =?us-ascii?Q?uTZ+nzzo1xAbdRB1SXvuumhR+OT7CUZTe6mE44DR6KfPowx6dOSl2ZDez0IE?= =?us-ascii?Q?zlWdIJLxLAXgYL0E+FlFxaaztPTfKWjZEj0kLDVytxR4V06WAbdvizuIKaKD?= =?us-ascii?Q?M2mGdghPTE4HDrvM9DbdJyLKiZmbbdes33Nux0N9YBKGYl05sPg/QuisbHAv?= =?us-ascii?Q?JwQm/rAQAQo2FrHO9NhAWlGgbrmp8xdEZBRLy3oa352CNBuLvxPlYeplQAGp?= =?us-ascii?Q?/ENuJFh6NoGjacM3phdyz7UQwV9qIF+eh30tZQFwN8uBz2wsAW5tcTEKmpCg?= =?us-ascii?Q?rEl6MA+pU9hu/iu+e5M8QOVlJR2L/j++2kFs8xSEuGHcfcK1JeQHl2OZ5lnQ?= =?us-ascii?Q?9miFbe2hmAt7nhMcTVoiHBM707BK/XSRfpV5/0WwGDZkuRRlKjCT5Zg8+xnY?= =?us-ascii?Q?FrqezTebN/8CPvaoMaXPRfGWD9HYaBG2EovnE3ZqoKAlbNJy9DKLnUr5A/NR?= =?us-ascii?Q?u5aIQLzLE8NX3ldeRJG160pb/yarUkhiNJ+HLFdM/upgK9+PVwjUhdpDryYL?= =?us-ascii?Q?AXcBS06H8wDaZ7U5I50=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6f24c48b-376b-4656-9380-08dbebd12325 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Nov 2023 03:06:07.2883 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: CaIMbMdGfMlELJpNJpu7cF8YW32XfXF+JycYmQPcTDaEs1Pa5Vl7E/E3piF+Akuv6dt41J5f8PXAHQQv2W7CGQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8459 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 0R4L6Bf2zYMWfVvuppIYvvATx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="MRCW/Mu8"; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io [AMD Official Use Only - General] Good to go. We can merge this after code freeze. Abner > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Chang, > Abner via groups.io > Sent: Thursday, November 23, 2023 9:20 AM > To: Nickle Wang ; Mike Maslenkin > ; devel@edk2.groups.io > Cc: igork@ami.com > Subject: Re: [edk2-devel] [PATCH v2 3/3] RedfishPkg: fix searching for th= e > BMC-exposed USB NIC > > [AMD Official Use Only - General] > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > [AMD Official Use Only - General] > > HI Nickle and Mike, > I also have some fixes and revised BMC USB NIC library for searching BMC > exposed NIC. > Please don't not merge this patch set just for now. I will review this an= d > compare with the changes I have. > > Thanks > Abner > > > -----Original Message----- > > From: Nickle Wang > > Sent: Thursday, November 23, 2023 8:24 AM > > To: Mike Maslenkin ; devel@edk2.groups.io > > Cc: Chang, Abner ; igork@ami.com > > Subject: RE: [PATCH v2 3/3] RedfishPkg: fix searching for the BMC-expos= ed > > USB NIC > > > > Caution: This message originated from an External Source. Use proper > caution > > when opening attachments, clicking links, or responding. > > > > > > Reviewed-by: Nickle Wang > > > > Regards, > > Nickle > > > > > -----Original Message----- > > > From: Mike Maslenkin > > > Sent: Thursday, November 23, 2023 8:01 AM > > > To: devel@edk2.groups.io > > > Cc: abner.chang@amd.com; Nickle Wang ; > > > igork@ami.com > > > Subject: [PATCH v2 3/3] RedfishPkg: fix searching for the BMC-exposed > USB > > NIC > > > > > > External email: Use caution opening links or attachments > > > > > > > > > According to RedfishPkg/Readme.md document: > > > "The last byte of host-end USB NIC MAC address is the last byte of BM= C- > end > > USB > > > NIC MAC address minus 1." > > > > > > It is necessary to subtract 1 from IpmiLanChannelMacAddress. > > > > > > Cc: Abner Chang > > > Cc: Nickle Wang > > > Cc: Igor Kulchytskyy > > > Signed-off-by: Mike Maslenkin > > > --- > > > .../PlatformHostInterfaceBmcUsbNicLib.c | 4 ++= -- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git > > > > > > a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInter > > fac > > > eBmcUsbNicLib.c > > > > > > b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInter > > fac > > > eBmcUsbNicLib.c > > > index 95900579118b..20ec89d4fcb0 100644 > > > --- > > > > > > a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInter > > fac > > > eBmcUsbNicLib.c > > > +++ > > b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostI > > > +++ nterfaceBmcUsbNicLib.c > > > @@ -738,8 +738,8 @@ HostInterfaceIpmiCheckMacAddress ( > > > (VOID *)&IpmiLanChannelMacAddress.Addr, > > > > > > IpmiLanMacAddressSize - 1 > > > > > > ) !=3D 0) || > > > > > > - (IpmiLanChannelMacAddress.Addr[IpmiLanMacAddressSize - 1] = !=3D > > > > > > - *(UsbNicInfo->MacAddress + IpmiLanMacAddressSize - 1) - 1= ) > > > > > > + (IpmiLanChannelMacAddress.Addr[IpmiLanMacAddressSize - 1] = - 1 > > > + !=3D > > > > > > + *(UsbNicInfo->MacAddress + IpmiLanMacAddressSize - 1)) > > > > > > ) > > > > > > { > > > > > > DEBUG ((DEBUG_REDFISH_HOST_INTERFACE, " MAC address is no= t > > > matched.\n")); > > > > > > -- > > > 2.32.0 (Apple Git-132) > > > >=20 > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111644): https://edk2.groups.io/g/devel/message/111644 Mute This Topic: https://groups.io/mt/102759080/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-