From: "Chang, Abner" <abner.chang@amd.com>
To: Minh Nguyen <minhnguyen1@os.amperecomputing.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "patches@amperecomputing.com" <patches@amperecomputing.com>,
"nicklew@nvidia.com" <nicklew@nvidia.com>,
"igork@ami.com" <igork@ami.com>,
"nhi@os.amperecomputing.com" <nhi@os.amperecomputing.com>
Subject: Re: [v1 PATCH 0/5] Adding necessary changes for RedfishPkg
Date: Thu, 4 May 2023 02:16:39 +0000 [thread overview]
Message-ID: <MN2PR12MB3966E2D004F4D50A450C31F4EA6D9@MN2PR12MB3966.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20230504015754.1352305-1-minhnguyen1@os.amperecomputing.com>
[AMD Official Use Only - General]
Hi Minh,
You can run Patchcheck (Basetools/Scripts/) before you sending out the patch, Patchcheck can catch the patch format errors.
Please add "Cc:" to maintainers in commit message in each patch and send the V2 with the subject prefix in the format of "PATCH version", such as "PATCH V2".
For example:
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Thanks
Abner
> -----Original Message-----
> From: Minh Nguyen <minhnguyen1@os.amperecomputing.com>
> Sent: Thursday, May 4, 2023 9:58 AM
> To: devel@edk2.groups.io
> Cc: patches@amperecomputing.com; Chang, Abner
> <Abner.Chang@amd.com>; nicklew@nvidia.com; igork@ami.com;
> nhi@os.amperecomputing.com; Minh Nguyen
> <minhnguyen1@os.amperecomputing.com>
> Subject: [v1 PATCH 0/5] Adding necessary changes for RedfishPkg
>
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
>
>
> This patchset adds necessary changes for RedfishPkg to avoid some
> unexpected cases and fix compilation.
>
> Changes since v1:
> + Remove redundant change and change the commit message for more
> precise in PATCH 2/5.
>
> Nhi Pham (1):
> RedfishPkg: Add missing newline character
>
> Vu Nguyen (4):
> RedfishPkg: Correct variable type to prevent memory corruption
> RedfishPkg: Fix condition checking of error status
> RedfishPkg: Create RestEx child on selected interface
> RedfishPkg: Fix compile issue on Linux
>
> RedfishPkg/Include/Library/RestExLib.h | 3 +
> RedfishPkg/Include/Pcd/RestExServiceDevicePath.h | 5 +-
> RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.h | 3 +-
> RedfishPkg/Library/DxeRestExLib/DxeRestExLib.c | 153 ++++++++----
> --------
> RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 4 +-
> RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c | 3 +-
> 6 files changed, 73 insertions(+), 98 deletions(-)
>
> --
> 2.39.0
next prev parent reply other threads:[~2023-05-04 2:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-04 1:57 [v1 PATCH 0/5] Adding necessary changes for RedfishPkg Minh Nguyen
2023-05-04 1:57 ` [v1 PATCH 1/5] RedfishPkg: Correct variable type to prevent memory corruption Minh Nguyen
2023-05-04 1:57 ` [v1 PATCH 2/5] RedfishPkg: Fix condition checking of error status Minh Nguyen
2023-05-04 1:57 ` [v1 PATCH 3/5] RedfishPkg: Create RestEx child on selected interface Minh Nguyen
2023-05-04 1:57 ` [v1 PATCH 4/5] RedfishPkg: Add missing newline character Minh Nguyen
2023-05-04 1:57 ` [v1 PATCH 5/5] RedfishPkg: Fix compile issue on Linux Minh Nguyen
2023-05-04 2:16 ` Chang, Abner [this message]
2023-05-04 2:33 ` [v1 PATCH 0/5] Adding necessary changes for RedfishPkg Minh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR12MB3966E2D004F4D50A450C31F4EA6D9@MN2PR12MB3966.namprd12.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox