From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (NAM12-DM6-obe.outbound.protection.outlook.com [40.107.243.56]) by mx.groups.io with SMTP id smtpd.web11.40314.1683166602402990303 for ; Wed, 03 May 2023 19:16:42 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=coJg28ae; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.243.56, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LxMRXG5eHo4pTpnrQAe7cZ7Bmt+kfsveoHIbWvD20atxK2f09qcA3NYkHSoLFzPY/nW2xZvrMKcBHSrjP7ZE3H1UpuZaq0b7Z7F/1NVXXlNkSv1hSZz+4BEw3WQT/9ketzee0OJsMFKoHDLPnBThgvQtRGcYXnZdRK2hTMqLTUtowE3zjhbjzkzkGt4XDJRNBF6SgQrrKfp5zfhvz1SzW02T3L5Uc+x5npvFLYL0jq0B55lVUHWy/DTdTrEBtc0JaOdoTSYhmyIPiXn/F/xxvEvAE53Nmf6azval+0UodDFq8DIp7QhXjTevZGCrUT7K/4vB6JAqwohfJpGkGDjYVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=q6ACcNUpbxJJl4BcTWWACefcriVsqdOlegjNgKYNjMQ=; b=UVXEnugimPE7gy3NyjwAmsnrhXV2TMd2Wc+D0T4Zl7XGhV6iM9HjrVEhJqy91LTdkij0XllOHv9MGjTZfzytgsG4Nf2EFvWsFgKJDtUNrB+QdKFDhO5DnYtIXP8e9JwjyUOJpI/krhThUowzUY+xEhBq2fCfe72t+aa+PER5ZBChxIexNyaA++QW3/XACKFapZKDpgT9xPpYx5gT81Ig75C+oaeBJ+RMEv0I9vHqbFbXEtBP2hXoqpGeIFkF8migJE1KXuTML1QjCC6yHl2s+bZ0hi4r1f0jbbv1sZsnNBPiHZiJ5gZ2LMVmXm6rREa4liwf2bxa1Yu6EQwxsEygDA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q6ACcNUpbxJJl4BcTWWACefcriVsqdOlegjNgKYNjMQ=; b=coJg28aeSSaiIO/OJWPgPoClMIiPGhR9J3B9P3TI2UojAq9eH1fx4xXIiZjDqO7cKGMNfea8fQjV9gsICuivYujW76g0jtcB0mwGnJnUDwcY13evmBzsUo0aj4gztGsEB1zWx4sIUxtG7S3+0IOOnNu8hT/GPTOTWnatBex0i3w= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by DM6PR12MB4910.namprd12.prod.outlook.com (2603:10b6:5:1bb::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26; Thu, 4 May 2023 02:16:39 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::46f1:bdce:a4bc:29e3]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::46f1:bdce:a4bc:29e3%3]) with mapi id 15.20.6340.031; Thu, 4 May 2023 02:16:39 +0000 From: "Chang, Abner" To: Minh Nguyen , "devel@edk2.groups.io" CC: "patches@amperecomputing.com" , "nicklew@nvidia.com" , "igork@ami.com" , "nhi@os.amperecomputing.com" Subject: Re: [v1 PATCH 0/5] Adding necessary changes for RedfishPkg Thread-Topic: [v1 PATCH 0/5] Adding necessary changes for RedfishPkg Thread-Index: AQHZfivvdblKfwJuy0aU5KBBOlfUza9JXvUQ Date: Thu, 4 May 2023 02:16:39 +0000 Message-ID: References: <20230504015754.1352305-1-minhnguyen1@os.amperecomputing.com> In-Reply-To: <20230504015754.1352305-1-minhnguyen1@os.amperecomputing.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-05-04T02:16:37Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=53050c31-5003-44fe-9859-92ff354f8fc2; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|DM6PR12MB4910:EE_ x-ms-office365-filtering-correlation-id: 6e3109de-78c9-4dfa-ae44-08db4c45982d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: kr/y5y1n+iKivBFqIsiQb75JTttqxZzGluW+CkCYWgZRv1Xac58EH8Bmx+g8AgmxAidbKVi16h+LTE0dcIw2SqkAhE/BOy6prxvqTqmbNVnRh5PjM+SzuxyVtMeOwhxALfPjim+4ADPqgifm4MQw6Zem5WRkFo6sw+xGzwqVrDCIPv0ICnpn2sAcGE5GfbHZPi1KjPGcW4E9L13VcAYE2COFurFrQI43TfL/IZnVedBvLSv0pG4tZBxdTiu18l7NPiHKKOItZ4JiiWC6h4LGLBHUybTuGOQGNd6fhnyiXA7WyN6OEHeN3zEketVBAhjxT1DwX/jfMx2v9U4ZFyq9KVXXzZFmiXgdYQfVZmNmquL1p/6NBRy2xvfCz+R0Q73QHWbcVUCLsabFvucei+p/+PyLULLeGddwp60yxNV3YL7xf5fwO0/QB0UFRDP8km2dyTdfIHIXWKvMbhVq/i0i6wbKQ5xbZrHM85a4f41Jw3d4UU9Ys6pMK6tBoqCzhCA2+STWQ6aMGmO8P8bBw9kiF+uzPc0dkIxAh0KLm5S15sMTsbVHEYqtnRy2xQGhaJlYIef81DkkLnXZX5kJ5uk22CN/w+r2v69JX/kvn+vGTiGF+L3RrkkA1PjilKm+FVy3 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(366004)(39860400002)(376002)(346002)(136003)(451199021)(38100700002)(478600001)(122000001)(55016003)(52536014)(8936002)(5660300002)(8676002)(110136005)(71200400001)(54906003)(26005)(6506007)(86362001)(66946007)(76116006)(66556008)(66446008)(7696005)(4326008)(83380400001)(64756008)(66476007)(33656002)(316002)(186003)(41300700001)(53546011)(9686003)(2906002)(38070700005);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?hWhLJlql0nv3/fwRi5ixUU0jaRzvCp8nYBQKYY/0OUJanbZdWFcj3mFBgSgQ?= =?us-ascii?Q?4rnA/H6ZVg31DCW/iq5Z60Wim7/EBZmHd1IU491DUXCW7pOEEPzmqo5RfNkv?= =?us-ascii?Q?c+xYNyQxGHQ/3YmwSXdXHx005pRkszxOXkCsRNQYgsa9rjK6H8YGcOqSXqHQ?= =?us-ascii?Q?rZSzk1kkpvP2agx+0nFylDczheY8nAvvrle0BZB4oNHdje3vwDP3598WaHiE?= =?us-ascii?Q?64IjA3K5VmNOLfVDg8Kp9Nf7MuBXIiggFbKY1xm7GONVuALd/ZsLKLSwIRzZ?= =?us-ascii?Q?L8lMGN+KPwTRPKA5HRK/KKTrTGrPB4qB9H7S+cnFJF2bSEeh+C1m+I3YXP/e?= =?us-ascii?Q?3BVvhSKGZ6TqBsG42Yse/1WLcReUOsGpeHmqCVXvEtrDYM4adO8NrWnFcHOG?= =?us-ascii?Q?7mmDqpAwIC1Upt7E0y11XGlsCVo1dKeZGDW0q+J28Ptt7RzDib0kDdBXC+wD?= =?us-ascii?Q?l/BFeA7pMImZ6knOMV3efvixoBK4QyWut5zp/Ea3ElZhiH2zaaS0M1KHzHey?= =?us-ascii?Q?VBOm+Zgc77W4V/i1LsaKhpqfx+gd04AVZgnz6A3ikmWEFY9IWSXLN9piOOO/?= =?us-ascii?Q?tPn1Jb2y04lmGh1SJy3no6Qu20dfkfTuDr8mV0of75Bc9jE4fMUkZq9xrpCG?= =?us-ascii?Q?TJ1Ejp1I9mWPDqIgcMOYB2HCby0FaliN/uVPbVQbpJ376LrtWpaqgwEY6off?= =?us-ascii?Q?4jBeuxaQdDmlWpeV064U/Ns32lSkBo7JWDQ5GPMc8v5VM9c2p2F0TZrIZmH4?= =?us-ascii?Q?mDaNNnPQlisqCnovjIbKqL1QxJieItRi7UFj+v7OvO/uXethTXu1K9CjXEgu?= =?us-ascii?Q?8QZsP7FROfTI3oMu/Bry+SbTlqKIykJvR338f4PeGjOKOa6MtpCTrQvUKxV7?= =?us-ascii?Q?TBLvGdsVuleja5FLibSZ3jLgLdWOL24rEPPSyhjRmFIG1k6OrSgNcusZlxAX?= =?us-ascii?Q?Y/+YZWYEs1S9eii6QKZmo39LyNUR5Xhzs7RW/8QbyDU8JIECJeL/VkZ9ReAP?= =?us-ascii?Q?r8Wj4hT74Ngago2/RFnk3LHP07V8qJULI1+sALQjvA3OdmFuK8VwSOCDza0y?= =?us-ascii?Q?zTlNm1/fXVVq1Fx76ZDM/fjv3wsV0j8LCf+hWjffugtvd+ICzpWVG1YQmmjW?= =?us-ascii?Q?JAqW0QZE0imNRUhHcvTY/baiC0uUqAIbONIfAjo9U93zcyZy9BF9PuOLBBWV?= =?us-ascii?Q?GhIZXkaEdcias2ZfBdjV9d4SNdCkh9LyS9SoQ24hnErFRYK+Op9zrQzBFnE0?= =?us-ascii?Q?kzz+1G1afGSw/Xqx5oXXmRE8EqsgsGbWUcqMIIpg2BMou/wtUmAA54ezPMV5?= =?us-ascii?Q?lv92IjmDx0RgR67tZ+aGQJBlAMV+9oZv0Xa4GjNwQ3cMxNmYf9VnbhCjOEXJ?= =?us-ascii?Q?f4k8UpihSnXD70UNG56lPshr0qq+OReA4yxXhcc4w6hBvvaKTpSuIb6ZK6l+?= =?us-ascii?Q?7grgMb7Z3w+SsMvmH3Rc/jxNFSjq0E9+i08RX12Bv7KtyC5HeP0uv+9Fqndh?= =?us-ascii?Q?EoAPj1VBTQgE1kQ/Vas0nDgjVcI6iV+RMlrpEy1QsHtSDSnhzjGQXYAtG2BW?= =?us-ascii?Q?YHnJ4QROEexPTRXp/lk=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6e3109de-78c9-4dfa-ae44-08db4c45982d X-MS-Exchange-CrossTenant-originalarrivaltime: 04 May 2023 02:16:39.2442 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5pfAc5qU8raxn64BWfbYO4NraVXVt4cIhmvWUBRZn9dVaBeRs5CabmOiAoZWPcVnMrEw1fFyGHyQw/em8CPQGA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4910 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Hi Minh, You can run Patchcheck (Basetools/Scripts/) before you sending out the patc= h, Patchcheck can catch the patch format errors. Please add "Cc:" to maintainers in commit message in each patch and send th= e V2 with the subject prefix in the format of "PATCH version", such as "PAT= CH V2". For example: Cc: Michael D Kinney Cc: Liming Gao Thanks Abner > -----Original Message----- > From: Minh Nguyen > Sent: Thursday, May 4, 2023 9:58 AM > To: devel@edk2.groups.io > Cc: patches@amperecomputing.com; Chang, Abner > ; nicklew@nvidia.com; igork@ami.com; > nhi@os.amperecomputing.com; Minh Nguyen > > Subject: [v1 PATCH 0/5] Adding necessary changes for RedfishPkg >=20 > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. >=20 >=20 > This patchset adds necessary changes for RedfishPkg to avoid some > unexpected cases and fix compilation. >=20 > Changes since v1: > + Remove redundant change and change the commit message for more > precise in PATCH 2/5. >=20 > Nhi Pham (1): > RedfishPkg: Add missing newline character >=20 > Vu Nguyen (4): > RedfishPkg: Correct variable type to prevent memory corruption > RedfishPkg: Fix condition checking of error status > RedfishPkg: Create RestEx child on selected interface > RedfishPkg: Fix compile issue on Linux >=20 > RedfishPkg/Include/Library/RestExLib.h | 3 + > RedfishPkg/Include/Pcd/RestExServiceDevicePath.h | 5 +- > RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.h | 3 +- > RedfishPkg/Library/DxeRestExLib/DxeRestExLib.c | 153 +++++= +++---- > -------- > RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 4 +- > RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c | 3 +- > 6 files changed, 73 insertions(+), 98 deletions(-) >=20 > -- > 2.39.0