public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Chang, Abner" <abner.chang@amd.com>
To: Tinh Nguyen <tinhnguyen@amperemail.onmicrosoft.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Isaac Oram <isaac.w.oram@intel.com>,
	"Attar, AbdulLateef (Abdul Lateef)" <AbdulLateef.Attar@amd.com>,
	Nickle Wang <nicklew@nvidia.com>
Subject: Re: [edk2-platforms][PATCH 1/3] ManageabilityPkg/IpmiPpi: Fix duplicate library instance
Date: Mon, 17 Apr 2023 12:56:41 +0000	[thread overview]
Message-ID: <MN2PR12MB3966E603DAEA36C4D919C008EA9C9@MN2PR12MB3966.namprd12.prod.outlook.com> (raw)
In-Reply-To: <bdad3666-59e3-a124-804b-b7eccc0c4c7f@amperemail.onmicrosoft.com>

[AMD Official Use Only - General]

Sure, I fixed it. Please check V2

Thanks
Abner

> -----Original Message-----
> From: Tinh Nguyen <tinhnguyen@amperemail.onmicrosoft.com>
> Sent: Monday, April 17, 2023 6:40 PM
> To: Chang, Abner <Abner.Chang@amd.com>; devel@edk2.groups.io
> Cc: Isaac Oram <isaac.w.oram@intel.com>; Attar, AbdulLateef (Abdul Lateef)
> <AbdulLateef.Attar@amd.com>; Nickle Wang <nicklew@nvidia.com>
> Subject: Re: [edk2-platforms][PATCH 1/3] ManageabilityPkg/IpmiPpi: Fix
> duplicate library instance
> 
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
> 
> 
> Hi Abner,
> 
> Please assist me in changing the email address to
> tinhnguyen@os.amperecomputing.com.
> 
> Reviewed-by: Tinh Nguyen <tinhnguyen@os.amperecomputing.com>
> 
> On 15/04/2023 18:57, abner.chang@amd.com wrote:
> > [EXTERNAL EMAIL NOTICE: This email originated from an external sender.
> > Please be mindful of safe email handling and proprietary information
> > protection practices.]
> >
> >
> > From: Abner Chang <abner.chang@amd.com>
> >
> > Remove duplicate library instance in [LibraryClass] section.
> >
> > Signed-off-by: Abner Chang <abner.chang@amd.com>
> > Cc: Isaac Oram <isaac.w.oram@intel.com>
> > Cc: Abdul Lateef Attar <abdattar@amd.com>
> > Cc: Nickle Wang <nicklew@nvidia.com>
> > Cc: Tinh Nguyen <tinhnguyen@amperemail.onmicrosoft.com>
> > ---
> >   .../ManageabilityPkg/Universal/IpmiProtocol/Pei/IpmiPpiPei.inf   | 1 -
> >   1 file changed, 1 deletion(-)
> >
> > diff --git
> > a/Features/ManageabilityPkg/Universal/IpmiProtocol/Pei/IpmiPpiPei.inf
> > b/Features/ManageabilityPkg/Universal/IpmiProtocol/Pei/IpmiPpiPei.inf
> > index 8d59b46d48..3f839625ac 100644
> > ---
> > a/Features/ManageabilityPkg/Universal/IpmiProtocol/Pei/IpmiPpiPei.inf
> > +++ b/Features/ManageabilityPkg/Universal/IpmiProtocol/Pei/IpmiPpiPei.
> > +++ inf
> > @@ -37,7 +37,6 @@
> >     ManageabilityTransportHelperLib
> >     ManageabilityTransportLib
> >     PeimEntryPoint
> > -  ManageabilityTransportLib
> >
> >   [Ppis]
> >     gPeiIpmiPpiGuid       # PPI ALWAYS PRODUCED
> > --
> > 2.37.1.windows.1
> >

      reply	other threads:[~2023-04-17 12:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-15 11:57 [edk2-platforms][PATCH 1/3] ManageabilityPkg/IpmiPpi: Fix duplicate library instance Chang, Abner
2023-04-15 11:57 ` [edk2-platforms][PATCH 2/3] ManageabilityPkg: Use SMBUS I2C instead of I2C Chang, Abner
2023-04-17  4:50   ` Attar, AbdulLateef (Abdul Lateef)
2023-04-17  5:22     ` Chang, Abner
2023-04-15 11:57 ` [edk2-platforms][PATCH 3/3] ManageabilityPkg: Support AARCH64 Chang, Abner
2023-04-17  4:51   ` Attar, AbdulLateef (Abdul Lateef)
2023-04-17 10:43   ` Tinh Nguyen
2023-04-17  4:41 ` [edk2-platforms][PATCH 1/3] ManageabilityPkg/IpmiPpi: Fix duplicate library instance Attar, AbdulLateef (Abdul Lateef)
2023-04-17 10:40 ` Tinh Nguyen
2023-04-17 12:56   ` Chang, Abner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MN2PR12MB3966E603DAEA36C4D919C008EA9C9@MN2PR12MB3966.namprd12.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox