From: "Chang, Abner" <abner.chang@amd.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Chang, Abner" <Abner.Chang@amd.com>,
Nickle Wang <nicklew@nvidia.com>
Cc: Igor Kulchytskyy <igork@ami.com>
Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH 4/8] RedfishClientPkg: Bug fix on RedfishFeatureCoreDxe
Date: Fri, 5 May 2023 01:14:44 +0000 [thread overview]
Message-ID: <MN2PR12MB3966E6E2DAB2B29CC6A9E32BEA729@MN2PR12MB3966.namprd12.prod.outlook.com> (raw)
In-Reply-To: <175C194A98AEC019.898@groups.io>
[AMD Official Use Only - General]
Correct email address
Reviewed-by: Abner Chang <abner.chang@amd.com>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Chang,
> Abner via groups.io
> Sent: Friday, May 5, 2023 8:56 AM
> To: Nickle Wang <nicklew@nvidia.com>; devel@edk2.groups.io
> Cc: Igor Kulchytskyy <igork@ami.com>
> Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH 4/8] RedfishClientPkg:
> Bug fix on RedfishFeatureCoreDxe
>
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
>
>
> [AMD Official Use Only - General]
>
> Reviewed-by: Abner Chang <abner.chang@hpe.com>
>
> > -----Original Message-----
> > From: Nickle Wang <nicklew@nvidia.com>
> > Sent: Thursday, May 4, 2023 10:22 PM
> > To: devel@edk2.groups.io
> > Cc: Chang, Abner <Abner.Chang@amd.com>; Igor Kulchytskyy
> > <igork@ami.com>
> > Subject: [edk2-redfish-client][PATCH 4/8] RedfishClientPkg: Bug fix on
> > RedfishFeatureCoreDxe
> >
> > Caution: This message originated from an External Source. Use proper
> > caution when opening attachments, clicking links, or responding.
> >
> >
> > Action in StartupContext is not set properly.
> >
> > Signed-off-by: Nickle Wang <nicklew@nvidia.com>
> > Cc: Abner Chang <abner.chang@amd.com>
> > Cc: Igor Kulchytskyy <igork@ami.com>
> > ---
> > RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c | 3
> > ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git
> > a/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c
> > b/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c
> > index 5cd89872..3776d52b 100644
> > --- a/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c
> > +++
> b/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c
> > @@ -376,7 +376,8 @@ RedfishFeatureCoreEntryPoint (
> > EventGuid = (EFI_GUID *)PcdGetPtr
> > (PcdEdkIIRedfishFeatureDriverStartupEventGuid);
> >
> > ZeroMem ((VOID *)&mFeatureDriverStartupContext, sizeof
> > (REDFISH_FEATURE_STARTUP_CONTEXT));
> > - mFeatureDriverStartupContext.This = &mRedfishFeatureProtocol;
> > + mFeatureDriverStartupContext.This = &mRedfishFeatureProtocol;
> > + mFeatureDriverStartupContext.Action = CallbackActionStartOperation;
> >
> > Status = gBS->CreateEventEx (
> > EVT_NOTIFY_SIGNAL,
> > --
> > 2.17.1
>
>
>
>
prev parent reply other threads:[~2023-05-05 1:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-04 14:22 [edk2-redfish-client][PATCH 4/8] RedfishClientPkg: Bug fix on RedfishFeatureCoreDxe Nickle Wang
2023-05-05 0:56 ` Chang, Abner
[not found] ` <175C194A98AEC019.898@groups.io>
2023-05-05 1:14 ` Chang, Abner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR12MB3966E6E2DAB2B29CC6A9E32BEA729@MN2PR12MB3966.namprd12.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox