* [edk2-redfish-client][PATCH 4/8] RedfishClientPkg: Bug fix on RedfishFeatureCoreDxe
@ 2023-05-04 14:22 Nickle Wang
2023-05-05 0:56 ` Chang, Abner
[not found] ` <175C194A98AEC019.898@groups.io>
0 siblings, 2 replies; 3+ messages in thread
From: Nickle Wang @ 2023-05-04 14:22 UTC (permalink / raw)
To: devel; +Cc: Abner Chang, Igor Kulchytskyy
Action in StartupContext is not set properly.
Signed-off-by: Nickle Wang <nicklew@nvidia.com>
Cc: Abner Chang <abner.chang@amd.com>
Cc: Igor Kulchytskyy <igork@ami.com>
---
RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c b/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c
index 5cd89872..3776d52b 100644
--- a/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c
+++ b/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c
@@ -376,7 +376,8 @@ RedfishFeatureCoreEntryPoint (
EventGuid = (EFI_GUID *)PcdGetPtr (PcdEdkIIRedfishFeatureDriverStartupEventGuid);
ZeroMem ((VOID *)&mFeatureDriverStartupContext, sizeof (REDFISH_FEATURE_STARTUP_CONTEXT));
- mFeatureDriverStartupContext.This = &mRedfishFeatureProtocol;
+ mFeatureDriverStartupContext.This = &mRedfishFeatureProtocol;
+ mFeatureDriverStartupContext.Action = CallbackActionStartOperation;
Status = gBS->CreateEventEx (
EVT_NOTIFY_SIGNAL,
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [edk2-redfish-client][PATCH 4/8] RedfishClientPkg: Bug fix on RedfishFeatureCoreDxe
2023-05-04 14:22 [edk2-redfish-client][PATCH 4/8] RedfishClientPkg: Bug fix on RedfishFeatureCoreDxe Nickle Wang
@ 2023-05-05 0:56 ` Chang, Abner
[not found] ` <175C194A98AEC019.898@groups.io>
1 sibling, 0 replies; 3+ messages in thread
From: Chang, Abner @ 2023-05-05 0:56 UTC (permalink / raw)
To: Nickle Wang, devel@edk2.groups.io; +Cc: Igor Kulchytskyy
[AMD Official Use Only - General]
Reviewed-by: Abner Chang <abner.chang@hpe.com>
> -----Original Message-----
> From: Nickle Wang <nicklew@nvidia.com>
> Sent: Thursday, May 4, 2023 10:22 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner <Abner.Chang@amd.com>; Igor Kulchytskyy
> <igork@ami.com>
> Subject: [edk2-redfish-client][PATCH 4/8] RedfishClientPkg: Bug fix on
> RedfishFeatureCoreDxe
>
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
>
>
> Action in StartupContext is not set properly.
>
> Signed-off-by: Nickle Wang <nicklew@nvidia.com>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
> ---
> RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git
> a/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c
> b/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c
> index 5cd89872..3776d52b 100644
> --- a/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c
> +++ b/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c
> @@ -376,7 +376,8 @@ RedfishFeatureCoreEntryPoint (
> EventGuid = (EFI_GUID *)PcdGetPtr
> (PcdEdkIIRedfishFeatureDriverStartupEventGuid);
>
> ZeroMem ((VOID *)&mFeatureDriverStartupContext, sizeof
> (REDFISH_FEATURE_STARTUP_CONTEXT));
> - mFeatureDriverStartupContext.This = &mRedfishFeatureProtocol;
> + mFeatureDriverStartupContext.This = &mRedfishFeatureProtocol;
> + mFeatureDriverStartupContext.Action = CallbackActionStartOperation;
>
> Status = gBS->CreateEventEx (
> EVT_NOTIFY_SIGNAL,
> --
> 2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [edk2-devel] [edk2-redfish-client][PATCH 4/8] RedfishClientPkg: Bug fix on RedfishFeatureCoreDxe
[not found] ` <175C194A98AEC019.898@groups.io>
@ 2023-05-05 1:14 ` Chang, Abner
0 siblings, 0 replies; 3+ messages in thread
From: Chang, Abner @ 2023-05-05 1:14 UTC (permalink / raw)
To: devel@edk2.groups.io, Chang, Abner, Nickle Wang; +Cc: Igor Kulchytskyy
[AMD Official Use Only - General]
Correct email address
Reviewed-by: Abner Chang <abner.chang@amd.com>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Chang,
> Abner via groups.io
> Sent: Friday, May 5, 2023 8:56 AM
> To: Nickle Wang <nicklew@nvidia.com>; devel@edk2.groups.io
> Cc: Igor Kulchytskyy <igork@ami.com>
> Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH 4/8] RedfishClientPkg:
> Bug fix on RedfishFeatureCoreDxe
>
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
>
>
> [AMD Official Use Only - General]
>
> Reviewed-by: Abner Chang <abner.chang@hpe.com>
>
> > -----Original Message-----
> > From: Nickle Wang <nicklew@nvidia.com>
> > Sent: Thursday, May 4, 2023 10:22 PM
> > To: devel@edk2.groups.io
> > Cc: Chang, Abner <Abner.Chang@amd.com>; Igor Kulchytskyy
> > <igork@ami.com>
> > Subject: [edk2-redfish-client][PATCH 4/8] RedfishClientPkg: Bug fix on
> > RedfishFeatureCoreDxe
> >
> > Caution: This message originated from an External Source. Use proper
> > caution when opening attachments, clicking links, or responding.
> >
> >
> > Action in StartupContext is not set properly.
> >
> > Signed-off-by: Nickle Wang <nicklew@nvidia.com>
> > Cc: Abner Chang <abner.chang@amd.com>
> > Cc: Igor Kulchytskyy <igork@ami.com>
> > ---
> > RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c | 3
> > ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git
> > a/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c
> > b/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c
> > index 5cd89872..3776d52b 100644
> > --- a/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c
> > +++
> b/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c
> > @@ -376,7 +376,8 @@ RedfishFeatureCoreEntryPoint (
> > EventGuid = (EFI_GUID *)PcdGetPtr
> > (PcdEdkIIRedfishFeatureDriverStartupEventGuid);
> >
> > ZeroMem ((VOID *)&mFeatureDriverStartupContext, sizeof
> > (REDFISH_FEATURE_STARTUP_CONTEXT));
> > - mFeatureDriverStartupContext.This = &mRedfishFeatureProtocol;
> > + mFeatureDriverStartupContext.This = &mRedfishFeatureProtocol;
> > + mFeatureDriverStartupContext.Action = CallbackActionStartOperation;
> >
> > Status = gBS->CreateEventEx (
> > EVT_NOTIFY_SIGNAL,
> > --
> > 2.17.1
>
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-05-05 1:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-04 14:22 [edk2-redfish-client][PATCH 4/8] RedfishClientPkg: Bug fix on RedfishFeatureCoreDxe Nickle Wang
2023-05-05 0:56 ` Chang, Abner
[not found] ` <175C194A98AEC019.898@groups.io>
2023-05-05 1:14 ` [edk2-devel] " Chang, Abner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox