From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.41]) by mx.groups.io with SMTP id smtpd.web11.17086.1683249287335761548 for ; Thu, 04 May 2023 18:14:47 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=LKLCpEBR; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.236.41, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L1Cvwk1q2Ysl8sfD42bxs7VJH1yjxao5ai2P6CjxsEr+xy3zpJJcLDRXgXX/hFVr+0USCMnEZiM4jQ7SPlhNCIIEyQMwTIra6rv4mpRNXECQE6GWIRR5KvONKll3C63QH1C6S+fTkrJ8c1oZz37sa+UHJRLY+DSVreTvfZKvIPGkYPDxzsX/j3f8CaTibi3xmruKiWzFOSGrTJlMc+7GjM6EHJ4JeJkOghDvqhv1DbMlqMHom5AgaPfqKfp0B38qhG803L4vnDmhksFV/Ooqso7E+agi8sWtk4fTMpnmjBP3TgRv4hAnNFpA+npKpyEFSnLQSg+7FjoS43inDA8dRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fUDTzaV02SL90dfUoA9Ex7WexGXhGDCU+D4zpNmkUhs=; b=PskhFcMB/nzwWC6M8sJs33YkILc7P+u7qCoxBF2ru0CAqFKc10yt2GQjUjIySj36rnjFhJJBMIY4fyy+uks3XJPN7pbzC9i33srWEp9V/ZaN1Ln/RdBpdo5cW0gS87RnwrhhCVQNdMOUdLjJ5kBf6O7l+h58ITVaJoX4d40QK4cCu25Ywtv42hBqIFURoWlmxiuYwLUULjoNmMuPifubmTXqD1Imv+nbJkbp5PclKqjJv+4tzoXSd9L5W0/omXUBiB0RpgubulT6LZ4hHbSbw/GI/bAs1iDj0iCH2k64PrfwOu/HL5pQb+bwM+ZuHuwlBLwS3eO7UNAGn6vkKQJvMw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fUDTzaV02SL90dfUoA9Ex7WexGXhGDCU+D4zpNmkUhs=; b=LKLCpEBR818AqVUgf30jln4nYNEO0HtOPJnpWlsAgo/z++4pHIiTJ9FhGzjA/J61wXBTMSdT03ueC6O1hnu5jCJsWM9lsC5abhx4l9Ifeyyl2VgZwFoBjfMwEGg6jpNVutsOd0Tt/Z1qkMOpEquzSh43K6VysTU4XH6TEb+Gp3Q= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by CY8PR12MB7338.namprd12.prod.outlook.com (2603:10b6:930:52::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26; Fri, 5 May 2023 01:14:45 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::46f1:bdce:a4bc:29e3]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::46f1:bdce:a4bc:29e3%3]) with mapi id 15.20.6363.027; Fri, 5 May 2023 01:14:44 +0000 From: "Chang, Abner" To: "devel@edk2.groups.io" , "Chang, Abner" , Nickle Wang CC: Igor Kulchytskyy Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH 4/8] RedfishClientPkg: Bug fix on RedfishFeatureCoreDxe Thread-Topic: [edk2-devel] [edk2-redfish-client][PATCH 4/8] RedfishClientPkg: Bug fix on RedfishFeatureCoreDxe Thread-Index: AQHZfpPctLMPfs1F3ku05rG8mMpYi69K25CggAAFNoA= Date: Fri, 5 May 2023 01:14:44 +0000 Message-ID: References: <20230504142219.16327-1-nicklew@nvidia.com> <175C194A98AEC019.898@groups.io> In-Reply-To: <175C194A98AEC019.898@groups.io> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-05-05T01:14:43Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=21ff5212-5e49-4f0e-adaa-c54600adafb5; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|CY8PR12MB7338:EE_ x-ms-office365-filtering-correlation-id: f63822e3-8d7d-4faa-0c1f-08db4d061caf x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3nmy5cuXFxFFEWFK830VKV7pFKYyjD5nBWw9btMtcF5eZzzyYC369EstOH6NswveSxOvjGTpQXFp2vKmcyRAV+nwgzi5vyIWVVChRm1DxGzk08kSWiX9Z5VvP+buWgS8dAgDVgTullzugebvwgYJ0JeydmE6dr+fK4QUgA+skQrciUpHp7Icd3H5q4LBy+5VqkANoTx6Vg5Y01+AAKbydGK/eQdN80JwXk7bhaT7V7KDlVMtpbMRSdF632XwnU0ERz5NIy5a9SCy9zvVgJqP3UETResPp80Twps0YtyqoGadXCcHGN2hUEwzcDcJjYfBxdvuf6w6xv1fhj912P3XvDRmAgKicTU5l308MC/yu8ecPYeaOsGf4zej4PihRvYTOnBmZHj9trl0yD7rR0iRfKpO68dR2dtJjOwEtd39r4aJwDA0YwwQB81gw63h3X06dySTqqRr6fGYbceHn9crqOS43i29JhUv/YI9gpYMlSwRYpDStSHVDEVEihQFjeAPHjC2WfgY3w/B7VSlpA3vLM/7y2LvPB0j34TpqzM5IlaQw50JMR8iWBrglyU774oWNz1X0iJi/xjNCob4NwobdEk/gTP5zwZ2hlIijSHY4/E= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(366004)(376002)(346002)(39860400002)(136003)(451199021)(52536014)(966005)(7696005)(33656002)(122000001)(41300700001)(8936002)(8676002)(86362001)(83380400001)(5660300002)(53546011)(9686003)(4326008)(26005)(6506007)(478600001)(71200400001)(316002)(76116006)(38100700002)(66556008)(66446008)(66476007)(64756008)(66946007)(2906002)(38070700005)(66899021)(186003)(55016003)(110136005);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Js2cYKNy98NUd10Yd4yTGJ0adZru/UnIVOsj3akh/wmX1GcSZBttJwoY6AI6?= =?us-ascii?Q?5NBByh8O732W81cpsYxiyUpFijVOhrT0xOZ1F8pv0sd0Mr8SnDMktkiJhXq+?= =?us-ascii?Q?zaVxz0yNP4CQMt7jjCMuynjMP0YZkz0lBynpCNN0ju/bfRIIhkfABBmdKa7k?= =?us-ascii?Q?RnY7z9gvrKIn6rPsDxS7ejuwtIUaJLhKXUuhZFuoiMhH8ISUPsxtNIH31yBI?= =?us-ascii?Q?Hwx/cW4J0XR25H/V654aUONdE6HDHtVCg2AQj7jbM85JVYzTmV52F+nnj7Yg?= =?us-ascii?Q?ST67Zu1ZGQ5R4B3Ru+G9ewzvK8myaCtvPQ9bed2cnZeG7imgS0VNJZyw2lIS?= =?us-ascii?Q?MAy7CGxNX/KROLcu+g5j3UQi/+vCFvEc0bJ0X14GQ4AT/a2HaV+IDHZhmDh7?= =?us-ascii?Q?q8at7cTBlsJMv2i2JkISWvMAhkVDveGma3+0ca1LANUTtSGqNhZvUUGU6i1Z?= =?us-ascii?Q?HErQ/UQ4sRgahP3HgljO26Fkmaaq9pDhkU+C9IQDeWfV0aSAGZaokZDYu6Fr?= =?us-ascii?Q?LdnoUcf6wTVh8BpkBEotKPanwTgEZEN1ugzhhwCpbESpPOvAqt/nvyYBVZLR?= =?us-ascii?Q?xr+/ADrRb2/d6ZO6PLt1feuI+/WgcsdPDpSrd1AehNuwpagPN74/9/zrdTzS?= =?us-ascii?Q?DfAUVyaX8nYaaKtsyspbnZyTyZQN9+vruQKd+e0xiOn6vX0nAi+ye8hrdIQk?= =?us-ascii?Q?HGMlZ3c5AInvu6kWLDQoh/B/MgjSZaaN+sSTBkS449M9tC09yApUt6m255Pb?= =?us-ascii?Q?BOj0cSrP+pRv1vof4m5eQhFHRbpNo+Q7FkOxZOfTo0/FZuQ08Zu1aoQqoycd?= =?us-ascii?Q?6WSf2iHWzJvLbJ5k7BjEUVPDbEoV49erGvMT4PPSnxcRGjR/4qAY+egCicRU?= =?us-ascii?Q?p+10M7L0ItKsulGmafFpTlM9CTJcVWrUHZTWVcrEbZ58/SgWagAD5yA7+szZ?= =?us-ascii?Q?/MOf7+uqhwlvQYjOid7rZza2Fpnofz/NJLoS95SCXEzBRJpbOaLYmLYY2NOC?= =?us-ascii?Q?QLfhAZQ1Vwopyfs5t59w7FaH3HUeWf9hiqdtZy0mmfAMGwcvdKd8DJDeLFOf?= =?us-ascii?Q?7rpoA2r163STc2EH55e3FbEpcV9q+z595ZSu0AuBB2NlT/swlR/OEQ3uF3xH?= =?us-ascii?Q?cXnhIpArUYlJRF8cwp+ujHjkUym9yK9CS0TCjbpfbLRr/8HkinwQpJpW3mi4?= =?us-ascii?Q?Su/Eqj84jw21nCLJIi1UDubo4uYRKf4BgCQ4JqeHr+ngCK1vKQ4QXCSgd7JC?= =?us-ascii?Q?CmUUMBun43xkf2GIBn3X7iMO5Q4pp23hjyKTqFdSYbAT3npmJuMHnxN4Mvcu?= =?us-ascii?Q?MyBExyCnGDMJVDwBT57u8moNVU+xxTAwJOpb/Ug9D54Hsrs7S+ATN5mdeY4C?= =?us-ascii?Q?Iv89D+EdF2fBFwsR22mXw0g03ZegJpzkXLyXreMX92dDob59Lmv0ogYKsnYl?= =?us-ascii?Q?shWG1FhxaYNjTFcB/07gGT4tFub5GnXDk58KzP9cBVO5WPLeEhPZAA29+BcT?= =?us-ascii?Q?5lluhnMn6M8kJ4tdX/u5DXWWmEp2ky7WfZeSeelSOmfcvAjozLrP9XWtIMfF?= =?us-ascii?Q?FSN+NXI7m8I0gSViH3URZv9jJziugdM69JzpViO2?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f63822e3-8d7d-4faa-0c1f-08db4d061caf X-MS-Exchange-CrossTenant-originalarrivaltime: 05 May 2023 01:14:44.9312 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3wKf6Uyw2gCx7rScUFzAEgACnzj3Yig3HAVTupHKNcFiSqJBHzvYR1yEzrncqvS6qZ1v6QHDpzh/Wz01/hCMdA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7338 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Correct email address Reviewed-by: Abner Chang > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Chang, > Abner via groups.io > Sent: Friday, May 5, 2023 8:56 AM > To: Nickle Wang ; devel@edk2.groups.io > Cc: Igor Kulchytskyy > Subject: Re: [edk2-devel] [edk2-redfish-client][PATCH 4/8] RedfishClientP= kg: > Bug fix on RedfishFeatureCoreDxe >=20 > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. >=20 >=20 > [AMD Official Use Only - General] >=20 > Reviewed-by: Abner Chang >=20 > > -----Original Message----- > > From: Nickle Wang > > Sent: Thursday, May 4, 2023 10:22 PM > > To: devel@edk2.groups.io > > Cc: Chang, Abner ; Igor Kulchytskyy > > > > Subject: [edk2-redfish-client][PATCH 4/8] RedfishClientPkg: Bug fix on > > RedfishFeatureCoreDxe > > > > Caution: This message originated from an External Source. Use proper > > caution when opening attachments, clicking links, or responding. > > > > > > Action in StartupContext is not set properly. > > > > Signed-off-by: Nickle Wang > > Cc: Abner Chang > > Cc: Igor Kulchytskyy > > --- > > RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c | 3 > > ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git > > a/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c > > b/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c > > index 5cd89872..3776d52b 100644 > > --- a/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c > > +++ > b/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c > > @@ -376,7 +376,8 @@ RedfishFeatureCoreEntryPoint ( > > EventGuid =3D (EFI_GUID *)PcdGetPtr > > (PcdEdkIIRedfishFeatureDriverStartupEventGuid); > > > > ZeroMem ((VOID *)&mFeatureDriverStartupContext, sizeof > > (REDFISH_FEATURE_STARTUP_CONTEXT)); > > - mFeatureDriverStartupContext.This =3D &mRedfishFeatureProtocol; > > + mFeatureDriverStartupContext.This =3D &mRedfishFeatureProtocol; > > + mFeatureDriverStartupContext.Action =3D CallbackActionStartOperation= ; > > > > Status =3D gBS->CreateEventEx ( > > EVT_NOTIFY_SIGNAL, > > -- > > 2.17.1 >=20 >=20 >=20 >=20