Re: [edk2-devel] [PATCH V2 1/3] MdeModulePkg/Xhci: Initial XHCI DCI slot's Context value

["Chang, Abner" <abner.chang@amd.com>]

[AMD Official Use Only - General]

Thanks Hao

Abner

> -----Original Message-----
> From: Wu, Hao A <hao.a.wu@intel.com>
> Sent: Monday, January 16, 2023 10:41 AM
> To: devel@edk2.groups.io; Chang, Abner <Abner.Chang@amd.com>
> Cc: Ni, Ray <ray.ni@intel.com>; Kirkendall, Garrett
> <Garrett.Kirkendall@amd.com>; Lin, Kuei-Hung (Timothy) <Kuei-
> Hung.Lin@amd.com>
> Subject: RE: [edk2-devel] [PATCH V2 1/3] MdeModulePkg/Xhci: Initial XHCI
> DCI slot's Context value
> 
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
> 
> 
> The 3-patch series is merged via:
> PR - https://github.com/tianocore/edk2/pull/3899
> Commits - 7cd55f300915...47ab397011b6:
> https://github.com/tianocore/edk2/commit/8147fe090fb566f9a1ed8fde2409
> 8bbe425026be
> https://github.com/tianocore/edk2/commit/be8d6ef3856fac2e64e23847a8f0
> 5d37822b1f14
> https://github.com/tianocore/edk2/commit/47ab397011b6d1ce4d5805117dc
> 87d9e35f378db
> 
> Best Regards,
> Hao Wu
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Chang,
> > Abner via groups.io
> > Sent: Wednesday, January 11, 2023 11:10 AM
> > To: devel@edk2.groups.io
> > Cc: Wu, Hao A <hao.a.wu@intel.com>; Ni, Ray <ray.ni@intel.com>;
> > Garrett Kirkendall <garrett.kirkendall@amd.com>; Abner Chang
> > <abner.chang@amd.com>; Kuei-Hung Lin <Kuei-Hung.Lin@amd.com>
> > Subject: [edk2-devel] [PATCH V2 1/3] MdeModulePkg/Xhci: Initial XHCI
> > DCI slot's Context value
> >
> > From: Abner Chang <abner.chang@amd.com>
> >
> > Initialize XHCI DCI slot's context entries value.
> >
> > Signed-off-by: Jiangang He <jiangang.he@amd.com>
> > Cc: Hao A Wu <hao.a.wu@intel.com>
> > Cc: Ray Ni <ray.ni@intel.com>
> > Cc: Garrett Kirkendall <garrett.kirkendall@amd.com>
> > Cc: Abner Chang <abner.chang@amd.com>
> > Cc: Kuei-Hung Lin <Kuei-Hung.Lin@amd.com>
> > Reviewed-by: Hao A Wu <hao.a.wu@intel.com>
> > ---
> >  MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c | 7 +++++++
> > MdeModulePkg/Bus/Pci/XhciPei/XhciSched.c | 7 +++++++
> >  2 files changed, 14 insertions(+)
> >
> > diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c
> > b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c
> > index 13247f7b0df..4b7462704a8 100644
> > --- a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c
> > +++ b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c
> > @@ -4,6 +4,7 @@
> >
> >  Copyright (c) 2011 - 2020, Intel Corporation. All rights
> > reserved.<BR>  Copyright (c) Microsoft Corporation.<BR>
> > +Copyright (C) 2022 Advanced Micro Devices, Inc. All rights
> > +reserved.<BR>
> >  SPDX-License-Identifier: BSD-2-Clause-Patent
> >
> >  **/
> > @@ -2807,6 +2808,9 @@ XhcInitializeEndpointContext (
> >    MaxDci = 0;
> >
> >    NumEp = IfDesc->NumEndpoints;
> > +  if (NumEp == 0) {
> > +    MaxDci = 1;
> > +  }
> >
> >    EpDesc = (USB_ENDPOINT_DESCRIPTOR *)(IfDesc + 1);
> >    for (EpIndex = 0; EpIndex < NumEp; EpIndex++) { @@ -3006,6 +3010,9
> > @@ XhcInitializeEndpointContext64 (
> >    MaxDci = 0;
> >
> >    NumEp = IfDesc->NumEndpoints;
> > +  if (NumEp == 0) {
> > +    MaxDci = 1;
> > +  }
> >
> >    EpDesc = (USB_ENDPOINT_DESCRIPTOR *)(IfDesc + 1);
> >    for (EpIndex = 0; EpIndex < NumEp; EpIndex++) { diff --git
> > a/MdeModulePkg/Bus/Pci/XhciPei/XhciSched.c
> > b/MdeModulePkg/Bus/Pci/XhciPei/XhciSched.c
> > index cc597a43717..8400c90f7ad 100644
> > --- a/MdeModulePkg/Bus/Pci/XhciPei/XhciSched.c
> > +++ b/MdeModulePkg/Bus/Pci/XhciPei/XhciSched.c
> > @@ -3,6 +3,7 @@ PEIM to produce gPeiUsb2HostControllerPpiGuid based
> on
> > gPeiUsbControllerPpiGuid  which is used to enable recovery function
> > from USB Drivers.
> >
> >  Copyright (c) 2014 - 2017, Intel Corporation. All rights
> > reserved.<BR>
> > +Copyright (C) 2022 Advanced Micro Devices, Inc. All rights
> > +reserved.<BR>
> >
> >  SPDX-License-Identifier: BSD-2-Clause-Patent
> >
> > @@ -1752,6 +1753,9 @@ XhcPeiSetConfigCmd (
> >      }
> >
> >      NumEp = IfDesc->NumEndpoints;
> > +    if ((NumEp == 0) && (MaxDci == 0)) {
> > +      MaxDci = 1;
> > +    }
> >
> >      EpDesc = (USB_ENDPOINT_DESCRIPTOR *)(IfDesc + 1);
> >      for (EpIndex = 0; EpIndex < NumEp; EpIndex++) { @@ -1974,6
> > +1978,9 @@ XhcPeiSetConfigCmd64 (
> >      }
> >
> >      NumEp = IfDesc->NumEndpoints;
> > +    if ((NumEp == 0) && (MaxDci == 0)) {
> > +      MaxDci = 1;
> > +    }
> >
> >      EpDesc = (USB_ENDPOINT_DESCRIPTOR *)(IfDesc + 1);
> >      for (EpIndex = 0; EpIndex < NumEp; EpIndex++) {
> > --
> > 2.37.1.windows.1
> >
> >
> >
> > 
> >