From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 57A259411BE for ; Tue, 31 Oct 2023 07:00:10 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Ws7NTCE9Lln78HXd0aqNvItS1SmD5Pxt5SseD8bSnDM=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type; s=20140610; t=1698735609; v=1; b=GyQv6eCnTIa4ZqQuD3l7zPrtWn2Nc/M/gKlujKaxCo/oTqSDE4G/cdD3VrlaTbsj/bF+w+gx +/G7QKkCoWJCBlGbHqSm2IYkFmpMUS4IBlQl/kOq1imnrYexEk1tRsyyKj6bCMX/hNxGRvkLVr4 mEHsZcz/tSjNS41Rtpd2VHUE= X-Received: by 127.0.0.2 with SMTP id A3dDYY7687511xaEXlfYF38l; Tue, 31 Oct 2023 00:00:09 -0700 X-Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.75]) by mx.groups.io with SMTP id smtpd.web11.181084.1698735608341699457 for ; Tue, 31 Oct 2023 00:00:08 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HrGsuSaZ/DNXoCtylKbxAQmhQOCs+Ni+qa3JYMkIFVjGrhzLffsyFrMy/gNrM0CNw5wCdkVPw8z4MVmo5MLmb1kTuNz7l41Z1Q23TfzhO53HBO5tRp30OJ8O4U8anHoOVR9v40ygzDhRPnhYYoHQwvLCxMaHBZsNNDPgyutxPkuaduJhwNAr8LtudyPdajUV1J+Yk2vUmewFV+QdvKPwJxQajBp7pyrVeVXJI9ePn+v8lpJTywaEBi1lkHRRRE7mdr8/ndektD/jmGsNz5P7HvhbucnjEHxzBIZx+syeJyig1Zq9n+6J4TXOjOPA8uSW+QZJmYntZmP2+c779qmboQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=anz8uOH4imiZEfX6UtUgF/qTMRI7WUwNwONcoYNMIrg=; b=RFIR4hyF3Kj7zYsZNUZav+AtPA5E/OWP3Y/c5NSG3HX/eY4QjG280WeEuGLc8S9w5RPy6kR+stWGfhDGkvC8kGqzfb6c41vbatEsQtF/Qsw4vQ4gruytBbVolqKicgDb5K+P1s5xWaJ9vRlQBFmY8XEtQZz+I6HZNnNvXVfYBYA9kY5qDewl5fEFxPE/onDosRDV1WiEovEOKSzdXWg00VKSdqTwkWNOgpt9UjqgZam/VpZK4NNPEI08ELVhIYpY0zUkzeHfRKcxwv1a6FJQekoOK+hV7xKJjWJFGkASmYtJV2QCVy3jMAnxXhL7ZeMzSFYtriYZPMiSGi/Y3+sWCQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by SA1PR12MB7269.namprd12.prod.outlook.com (2603:10b6:806:2be::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.26; Tue, 31 Oct 2023 07:00:03 +0000 X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::e670:e45f:fa32:2420]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::e670:e45f:fa32:2420%6]) with mapi id 15.20.6933.029; Tue, 31 Oct 2023 07:00:03 +0000 From: "Chang, Abner via groups.io" To: Yoshinoya , "devel@edk2.groups.io" CC: Konstantin Aladyshev , "Attar, AbdulLateef (Abdul Lateef)" , "nicklew@nvidia.com" Subject: Re: [edk2-devel] [PATCH edk2-platforms v3 00/16] MTCP-over-KCS support Thread-Topic: Re:Re: [edk2-devel] [PATCH edk2-platforms v3 00/16] MTCP-over-KCS support Thread-Index: AQHaBbGU+a9whfjsFECc0pszYz6JzrBYO1vAgANMZjCAB/ZRAIAABIZQ Date: Tue, 31 Oct 2023 07:00:03 +0000 Message-ID: References: <20231023130511.4521-1-aladyshev22@gmail.com> <47cfdef0.38bd.18b8473a941.Coremail.yoshinoyatoko@163.com> In-Reply-To: <47cfdef0.38bd.18b8473a941.Coremail.yoshinoyatoko@163.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_64e4cbe8-b4f6-45dc-bcba-6123dfd2d8bf_ActionId=46f442de-9913-45de-9a9c-b2b5d9ef1195;MSIP_Label_64e4cbe8-b4f6-45dc-bcba-6123dfd2d8bf_ContentBits=0;MSIP_Label_64e4cbe8-b4f6-45dc-bcba-6123dfd2d8bf_Enabled=true;MSIP_Label_64e4cbe8-b4f6-45dc-bcba-6123dfd2d8bf_Method=Privileged;MSIP_Label_64e4cbe8-b4f6-45dc-bcba-6123dfd2d8bf_Name=Non-Business-AIP 2.0;MSIP_Label_64e4cbe8-b4f6-45dc-bcba-6123dfd2d8bf_SetDate=2023-10-31T06:54:43Z;MSIP_Label_64e4cbe8-b4f6-45dc-bcba-6123dfd2d8bf_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|SA1PR12MB7269:EE_ x-ms-office365-filtering-correlation-id: f542a4ae-bc71-4209-7f8b-08dbd9df020f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 0X9chKLaFbvmhrIXvJ/i/FA7qVjKPjJUnq6N0l4UDL3Btp/7dkUYU1jssB9YsqW2TwrFBSHgnfiCgC1uVZJ+VETxLvipMbgdEsm4roIUJEKqOV3osO+sqQeqyBGzpTYpVDGJPeqOcnLqs7xWBDVEafDnLsqI3YsnKUzJcu5Zr4Asb1hfEsQijbkW1N0yBJAUnQzIHHLqjcQCrlDeZC+2OQxJ60aqv4gwOUdFzJcirI+UBsTiQk+3VZZM+FSvkLKy7r69F/0nj732MFtnYEiSI0aP6X/uCqWotZhNBl/KFq9Ajkx2g+O+6ii/RY7clA5xfEXrQ8lDasmdstwgb9VOvXCf2VuUcE5+m03cDWLdDpCJSQVfRyjU0vpiEyZ/FEQJLs1BzwrqtseS91VaWw+R0ORs8UjYJWSJbUSi+YEj9oeEy3YTkakYEhhDU8FgLQHl8xJf71RGVrupvjxj3jbApTplW4lMq6TBAZLcR7wZ3Hc+uggDX53Y4hSk2AV91q4h4xVJAzkNy46Gg0ABgkM9G3cfzCw8GzBwMLW7O/U+vwjVS1fFZqxlYKOsizqoWg5FwoWIuH5vnqYxaT52s6YDIL+pyD7MATYeQcaccVMpndZVOngoTOMEAgB8MheRM7KSUC3odB4vpzQQ4kbAknCZ0i65poCIrnlsSdSA4EHHCrqBjePEu3THpJAZffuDmXl2 x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?t01TJrH3u8jKHcDip3pZlDf3Ry6ppEwf3vuLEsdcokX8VKs6GI58EFT+9x0S?= =?us-ascii?Q?XJHOmIAOFVSsoQlBEBzEeGU4WNlAswinL9FtqET555SGXo6Ky/xdyYLtXt6j?= =?us-ascii?Q?LUG9aZBKVUv9SVp38vBAkLAwYSreTkYJhFAQnr+6ptvFGaU95DyuDt6F9Ug/?= =?us-ascii?Q?UM/QFv0qx2kiauMSDFw5YUHDKxpaK/XzhKIqiEABlPoHqG9qkdl2iE8nFLcN?= =?us-ascii?Q?dWbQf3uZ62XLvfVUOmqwrDqCICP6HmyBC62PWRFac3n73phfQxog3nWfKbc+?= =?us-ascii?Q?yPYGvL0y9rsX+sxsjGccaWombbNlgq4rWCPP1DEB/oOtvMDPiquPPOGsxveO?= =?us-ascii?Q?8vYQITTEVW/izgAQ3P3rsFFYjvy6hkAH8t+aSVEeYCUaRqSmtYXbrrIbhdx5?= =?us-ascii?Q?q4GkTvYSfjDzpt253gTELgABCueRMwN3o6/VI9OTO7FdorA+R7rysAHqyHCY?= =?us-ascii?Q?Oh0W3E1q/V7hUDJJwv4djQDm6nFIm4J/eAM6NRlBvH1SsK4r6YttaJBJXfD1?= =?us-ascii?Q?gdbYk6O1FGItHp7PwQUqDIXhr1rkjXoFg5P0XuGdvVsZtWCLtEyyNa/Xb0Wj?= =?us-ascii?Q?c2ChbghAt0ZShWA3qAj378iAEVHjf8SmGylOKCPNj+vBeM1HaE1n+wYS0v1H?= =?us-ascii?Q?5yvBlBinOjdjHvqCgpLqaYYbNPUzKSI1/Akchj2uQ8TPvRRkAQrfTX1QvHbj?= =?us-ascii?Q?n/oPqOK/txBRrcu06Dpq8nknrjwrwRJAMKOf6qUazrFaxHwWgtHs0rKr8NZY?= =?us-ascii?Q?3gcqXFFBCrTwT0KlIC0fAiS9Uwh6x5vtsU6hGmIgS6T2xhVp9xWbs0k4Di6z?= =?us-ascii?Q?cKS/gxf6jgeWkVhRZpCkRKtWuH5xQxMt271oi+z0XE6bJO0iSe8aXyqdxW4P?= =?us-ascii?Q?AV3QN82je+MVmIBBQVu/dcaLVMnyZpD/6p9AU6vLzm6hLC0o6RKkaHSyQ0iW?= =?us-ascii?Q?U7cN9fTNvh7/k3KTI5a0fo8zMo+8fXB/2Q9cwj+IWcvbrWrEXS3K/UG4SoCD?= =?us-ascii?Q?rEsoqxyL09wCnb2o7bMuC5pzAp8Ubn4LNQ5spfQ0JufTMuiVmlQuEN39Kj6R?= =?us-ascii?Q?d2wxUsA4TZWMTyCIN+aVq59UoQndONsstTPaTJXVRIk6am+mYh7m33f6Pq9E?= =?us-ascii?Q?yQIEn9FZ/rS2mJLCAIzVtsmNUWmn5IM2m0AFFQQAleMWsDEVACk7Mr72qfhR?= =?us-ascii?Q?4wesSEwCYXy3vqz4y1Z2fs2obN3DsvzyFutaE/jrEILKJ7ihq9RqQnfKj1/4?= =?us-ascii?Q?vI0y+ayF6m4N8bu2X6m0HP9P8YoqOWB946YihYPkZ4wa1DS1/1nMteFjCop1?= =?us-ascii?Q?IDyH0dyHPTMyZxlJq+1DBlg9LsSjFZMH/7eljWuVjv2OMalTY68FUz1PUmfE?= =?us-ascii?Q?k94O98ySK7MYn52jIxTgqWyfEXXnxJlf6LgERPWd0wgAfD+eMuhxrrKGoF0y?= =?us-ascii?Q?x9NTQR+qRx5JtY+74LVTV6Jvv0VwyM1E2YFUrIQO+3LrcPbZdfuQLDJPexIL?= =?us-ascii?Q?BvBzcmxJnNMXUurxRBk+RDOY21sQOGeM3K4G4PO2Vz1fJW8i45sp/0ysRqXO?= =?us-ascii?Q?RdwQp1qs3r+ik4JFJZnw2pSV6mKO5pACzR1es9uv?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f542a4ae-bc71-4209-7f8b-08dbd9df020f X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Oct 2023 07:00:03.8129 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: J9K4qqW5x+D+Py9BhqZimRx/c4Po5VK9EIvtK/cj+NVOZly7g+thiuNclEZVa4M+UIx8zFEgPWbcR9gDSwjUtQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7269 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 1tgcgRpIh7aQGsFfK7R6ppjfx7686176AA= Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MN2PR12MB3966EA428B61DBC938B527A5EAA0AMN2PR12MB3966namp_" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=GyQv6eCn; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --_000_MN2PR12MB3966EA428B61DBC938B527A5EAA0AMN2PR12MB3966namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MCTP over KCS defines two types of KCS-like access, one is compatible with = IPMI KCS, another is memory map I/O access. It doesn't require any special = HW, just require the I/O cycle or memory cycle can be delivered to the mana= gement controller. Yes, we can consider MCTP is a software layer protocol and the that protoco= l is HW (transport interface) agnostic. Abner From: Yoshinoya Sent: Tuesday, October 31, 2023 2:38 PM To: devel@edk2.groups.io; Chang, Abner Cc: Konstantin Aladyshev ; Attar, AbdulLateef (Abdul= Lateef) ; nicklew@nvidia.com Subject: Re:Re: [edk2-devel] [PATCH edk2-platforms v3 00/16] MTCP-over-KCS = support Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding. Hi, Abner: I ask you a favor. KCS actually layer on LPC interface. KCS is a usual BMC-to-CPU communication channel. Does MCTP-over-KCS feature require some special LPC interface hardware chan= ges? Or, MCTP is just a software stack and it uses current LPC interface, not an= y special hardward design change requirement. Thanks At 2023-10-26 13:03:02, "Chang, Abner via groups.io" > wrote: >[AMD Official Use Only - General] > >Merged. I will send another patch for Uncrustify updates if any. > >Abner > >> -----Original Message----- >> From: Chang, Abner >> Sent: Tuesday, October 24, 2023 10:44 AM >> To: Konstantin Aladyshev >; devel@edk2.groups.io >> Cc: Attar, AbdulLateef (Abdul Lateef) >; >> nicklew@nvidia.com >> Subject: RE: [PATCH edk2-platforms v3 00/16] MTCP-over-KCS support >> >> For entire V3 and the additional patch 16/16, >> Reviewed-by: Abner Chang > >> >> I will do the Uncrustify check and merge this patch set once the corresp= onding >> edk2 changes are merged. >> Thanks >> Abner >> >> > -----Original Message----- >> > From: Konstantin Aladyshev > >> > Sent: Monday, October 23, 2023 9:05 PM >> > To: devel@edk2.groups.io >> > Cc: Chang, Abner >; At= tar, AbdulLateef (Abdul >> > Lateef) >;= nicklew@nvidia.com; Konstantin >> > Aladyshev > >> > Subject: [PATCH edk2-platforms v3 00/16] MTCP-over-KCS support >> > >> > Caution: This message originated from an External Source. Use proper >> caution >> > when opening attachments, clicking links, or responding. >> > >> > >> > The Manageability KCS transport library needs to support requests both >> > from MCTP and IPMI transports. Currently the code only handles IPMI >> > case correctly. >> > In the MCTP case the communication should be based on the MCTP-over- >> KCS >> > specification (DSP0254). This specification defines a special KCS >> > binding header and trailer structures that need to be present in every >> > MCTP message. >> > The header structure contains a length field, therefore response packe= t >> > size is not needed to be known beforehand. >> > The trailer structure contains a PEC checksum that can be used to chec= k >> > itegrity of the response message. >> > Modify Manageability KCS transport library code to check which message >> > is processed (IPMI or MCTP) and handle each case correctly based on it= s >> > own specification. >> > This patch is a result of a joint effort from the Konstantin Aladyshev >> > > and Abner Chang = >. >> > >> > Tested: >> > PLDM communication between the HOST and BMC was tested with both >> > components implemented via open-source software: >> > - The HOST (UEFI firmware) part was based one the edk2 [1] and >> > edk2-platforms [2] code, >> > - The BMC part was based on the openbmc [3] distribution. >> > >> > The testing process and all the necessary utilities are described in >> > the [4] repository. >> > >> > The provided changes keep IPMI over KCS stack working as reported by >> > Abner Chang. >> > >> > [1]: https://github.com/tianocore/edk2 >> > [2]: https://github.com/tianocore/edk2-platforms >> > [3]: https://github.com/openbmc/openbmc >> > [4]: https://github.com/Kostr/PLDM >> > >> > Changes v2 -> v3: >> > - Add new patch that adds PLDM completion code check >> > >> > Changes v1 -> v2: >> > - Add new patches with corrections for the PLDM protocol. The >> > resulting communication via EDKII_PLDM_PROTOCOL was successfully >> > tested. >> > >> > Abner Chang (4): >> > ManageabilityPkg: Add PLDM terminus PCDs >> > PldmProtocolDxe: Correct TID argument usage >> > ManageabilityPkg/PldmProtocol: Remove PLDM command table >> > PldmSmbiosTransferDxe: Implement Set PLDM terminus ID API >> > >> > Konstantin Aladyshev (12): >> > ManageabilityPkg: Add definition for the MCTP KCS TRAILER structure >> > ManageabilityPkg: Check MCTP EIDs for reserved values >> > ManageabilityPkg: Support both MCTP and IPMI in KCS tranport library >> > ManageabilityPkg: Check header fields in the MCTP response >> > ManageabilityPkg: Correct typo in MCTP destination EID field >> > ManageabilityPkg: Update the algorithm of using MCTP endpoint ID PCD >> > ManageabilityPkg: Correct value for the MCTP TAG_OWNER response bit >> > ManageabilityPkg: Don't check MCTP header fields if transfer has >> > failed >> > ManageabilityPkg: Use correct constants for PLDM header checks >> > ManageabilityPkg: Return error on multiple-packet MCTP responses >> > ManageabilityPkg: Return error on PLDM header check fails >> > ManageabilityPkg: Check PLDM completion code >> > >> > .../Include/Library/BasePldmProtocolLib.h | 16 + >> > .../Library/ManageabilityTransportMctpLib.h | 9 +- >> > .../Include/Protocol/MctpProtocol.h | 12 +- >> > .../Include/Protocol/PldmProtocol.h | 18 +- >> > .../Protocol/PldmSmbiosTransferProtocol.h | 26 ++ >> > .../Common/KcsCommon.c | 284 +++++++++++++++--= - >> > .../Dxe/ManageabilityTransportMctp.c | 4 +- >> > .../PldmProtocolLibrary/Dxe/PldmProtocolLib.c | 49 ++- >> > .../Dxe/PldmProtocolLib.inf | 6 +- >> > .../ManageabilityPkg/ManageabilityPkg.dec | 6 + >> > .../MctpProtocol/Common/MctpProtocolCommon.c | 129 +++++++- >> > .../Universal/MctpProtocol/Dxe/MctpProtocol.c | 51 +++- >> > .../PldmProtocol/Common/PldmProtocolCommon.c | 148 +++------ >> > .../PldmProtocol/Common/PldmProtocolCommon.h | 25 +- >> > .../Universal/PldmProtocol/Dxe/PldmProtocol.c | 69 ++++- >> > .../PldmProtocol/Dxe/PldmProtocolDxe.inf | 4 - >> > .../PldmSmbiosTransferDxe.c | 28 ++ >> > 17 files changed, 690 insertions(+), 194 deletions(-) >> > >> > -- >> > 2.34.1 > > > > > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110377): https://edk2.groups.io/g/devel/message/110377 Mute This Topic: https://groups.io/mt/102134646/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --_000_MN2PR12MB3966EA428B61DBC938B527A5EAA0AMN2PR12MB3966namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

MCTP over KCS defines tw= o types of KCS-like access, one is compatible with IPMI KCS, another is mem= ory map I/O access. It doesn’t require any special HW, just require the I/O cycle or memory cycle can be delivered to the man= agement controller.

Yes, we can consider MCT= P is a software layer protocol and the that protocol is HW (transport inter= face) agnostic.

 =

Abner<= /p>

 =

From: Yoshinoya <yoshinoyatoko@16= 3.com>
Sent: Tuesday, October 31, 2023 2:38 PM
To: devel@edk2.groups.io; Chang, Abner <Abner.Chang@amd.com> Cc: Konstantin Aladyshev <aladyshev22@gmail.com>; Attar, Abdul= Lateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>; nicklew@nvidia.com=
Subject: Re:Re: [edk2-devel] [PATCH edk2-platforms v3 00/16] MTCP-ov= er-KCS support

 

Caution: This message originated from an External Source. Use proper caution= when opening attachments, clicking links, or responding.

 

Hi, Abner:

I ask you a favor.

 

KCS actually layer on LPC interface.=

KCS is a usual BMC-to-CPU communication c= hannel.

 

Does MCTP-over-KCS feature require some s= pecial LPC interface hardware changes?

Or, MCTP is just a software stack and it = uses current LPC interface, not any special hardward design change requirem= ent.

 

Thanks

 

 

 


At 2023-10-26 13:03:02, "Chang, A=
bner via groups.io" <abner.chang=3Damd.com@groups.io> wrote:
>[AMD Official Use Only - General]=

> 
>Merged.   I will send anothe=
r patch for Uncrustify updates if any.
> 
>Abner
> 
>> -----Original Message-----
>> From: Chang, Abner
>> Sent: Tuesday, October 24, 2023 1=
0:44 AM
>> To: Konstantin Aladyshev <aladyshev22@gmail.com>; devel@edk2.groups.io=

>> Cc: Attar, AbdulLateef (Abdul Lat=
eef) <AbdulLateef.Attar@amd=
.com>;
>> nicklew@nvidia.com
>> Subject: RE: [PATCH edk2-platform=
s v3 00/16] MTCP-over-KCS support
>> 
>> For entire V3 and the additional =
patch 16/16,
>> Reviewed-by: Abner Chang <abner.chang@amd.com>
>> 
>> I will do the Uncrustify check an=
d merge this patch set once the corresponding
>> edk2 changes are merged.
>> Thanks
>> Abner
>> 
>> > -----Original Message-----
>> > From: Konstantin Aladyshev &=
lt;aladyshev22@gmail.com>
>> > Sent: Monday, October 23, 20=
23 9:05 PM
>> > To: devel@edk2.groups.io
>> > Cc: Chang, Abner <Abner.Chang@amd.com>; Attar, AbdulLa=
teef (Abdul
>> > Lateef) <AbdulLateef.Attar@amd.com>; nicklew@nvidia.com; Konstantin
>> > Aladyshev <aladyshev22@gmail.com><=
/pre>

>> > Subject: [PATCH edk2-platfor=
ms v3 00/16] MTCP-over-KCS support


>> >


>> > Caution: This message origin=
ated from an External Source. Use proper


>> caution


>> > when opening attachments, cl=
icking links, or responding.


>> >


>> >


>> > The Manageability KCS transp=
ort library needs to support requests both


>> > from MCTP and IPMI transport=
s. Currently the code only handles IPMI


>> > case correctly.


>> > In the MCTP case the communi=
cation should be based on the MCTP-over-


>> KCS


>> > specification (DSP0254). Thi=
s specification defines a special KCS


>> > binding header and trailer s=
tructures that need to be present in every


>> > MCTP message.


>> > The header structure contain=
s a length field, therefore response packet


>> > size is not needed to be kno=
wn beforehand.


>> > The trailer structure contai=
ns a PEC checksum that can be used to check


>> > itegrity of the response mes=
sage.


>> > Modify Manageability KCS tra=
nsport library code to check which message


>> > is processed (IPMI or MCTP) =
and handle each case correctly based on its


>> > own specification.


>> > This patch is a result of a =
joint effort from the Konstantin Aladyshev


>> > <aladyshev22@gmail.com> and Abner Chang <abner.chang@amd.com>.


>> >


>> > Tested:

>> > PLDM communication between t=
he HOST and BMC was tested with both


>> > components implemented via o=
pen-source software:


>> > - The HOST (UEFI firmware) p=
art was based one the edk2 [1] and


>> > edk2-platforms [2] code,


>> > - The BMC part was based on =
the openbmc [3] distribution.


>> >


>> > The testing process and all =
the necessary utilities are described in


>> > the [4] repository.


>> >


>> > The provided changes keep IP=
MI over KCS stack working as reported by


>> > Abner Chang.


>> >


>> > [1]: https://github.com/tianocore/edk2


>> > [2]: https://github.com/tianocore/edk2-platform=
s


>> > [3]: https://github.com/openbmc/openbmc


>> > [4]: https://github.com/Kostr/PLDM

>> >


>> > Changes v2 -> v3:


>> >  - Add new patch that a=
dds PLDM completion code check


>> >


>> > Changes v1 -> v2:


>> >  - Add new patches with=
 corrections for the PLDM protocol. The


>> >   resulting commun=
ication via EDKII_PLDM_PROTOCOL was successfully


>> >   tested.


>> >


>> > Abner Chang (4):<=
/span>


>> >   ManageabilityPkg=
: Add PLDM terminus PCDs


>> >   PldmProtocolDxe:=
 Correct TID argument usage


>> >   ManageabilityPkg=
/PldmProtocol: Remove PLDM command table


>> >   PldmSmbiosTransf=
erDxe: Implement Set PLDM terminus ID API


>> >


>> > Konstantin Aladyshev (12):


>> >   ManageabilityPkg=
: Add definition for the MCTP KCS TRAILER structure


>> >   ManageabilityPkg=
: Check MCTP EIDs for reserved values


>> >   ManageabilityPkg=
: Support both MCTP and IPMI in KCS tranport library

>> >   ManageabilityPkg=
: Check header fields in the MCTP response


>> >   ManageabilityPkg=
: Correct typo in MCTP destination EID field


>> >   ManageabilityPkg=
: Update the algorithm of using MCTP endpoint ID PCD

>> >   ManageabilityPkg=
: Correct value for the MCTP TAG_OWNER response bit


>> >   ManageabilityPkg=
: Don't check MCTP header fields if transfer has


>> >     fail=
ed


>> >   ManageabilityPkg=
: Use correct constants for PLDM header checks


>> >   ManageabilityPkg=
: Return error on multiple-packet MCTP responses


>> >   ManageabilityPkg=
: Return error on PLDM header check fails


>> >   ManageabilityPkg=
: Check PLDM completion code


>> >


>> >  .../Include/Library/Ba=
sePldmProtocolLib.h     |  16 +<=
/pre>

>> >  .../Library/Manageabil=
ityTransportMctpLib.h   |   9 +-

>> >  .../Include/Protocol/M=
ctpProtocol.h           |=
  12 +-


>> >  .../Include/Protocol/P=
ldmProtocol.h           |=
  18 +-


>> >  .../Protocol/PldmSmbio=
sTransferProtocol.h     |  26 ++=



>> >  .../Common/KcsCommon.c=
            &nb=
sp;           | 284 +++++=
++++++++++---


>> >  .../Dxe/ManageabilityT=
ransportMctp.c          | =
;  4 +-


>> >  .../PldmProtocolLibrar=
y/Dxe/PldmProtocolLib.c |  49 ++-


>> >  .../Dxe/PldmProtocolLi=
b.inf           &nbs=
p;       |   6 +-=



>> >  .../ManageabilityPkg/M=
anageabilityPkg.dec     |   6 +


>> >  .../MctpProtocol/Commo=
n/MctpProtocolCommon.c  | 129 +++++++-


>> >  .../Universal/MctpProt=
ocol/Dxe/MctpProtocol.c |  51 +++-


>> >  .../PldmProtocol/Commo=
n/PldmProtocolCommon.c  | 148 +++------


>> >  .../PldmProtocol/Commo=
n/PldmProtocolCommon.h  |  25 +-


>> >  .../Universal/PldmProt=
ocol/Dxe/PldmProtocol.c |  69 ++++-


>> >  .../PldmProtocol/Dxe/P=
ldmProtocolDxe.inf      |   4 -


>> >  .../PldmSmbiosTransfer=
Dxe.c           &nbs=
p;       |  28 ++

>> >  17 files changed, 690 =
insertions(+), 194 deletions(-)


>> >


>> > --


>> > 2.34.1

> 


> 


> 


>


> 
_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#110377) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--_000_MN2PR12MB3966EA428B61DBC938B527A5EAA0AMN2PR12MB3966namp_--