From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (NAM12-DM6-obe.outbound.protection.outlook.com [40.107.243.64]) by mx.groups.io with SMTP id smtpd.web12.1404.1668479942957402714 for ; Mon, 14 Nov 2022 18:39:03 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=QlrIisx6; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.243.64, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JighhM8BheJPOyLAYj/Lme0HgaJYFKrhALAOID/fgojBMDvrX4Dc/H303EjfXoS871w6F9U0pQauMU9yHCHEU4nKGaLXOAatHqEhK4V0oOWSEmBywyNyu284sqQBh40W6Fz0AhnRYsD9fPy7EJBFFdJHA60mICN7xT6FkOnwVcDqMf5oZ21UxhOTVySEPiMIdE/EldUp/mu5D6i+ZbneISd7p39vlLaWRH6uOtWKbLZMZrUTE927gfDzdTgfF36/Dd/W2JNMB8CZxrhhRdgU06mUZ6Q11GVK3WWVquHCKMfdzSAse5emVtMlHazNllXMlXnLMnf0ftcOuNnm1r/IMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mCE59U/ZQqgbfmwcmNSV1JjPlJO3ce5MGKzy4Lpynuc=; b=AcRCGMzi6amCCeKGRLTzrsGHud46r/lweZZbUtrmmyilxp2NCTvswNS+7IPCUlO6Kvkn/5TuSOxuYCc8kdYo5HVnR+LIs87fXdUs7eWa3DrANujWGAeomGkJ1Nn4I60M/NjjgocpGJuJH9GkHKJwtefQVT36juWgvrHqBFaHcgok0rL7eFuhet5Gd/VcujyiCrXrfhqvcG51OxXzOQoEJv8o8icv5HTPNKfAJZ4Bs2TwLoVnVbkjxIZJCY8OuZ/wTOIO09xENSdAznanQ/9PM7btQzHfwnXSs+cZZfWc082y9oJPI+dXAbj77cf/fKD4MjuOW5bRnuvFeeh1K/TUmA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mCE59U/ZQqgbfmwcmNSV1JjPlJO3ce5MGKzy4Lpynuc=; b=QlrIisx6AKK+/j6StNli7P3BMW0Ggg+Un5uimnTt8yDtNIMJYU9RGL6locoeAJRnK/tNwGqtOnKRQzENVyEw7xK0rP0Zy9vc4WjXjvJnGIs8X5CippwGZfN3bZxaXRJaD3rS45zWU3dOMq5VwaBAuLxaQwitNfl8BlkbKolNvLI= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by MN0PR12MB6247.namprd12.prod.outlook.com (2603:10b6:208:3c1::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17; Tue, 15 Nov 2022 02:39:00 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::ce0a:283e:839:34bd]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::ce0a:283e:839:34bd%3]) with mapi id 15.20.5813.017; Tue, 15 Nov 2022 02:38:59 +0000 From: "Chang, Abner" To: Sean Brogan , "devel@edk2.groups.io" , "mikuback@linux.microsoft.com" , "Kinney, Michael D" , Laszlo Ersek , "Kubacki, Michael" Subject: Re: [edk2-devel] [edk2-CCodingStandardsSpecification PATCH 2/2] Source Files / Spacing / Multi-line func. calls: allow condensed arguments Thread-Topic: [edk2-devel] [edk2-CCodingStandardsSpecification PATCH 2/2] Source Files / Spacing / Multi-line func. calls: allow condensed arguments Thread-Index: AQHY9wA8eJ5V+X7WCU6R4R6Zrs8Iy648GJaAgABv7YCAAJZGAIAAe85QgAEOf4CAABBLm4AABZWAgAAGn4CAAAWAAIAAfByw Date: Tue, 15 Nov 2022 02:38:59 +0000 Message-ID: References: <922996c2-e60a-80ec-6d4a-8b2e5a639c9b@redhat.com> <25893.1668303336748921539@groups.io> <17278424C4A5D78F.32003@groups.io> <7ed9dd39-71c2-f175-9ee9-f7f2f7b89e23@linux.microsoft.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2022-11-15T02:38:56Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=662f8413-99c9-4f4f-b197-7f67914dae5b; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|MN0PR12MB6247:EE_ x-ms-office365-filtering-correlation-id: e24b7ee6-d072-48e4-5c23-08dac6b28cd6 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: =?us-ascii?Q?d9h/whUXe18WLeU9Q0vLXRYG+yFS+OrCHYMgU8WfjToRz70vjN1NrvQ0M01/?= =?us-ascii?Q?31DZeOi71bEKzhLx+MjiiLAgtRnbkBllgmLiQNEqNmZSp8g897jYi7iyceNF?= =?us-ascii?Q?89CRZh0ah1zsXsRO9FrRk2WmrH6F1bOfaonfMNsUddBhoLLmBonXOKMRBu38?= =?us-ascii?Q?B3EL0gOiorIgYgKT00A8OkXUdwQR0/JbBEJw2nuBxu+XG1ImXVQFNihLb1Wu?= =?us-ascii?Q?MZxX8dLHrH/izsD78H/m71G7NW1sCyTp3YjPv3pQMyEdc/wcRFGQMIDewucm?= =?us-ascii?Q?93KPs4kKoXbXqv7ZE6Pj2n4RFNX66qU8/tdM95a6r3DbLX5mTvvdHbx6kDiK?= =?us-ascii?Q?gGi9DSg8ymTNLOWksT6lAqO1tx0pRNIl6sT7+vvCSzSXXuvj/QC5k1g/Rcyh?= =?us-ascii?Q?Dz5/Ju5uMOWvCj5uG07aZ0seI5lgG0N+1iVu/ClpwytRNwcG+q/0UIYPaotu?= =?us-ascii?Q?2cyXgn/liKYa+zQsqtRjbF0g6EmB8lwnwEkkmySLqvbIlApZM/eTc09L178E?= =?us-ascii?Q?gamCrfiTysnMqaKxBGRl5+wDCTeYvzdk8tgbDOGg9jcjSSy2BGa/D0Yn1rhy?= =?us-ascii?Q?quJXO9NhH6+WQCNXI1LlyIFIDxEML6tIV0nsf/YqPk59zg6Lu9/RtwNPFNHd?= =?us-ascii?Q?3jfIS2n/tD8dwpxB//r4i5eaN4YxQmWWXqU6G1R76ls/Ozg5+yDUmdi/It2Z?= =?us-ascii?Q?8yJejjQyOBnvGEQD/vIsW0vWlo7tAylYKuvpSgwnjvIxhyxOANDZn5zUS9lY?= =?us-ascii?Q?Akk+r9h/BoCxEQxpiUDtHE84UBDcUPhMoZ14Rm5NkTqDWReOF1T1ctWNQZeN?= =?us-ascii?Q?jEksSwFmpK58vj4u2XLcb69WUdZ96+lLmpVV95hdKGmfrjDq85GLPFtxLPfW?= =?us-ascii?Q?UPuMAwusXbn7UxhHt5TT3/SlUGOgO/HEgBcZdj2sv4iWYOJ7DljiX6G7Uupo?= =?us-ascii?Q?1oPcGppB7+kqDdTiTwv0RYstCCp13Ojs86nwP2f9Et87CzxuBovIxx8Nl7E3?= =?us-ascii?Q?iDoWkB2KTN0+cAiN9tDIw/1C6VHV6FCcaPp96kBwc1EmOhsjMNzvtwN9DmlV?= =?us-ascii?Q?V+YhK7c5IpL7mnTzEln9Hm9eYCb/4lnt3lzpdwR8olS9V8Wq9y9lS9eW13k/?= =?us-ascii?Q?TsUp+5xsS5hBMZK8+R+0MNvxcIS+IGlaIe9f/i0HvcNGdlawW3AGk59bEFXJ?= =?us-ascii?Q?1bI9jJeKAHeif+wWJ5ZcC4ztaX1xwlPgLYJY9E0vkFZUL/wPExmMv90PBJh8?= =?us-ascii?Q?Kv///yN1r5yR+9qxTaun3nrq7CwUNSKB1/zvxhmh7Q=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(366004)(396003)(376002)(346002)(451199015)(122000001)(83380400001)(33656002)(478600001)(38100700002)(86362001)(55016003)(38070700005)(66946007)(64756008)(5660300002)(52536014)(316002)(966005)(8936002)(66476007)(66446008)(41300700001)(45080400002)(66556008)(8676002)(76116006)(71200400001)(186003)(110136005)(6506007)(7696005)(2906002)(9686003)(30864003)(26005)(53546011)(66899015);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?qlc1gP7nV7MYmHyDJHF1aYMdC9AgrxNnsxydVMJYKKnqBi73k8EMORZBh6kK?= =?us-ascii?Q?ofQYqmmA6RBcEXeETrjqsQe/iUS4Ia9QnpiW97kFBdh/FZuFf4qX6QsJBR4p?= =?us-ascii?Q?mEBWqRKajW6ekHM7Z7B7I6J3juWQQYAMEmszqvvy00qufFyW1J6uXam/HZyH?= =?us-ascii?Q?2ovV44wvX5SOE3KGL5yaktzWqqBGqwIZGjl4RDqHjVQE3Iiq8cfIfiyO0vgP?= =?us-ascii?Q?hk6r9L2bUrtvf44xwLuqvsWooL9/KWMsSrl41+7w4KlpZAz6xmmrwTj6cPOf?= =?us-ascii?Q?5MPzNzzeCHHWKXDOAEXkAA8dlk1KFVttzPfXRIpCf465wEIgzQso3BsaMIlc?= =?us-ascii?Q?WgW8+moVTsMzk/jxYvfRVjAp9j8GXAa7QgFr8Ez3JNgsMhNqlX+MHxCTz/el?= =?us-ascii?Q?91P7qAT0oEEINeyFkVPcRGJYmpjZgtwwTg/PT8cKHVzxOzILB43cp3tB9TWC?= =?us-ascii?Q?wmZ6DZ3dVyGu4Gl0eWYDEREiU+xLFxPcgr+WxHjIbs/2EMoBr1yzSCncMfvS?= =?us-ascii?Q?upY7mqjYmZx9W0jgVw4IzgzVVv6t4N6Z++5T54M2QvuYbnSgEr1EFHzluq/I?= =?us-ascii?Q?GyFH/as/rleBDeH5WsWzhg1bEZxNxOed8Kc9TRHQkIQE2xWpQIZeLxf1l1IB?= =?us-ascii?Q?38FUzLjpbTgthoRHdBDBGUJV79tks1PGn9EXR/a4nGRBzuEAv0HcNtwciII0?= =?us-ascii?Q?giRZHa4lMZ3/YCkOeMet2wOE9sVJ7z0PRCpJ0mwYuaelsqwQcQvCqpX2lr/d?= =?us-ascii?Q?FvzBcfv7+bN3lMePYZjUkDy2rUdlOzAUf2ouEFk2HMtVnVGe27LGRChjmj5I?= =?us-ascii?Q?JO5CxDumcAhDNreneLzoLrwlDXduabh3BtvNCohKJYhQP0UKBtAttENqWLuu?= =?us-ascii?Q?MzzJ9cQnLAC2U+S3ZV6t7BoumtJrF8E2bA9036uevii9Vz6GaHawVlkwG1PK?= =?us-ascii?Q?zeSjb9FxFkmcRI4w/p8ACXymHsIVcimEHrBaNrcEzIpCpssrUa4jSrjftteP?= =?us-ascii?Q?fZof4f3U7jr2QbhEOf5MUaWi/SVRg7DmlmaC4ezqb65GE7CXSF65Im995MDz?= =?us-ascii?Q?YX+hO4EhMbQ+WKx/8FpxpDbAgYpN5b/BPjyv0z2n/KIlk2OEGuIQppg+BdD3?= =?us-ascii?Q?2S2GT0mDJDFRZJmqxVmtvdgFdrekR/7msagXZflzhtg1rqLJHNWkIHNy6Wr3?= =?us-ascii?Q?t8sqNpwfxYx+/3l5DQBjREl8qqnerfazeUL8ezEC8FmRWguoHsw9vG11/0EL?= =?us-ascii?Q?cphMB3ZvvODdWg/37p+Tez4I/aLRq2iWFnRfhJhjsSpk7Eih1OAKsr/pcXDS?= =?us-ascii?Q?guIGvtparEpETxixlbS60SN/+gN3pUeE6yhKhTyHJyo5n+m7QP4p4j41cPiy?= =?us-ascii?Q?ANws9M7Nwmwo/XE/t7z8Ha9+jJ1FM6ETW6F9fSghfGBPGiZCY7K+UX3RZDzl?= =?us-ascii?Q?DJ9g4xVdppYpkGI2s3aB5HvntzW2mCQ/4ZbmQQ+/Mg5Z0Iqim1QvECaZYrQa?= =?us-ascii?Q?6cMdJTW/tKPS00EvHuETEBi7ZorfsojdbvdhaZdV5JtV6GiXhDYu7Zg7qxs8?= =?us-ascii?Q?/zhYtu+ZKd+X2LQjR+sCsZj2q+Dj7YyLcMRdg70W?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e24b7ee6-d072-48e4-5c23-08dac6b28cd6 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Nov 2022 02:38:59.5370 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3BVLboeyTgqvH0wYA1rGJGcq0+p5K3y8hcNB9mkVVBuqaIrZjRNPB/F6VnN2GcWHJbdrHNsonOoCVaLpL/vovw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6247 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Seem we have the consensus to change this BZ to WONTFIX, reopen it if neces= sary after the further discussions. The "code > 80 columns" and "the multip= le argus at one line" are not considered to be part of CCS v2.3 release als= o. Abner > -----Original Message----- > From: Sean Brogan > Sent: Tuesday, November 15, 2022 3:09 AM > To: devel@edk2.groups.io; mikuback@linux.microsoft.com; Kinney, Michael > D ; Chang, Abner ; > Laszlo Ersek ; Kubacki, Michael > > Subject: Re: [edk2-devel] [edk2-CCodingStandardsSpecification PATCH 2/2] > Source Files / Spacing / Multi-line func. calls: allow condensed argument= s >=20 > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. >=20 >=20 > If you look through the bugs you will see there is some debate. > Personally, I think there is never a single right answer on style and the= re will > always be differing opinions. The underlying goal that most agree on is > providing consistency for a project and to make it easy for someone to > contribute code that aligns with that consistent standard. > Since 2017, a lot has changed but the biggest thing is we have a relative= ly > easy, well documented, industry standard tool that supports > style/formatting of edk2. These tools can be run locally by those contrib= uting > and are run by the CI system on pull request to enforce this consistency.= We > have already reformatted the entire code base of > edk2 to align with that and although i am not opposed to auto reformattin= g in > the future for a great reason I don't see anything is these proposed chan= ges > that would justify that. >=20 >=20 > Thanks >=20 > Sean >=20 >=20 >=20 > On 11/14/2022 10:49 AM, Michael Kubacki wrote: > > I saw those, but they're from over 5 years ago and the community has > > changed since then. > > > > This is an impactful change. It will impact every line of code written. > > > > I'm not suggesting this go to the Tools & CI Meeting because of > > uncrustify. I'm not concerned with any impact to uncrustify. > > > > This came to my attention because I was added to thread. I would like > > to suggest that we raise more awareness about this change in a meeting > > with members of the community to capture additional feedback. > > > > Also, the logistics (uncrustify aside) about how to execute this > > change are unclear (as written in this thread and the BZ) and it would > > be easier/faster to discuss in a community call. > > > > Is that possible? > > > > Thanks, > > Michael > > > > On 11/14/2022 1:25 PM, Kinney, Michael D wrote: > >> Hi Michael, > >> > >> Yes. They have been discussed. There were patches and discussion on > >> mailing lists back in 2017. Long before enabling uncrustify. I > >> provided links to these conversations in the following email about a > >> week ago. > >> > >> > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fedk > >> > 2.groups.io%2Fg%2Fdevel%2Fmessage%2F96038&data=3D05%7C01%7Cab > ner.ch > >> > ang%40amd.com%7C1f9c0bc3c6c747f1297308dac673afe9%7C3dd8961fe4884 > e608e > >> > 11a82d994e183d%7C0%7C0%7C638040497500028713%7CUnknown%7CTWFp > bGZsb3d8e > >> > yJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D > %7C3 > >> > 000%7C%7C%7C&sdata=3DTEqQG9CS8IgF4x33PsIufmwLfM6Tpj%2Be8JQx > 9ZxeqHo% > >> 3D&reserved=3D0 > >> > >> > >> Mike > >> > >>> -----Original Message----- > >>> From: devel@edk2.groups.io On Behalf Of > >>> Michael Kubacki > >>> Sent: Monday, November 14, 2022 10:05 AM > >>> To: devel@edk2.groups.io; Kinney, Michael D > >>> ; abner.chang@amd.com; Laszlo Ersek > >>> ; Kubacki, Michael > >>> > >>> Subject: Re: [edk2-devel] [edk2-CCodingStandardsSpecification PATCH > >>> 2/2] Source Files / Spacing / Multi-line func. calls: allow > >>> condensed arguments > >>> > >>> Have these changes been discussed in a community forum? Do you think > >>> we could talk about it in the Tianocore Tools & CI Meeting today? > >>> > >>> Thanks, > >>> Michael > >>> > >>> On 11/14/2022 12:37 PM, Michael Kubacki wrote: > >>>> I'm catching up on this thread so let me know if I miss something. > >>>> > >>>> Uncrustify can perform conversions/enforcements like adjusting code > >>>> to < > >>>> 80 columns. > >>>> > >>>> The edk2 uncrustify configuration file is here and you will see > >>>> that I commented column width enforcement: > >>>> > >>>> > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgith > ub.com%2Ftianocore%2Fedk2%2Fblob%2Fmaster%2F.pytool%2FPlugin%2FU > ncrustifyCheck%2Funcrustify.cfg%23L19&data=3D05%7C01%7Cabner.chan > g%40amd.com%7C1f9c0bc3c6c747f1297308dac673afe9%7C3dd8961fe4884e6 > 08e11a82d994e183d%7C0%7C0%7C638040497500028713%7CUnknown%7CT > WFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLC > JXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3D6CpnXs63WTGicnIznfXtG > MZHWjgq24Sz3yC8uWzEwQA%3D&reserved=3D0. > >>>> > >>>> > >>>> > >>>> Uncrustify aside, column width is particularly difficult to adjust > >>>> consistently. Both humans and tools have to make many (constant) > >>>> situational decisions based on code structure. > >>>> > >>>> However, it should be possible. I've taken the current uncrustify > >>>> configuration file, made minimal changes to restrict code to 80 > >>>> columns, and published the results based on the current edk2 code > >>>> tree here: > >>>> > >>>> > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fg > >>>> > ithub.com%2Fmakubacki%2Fedk2%2Ftree%2Funcrustify_80_column_chang > e&a > >>>> > mp;data=3D05%7C01%7Cabner.chang%40amd.com%7C1f9c0bc3c6c747f1297308 > dac > >>>> > 673afe9%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C6380404975 > 0002 > >>>> > 8713%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2lu > MzIiLC > >>>> > JBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3D7OJjrlwy > Eq%2 > >>>> FPdbYEZFFsVvHsYs0ir0cVuLMWy4wxLEM%3D&reserved=3D0 > >>>> > >>>> You can see the I ran uncrustify 3 times to reach a mostly steady > >>>> state. > >>>> The issue after the second run is that uncrustify is confused about > >>>> what to do with single macros that exceed 80 columns. > >>>> > >>>> Examples: > >>>> 1. > >>>> > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fg > >>>> > ithub.com%2Fmakubacki%2Fedk2%2Fblob%2Funcrustify_80_column_chang > e%2 > >>>> FMdePkg%2FInclude%2FIndustryStandard%2FAcpi30.h%23L702- > %23L704& > >>>> > data=3D05%7C01%7Cabner.chang%40amd.com%7C1f9c0bc3c6c747f1297308dac > 673 > >>>> > afe9%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C6380404975000 > 2871 > >>>> > 3%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzI > iLCJBT > >>>> > iI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3D1nCH5GoBl > LU9Lb0 > >>>> r%2FVzuEaPg2mXTS3JGpLi9UBwRTYk%3D&reserved=3D0 > >>>> > >>>> > >>>> 2. > >>>> > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fg > >>>> > ithub.com%2Fmakubacki%2Fedk2%2Fblob%2Funcrustify_80_column_chang > e%2 > >>>> > FMdePkg%2FInclude%2FIndustryStandard%2FIpmiNetFnApp.h%23L1023- > %23L1 > >>>> > 031&data=3D05%7C01%7Cabner.chang%40amd.com%7C1f9c0bc3c6c747f1 > 2973 > >>>> > 08dac673afe9%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C63804 > 0497 > >>>> > 500028713%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIj > oiV2luM > >>>> > zIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3DSw > %2BVP > >>>> dtwl8ydIWSq3B80hDz2luABjdXsP91O2WcJ0aA%3D&reserved=3D0 > >>>> > >>>> > >>>> > >>>> There are other cases there as well. > >>>> > >>>> Anyway, if those were reduced in length, I think we could reach a > >>>> steady state. Some other minor tweaks might also be required. > >>>> > >>>> Regarding function calls, I put together the following branch to > >>>> demonstrate some examples of what is done now. > >>>> > >>>> In summary, multiple arguments can be provided on a single line > >>>> (with no width or argument count maximum) or multiple lines. If a > >>>> single argument is multi-line, then all arguments must be on a > >>>> unique line to follow the multi-line argument convention. > >>>> > >>>> See the top two commits in this branch for examples: > >>>> > >>>> > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fg > >>>> > ithub.com%2Fmakubacki%2Fedk2%2Ftree%2Ffunc_arg_formatting_demo& > amp; > >>>> > data=3D05%7C01%7Cabner.chang%40amd.com%7C1f9c0bc3c6c747f1297308dac > 673 > >>>> > afe9%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C6380404975000 > 2871 > >>>> > 3%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzI > iLCJBT > >>>> > iI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3DY2MTi5v5Fl > PuEdx > >>>> 5Lmg8%2Fm15TK7rNwlYapK%2FBExHC6o%3D&reserved=3D0 > >>>> > >>>> I agree uncrustify and the spec be in sync. > >>>> > >>>> Regards, > >>>> Michael > >>>> > >>>> On 11/14/2022 12:07 PM, Michael D Kinney wrote: > >>>>> I disagree that they can coexist. > >>>>> > >>>>> If uncrustify is forcing 1 arg per line, then a developer that > >>>>> follows a CSS that allows multiple per line, the code change will > >>>>> be rejected by EDK II CI. > >>>>> > >>>>> The CSS and Uncristify behavior need to be aligned.If we want a > >>>>> CSS change that requires Uncristify changes, then they have to be > >>>>> coordinated. > >>>>> > >>>>> Mike > >>>>> > >>>>> *From:*devel@edk2.groups.io *On Behalf > Of > >>>>> *Chang, Abner via groups.io > >>>>> *Sent:* Sunday, November 13, 2022 5:10 PM > >>>>> *To:* devel@edk2.groups.io; Kinney, Michael D > >>>>> ; Laszlo Ersek ; > >>>>> Kubacki, Michael > >>>>> *Subject:* Re: [edk2-devel] [edk2-CCodingStandardsSpecification > >>>>> PATCH 2/2] Source Files / Spacing / Multi-line func. calls: allow > >>>>> condensed arguments > >>>>> > >>>>> [AMD Official Use Only - General] > >>>>> > >>>>> For this case, we don't have to take another global reformatting. > >>>>> These two formats can coexisting without the conflict. We just > >>>>> allow the condense argus format in CSS. Also, update Uncrustify to > >>>>> not forcing each argument at its own line. > >>>>> > >>>>> The current Uncrustify behavior seems to me match the CCS spec. > >>>>> But this patch was sent to allow the multiple argus at the same > >>>>> line, which was not proposed to fix the issue in current > >>>>> Uncrustify. You sure we just close this issue? > >>>>> > >>>>> Abner > >>>>> > >>>>> *From:* devel@edk2.groups.io > >>>>> > *On Behalf > Of > >>>>> *Michael D Kinney via groups.io > >>>>> *Sent:* Monday, November 14, 2022 1:36 AM > >>>>> *To:* devel@edk2.groups.io ; Chang, > >>>>> Abner >; > Laszlo > >>>>> Ersek >; Kubacki, > >>>>> Michael >>>>> >; Kinney, Michael D > >>>>> > > >>>>> *Subject:* Re: [edk2-devel] [edk2-CCodingStandardsSpecification > >>>>> PATCH 2/2] Source Files / Spacing / Multi-line func. calls: allow > >>>>> condensed arguments > >>>>> > >>>>> > >>>>> > >>>>> *Caution:*This message originated from an External Source. Use > >>>>> proper caution when opening attachments, clicking links, or > responding. > >>>>> > >>>>> We do not want another global format change because that make git > >>>>> blame difficult to use. > >>>>> > >>>>> Are any clarifications required to describe the current Uncrustify > >>>>> behavior? Or is the description correct? > >>>>> > >>>>> If the current description matches Uncristify behavior, then I > >>>>> recommend we close this issue as will not fix. > >>>>> > >>>>> Mike > >>>>> > >>>>> *From:* devel@edk2.groups.io > >>>>> > *On Behalf > Of > >>>>> *Chang, Abner via groups.io > >>>>> *Sent:* Sunday, November 13, 2022 12:45 AM > >>>>> *To:* Kinney, Michael D >>>>> >; devel@edk2.groups.io > >>>>> ; Laszlo Ersek >>>>> >; Kubacki, Michael > >>>>> >>>>> > > >>>>> *Subject:* Re: [edk2-devel] [edk2-CCodingStandardsSpecification > >>>>> PATCH 2/2] Source Files / Spacing / Multi-line func. calls: allow > >>>>> condensed arguments > >>>>> > >>>>> [AMD Official Use Only - General] > >>>>> > >>>>> Uncrustify can fix the first argument that is not at the indent > >>>>> with two space. It also can fix the first argument that is not at > >>>>> the new line. > >>>>> > >>>>> But it also makes each argument a new line if multiple args are > >>>>> condensed in one line. That is what we have to update Uncrustify > >>>>> if we have this patch merged to CCS. > >>>>> > >>>>> +Michael Kubacki in loop. > >>>>> > >>>>> Abner > >>>>> > >>>>> *From:* Kinney, Michael D >>>>> > > >>>>> *Sent:* Sunday, November 13, 2022 9:58 AM > >>>>> *To:* devel@edk2.groups.io ; Chang, > >>>>> Abner >; > Laszlo > >>>>> Ersek >; Kinney, > >>>>> Michael D >>>>> > > >>>>> *Subject:* RE: [edk2-devel] [edk2-CCodingStandardsSpecification > >>>>> PATCH 2/2] Source Files / Spacing / Multi-line func. calls: allow > >>>>> condensed arguments > >>>>> > >>>>> > >>>>> > >>>>> *Caution:*This message originated from an External Source. Use > >>>>> proper caution when opening attachments, clicking links, or > responding. > >>>>> > >>>>> Is this exactly what Uncrustify does now? > >>>>> > >>>>> Mike > >>>>> > >>>>> *From:* devel@edk2.groups.io > >>>>> > *On Behalf > Of > >>>>> *Chang, Abner via groups.io > >>>>> *Sent:* Saturday, November 12, 2022 5:36 PM > >>>>> *To:* Laszlo Ersek >; > >>>>> devel@edk2.groups.io > >>>>> *Subject:* Re: [edk2-devel] [edk2-CCodingStandardsSpecification > >>>>> PATCH 2/2] Source Files / Spacing / Multi-line func. calls: allow > >>>>> condensed arguments > >>>>> > >>>>> Hi all, > >>>>> As we are going to release CCS 2.3, we would like to address some > >>>>> pending issues of CCS. For this, I think we can, > >>>>> - Still keep the one line per argument style in CCS although the > >>>>> multi-arguments in the one line style can cover this. This avoids > >>>>> confusion from readers and questions about if they can do the > >>>>> one-line per argument style. > >>>>> - If the arguments are in different lines, the first argument must > >>>>> be indented with two spaces from the start of the function name or > >>>>> the member function name. > >>>>> How is this? > >>>>> > >>>>> Abner > >>>>> > >>>>> > >>>> > >>>> > >>>> > >>>> > >>> > >>> > >>> > >>> > >> > > > > > >=20 > > > >