From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 27F9A740035 for ; Mon, 2 Oct 2023 02:30:26 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=+8vs/iFR3Y/M2ZM9F6gxpC7B+gv4aGO9gLCdN4NNUQk=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1696213825; v=1; b=D9tpN093MJz4UsD0tXHooG5VFkc+Vq1+TIRVcZDNaxuevgkh5ZXXaTQFS5bFyljAf6nYWUVu nFAmdXwr9ILVhR88O0dUCiOgd3Q4av8DAtvYAXp0EumT8MT9ORpZomTxLnaMWmYRj0WzmGiFP8d GL4nnmZp/XIpt831yKa7IYEo= X-Received: by 127.0.0.2 with SMTP id blHpYY7687511xQBANsaRTuQ; Sun, 01 Oct 2023 19:30:25 -0700 X-Received: from NAM10-MW2-obe.outbound.protection.outlook.com (NAM10-MW2-obe.outbound.protection.outlook.com [40.107.94.79]) by mx.groups.io with SMTP id smtpd.web11.73717.1696213825010013330 for ; Sun, 01 Oct 2023 19:30:25 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A3+jSnR6bEbmqtsg5luRyC63/h8K0fndOQOFuAN33pA+KKHrJo5rAYxfR2mmzJeDCZezsqOkDC8UkqqUyLUAcn2Ix20LiapN6CFpeRF9vj+lCAb0H0I0lN0Xv2XGRArRvHoESBDlzCXQ9Sy421baho4/HqSLWSTHpmgAa5sXKU2ZArd3N4jS1WL3KKt5kSwM0UBSs/EXARxjZ1UkhUSAlzpOVSAx9ExhdjfeThGP3pexWtlOooJS8wkXAlQMDBh+U6L2wTadwzr4nymdJmWr7O7mBHuPdn/8GKUdOHJlzQn3nhQOM98hrHKn10F1HAY9hgQB8r2UDsz2w58yjeyhiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BIrJgZS+ABypMBXoG+T8/+bDGOHdNUO057gu5Exv7ds=; b=BY/2Vs/8L01pyFfwH0gjL67eUgSDpO3LM43c3+C74ydtxUSK7UiIaSrfuK+9ZgbHsufHQDlH6/tEgvRwpm24xZrgJx3XMmu7e0El+Ei6Ev1Iaa6rh1I5xMXkXkV1BQAg86pSQWojjYuKeyzrbtQJza/Xxl/uvWFdbGx7ZgLfhTyVo53ZRvgM/gpeKgilOb2tHUf9EI+vhofSZrulPQo2p6xp5lgJoZLlUlKLvaOedACHil1BhqZWkTAA0YEdBODEGGioheoVmE7zFumNPtOQUDQpswH0OxxpS8palHtt2POL08TisFKvUrdOT2sQFzNq2kUwIJ8tsD8Xdin1zdBAJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by SJ2PR12MB8036.namprd12.prod.outlook.com (2603:10b6:a03:4c1::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.25; Mon, 2 Oct 2023 02:30:22 +0000 X-Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::2061:ca33:b659:2c02]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::2061:ca33:b659:2c02%5]) with mapi id 15.20.6838.029; Mon, 2 Oct 2023 02:30:22 +0000 From: "Chang, Abner via groups.io" To: Mike Maslenkin , "devel@edk2.groups.io" CC: "nicklew@nvidia.com" , "igork@ami.com" Subject: Re: [edk2-devel] [PATCH 6/9] RedfishClientPkg: fix memory leaks while applying feature settings Thread-Topic: [PATCH 6/9] RedfishClientPkg: fix memory leaks while applying feature settings Thread-Index: AQHZ8yA3z3vaOXpy606vnzYcPpWmhLA1ynuA Date: Mon, 2 Oct 2023 02:30:22 +0000 Message-ID: References: <20230929215915.46616-1-mike.maslenkin@gmail.com> <20230929215915.46616-7-mike.maslenkin@gmail.com> In-Reply-To: <20230929215915.46616-7-mike.maslenkin@gmail.com> Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=22b29e2a-c31f-4740-b1c2-de6e9f3cff2c;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-10-02T02:30:11Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|SJ2PR12MB8036:EE_ x-ms-office365-filtering-correlation-id: 586d66ad-894d-48b5-8564-08dbc2ef876e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: ozvx6psHqslQTBdBwLsiof0DP9zT1Lf/LRVb7xrFPKsU7T3E65/szzx0lyEhZap3Yzl3X9W6fmCvAKXnNutmoME9CDAvbW31NNg9bMt2RNIYDFc7QjJn9Lmh+tPUi29AfwWUyB1wplsKWOW57CrZVv7FNLCQMo7N53mAPgqxPPaqJT/B8yHenO8r5IQxhOF+/mBr33I/7G+uSo+N6A5mdjWh5PjLBO5bT/f7AjDQUmnW1XUCj+yaM0Ztum6J4KJ0gKtqykwMFN+Ujy2JkZLMQrqUymRCFSs/CkzYTqfCdke/SoSZtCzF1naPD3Ac4vPnLE0d0l7bXNAOHXaiIGNtI/pOrq8aXxsxogPBQ86nZndjLtNXcyJfFW6ZwElQUXLdO32yNKAbdNrPikt5UK3nNSPImx18LL+Qz5cLSXw24BEYg3fFaf2ecY2EwkQz32YY7HFlzBpS6HePpiX9LAJaG3ooLxjgHcsKrrtRHYN0Tu0V1hZ9aBI1BHZe/7MdKbsgmCo+3USm5ZRlDklOnPbzHpdjuqthXipq5Hv29JRqnzkxbym8FZOcgGCQ5b3QMLlMr40MOYkcpmJRGNft+dFBP5pz8tAuXWykcA2FjjVyNzbfvcnBG+66vpZh9i1KTTJr x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?zQDQKx4/6MRb4NDJqMJSZJGbfv89Ej95jX/QXoELoX3LLWP9zeEpuORQzrm8?= =?us-ascii?Q?mQZHvWNoqSRghyG28bGJO6SkXaOY16XTvGTi72urWt8P/EP5QZw41Xq74hWF?= =?us-ascii?Q?BNugOwv7dfVuth8ol/MUwjk5egPfwefpSxxKWbw3N+QAL+mYKiiCiK6aIOE9?= =?us-ascii?Q?Z4tsG/XR/S/n5GBE1w/bmPGTLMrD0bZ6oARwG+BOpSt95DKnWRusmDFoJdWq?= =?us-ascii?Q?/bDIgMoaJ47o/rreixKs1PeweyklgCUmnvueK0dHYvxCGd9ZEyGI7p23qo37?= =?us-ascii?Q?jhEC/Ucz9IUsWPge1NrPozOdwbDC9s61TCID0VQEvPHOY5/IdnaRHhvxS0/c?= =?us-ascii?Q?Imond9Jnm+B2robMdVbs1jM/oFg+9YfZ25nvYzh/djCiqHax1Kjo/IHEXZlA?= =?us-ascii?Q?4jy5HvD1DHmt2/Vpi10spjtmryfFwwEbMFrntuayy5JYfDViq4JuVQQ7NX78?= =?us-ascii?Q?WU/nsQsWhLDoPdqIjep3MVe91LpLVXfFXY5jXqaYnZEX1Od+EXGKnpB6o251?= =?us-ascii?Q?xm0Wmd6KidhTaNXyFN/PD3HuRTDy0AF7beFj+ROeWPJdmHZLE0aTPE3Q8b5s?= =?us-ascii?Q?7ZHhesLlJzvieDgyuADNRC8kpuk0zUVCckidPBHb/RW9Td/EO6pKERipqh4Y?= =?us-ascii?Q?F+tgoNV9m7hZHGNXGJNlh0AgSVzifVKzbuBnw/fpTuhU7RFV8YwHjupqt3Vw?= =?us-ascii?Q?QWyQ4c2JV4wOcEFgMPQoqNDuLm2wLYp4xUBYlYkXvqGwxSLudzt6qUyfsKN1?= =?us-ascii?Q?fctbABB15M1ZklQTYAJ90rD5rs2bQ+wU5yu4pu8kCVw4Nvac9aWTHoD+a/GE?= =?us-ascii?Q?SNgSdcFjXwb4bQYZOU19ZdlbcTcNFV3aYNWujchoWdPwdhmYE8hM3PW+O8eC?= =?us-ascii?Q?FmJnqtGt4ZNBca0qJh3l78QPoMw2fi73jpdchn8rH9C6FkcdtSy3M7sQQzzY?= =?us-ascii?Q?z1E/anl7tw1nymz8URoV8cmwSlKm/FmR3T9/orL4VhoNBQv+OXp/0zlB6m9M?= =?us-ascii?Q?eltIBHPoGmFSQcbcNCwoPXBomb+IuMvfFGNolutU3RjEFk/PazJCN+gFg6MQ?= =?us-ascii?Q?GUdi5p2WMj0NncdMkMvqgpLhzBuUV+Il4mPVuPnCTJ+KhA3+pFyxDPnpJ4Yc?= =?us-ascii?Q?8LqFSwqcL7NGTpiSp2i+P3ra3IO35ecuRFRWvFBPjgr7lvaRU8+QcL/gTl58?= =?us-ascii?Q?3TzGtw9Tx29RfuVkOje8QYZ3YrDoM6hv7dI1e5fG6torijKjNujxT1gq/k1r?= =?us-ascii?Q?4AsD9iesT978tr5I8mPLyyVlm4WcLbx0kMLfam3d/DAjfkuDfj0BvfmAaz+H?= =?us-ascii?Q?dARSS6d1eoxJqKZ/rX4PqDELhlKgV6oj0jQrl4byvRcvAl+wO1SeEBe1bhma?= =?us-ascii?Q?knvddUccjh3S2jDeSQ0RGeRRR5GaqEdZ0Y5iTy6/abLZLsGRF0V7Ejg8cldu?= =?us-ascii?Q?KZdb0iW2SHE3vAh0VooDcvQLnQ/DBBBrS2l/xFfm5ubAwE4opKmc6h28fbmU?= =?us-ascii?Q?KVbZdEDOoMAowdRj1WiMRCUF+3PKL3EBY7R04NYKsw5ZyyGWMP4k+b7CAfAZ?= =?us-ascii?Q?Ng7P9a07W7pE2Mj8fjU=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 586d66ad-894d-48b5-8564-08dbc2ef876e X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Oct 2023 02:30:22.7842 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 39fwRNnqHpCCmLvRaOYhBjzTmcw8JfdTHP3PZ6VSpr+FrLpM6h6Q3JUfRZgMLwanjmdoEOYz948qJlLxL8Vsug== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8036 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: sM9g2kkFm51mrD4eagMDpA9vx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=D9tpN093; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") [AMD Official Use Only - General] Reviewed-by: Abner Chang > -----Original Message----- > From: Mike Maslenkin > Sent: Saturday, September 30, 2023 5:59 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; nicklew@nvidia.com; > igork@ami.com; Mike Maslenkin > Subject: [PATCH 6/9] RedfishClientPkg: fix memory leaks while applying > feature settings > > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. > > > Signed-off-by: Mike Maslenkin > --- > .../RedfishFeatureUtilityLib.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git > a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtility= Lib. > c > b/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtility= Lib. > c > index 0941f33fd73a..e189987850f7 100644 > --- > a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtility= Lib. > c > +++ > b/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtility= Lib. > c > @@ -806,6 +806,7 @@ ApplyFeatureSettingsStringArrayType ( > RedfishValue.Value.StringArray[Index] =3D AllocateCopyPool (AsciiS= trSize > (Buffer->ArrayValue), Buffer->ArrayValue); > > if (RedfishValue.Value.StringArray[Index] =3D=3D NULL) { > > ASSERT (FALSE); > > + FreePool (RedfishValue.Value.StringArray); > > return EFI_OUT_OF_RESOURCES; > > } > > > > @@ -828,6 +829,12 @@ ApplyFeatureSettingsStringArrayType ( > DEBUG ((DEBUG_ERROR, "%a, %a.%a %s array value has no change\n", > __func__, Schema, Version, ConfigureLang)); > > } > > > > + for (Index =3D 0; Index < RedfishValue.ArrayCount; Index++) { > > + FreePool (RedfishValue.Value.StringArray[Index]); > > + } > > + > > + FreePool (RedfishValue.Value.StringArray); > > + > > return Status; > > } > > > > @@ -927,6 +934,8 @@ ApplyFeatureSettingsNumericArrayType ( > DEBUG ((DEBUG_ERROR, "%a, %a.%a %s array value has no change\n", > __func__, Schema, Version, ConfigureLang)); > > } > > > > + FreePool (RedfishValue.Value.IntegerArray); > > + > > return Status; > > } > > > > @@ -1026,6 +1035,8 @@ ApplyFeatureSettingsBooleanArrayType ( > DEBUG ((DEBUG_ERROR, "%a, %a.%a %s array value has no change\n", > __func__, Schema, Version, ConfigureLang)); > > } > > > > + FreePool (RedfishValue.Value.BooleanArray); > > + > > return Status; > > } > > > > -- > 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109246): https://edk2.groups.io/g/devel/message/109246 Mute This Topic: https://groups.io/mt/101667465/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-