Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
Hi Eric,
Thanks.
You didn't really need to rework the patch, but I do want to see the
Reviewed-by's from the other added people before merging.
Best Regards,
Leif
On Thu, Sep 28, 2023 at 17:13:36 +0000, Xing, Eric wrote:
> [AMD Official Use Only - General]
>
> Thanks Leif for your quick response and reminder. I added Abner as CC in PATCH v2.
> Sorry troubling you, would you help review it again so I can get your approved with v2 patch? Thanks again.
>
> Eric
>
> -----Original Message-----
> From: Leif Lindholm <quic_llindhol@quicinc.com>
> Sent: Friday, September 29, 2023 12:15 AM
> To: Xing, Eric <Eric.Xing@amd.com>
> Cc: devel@edk2.groups.io; Michael D Kinney <michael.d.kinney@intel.com>; Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>
> Subject: Re: [[edk2-non-osi][Silicon/AMD][PATCH] VanGogh Silicon initialization firmware binaries 1/2] Maintainers.txt: Add maintainer for Silicon/AMD and Silicon/AMD/Vangogh
>
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>
>
> +Abner
>
> Looks fine to me, but I'd like to have a Reviewed-by from Abner, Abdul, Duke.
>
> Best Regards,
>
> Leif
>
> On Thu, Sep 28, 2023 at 22:30:53 +0800, eric.xing@amd.com wrote:
> > From: Eric Xing <Eric.Xing@amd.com>
> >
> > Signed-off-by: Eric Xing <eric.xing@amd.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> > Cc: Abdul Lateef Attar <abdattar@amd.com>
> > Signed-off-by: Eric Xing <Eric.Xing@amd.com>
> > ---
> > Maintainers.txt | 9 +++++++++
> > 1 file changed, 9 insertions(+)
> >
> > diff --git a/Maintainers.txt b/Maintainers.txt index c42d135..1d5dacb
> > 100644
> > --- a/Maintainers.txt
> > +++ b/Maintainers.txt
> > @@ -58,6 +58,15 @@ Platform/Intel/CometlakeSiliconBinPkg
> > M: Kathappan Esakkithevar <kathappan.esakkithevar@intel.com>
> > M: Sai Chaganty <rangasai.v.chaganty@intel.com>
> >
> > +Silicon/AMD
> > +M: Abner Chang <abner.chang@amd.com>
> > +M: Abdul Lateef Attar <abdattar@amd.com>
> > +M: Eric Xing <eric.xing@amd.com>
> > +
> > +Silicon/AMD/Vangogh
> > +M: Duke Zhai <duke.zhai@amd.com>
> > +M: Eric Xing <eric.xing@amd.com>
> > +
> > Silicon/Ampere/AmpereAltraBinPkg
> > M: Nhi Pham <nhi@os.amperecomputing.com>
> > M: Vu Nguyen <vunguyen@os.amperecomputing.com>
> > --
> > 2.17.1
> >