Re: [edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH V5 13/30] UefiCpuPkg/CpuTimerLib: Refactor to allow other architectures

["Chang, Abner" <abner.chang@amd.com>]

[AMD Official Use Only - General]

Acked-by: Abner Chang <abner.chang@amd.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Sunil V L
> via groups.io
> Sent: Sunday, October 30, 2022 9:28 PM
> To: devel@edk2.groups.io
> Cc: Eric Dong <eric.dong@intel.com>; Ray Ni <ray.ni@intel.com>; Rahul
> Kumar <rahul1.kumar@intel.com>
> Subject: [edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH V5 13/30]
> UefiCpuPkg/CpuTimerLib: Refactor to allow other architectures
> 
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
> 
> 
> REF:
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugz
> illa.tianocore.org%2Fshow_bug.cgi%3Fid%3D4076&amp;data=05%7C01%7Ca
> bner.chang%40amd.com%7C67d9801d83d143b0bf2908daba7aef42%7C3dd89
> 61fe4884e608e11a82d994e183d%7C0%7C0%7C638027334440445381%7CUnkn
> own%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik
> 1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=IGuSZ7ju65kJPe
> zopj9ks0DquRiOSLMAkM%2Fk1aMNFiA%3D&amp;reserved=0
> 
> Currently, CpuTimerLib library supports only X86 architecture.
> Refactor to allow other CPU architectures.
> 
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Rahul Kumar <rahul1.kumar@intel.com>
> Signed-off-by: Sunil V L <sunilvl@ventanamicro.com>
> ---
>  UefiCpuPkg/Library/CpuTimerLib/BaseCpuTimerLib.inf             | 6 +++---
>  UefiCpuPkg/Library/CpuTimerLib/{ => Ia32X64}/BaseCpuTimerLib.c | 0
>  UefiCpuPkg/Library/CpuTimerLib/{ => Ia32X64}/CpuTimerLib.c     | 0
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/UefiCpuPkg/Library/CpuTimerLib/BaseCpuTimerLib.inf
> b/UefiCpuPkg/Library/CpuTimerLib/BaseCpuTimerLib.inf
> index de0648de91b5..4b263965ed90 100644
> --- a/UefiCpuPkg/Library/CpuTimerLib/BaseCpuTimerLib.inf
> +++ b/UefiCpuPkg/Library/CpuTimerLib/BaseCpuTimerLib.inf
> @@ -18,9 +18,9 @@ [Defines]
>    LIBRARY_CLASS                  = TimerLib
>    MODULE_UNI_FILE                = BaseCpuTimerLib.uni
> 
> -[Sources]
> -  CpuTimerLib.c
> -  BaseCpuTimerLib.c
> +[Sources.IA32, Sources.X64]
> +  Ia32X64/CpuTimerLib.c
> +  Ia32X64/BaseCpuTimerLib.c
> 
>  [Packages]
>    MdePkg/MdePkg.dec
> diff --git a/UefiCpuPkg/Library/CpuTimerLib/BaseCpuTimerLib.c
> b/UefiCpuPkg/Library/CpuTimerLib/Ia32X64/BaseCpuTimerLib.c
> similarity index 100%
> rename from UefiCpuPkg/Library/CpuTimerLib/BaseCpuTimerLib.c
> rename to UefiCpuPkg/Library/CpuTimerLib/Ia32X64/BaseCpuTimerLib.c
> diff --git a/UefiCpuPkg/Library/CpuTimerLib/CpuTimerLib.c
> b/UefiCpuPkg/Library/CpuTimerLib/Ia32X64/CpuTimerLib.c
> similarity index 100%
> rename from UefiCpuPkg/Library/CpuTimerLib/CpuTimerLib.c
> rename to UefiCpuPkg/Library/CpuTimerLib/Ia32X64/CpuTimerLib.c
> --
> 2.38.0
> 
> 
> 
> 
>