From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (NAM12-DM6-obe.outbound.protection.outlook.com [40.107.243.47]) by mx.groups.io with SMTP id smtpd.web10.139.1685723490787324694 for ; Fri, 02 Jun 2023 09:31:31 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=PSiogdkh; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.243.47, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gFjLTwWYbBPOaTMrw0kxvezPP/qHsl5baeevjTXJZlZrfK2Bzd1IVqmizYvwyhVrnt1QX7KewU8DIBeWr8T1W6fne27BcViOvWNFu88heMFhqwtcfLMS5nsasdncrPmUmIDIxIM+358ONw6+M/VhBj/fJ3CV2XtC3gPDmxrH8t8ev7gJEL90+6cSIhMUPKgwmE0AmnCaLvoKckjEOoteojlqd4sMNDo8o59SPp9uwiTtMjzmk/orDQNc8zMkeJrLfmra3xZKUC2kCmK4wCZ5epl5dMWtfm0UOvhaf0iGUTPvvEQtW4KAUhXg+LcD5Vj8QLiZO7zA8ZD1km3uPMWX2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LOzOg/e6X1+4642f+WOKjeTtNa83/B0na00RJJrxh+M=; b=WA1+bMp45PAI409WKKqykQdsy9qzBIPZFbpqrr0ZDjNjPwvFnnMMy7nXbFn89xoJmGZgOzB+xuB+V5n2jYbkpU9HOXoih4/pQaG5R9aPXX2dsxqinW5yKHGAsZJT8AzXKyt6h6lFLQENhkajsU2r/2KfhnZqH5ZMyOeHQobrxucmvFIaKzk/aULrBvDbUK4kfHm3KINjNeHwEEDiJjqn3acqO1lYVq4IhucWcaX/hFZs05jGBnJAsTL7PvveW9ColLHAKadfffBf2U81Eq32TDLt7UfuB6zkGyT/ftrgD7FbgZQR8mbZx3BpSGaztWTZgFAS052dDLIex3Huyu+6TA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LOzOg/e6X1+4642f+WOKjeTtNa83/B0na00RJJrxh+M=; b=PSiogdkhaBvmW7sbqt52Z9G2vV+FTU08r7qFfu4s3LKj6k77REcnEai6Ht5mpKRiVy01kq1U7ZP97L5zcbj41sempnlkn5+A4yIOV10Qv6KOj7prYcEaA2YQrp+1YpKEH6axlEnHShvlYCjWk6elvLtNK5Est//V0774heFi354= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by MW3PR12MB4443.namprd12.prod.outlook.com (2603:10b6:303:2d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.23; Fri, 2 Jun 2023 16:31:27 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::edb0:bed8:c650:5040]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::edb0:bed8:c650:5040%6]) with mapi id 15.20.6455.024; Fri, 2 Jun 2023 16:31:27 +0000 From: "Chang, Abner" To: "Hsueh, Hong-Chih (Neo)" , "Wu, Hao A" , "He, Jiangang" , "devel@edk2.groups.io" Subject: Re: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in AhciPei PEIM Thread-Topic: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in AhciPei PEIM Thread-Index: AQHZjZkboPIVCDc180mWVLPxgzEKQq9zxQmAgAC9sgCAAmLCgIAAvrYAgAAepLA= Date: Fri, 2 Jun 2023 16:31:27 +0000 Message-ID: References: <28f72c221f0c7f84e6d992b434565107cdb718b4.1684858126.git.Hong-Chih.Hsueh@amd.com> In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=True;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-06-02T14:37:06.463Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|MW3PR12MB4443:EE_ x-ms-office365-filtering-correlation-id: d8c2b2a3-14d4-439b-37fe-08db6386d058 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: j308ixwjS0oCptlcH+hPmInxZJLfZhrevO2yrY4XSrOSTpaUBaIKBfhRRIUpRqLOvfQKe3B6wXaIL8HMsSLZjZloXhXmDWq3k7xFxrCH1vbh6KPm+osajscsKVbRSRIxNgib+1oFQXiGxfaRr4rx6zxpOy2qBA6BZPPGQSMd/wf9jrb1tVVF6yHwimuFDv+ubQXhuy+FCDATWDpMVfBzh5MoWGeFSTk0pbnoj2HYNTgBFMXMvFUo43Ti20aTR+Iq9wbas9KQn3GEA+9JmcuVLPBMDLmgx2nKHD8oUnXblNIZusZd2iSST6X33KzVxnlFKBeVt6ni1VXQjKGbNxpvs4QrOpDmgeVZ7nWh0JK1qpraZi7CvXV7FUhkRynPZ9heC7st1zQRV2WpSzJ1o6vTYWZGGf/lJ2jwTfeM3LK3Nt0w5gm7nuwJlChJZGyWdlgNeUNEvmfOSatW8tkmD2N8KUPODa739O2/+XGdveArEUhEq3zEjPX9ow4J2ilIaHN+e0ksAnwDpgZhmeLL+F5QJjiLswV60L+sh9sBzfNOCvaiiTA3LJjzPeda1MBr3kgRE2fYLh9OjvrxEeh4Jvu0nzVlHXOsEeNfoxs2LJZozUA= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(136003)(39860400002)(396003)(376002)(366004)(451199021)(55016003)(71200400001)(66899021)(122000001)(478600001)(38100700002)(41300700001)(83380400001)(86362001)(8676002)(38070700005)(8936002)(2906002)(5660300002)(33656002)(52536014)(110136005)(316002)(64756008)(166002)(66946007)(66476007)(66556008)(76116006)(66446008)(966005)(53546011)(9686003)(26005)(186003)(7696005)(6506007);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?SL/AZ6P8+iFQYZXL6O2oiEs3SMPMzYZAHms5tCJAARgo6brPHdlToNxksA1+?= =?us-ascii?Q?TX8hri3rYiVVQohPXtwVmBoLmNTcN//Mi3a3DOqx5PIRdARW3RWnJRtrwV2y?= =?us-ascii?Q?vIULLoNreaL31TSWQ7vTZXX6M2FAgw0r446p2D82GOhCAL1uhSL2rkQsTTqF?= =?us-ascii?Q?ynsaNAtygqFEMAa2QuMYQydsfslYmsTWpmkes56DFZRi9BWMcC8HwCRbx7/3?= =?us-ascii?Q?cAimoopnP4OtadLgq7ol8f+om7nlNERI2220GghbTWFfqd3JNE1WW3ePyjRi?= =?us-ascii?Q?v578suNmJTUt0yrSpUXyisPkr99jNXCZaRFjXLIvAbaksoDJhGaEVwbGabLK?= =?us-ascii?Q?AUXrfreIiEufEXs5V0JmB8AgfzuzTHTubZJOFb0U+c4vbenwswRKRfiyBfqB?= =?us-ascii?Q?qxoJOCCWt1psUxgHrHOJukZwktMWdJm6nCjBl8NGD1heIeXFLEqSSGm6zH6/?= =?us-ascii?Q?r5Kg7Qyk0Tl9XEEyK8tM/+AzoQ7L0BAnsDflPG0S7+D2s3sJWKRIbcLeLoB7?= =?us-ascii?Q?zBOqo/BG38BmxD8xMmYOtcICmWKGdqR9AiRGJ5Jscjm24V2uOHNslfuVv8/r?= =?us-ascii?Q?lZj2I/WK73JBGEydScDVcqT2Imansp5eX8wRaG8CppjASZh1v85n+lsoZnW2?= =?us-ascii?Q?GUvsouvT5n1N6laiQTHPi8E/Y6DaYyrbUbVGm6wNF2O5r5BQhydy9X1ToV4k?= =?us-ascii?Q?XLynDYD4zoG6QW+7pU27PzrhltMfne8mZb2SRsAHLRJ5GguU2Wpm2VYyxfKb?= =?us-ascii?Q?gzDddy7rdIDxfkwBlwMRlWlB2tlapE2nB+y/7Mr0qPydyHbX/c+yz6jpWoiE?= =?us-ascii?Q?2YSCY3hRTyRqc+bwHsKwizw04TGsQgPTEil0nUxLeVxVDwpuIhJ46jTSHxc0?= =?us-ascii?Q?7O9Lvhgofp5aMojTlYsRUD65V6syyhIXiR//zlO82V/QXT3cGnyOLKLOGyVS?= =?us-ascii?Q?nK0v8LA6GEh7jpCPB8Be8QFvzwN6ApJ62aC8vXNmXEDArigaK5AcE+47X+8m?= =?us-ascii?Q?0EJxvfj58htn+kN4PyZpP8ET30+asC/f/WIgZln0EfB0cyj72LWOQ7opTIQN?= =?us-ascii?Q?+I/7W5+NAJOUnKV0KoPkyDgKE9YpKl4GNWoSkV8BbOkuYbonrkEvCgiFdqAm?= =?us-ascii?Q?SlLRRYYqeVU7A8x8p2MBkifDH/Kje9/zyGc1Im8TDsUmogFiObi3cSj7w3yW?= =?us-ascii?Q?xgS492iAoF9HnxFoPcC7uC5q3AskuNn9MLf5O615yl2NAynQXfQUeiQf+Y8y?= =?us-ascii?Q?7YWc1rP3wbuvcUuet7fvbnyAv2rgcouNdZ9FQS7toLu8FheHg1xS8cnoBWle?= =?us-ascii?Q?42y6b0n1vUGqgj3Y0J9kc5Zc3YIWoy9U7td2djouLZTv57HVCOL3hyYLcGtq?= =?us-ascii?Q?OG3A3PoPlEhxtCNDaDel5gVrRNoHEFoWzAOwk4kbIXoQIXEogrTSdSt+JAd8?= =?us-ascii?Q?shpPZHaZqWc3lli5uAXUJg1CIcY6Nk7bqWdlC0l27ouEVhbARDtFJc8p7u0B?= =?us-ascii?Q?hTBytTdTse1RIWh+7q1pHU4ciMl8JpQP3B7ZGkeGsAFVDOLB8JQSJEz1/Jlb?= =?us-ascii?Q?o4qhFuob9E/nnlBm24g=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d8c2b2a3-14d4-439b-37fe-08db6386d058 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jun 2023 16:31:27.4765 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: EzyYrboRs7n6sPWcX9fKpHp/GPRivw680lHevoRLfDdSNrYlaR8qmCPq9bw0EdkpI2Q5EUIdOVMq0ALZIM/F8g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4443 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MN2PR12MB3966F26BBEE0AB583BE0B2F8EA4EAMN2PR12MB3966namp_" --_000_MN2PR12MB3966F26BBEE0AB583BE0B2F8EA4EAMN2PR12MB3966namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Hi Leo, Please add Hao's RB in the commit message below your signed-off-by, thus we= know this patch has been reviewed. I also suggest to update your commit subject to "MdeModulePkg/Bus: Fix port= multiplier port in AhciPei PEIM". Please resend the PR with above updates, then Hao will add "Push" label to = this PR once your change passed CI. Thanks Abner From: Hsueh, Hong-Chih (Neo) Sent: Friday, June 2, 2023 10:37 PM To: Wu, Hao A ; He, Jiangang ; dev= el@edk2.groups.io Cc: Chang, Abner Subject: Re: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in= AhciPei PEIM [AMD Official Use Only - General] Hi Hao, Thank you for your review. I already created a pull request for this commit, may I know how to proceed= to merge it into master? https://github.com/tianocore/edk2/pull/4424 Regards, Neo ________________________________ From: Wu, Hao A > Sent: Thursday, June 1, 2023 10:14 PM To: He, Jiangang >; devel@e= dk2.groups.io >; Hsueh, Hong-Chih (Neo) > Cc: Chang, Abner > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port in= AhciPei PEIM [AMD Official Use Only - General] Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding. Thanks. Reviewed-by: Hao A Wu > Best Regards, Hao Wu > -----Original Message----- > From: He, Jiangang > > Sent: Wednesday, May 31, 2023 10:49 PM > To: Wu, Hao A >; devel@edk2= .groups.io; Hsueh, Hong- > Chih (Neo) > > Cc: Chang, Abner > > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port = in > AhciPei PEIM > > [AMD Official Use Only - General] > > We did crisis recovery and Opal HD password unlock from S3 resume from > SATA HD test on two different version of AHCI host controllers. > > Thanks, > Jiangang > -----Original Message----- > From: Wu, Hao A > > Sent: Tuesday, May 30, 2023 10:30 PM > To: devel@edk2.groups.io; Hsueh, Hong-Chih (= Neo) Chih.Hsueh@amd.com> > Cc: He, Jiangang >; Chang= , Abner > > > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port = in > AhciPei PEIM > > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. > > > Thanks, the code changes look good to me. > May I know what tests have been performed for the patch? > > Best Regards, > Hao Wu > > > -----Original Message----- > > From: devel@edk2.groups.io > On Behalf Of Neo > > Hsueh via groups.io > > Sent: Wednesday, May 24, 2023 1:07 AM > > To: devel@edk2.groups.io > > Cc: jiangang.he@amd.com; abner.chang@amd.co= m; Neo Hsueh > Chih.Hsueh@amd.com> > > Subject: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier port > > in AhciPei PEIM > > > > If there is no port multiplier, PortMultiplierPort should be converted > > to 0 to follow AHCI spec. > > The same logic already applied in AtaAtapiPassThruDxe driver. > > > > Signed-off-by: Neo Hsueh > > > --- > > MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c > > b/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c > > index cd55272c96..7bd04661d0 100644 > > --- a/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c > > +++ b/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c > > @@ -3,6 +3,7 @@ > > mode at PEI phase. > > > > Copyright (c) 2019, Intel Corporation. All rights reserved.
> > + Copyright (C) 2023 Advanced Micro Devices, Inc. All rights > > + reserved.
> > > > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > @@ -92,6 +93,15 @@ AhciPassThruExecute ( { > > EFI_STATUS Status; > > > > + if (PortMultiplierPort =3D=3D 0xFFFF) { > > + // > > + // If there is no port multiplier, PortMultiplierPort will be 0xFF= FF > > + // according to UEFI spec. Here, we convert its value to 0 to foll= ow > > + // AHCI spec. > > + // > > + PortMultiplierPort =3D 0; > > + } > > + > > switch (Packet->Protocol) { > > case EFI_ATA_PASS_THRU_PROTOCOL_ATA_NON_DATA: > > Status =3D AhciNonDataTransfer ( > > -- > > 2.40.0.windows.1 > > > > > > > >=20 > > --_000_MN2PR12MB3966F26BBEE0AB583BE0B2F8EA4EAMN2PR12MB3966namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

[AMD Official Use Only - General]


Hi Leo,

Please add Hao’s RB in the commit message belo= w your signed-off-by, thus we know this patch has been reviewed.=

I also suggest to update your commit subject to R= 20;MdeModulePkg/Bus: Fix port multiplier port in AhciPei PEIM”= .

 

Please resend the PR with above updates, then Hao wi= ll add “Push” label to this PR once your change passed CI.=

 

Thanks

Abner

 

 

 

From: Hsueh, Hong-Chih (Neo) <Hong-Chih.Hs= ueh@amd.com>
Sent: Friday, June 2, 2023 10:37 PM
To: Wu, Hao A <hao.a.wu@intel.com>; He, Jiangang <Jiangang.= He@amd.com>; devel@edk2.groups.io
Cc: Chang, Abner <Abner.Chang@amd.com>
Subject: Re: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier = port in AhciPei PEIM

 

[AMD Official Use Only - General]<= /o:p>

 

Hi Hao,=

&n= bsp;

Thank y= ou for your review.

&n= bsp;

I alrea= dy created a pull request for this commit, may I know how to proceed to mer= ge it into master?

&n= bsp;

&n= bsp;

&n= bsp;

Regards= ,

Neo

From: Wu, Hao A <hao.a.wu@intel.com>
Sent: Thursday, June 1, 2023 10:14 PM
To: He, Jiangang <Jiangang= .He@amd.com>; devel@edk2.groups.io <devel@edk2.groups.io>; Hsueh, Hong= -Chih (Neo) <Hong-Chih.Hsueh@= amd.com>
Cc: Chang, Abner <Abner.Ch= ang@amd.com>
Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier = port in AhciPei PEIM

 

[AMD Official Use Onl= y - General]

Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding.


Thanks.
Reviewed-by: Hao A Wu <hao.a.wu@in= tel.com>

Best Regards,
Hao Wu

> -----Original Message-----
> From: He, Jiangang <Jiangang= .He@amd.com>
> Sent: Wednesday, May 31, 2023 10:49 PM
> To: Wu, Hao A <hao.a.wu@intel= .com>; devel@edk2.groups.io; Hsueh, Hong-
> Chih (Neo) <Hong-Chih.Hs= ueh@amd.com>
> Cc: Chang, Abner <Abner.Chan= g@amd.com>
> Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier po= rt in
> AhciPei PEIM
>
> [AMD Official Use Only - General]
>
> We did crisis recovery and Opal HD password unlock from S3 resume from=
> SATA HD test on two different version of AHCI host controllers.
>
> Thanks,
> Jiangang
> -----Original Message-----
> From: Wu, Hao A <hao.a.wu@int= el.com>
> Sent: Tuesday, May 30, 2023 10:30 PM
> To: devel@edk2.groups.io; = Hsueh, Hong-Chih (Neo) <Hong-
> Chih.Hsueh@amd.com>
> Cc: He, Jiangang <Jiangang.H= e@amd.com>; Chang, Abner
> <Abner.Chang@amd.com>=
> Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier po= rt in
> AhciPei PEIM
>
> Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding.
>
>
> Thanks, the code changes look good to me.
> May I know what tests have been performed for the patch?
>
> Best Regards,
> Hao Wu
>
> > -----Original Message-----
> > From: devel@edk2.groups.i= o <devel@edk2.groups.io&= gt; On Behalf Of Neo
> > Hsueh via groups.io
> > Sent: Wednesday, May 24, 2023 1:07 AM
> > To: devel@edk2.groups.io<= /a>
> > Cc: jiangang.he@amd.com; abner.chang@amd.com; Neo Hsueh <Hong-
> > Chih.Hsueh@amd.com><= br> > > Subject: [edk2-devel] [PATCH] MdeModulePkg: Fix port multiplier p= ort
> > in AhciPei PEIM
> >
> > If there is no port multiplier, PortMultiplierPort should be conv= erted
> > to 0 to follow AHCI spec.
> > The same logic already applied in AtaAtapiPassThruDxe driver.
> >
> > Signed-off-by: Neo Hsueh <Hong-Chih.Hsueh@amd.com>
> > ---
> >  MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c | 10 +++++++= +++
> >  1 file changed, 10 insertions(+)
> >
> > diff --git a/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c
> > b/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c
> > index cd55272c96..7bd04661d0 100644
> > --- a/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c
> > +++ b/MdeModulePkg/Bus/Ata/AhciPei/AhciPeiPassThru.c
> > @@ -3,6 +3,7 @@
> >    mode at PEI phase.
> >
> >    Copyright (c) 2019, Intel Corporation. All righ= ts reserved.<BR>
> > +  Copyright (C) 2023 Advanced Micro Devices, Inc. All right= s
> > + reserved.<BR>
> >
> >    SPDX-License-Identifier: BSD-2-Clause-Patent > >
> > @@ -92,6 +93,15 @@ AhciPassThruExecute (  {
> >    EFI_STATUS  Status;
> >
> > +  if (PortMultiplierPort =3D=3D 0xFFFF) {
> > +    //
> > +    // If there is no port multiplier, PortMultip= lierPort will be 0xFFFF
> > +    // according to UEFI spec. Here, we convert i= ts value to 0 to follow
> > +    // AHCI spec.
> > +    //
> > +    PortMultiplierPort =3D 0;
> > +  }
> > +
> >    switch (Packet->Protocol) {
> >      case EFI_ATA_PASS_THRU_PROTOCOL_ATA= _NON_DATA:
> >        Status =3D AhciNonDataT= ransfer (
> > --
> > 2.40.0.windows.1
> >
> >
> >
> >
> >

--_000_MN2PR12MB3966F26BBEE0AB583BE0B2F8EA4EAMN2PR12MB3966namp_--