From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (NAM02-BN1-obe.outbound.protection.outlook.com [40.107.212.65]) by mx.groups.io with SMTP id smtpd.web11.157.1675482693415248491 for ; Fri, 03 Feb 2023 19:51:33 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=qvwPnJCw; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.212.65, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=haWda6U9r70gGlWWG6uGcBTjvMYDcBItecuDust/fpaRhBvA1spGmbJC+ncRvbV3vMNHB+IbfeFCZG6zc7bq71j83gBThsiDcTNmXMiNsGVTfiGS7lOEkj2T+w1EDY0pGW5YcsqXeNR/l5XiFCNB2oKck/C19Ho3wwT3onltTpcpERFtts7ejRlqTtiLgp6vNu7nFeibZlImCxi3ykGquGNt0LF+qLKhRQvYHL+z6ODTkHK2O7gglWi2QGcAQq6zEaB+isvtM5QRBSxozIXGUKtw0LiX/sGP8DDdO3BlwNkUCEQ//xwPCtWr0PVAkOsdeNUDAcI3gMBBEt+o4RGxbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BI54tAMloqUp0ETyve39PwUYoAMOlifUYEKLVgRRhi0=; b=oLDtVWYkidhPRmYy2CfYagjnZ9apGNMYjE0fyiURl0M1fZ2Z/bKHnAle8GYyckrbVwJSfv2vMQYoc0fGVSMrhsSCaEwif+yXCFR1nsPVWn4pjq/woz+uy9c0WaD2NYkJ9TdW0IHOcXsTZGB+ceiY15fY7mkoWwhvUD9Q+NT8CzaONJkpmWgcpUz6VEkTv1IQXD6lAAom4iqU896pYIJQrwZbbYZaePHnRhC3q9ZS5H+QWJ6axGgc2PT9rnWIBn1ATgfvVRU6AZ0cPavN3Lg2VR5C9QFP4Nh70qB4Y/BKYexFFlzobmR6WQ4v2sSHZUaBv4s862U45GFf1fN5wRPWlw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BI54tAMloqUp0ETyve39PwUYoAMOlifUYEKLVgRRhi0=; b=qvwPnJCwcr3DbSBFQQMJLgBX1tCxdgW2TeG6Z809gzQkk4B6x4ny0KXp5xgfALxfu7vH6dxGT4adKcIzTm0Cr0NnfczDYDPLZ2Bzef4wBsR8B25sOze43vsYKjGsA2iCM0cXg2+HvWZnCdEM78it7ZUPPAqVtImKtNtorxI5g3U= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by SA1PR12MB6947.namprd12.prod.outlook.com (2603:10b6:806:24e::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.27; Sat, 4 Feb 2023 03:51:29 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::d606:ab63:cf3:5d36]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::d606:ab63:cf3:5d36%5]) with mapi id 15.20.6064.031; Sat, 4 Feb 2023 03:51:29 +0000 From: "Chang, Abner" To: Nickle Wang , "devel@edk2.groups.io" CC: Igor Kulchytskyy , Nick Ramirez Subject: Re: [PATCH 1/2] RedfishPkg: fix config handler driver bug Thread-Topic: [PATCH 1/2] RedfishPkg: fix config handler driver bug Thread-Index: AQHZNeoDvE+9unITFEyPy8X/rJsjPq6+K/2w Date: Sat, 4 Feb 2023 03:51:29 +0000 Message-ID: References: <20230201030503.345-1-nicklew@nvidia.com> In-Reply-To: <20230201030503.345-1-nicklew@nvidia.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-02-04T03:51:27Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=e8f3ccff-d302-4fdc-a056-4c8705362f77; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|SA1PR12MB6947:EE_ x-ms-office365-filtering-correlation-id: b4691068-4679-4985-e1eb-08db06631929 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6WWOlS5s5kJBMmVr16syOp0lh+exWCapm52/WwBJRdlkWbZeuOXQXxiDiWE9i0Yk5NQlh3ytTP+wNHA8oQ+KRR5dR+TLOhH2Ie15WIThVZcUpldNUlmKeWW/1lqa+fx1Rp+TLgBs5iHS7nYOUGVIltjTLuVR3Mt2sDhL5j94/tUfQqBXDCQfuXSCJiFGk2U4aBCAs8NxuauOLqDpnq1/quLdrmdyzOoQoilLY4WSCj57H3cixNZ9cK78sugYPk9bt4s3fMUMKC0JPQ84gkjWiVMlTJgfSnALAKQcu9LHwsO9QVTff/O80nPnCQyMfIWeikSGcQePrAfIDrjgI5tSJPmriomqO3DMXdHXyrTPmlCTuhzjf0qWT6SYBTr/QYyYXsrmwaoYyn6tCnGcVJyyvMlHp9tgtOb7maTLoYoTAWvUrYPHhgNBp/HpTSu2e+nADNIkJmOFDgUFnw5GQJftzN6ZLCcSmS8TOWz0YFoq9IyBn1vMhOzrE0l5IG5mjYgS1zwluoLEGOUedrYf1XzOhFoMo9/HJVnc8M1/Q28MDJJgEN5mxRU68/lLL1dib4O1QCTBkKtz1gqLuEdZ4DMH6YNljvIRwx4NgLc1H2ACM3bw0kdL45ab8zh0bMaSnLiRqyl42cjIOWfDDOIx8fC4/3B8jU8oXmV1MnKkQoPtMWH9NlLw9+Y4MmPIC5yBwgUXzdOE+vTb4feyMVDOb0VHAw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(346002)(366004)(39860400002)(136003)(376002)(396003)(451199018)(41300700001)(478600001)(66556008)(122000001)(4326008)(38100700002)(66476007)(83380400001)(8676002)(54906003)(64756008)(316002)(66446008)(110136005)(5660300002)(186003)(71200400001)(26005)(53546011)(76116006)(33656002)(9686003)(55016003)(6506007)(86362001)(38070700005)(52536014)(7696005)(8936002)(66946007)(2906002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?PP0l/w/Qj1wiq8MEkeBfCiOPpac1bxAokkpC2nidOwM1XjF6xvvY5cQs1Nbt?= =?us-ascii?Q?GT1uHlDlUX3ZlSqypX5JKtctr/jfRPmB+7IDktsEgpt/DSvoQdX8ZGorZ8NQ?= =?us-ascii?Q?s6PXkk8HJW/A6W2zo6C8Y/zc3Aor5kMqCxs1o66M01ew5LLwjoM9X7rvrH2r?= =?us-ascii?Q?vnZfglzshyQG4G+JLnpi9P+CuW4rK+3tOw8NFMjfae78l2kRcOcfyLlAxdl6?= =?us-ascii?Q?9cTExauNGFfHquCL0IaWMBgaCCfLy8t83w3q4/dU98ZBLAhIuXLyCpRIlHS1?= =?us-ascii?Q?QuoZ98K86d5clCSlPJiobM9IspGH1b0y10NvdowxPeHXGEpFVrW8aYrmQnJe?= =?us-ascii?Q?y81FkrJTvUcvP5MMDOn7H6uwizqYuR2CpixXWmrAq+uTvRvmzPole43FhuVx?= =?us-ascii?Q?rCQorVZouGoq7GkNHsq41qqLHeL6PgLhEyOU6f8kUu+0TEkP6XAzKyVieoDE?= =?us-ascii?Q?x1fS4OABv26CWU+N2PVtIqqqx3YVRuADNyOAXfY/buxjRWOVPVCGqByla5wC?= =?us-ascii?Q?4x7owH3A/azWTrV759JMMAFFEhdjRC3APqaNpAcTCiG31UXJL8bn11iofJUS?= =?us-ascii?Q?3rd7lMPk6htMBPk67OJQBy+UdZcnzumHptAlNboEWK2oy3pLMkejQaZWLsh1?= =?us-ascii?Q?kJyVWQMqthCRa3DV0+5KlE+pR+e5vPz+7T75uFDBEneMdSQzte2s74Nu5hAl?= =?us-ascii?Q?fnj0Qh3gnTJHo06UPF/khlVjRzHIYVdIG3Sq/U8t/admG5e1/QS/diwQszM+?= =?us-ascii?Q?3fZX4FAO2iJFIfS57HEuLmWqYsW+ht/qd7UmIWG7LsOx1nKFhFKr9ZAKLBxh?= =?us-ascii?Q?DJzPz3YgqBIpjjtwPlzweSOF75wcalzFhsws/SvW0SRPH/WkQBi7EmceeGlN?= =?us-ascii?Q?rSJANUrrxcy7ZMNX7hPMcG0+WM/mL8PcWn2IhzYE5unWdBQV5YEYBju0O7yV?= =?us-ascii?Q?umUo5Vg7yTZIbTXoGEgXWW4SfiZClg0ffhWriXthxkSC5nMc1d6vTNw5kHA3?= =?us-ascii?Q?+Tba3k/qYUJLCg2M9uzk9vsJDNWyJ267bW7UQFSZVyF9gsieMGY0Rof7oEf4?= =?us-ascii?Q?cjNp0cDl7c005zZFRPPnnn1mgDw6CYxAu55wzzn5FJMqYnlUForWWlNpLnqZ?= =?us-ascii?Q?xsr2TiDTbSZvVhUnNmpyhfmSBh8TDPM6ZfZIT+VVMxJttI8vn9Yz17CZv2DI?= =?us-ascii?Q?c/S1DQuX0L/8Nu6IuC0nDnDuvxxO5vSh8IYLtLUmJhku9HwCUpAQDySD7MIT?= =?us-ascii?Q?4QLjZSt9tO1SKHstR8gm6ADVElt5Fs8wZ92Dj7iT6x+OFxZ7+puv3aC5NPJP?= =?us-ascii?Q?yB9GMce9aoBExtFLKoBuoln7SRXAkTzgr7LwA9NQl+uN1gp18ej01w473a5C?= =?us-ascii?Q?MBvV1O+qNnSQsoTVl0lgcgDylApa7KYfdT4Fr8mPTcV3fM2PkVxWHPcNFtKi?= =?us-ascii?Q?zZpJjOZmEdGfZ8MTXrqfnXP6T5O/LkVGxYIuZy2k0Ivl0xU+M5ogIyaBQfGa?= =?us-ascii?Q?c5C0Dfl02OvP07QiBr1fbE/hlPanglofntnfCis04PgERwyXpDOXFsCjjEl6?= =?us-ascii?Q?K4VYs5Npr4OgymgXc0U=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b4691068-4679-4985-e1eb-08db06631929 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Feb 2023 03:51:29.6448 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jLRCUG4x8MY8UORbB2K7BybiBFg84ylpJUzE8w+ahW1TMPyjDe49PMUcyDSu758FqObv31Weuze2A35n/JxjxQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB6947 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Reviewed-by: Abner Chang > -----Original Message----- > From: Nickle Wang > Sent: Wednesday, February 1, 2023 11:05 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [PATCH 1/2] RedfishPkg: fix config handler driver bug >=20 > Caution: This message originated from an External Source. Use proper caut= ion > when opening attachments, clicking links, or responding. >=20 >=20 > Bug fix: > - function stack fault > - config handler driver requires the dependency of Redfish Credential > Protocol > - incorrect caller id installation when failed to perform init() >=20 > Signed-off-by: Nickle Wang > Cc: Abner Chang > Cc: Igor Kulchytskyy > Cc: Nick Ramirez > --- > .../RedfishConfigHandler/RedfishConfigHandlerDriver.inf | 4 ++-- > RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerCommon.c | 4 +++- > 2 files changed, 5 insertions(+), 3 deletions(-) >=20 > diff --git a/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.i= nf > b/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.inf > index def91c7531..b167c6e1ee 100644 > --- a/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.inf > +++ b/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerDriver.inf > @@ -4,6 +4,7 @@ > # > # Copyright (c) 2019, Intel Corporation. All rights reserved.
# (= C) > Copyright 2021 Hewlett Packard Enterprise Development LP
> +# Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reser= ved. > # > # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -56,5 +57,4 @@ > gEfiEndOfDxeEventGroupGuid ## CONSUMES ## Event >=20 > [Depex] > - TRUE > - > + gEdkIIRedfishCredentialProtocolGuid > diff --git a/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerCommon.c > b/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerCommon.c > index c3a7efd796..45276793c7 100644 > --- a/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerCommon.c > +++ b/RedfishPkg/RedfishConfigHandler/RedfishConfigHandlerCommon.c > @@ -2,6 +2,7 @@ > The common code of EDKII Redfish Configuration Handler driver. >=20 > (C) Copyright 2021 Hewlett Packard Enterprise Development LP
> + Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserv= ed. >=20 > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > @@ -225,7 +226,7 @@ RedfishConfigHandlerInitialization ( > UINTN NumberOfHandles; > EDKII_REDFISH_CONFIG_HANDLER_PROTOCOL *ConfigHandler; > UINTN Index; > - UINT32 Id; > + UINT32 *Id; >=20 > Status =3D gBS->LocateHandleBuffer ( > ByProtocol, > @@ -257,6 +258,7 @@ RedfishConfigHandlerInitialization ( > Status =3D ConfigHandler->Init (ConfigHandler, > &gRedfishConfigData.RedfishServiceInfo); > if (EFI_ERROR (Status) && (Status !=3D EFI_ALREADY_STARTED)) { > DEBUG ((DEBUG_ERROR, "ERROR: Failed to init Redfish config handler > %p.\n", ConfigHandler)); > + continue; > } >=20 > // > -- > 2.39.1.windows.1