Re: [edk2-devel] [PATCH 1/1] Platform/RISC-V/PlatformPkg:fix image link error

["Chang, Abner" <abner.chang@amd.com>]

[AMD Official Use Only - General]

Acked-by: Abner Chang <abner.chang@amd.com>

Thanks for fixing this.
Abner
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> Dongdong Zhang via groups.io
> Sent: Wednesday, December 28, 2022 1:46 PM
> To: devel@edk2.groups.io
> Cc: zhuwenjun@eswincomputing.com; zhengyu@eswincomputing.com;
> jinyanjiang@eswincomputing.com; Dongdong Zhang
> <zhangdongdong@eswincomputing.com>
> Subject: [edk2-devel] [PATCH 1/1] Platform/RISC-V/PlatformPkg:fix image
> link error
> 
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
> 
> 
> Edk2OpensbiPlatformWrapperLib Library and RiscVSpecialPlatformLib Library
> mark the serial number in the figure is opposite to the text description, fix it
> and adjust the text order.
> 
> Signed-off-by: Dongdong Zhang <zhangdongdong@eswincomputing.com>
> ---
>  Platform/RISC-V/PlatformPkg/Readme.md | 14 ++++++++------
>  1 file changed, 8 insertions(+), 6 deletions(-)
> 
> diff --git a/Platform/RISC-V/PlatformPkg/Readme.md b/Platform/RISC-
> V/PlatformPkg/Readme.md
> index 5a344a8..d7166ba 100644
> --- a/Platform/RISC-V/PlatformPkg/Readme.md
> +++ b/Platform/RISC-V/PlatformPkg/Readme.md
> @@ -35,19 +35,21 @@ are from OpenSBI project. edk2 libraries are
> introduced as the wrapper libraries  [Indicated as #2 in the figure](#risc-v-
> edk2-port-design-diagrams)
>  > ***OpenSbiPlatformLib*** provides the generic RISC-V platform
> initialization code. Platform vendor can just utilize this library if they don't
> have additional requirements on the platform initialization.
> 
> -##### RiscVSpecialPlatformLib Library
> -[Indicated as #3 in the figure](#risc-v-edk2-port-design-diagrams)
> -> The major use case of this library is to facilitate the interfaces
> -> for platform vendors to provide the special
> -platform initialization based on the generic platform initialization library.
> -
>  ##### Edk2OpensbiPlatformWrapperLib Library -[Indicated as #4 in the
> figure](#risc-v-edk2-port-design-diagrams)
> +
> +[Indicated as #3 in the figure](#risc-v-edk2-port-design-diagrams)
>  > In order to providing the flexibility to edk2 RISC-V firmware solution,
> ***Edk2OpensbiPlatformWrapperLib*** is the wrapper library of
> [OpenSbiPlatformLib](#OpenSbiPlatformLib-library) to provide the interfaces
> for OEM. The ***platform_ops_address***in the generic platform structure
> is replaced with ***Edk2OpensbiplatformOps*** in SEC  module. The
> platform function invoked by OpenSBI core is hooked to
> ***Edk2OpensbiPlatformWrapperLib***. This gives  a change to OEM for
> implementing platform-specific initialization before and after the generic
> platform code. OEM  can override this library under their platform folder on
> demand without touching ***RiscVOpensbiLib*** library  source files and
> other common source files.
> 
> +##### RiscVSpecialPlatformLib Library
> +
> +[Indicated as #4 in the figure](#risc-v-edk2-port-design-diagrams)
> +> The major use case of this library is to facilitate the interfaces
> +> for platform vendors to provide the special
> +platform initialization based on the generic platform initialization library.
> +
>  ##### Next Phase Address and Privilege Mode  [Indicated as #5 in the
> figure](#risc-v-edk2-port-design-diagrams)
>  > Once OpenSBI finishes the boot initialization, it will jump to the next phase
> with the default privilege set to
> --
> 2.17.1
> 
> 
> 
> 
>