From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (NAM11-DM6-obe.outbound.protection.outlook.com [40.107.223.78]) by mx.groups.io with SMTP id smtpd.web10.195231.1672276499275999635 for ; Wed, 28 Dec 2022 17:14:59 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=s0gBRU4F; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.223.78, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EPYd/W3vmr0pPRhDBd4f1L99/KrFiCKj20FZPSFVncz29HYwhF2AySl2rssw0Iw+Yu5d+zvRTML0kQC5t/JJZoTKkHkAWMXyE9pjpt6PmfPKV6W08ooH5TUKk2sTqGQ6uf5jO0+weR2W9CEIsRg9PzvvkqbpzJBNhClCODoE4w1u7nJb+eDDlccj+8FYWAJG8ybTUJ9cbe4EMhpOCs9A/r7ndeOwe22h9AVkBRf9dWWuVeAKkOlPfu7l2AI6yuqTqyqoTox/I+q7PITbxE4DDeRffirqagqD7LHeDQmM34Iyy8G1U+ZQI99C2SeheW/51nnAXTR+kREsfBn1meLaNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lYTJhT7uJtDHhZbRDm/bJq7iOGkgLizOfH09Q2XIkJY=; b=m0AS8g/1jZiU5mHruGA1/r6W7HsGzBenfLrAm2M90+3KiCS1cBB/WHG/yJcAf5MV3GUFGkQb/9oz72vAm8YdcAz6WV35u9zdJ9ndW4ob2LzFjmeMHvBiDK+qRBBSegR1ERwoxmTvGKOf2cGM3cj+gSqJaWUJvIk5g+O+8gbW6z+8w2MWwiUeulkSATFACIgib1uIDwE3dO+xvidYJbe4+7tz4DTR0YtLt5grhz0u9BLDAzL/av0fMyg2Cns6zQ4ndd/v5jeSnDF4bn9BWAU9X6pkyOdpduNdIalCnvmqfAUX0CClbpvil1wYTSIxjotVTmN+YnJvQbi9qPmw31OZYg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lYTJhT7uJtDHhZbRDm/bJq7iOGkgLizOfH09Q2XIkJY=; b=s0gBRU4FYFV+XK0rNKS9IvHqdG0az4XKW5L5vstw5yZ95oBDpfMD9Qh65DYR2gc7P1n+3nAC0qzSdZVp6y9KmiVKzA+ewLqTkeQHsFI5o0rGXKdEehoSymG2Z9cti3pM4du6EVwmXqOzmXBnwGNplTT+4KH3ubLjKe4ck7Z3pvk= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by CH2PR12MB5018.namprd12.prod.outlook.com (2603:10b6:610:6e::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.16; Thu, 29 Dec 2022 01:14:57 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::cddb:3de9:cd1d:26e4]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::cddb:3de9:cd1d:26e4%5]) with mapi id 15.20.5944.016; Thu, 29 Dec 2022 01:14:51 +0000 From: "Chang, Abner" To: "devel@edk2.groups.io" , "zhangdongdong@eswincomputing.com" CC: "zhuwenjun@eswincomputing.com" , "zhengyu@eswincomputing.com" , "jinyanjiang@eswincomputing.com" Subject: Re: [edk2-devel] [PATCH 1/1] Platform/RISC-V/PlatformPkg:fix image link error Thread-Topic: [edk2-devel] [PATCH 1/1] Platform/RISC-V/PlatformPkg:fix image link error Thread-Index: AQHZGn+wxLy4nWTo0kOROGpHzwkNea6EEF4g Date: Thu, 29 Dec 2022 01:14:51 +0000 Message-ID: References: <20221228054550.6530-1-zhangdongdong@eswincomputing.com> <20221228054550.6530-2-zhangdongdong@eswincomputing.com> In-Reply-To: <20221228054550.6530-2-zhangdongdong@eswincomputing.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2022-12-29T01:14:47Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=5f26bd21-5d3d-4a16-9810-b452ca73ebd9; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|CH2PR12MB5018:EE_ x-ms-office365-filtering-correlation-id: e77f0b1e-09ce-4b61-dfae-08dae93a15eb x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jwStTkjVjQ9mhGZ6RofhMeETJLm6SyO1s4+BRZ+aKCiaHGNwVlehA5LIg0NgvLHbeqhK5j+AM/FM0+GKUdNYXKGPk8I+XyqYrnKxquxgRlrLGq6hNgB1i2bZl8WlD6FWZMXAG2zgjQD+AGwJqiz0bRbUMntj0fHoIbLiiHgyJxt5cG7Fy7SY2/xv/xth7cPTleldUyWyVMEVQLvLoHYUU+403PKmCEDx2p83lHAI5RicRj5Cxq2Nd8uHK+81cJzipnlSG3GO/CV7Qh1xd19cts3hgUR12wjT3ESSZmbm1YI8s64iCIag67ppnP6hyIbzP9JW5Lh9hiVRHxAOmNI8l1CIv+Rcyep2FtHoRNGBUbEYO7NyrBPxQJGvbQBG03MmKbs3ZAk0SzylamU1+KWO8tD8ZAxDRFoCGbgqSMsyuKSk5KPD8Omli7v6HARHZVRqTgQiTFIheJQdX7Sw1qV1mK4bPkIBeO1N+xPbDtFOP+xuQe7DkJR9u+LK6E0fMtrzHPr+DJF5dE9+Il2G6fsiR61G2J4A6zklBCDBhh1tTfXyJN9tLiZHKnk6cE/8ztA+4GP0FnmVldJFxWMGT4p1aWY2SO0lZZRIBt+j6IiJTzT3/aGBykOBl9csr4id8srGn63BNjm5Y5oaCA7IDv+Onuvqd5SR+i8tSaVMzESV9YxAiL2AaR3wB9/TxotvIdEQ/ooV8qtmNzoVbDkyfs9Gr2bMqaQXSIPl0e1PtodZEVgICpguJ/TmHgizPSU4xPoD5Ee7K5TywvhROtFW7e2OJg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(366004)(376002)(39860400002)(396003)(451199015)(86362001)(38100700002)(122000001)(2906002)(38070700005)(83380400001)(5660300002)(52536014)(41300700001)(8936002)(55016003)(6506007)(53546011)(478600001)(26005)(186003)(316002)(19627235002)(9686003)(8676002)(4326008)(66946007)(71200400001)(66446008)(64756008)(66556008)(66476007)(110136005)(7696005)(966005)(54906003)(45080400002)(76116006)(66899015)(33656002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?0oWQf1xNNmu32eXRUnR21PQpERUpzymInirZQPqVGKzxFBkEhvFm+5o3v3Z9?= =?us-ascii?Q?Qyyuai65UzzdyljldkpCiAgmPHmOSTEDeSxKaL9Xv8KCFVggqr5j0y7SCguB?= =?us-ascii?Q?HtikkriCk+kgK4O3Chc5j4gYPgSrpsQU3+wmU+NsTDgdXjmYN6vY9CXTtECU?= =?us-ascii?Q?FeyniwFzGyJiVlwMnPcPgCKtyZJKtm8blTkT87lzBWdjoKIOh5quTxnYkaQZ?= =?us-ascii?Q?688odeSgFy6gurkJwETWO+1J4cY4QGcVFl/jJ7zF7Y7fFpi125I9NnZzMsv5?= =?us-ascii?Q?KAay+WE0JZw994M8IxY5KNZ9BqN6Npd39DEqDK6D02zXMIe1NyTkpYGJycju?= =?us-ascii?Q?/j8iOjd9/v67CDgBAedwaxaXkSjeE8SviJHuuuhiQwX+wLTpd47gkuElqWQ+?= =?us-ascii?Q?o73tKxx5JCth0TyF68NtOHxCPEIuYjZHlsdvI1/DOhgcD7cElkyjW+K61/VR?= =?us-ascii?Q?JG4u2tyhijFDUb19/+YYgL3lKxN5hgVjjOaojrP1Jw/p6AToXZ/3yzNwTFBU?= =?us-ascii?Q?GcmFHJvsUkb0MQuxX/mlGPfMln3esNmIoqdVfAmyRAYxafaPw8nkBw5HnbKt?= =?us-ascii?Q?rqDE+EEPkV83y/xfPPdYUtJfK1vridSIhxXK3tnRVGJCcn+MefP4qryWCkqJ?= =?us-ascii?Q?UTQkYhmSUfqVdXEyx1yN+uqS5/SddJNhixuXHfFPEA4F/eja9MlDJa77pJ9U?= =?us-ascii?Q?uwEsXYfFvJ2MqiPIP7bl9/akOd7VfWTqy8XlwBJKRyFm9Qk/1Ri8M+x3uHlU?= =?us-ascii?Q?cQKXAGKeYJiIC5B040q9Px/BeAEE6ksK5QiK72Si4c4vpFO3BdCvUCoDNX4W?= =?us-ascii?Q?1DuNPy/saGvfz1Kevj5XLaY2Wjvy8fsxSZYR+5/fC5LYNtGtvYumZs41HSfg?= =?us-ascii?Q?pB7Ut9khu552uY1YGfZn26c4VSpzfLm81UtxIHh6qvo8SBinNhqtWe6dyQ5b?= =?us-ascii?Q?h191bwuok4kLRKRhy/Y7lhOo7wdX8qYRALJ0TsK2F93RD+vIVLagnweJrjvN?= =?us-ascii?Q?KQQwcf+z/K7pGBQAL1tW/Yd9uh1Gec4aepqftj93R2PIHfNJPwQkG7RE5JGg?= =?us-ascii?Q?FITJHwhDsGwMEpWMiYGZAvANglBxqLNfqOFwnTS7xmPOdd441N29WJ7KtFxZ?= =?us-ascii?Q?nhpwbaTgToG0xy+3UoVTL0hjvMgl/h7nPjcHIac0DT+JyGWp1S7v5K6Jte/i?= =?us-ascii?Q?WlSuyjcaCxLZJWUwGZX/rzKPujGczWjQSKYchjHnYro/vZU9B8ugZRuqCjFV?= =?us-ascii?Q?gJRlokzDWAtmkoAlImVCIeNw9fNPhB6l0QfF6jf9/pgRK+NhI44P7S1UQJBq?= =?us-ascii?Q?m95Bv+DJlOIZuHRu2RkT11HB5L0q9zQ+KCrrBK9Ix0RslualHqqk0oYwy2PC?= =?us-ascii?Q?G22wrlwVjdQ5vrLodrqb32Rxw8bdTR/HFWebGaujjSjh4u8V+rKcMrYgl96h?= =?us-ascii?Q?7gNytTEgUQ81yHIj6X6ZnzLwATBRK5t8Dhx0+q3FOO5nFquzw6kKjhhm9slu?= =?us-ascii?Q?ClXAmD5REAfSR+T6BAW5muToJXnFUmf8Z8vS+x/77TOJnKPbI4C9jBiRAKsl?= =?us-ascii?Q?YyxzPb8MIXXPNCgRlHWQ9YgabzMDjTiD8duCIh5l?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e77f0b1e-09ce-4b61-dfae-08dae93a15eb X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Dec 2022 01:14:51.0876 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tFBHigcB76sIGfhCZKRBfM3hbc2bdqNO619ckiTn8nicGxigZEbMJxsuWSBsJaoS8E5r756Immd80QNHKHx2ug== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB5018 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Acked-by: Abner Chang Thanks for fixing this. Abner > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of > Dongdong Zhang via groups.io > Sent: Wednesday, December 28, 2022 1:46 PM > To: devel@edk2.groups.io > Cc: zhuwenjun@eswincomputing.com; zhengyu@eswincomputing.com; > jinyanjiang@eswincomputing.com; Dongdong Zhang > > Subject: [edk2-devel] [PATCH 1/1] Platform/RISC-V/PlatformPkg:fix image > link error >=20 > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. >=20 >=20 > Edk2OpensbiPlatformWrapperLib Library and RiscVSpecialPlatformLib Library > mark the serial number in the figure is opposite to the text description,= fix it > and adjust the text order. >=20 > Signed-off-by: Dongdong Zhang > --- > Platform/RISC-V/PlatformPkg/Readme.md | 14 ++++++++------ > 1 file changed, 8 insertions(+), 6 deletions(-) >=20 > diff --git a/Platform/RISC-V/PlatformPkg/Readme.md b/Platform/RISC- > V/PlatformPkg/Readme.md > index 5a344a8..d7166ba 100644 > --- a/Platform/RISC-V/PlatformPkg/Readme.md > +++ b/Platform/RISC-V/PlatformPkg/Readme.md > @@ -35,19 +35,21 @@ are from OpenSBI project. edk2 libraries are > introduced as the wrapper libraries [Indicated as #2 in the figure](#ris= c-v- > edk2-port-design-diagrams) > > ***OpenSbiPlatformLib*** provides the generic RISC-V platform > initialization code. Platform vendor can just utilize this library if the= y don't > have additional requirements on the platform initialization. >=20 > -##### RiscVSpecialPlatformLib Library > -[Indicated as #3 in the figure](#risc-v-edk2-port-design-diagrams) > -> The major use case of this library is to facilitate the interfaces > -> for platform vendors to provide the special > -platform initialization based on the generic platform initialization lib= rary. > - > ##### Edk2OpensbiPlatformWrapperLib Library -[Indicated as #4 in the > figure](#risc-v-edk2-port-design-diagrams) > + > +[Indicated as #3 in the figure](#risc-v-edk2-port-design-diagrams) > > In order to providing the flexibility to edk2 RISC-V firmware solution= , > ***Edk2OpensbiPlatformWrapperLib*** is the wrapper library of > [OpenSbiPlatformLib](#OpenSbiPlatformLib-library) to provide the interfac= es > for OEM. The ***platform_ops_address***in the generic platform structure > is replaced with ***Edk2OpensbiplatformOps*** in SEC module. The > platform function invoked by OpenSBI core is hooked to > ***Edk2OpensbiPlatformWrapperLib***. This gives a change to OEM for > implementing platform-specific initialization before and after the generi= c > platform code. OEM can override this library under their platform folder= on > demand without touching ***RiscVOpensbiLib*** library source files and > other common source files. >=20 > +##### RiscVSpecialPlatformLib Library > + > +[Indicated as #4 in the figure](#risc-v-edk2-port-design-diagrams) > +> The major use case of this library is to facilitate the interfaces > +> for platform vendors to provide the special > +platform initialization based on the generic platform initialization lib= rary. > + > ##### Next Phase Address and Privilege Mode [Indicated as #5 in the > figure](#risc-v-edk2-port-design-diagrams) > > Once OpenSBI finishes the boot initialization, it will jump to the nex= t phase > with the default privilege set to > -- > 2.17.1 >=20 >=20 >=20 >=20 >=20