From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (NAM12-DM6-obe.outbound.protection.outlook.com [40.107.243.47]) by mx.groups.io with SMTP id smtpd.web10.11488.1683707147683069403 for ; Wed, 10 May 2023 01:25:48 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=p2Wnqy6U; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.243.47, mailfrom: abner.chang@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H0OI0AbZIdKtxY10eblNjQiBKKONCWpHcqpDSSwqufnyWaimeDk9MT35brUSpKozJCbVPLkuykjWMwsSHNpPeY9x0wgIkBaXCi53iRX6+tyN0nWcsJrmlB6WBgUcIuHLd4Ni6ktUNIGR9Qs5NzpjDEFeMFxWKYH7ebiCt3z5avTaRsK7ONxWobrRJzlUWzs1yI0IyWvR957DOyI/kLFFQNyVZab4oE0e2+UodFInTLK58D5Hi3L4xcXgKkMoezj1O7pu5uHHsSaQWg9Mi5ZwExqiPOvwYgNpoUlzI+qdYZ4N3CsiVDOJXsp2xkcMqxkTT4FDRBDqBKKVY6X+V+0Mug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hA5oquNfqICq1iWEgeC5hshWBlzy1WRzqqR6dsYr/L8=; b=NSrN0rBi2ZRD+sk5OHyViT9qptTZ8A77Gu+LRXJnE3uMtXkBBQW62dmoiaZzZRdqdWypBmzyYTYo3+vS5tga8CYrpqNd5VJZbxBV9YUs58cks/DrQUznLwOl2hLNmJEjt7g4oGuBTnHE4ICRQcMInJMhuTXIzWOxOAdfra1DFxVZ2KcOReY/RdHqgzBPiqjim5z8chNrrWj7L566Cp3c05zKBZ7qp22gsTGCFNAV1p7Vh9ccrlENdDmapwaqa2XXxBsX9KeirZV4q1NJtmCLgiwPEkb0nhi0QDHYJHuASStMan4tNQnao95PMoFK22h50GF//lHvdb2c5OUzGEn8DA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hA5oquNfqICq1iWEgeC5hshWBlzy1WRzqqR6dsYr/L8=; b=p2Wnqy6UvPdUlY5NW7FX4ZiafPnosS39ymEUR3suN3m8ElCXhWBO63mVbYl9wJ9c8y2y+rjKppKORqgL5ymdR5t/Na52q6Qk594ToxGNagHVnoCjIrK0zX8AdxHDgqvELswNIrFiNgZwaZHvC/9E2VDQnqxTjCToKxV1NAbfIH8= Received: from MN2PR12MB3966.namprd12.prod.outlook.com (2603:10b6:208:165::18) by MN2PR12MB4359.namprd12.prod.outlook.com (2603:10b6:208:265::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.33; Wed, 10 May 2023 08:25:45 +0000 Received: from MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::46f1:bdce:a4bc:29e3]) by MN2PR12MB3966.namprd12.prod.outlook.com ([fe80::46f1:bdce:a4bc:29e3%3]) with mapi id 15.20.6363.032; Wed, 10 May 2023 08:25:45 +0000 From: "Chang, Abner" To: Nickle Wang , "devel@edk2.groups.io" CC: Igor Kulchytskyy Subject: Re: [edk2-redfish-client][PATCH 1/4] RedfishClientPkg: Update ETag driver Thread-Topic: [edk2-redfish-client][PATCH 1/4] RedfishClientPkg: Update ETag driver Thread-Index: AQHZgxi/XqTDw6Jr+UmjETmRzN6Tmq9TK8Sw Date: Wed, 10 May 2023 08:25:45 +0000 Message-ID: References: <20230510082330.12199-1-nicklew@nvidia.com> In-Reply-To: <20230510082330.12199-1-nicklew@nvidia.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-05-10T08:25:43Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=423daf2e-eaad-4c50-911c-e09e7fa547b2; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN2PR12MB3966:EE_|MN2PR12MB4359:EE_ x-ms-office365-filtering-correlation-id: e03879ba-ef5c-4290-85ab-08db513026b6 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: sOJa+Os49/CZ5xmo/OYdaMaQm6DeCKsk72mIwENk2FgtMzBqmo/juF/WFLlT39j3YgmGkVe45UGeeEAAXVqsjSa8P48+AvPsPXlBAGu5A2D2VO8YvilnSW2QQY8sY3QDAkcXNnPv8kTiGZ/+6XJsERzSNzN79jelMI75NFePYW4blimz6zwBdcZTSNAGQxscjwUbbYSzNNMPERUvCNE7cVYVMphQQl07lpFeD22B3GkgyLOEttjlPSUHZ8+QsuGs3JaT9SJ7nbHgskav2RmCmVwrgeLgUEpzCiXc52OAyQFmaxpFfYGexg7x8KvymRN+U85jSvT3K55dIp19vtC2rwRfvaEo2OlwbnUchImO28khCpeMpgTez0wYdBC78MQe21fEM7OOoGhM7P5QJw2rjFDKeiSpQMfdYXYUnbHMUuYZaNrau3xEwG74kll2fiV3h/LJOa28W1E/nrFDZp7gAD4tdq78WgPRtyddc1fM2Z2LxqxOUWlnkDp8wO21Xl2Ezvk8OO+IIn8GF2mftK/OkD2xaYCbmk0ZI/BRXqATd87ix8V/cRBUdNiMdyot2sxuJmMllWzv1+UJCLWxLYbetNxxwl6Vp2ZNayer8l3Qkl7a1Radu1XsyFXS3KyxEmLZ x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3966.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(396003)(39860400002)(376002)(136003)(366004)(451199021)(5660300002)(52536014)(478600001)(110136005)(7696005)(15650500001)(71200400001)(41300700001)(8676002)(316002)(8936002)(26005)(6506007)(9686003)(4326008)(66556008)(66476007)(66446008)(64756008)(66946007)(76116006)(53546011)(2906002)(83380400001)(186003)(122000001)(55016003)(38070700005)(33656002)(86362001)(38100700002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?luEpHHjxV2B2Khk6tb72VFRrR6t8IbysXgEW5kL+PnSkJq1M87cHUp7c+GGf?= =?us-ascii?Q?PM2iJ6RnmjoKzV9U8tLlxGy/QSEluW1FleqG+gZmkGG4RMC28P93M+KtrH5E?= =?us-ascii?Q?udS2gf9pQzCo62BX5Y/25hmEwxap4RtCpxsjWQk8jcO4hUVt1jOCSWlRIkY2?= =?us-ascii?Q?MXAdfn0K7zkNPeeu6aYAs8QOcy4ZywYB4FpoN0wjzFt80f4Pmriz4e1IuAX+?= =?us-ascii?Q?B/ArUhhTJ5N9OCYLGxyfl84Sp2KCMItqISe263+ygD98Ok6wAgLoiQiJqvK7?= =?us-ascii?Q?OuTPEP7vft3yo/IfboOIUsLezU7xcKi7qJHG90t/xnKUsokdH/dDyv33f7WW?= =?us-ascii?Q?aoCXz6m5VXdAZKAj6W/uGjOqnGK/P8bQZfieJDSaInZ4b20YYz6NKdDHWDea?= =?us-ascii?Q?dYKIKH+MvIPG3vlZD6W0eAGunXiYsDYz2enCIGlhe1C9/EduwmdCD1qzdEzE?= =?us-ascii?Q?njxa9aShoP7ftrYwFLtTJaPk+VFaQ62l5UyYZDZmGj93ho4tjUZej6bnGzRJ?= =?us-ascii?Q?NYVhe5++fkXtrW6LhBjxPmUgSs87Yqd95V7mhM3Rxn7MgMJSKHAOSQY/vs0B?= =?us-ascii?Q?AEregfRz4298pVJHuR82WD/u+H7NYDG/CEjPCLSZdPgaYUdS4gSOV37Ewzii?= =?us-ascii?Q?MIBkJS/l0eeJvdILLdmx4tmc4yNMbdB8PAD5XkieYJJ7MQdIrhKhrEPBu1yw?= =?us-ascii?Q?NyYem3NaOd/3enxRkKbc4Mmb0h3ebKtlSR8lzQR1G3FTOf+TfRsnvBjaUmrc?= =?us-ascii?Q?5mhyk4Np20f/V8ROXPv7c4xNW9kA2NHySHzAMiKD/sxYgC9fdvi/E7MxoVYZ?= =?us-ascii?Q?ta66QfoTNOSru3YG6bQg7in+tkfUbSMKhnnSP6j6VbUA3eCRkl54WoS64h8q?= =?us-ascii?Q?TCVoHLk16PMLFcKOdA3QOI8fGlBsuOe5Va8PeixWDjkeJ9RJPEF6/gCb0bLv?= =?us-ascii?Q?NByYfmXS0BcehowGl9guGuf9haeadV7pYaEYlm5TWy3VPX0p0U9TSsOpOHfE?= =?us-ascii?Q?YIc1nNK6e6nnyBcmmpQ69CrlaF6CNY+G7Gkb8TDVJA9iPMl4A4x5LxNCNIQp?= =?us-ascii?Q?NsPmgdU1DzqqUtOK/9yjldUz0UcySC6G936Z5lUNQIcrXlhbhG+o/Sm6EOMm?= =?us-ascii?Q?/t6bQ5vUFnyYk3/2z07yGBgpXW0vaFZaHNZFJ1KeLsy0RP/PJo1/3slrNr7I?= =?us-ascii?Q?jOfW72SXwK4+xgxWGOB2lqRwrWVXhgDrJXSHZgy8fobYdEu2dF0dNQQwGDhx?= =?us-ascii?Q?hB/l9NXkoqPln+R6bMoITbK09vGL1Lk2JZkyXCE/Vfo7gpdg4EUvWV6oiI4d?= =?us-ascii?Q?j8dHnKrQluHSX+T6pm3T7JdV9sYO1wNEyt58Ptga60AKeDxk4f+FQbauxBKd?= =?us-ascii?Q?kMiWqp0oZfA8vkbO9riSdyunbpksMh8o8/9xDRxaCySS8rQNlt4CRdjG2GrD?= =?us-ascii?Q?3X/UtQB1OLBZvMKIc8RV4o/YMDOSVElPI+l/fx8GXdQDwxT9lMZoS+G1orhv?= =?us-ascii?Q?TY4666KhV76fAtrebW+3cUQhCEBwiWwNGj3pcVDlAY3A0IX1oBW1eP+deFml?= =?us-ascii?Q?5Y3tZ/vbACTkDyjrM72eEXj0N0coUUVQaEHIPrfK?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3966.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e03879ba-ef5c-4290-85ab-08db513026b6 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 May 2023 08:25:45.2757 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: x70O0HRFALU1ROALrpPUeeLTZBuxE2as8LAztwYTnNJRVTB+++BrbBPdCINfhlz51QGXoFMLYwUxJonTjqntAQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4359 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Reviewed-by: Abner Chang > -----Original Message----- > From: Nickle Wang > Sent: Wednesday, May 10, 2023 4:24 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > > Subject: [edk2-redfish-client][PATCH 1/4] RedfishClientPkg: Update ETag > driver >=20 > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. >=20 >=20 > Update ETag driver and use specific variable GUID. Also fix the typo in > comment. >=20 > Signed-off-by: Nickle Wang > Cc: Abner Chang > Cc: Igor Kulchytskyy > --- > RedfishClientPkg/RedfishClientPkg.dec | 2 +- > RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.h | 4 ++-- > RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.c | 10 +++++----- > 3 files changed, 8 insertions(+), 8 deletions(-) >=20 > diff --git a/RedfishClientPkg/RedfishClientPkg.dec > b/RedfishClientPkg/RedfishClientPkg.dec > index 7bdab5be..67929341 100644 > --- a/RedfishClientPkg/RedfishClientPkg.dec > +++ b/RedfishClientPkg/RedfishClientPkg.dec > @@ -36,7 +36,7 @@ > gEdkIIRedfishFeatureProtocolGuid =3D { 0x785CC694, 0x4930, 0xEF= BF, > { 0x2A, 0xCB, 0xA4, 0xB6, 0xA1, 0xCC, 0xAA, 0x34 } } > ## Include/Protocol/EdkIIRedfishResourceConfigProtocol.h > gEdkIIRedfishResourceConfigProtocolGuid =3D { 0x6f164c68, 0xfb09, 0x46= 46, > { 0xa8, 0xd3, 0x24, 0x11, 0x5d, 0xab, 0x3e, 0xe7 } } > - ## Include/Protocol/EdkiiRedfishETagProtocol.h > + ## Include/Protocol/EdkIIRedfishETagProtocol.h > gEdkIIRedfishETagProtocolGuid =3D { 0x5706d368, 0xaf66, 0x48= f5, { 0x89, > 0xfc, 0xa6, 0x61, 0xce, 0xb5, 0xa6, 0xa9 } } > ## Include/Protocol/EdkIIRedfishConfigLangMapProtocol.h > gEdkIIRedfishConfigLangMapProtocolGuid =3D { 0x1d9ba9fe, 0x5d5a, 0x= 4b66, > {0x83, 0x5b, 0xe2, 0x5d, 0x13, 0x93, 0x4a, 0x9c } } > diff --git a/RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.h > b/RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.h > index 6dffa9d7..3542f289 100644 > --- a/RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.h > +++ b/RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.h > @@ -1,7 +1,7 @@ > /** @file > Common header file for RedfishETagDxe driver. >=20 > - (C) Copyright 2021 Hewlett Packard Enterprise Development LP
> + (C) Copyright 2021-2022 Hewlett Packard Enterprise Development LP
>=20 > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > @@ -11,6 +11,7 @@ > #define REDFISH_ETAG_DXE_H_ >=20 > #include > +#include >=20 > // > // Libraries > @@ -30,7 +31,6 @@ > #include >=20 > #define ETAG_VARIABLE_NAME L"RedfishETag" > -#define IS_EMPTY_STRING(a) ((a) =3D=3D NULL || (a)[0] =3D=3D '\0') #de= fine > ETAG_DEBUG_ENABLED 0x00 >=20 > // > diff --git a/RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.c > b/RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.c > index af920afc..a4233a64 100644 > --- a/RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.c > +++ b/RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.c > @@ -1,6 +1,6 @@ > /** @file >=20 > - (C) Copyright 2021 Hewlett Packard Enterprise Development LP
> + (C) Copyright 2021-2022 Hewlett Packard Enterprise Development LP
>=20 > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > @@ -401,16 +401,16 @@ SaveETagList ( > // > Status =3D GetVariable2 ( > VariableName, > - &gEfiCallerIdGuid, > + &mRedfishVariableGuid, > (VOID *)&Data, > NULL > ); > if (!EFI_ERROR (Status)) { > FreePool (Data); > - gRT->SetVariable (VariableName, &gEfiCallerIdGuid, > VARIABLE_ATTRIBUTE_NV_BS, 0, NULL); > + gRT->SetVariable (VariableName, &mRedfishVariableGuid, > + VARIABLE_ATTRIBUTE_NV_BS, 0, NULL); > } >=20 > - return gRT->SetVariable (VariableName, &gEfiCallerIdGuid, > VARIABLE_ATTRIBUTE_NV_BS, VarSize, (VOID *)VarData); > + return gRT->SetVariable (VariableName, &mRedfishVariableGuid, > + VARIABLE_ATTRIBUTE_NV_BS, VarSize, (VOID *)VarData); > } >=20 > /** > @@ -446,7 +446,7 @@ InitialETagList ( > // > Status =3D GetVariable2 ( > VariableName, > - &gEfiCallerIdGuid, > + &mRedfishVariableGuid, > (VOID *)&VarData, > &VariableSize > ); > -- > 2.17.1